32817 2009-12-21 00:43:50 -0800 [Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image 2009-12-23 18:23:54 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 yutak webkit-unassigned agl brettw commit-queue eric krit webkit.review.bot oldest_to_newest 173908 0 yutak 2009-12-21 00:43:50 -0800 PlatformContextSkia::beginLayerClippedToImage is supposed to limit the current painting window to the bounds of the given image, but it does not. This makes LayoutTests/svg/custom/mask-with-all-units.svg fail in the Chromium layout test. Chromium issue: http://code.google.com/p/chromium/issues/detail?id=29056 173918 1 45314 yutak 2009-12-21 01:18:15 -0800 Created attachment 45314 PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image. 173919 2 webkit.review.bot 2009-12-21 01:21:49 -0800 style-queue ran check-webkit-style on attachment 45314 without any errors. 174681 3 agl 2009-12-23 16:26:50 -0800 LGTM. (I am not a WebKit reviewer. You need a real review before landing.) 174684 4 45314 eric 2009-12-23 16:36:49 -0800 Comment on attachment 45314 PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image. Thank you Adam. LGTM too. 174711 5 45314 commit-queue 2009-12-23 18:23:48 -0800 Comment on attachment 45314 PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image. Clearing flags on attachment: 45314 Committed r52539: <http://trac.webkit.org/changeset/52539> 174712 6 commit-queue 2009-12-23 18:23:54 -0800 All reviewed patches have been landed. Closing bug. 45314 2009-12-21 01:18:15 -0800 2009-12-23 18:23:48 -0800 PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image. bug-32817-20091221181813.patch text/plain 1962 yutak ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODBkZGEzMy4uM2VjYjVlMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0xMi0yMSAgWXV0YSBLaXRhbXVy YSAgPHl1dGFrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBQbGF0Zm9ybUNvbnRleHRTa2lhOjpiZWdpbkxheWVyQ2xpcHBlZFRv SW1hZ2UoKSBuZWVkcyB0byBjbGlwIG91dHNpZGUgb2YgdGhlIGltYWdlLgorICAgICAgICAKKyAg ICAgICAgVGhpcyBtZXRob2Qgc2hvdWxkIGxpbWl0IHRoZSBjdXJyZW50IHBhaW50aW5nIHdpbmRv dyB0byB0aGUgYm91bmRzIG9mIHRoZSBnaXZlbgorICAgICAgICBpbWFnZSwgYnV0IGl0IGRpZCBu b3QuIER1ZSB0byB0aGlzIGJ1ZywgdW5uZWNlc3NhcnkgY29udGVudHMgd2VyZSByZW5kZXJlZCBp bgorICAgICAgICBzb21lIChsaW1pdGVkKSBzaXR1YXRpb25zLgorCisgICAgICAgIFtTa2lhXSBQ bGF0Zm9ybUNvbnRleHRTa2lhOjpiZWdpbkxheWVyQ2xpcHBlZFRvSW1hZ2UgZG9lcyBub3QgY2xp cCBvdXRzaWRlIG9mIHRoZSBpbWFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzI4MTcKKyAgICAgICAgCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVj YXVzZSB0aGlzIGlzIGEgZml4IG9mIGFuIGV4aXN0aW5nIHRlc3Qgd2hpY2ggaXMgY3VycmVudGx5 IGZhaWxpbmcgaW4KKyAgICAgICAgQ2hyb21pdW0uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwOgorICAgICAgICAoUGxhdGZvcm1Db250 ZXh0U2tpYTo6YmVnaW5MYXllckNsaXBwZWRUb0ltYWdlKTogQWRkIGNsaXBSZWN0KCkgY2FsbC4K KwogMjAwOS0xMi0xOCAgRHVtaXRydSBEYW5pbGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIENocm9taXVtIGJ1aWxkIGZpeCwgbm8gcmV2aWV3LgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCmluZGV4IGRm ZmZhMGQuLjQ5MDBkZmIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAKQEAgLTIzNCw3ICsyMzQsOCBAQCB2b2lkIFBs YXRmb3JtQ29udGV4dFNraWE6OmJlZ2luTGF5ZXJDbGlwcGVkVG9JbWFnZShjb25zdCBXZWJDb3Jl OjpGbG9hdFJlY3QmIHJlYwogICAgIG1fc3RhdGUtPm1fY2xpcCA9IHJlY3Q7CiAgICAgU2tSZWN0 IGJvdW5kcyA9IHsgU2tGbG9hdFRvU2NhbGFyKHJlY3QueCgpKSwgU2tGbG9hdFRvU2NhbGFyKHJl Y3QueSgpKSwKICAgICAgICAgICAgICAgICAgICAgICBTa0Zsb2F0VG9TY2FsYXIocmVjdC5yaWdo dCgpKSwgU2tGbG9hdFRvU2NhbGFyKHJlY3QuYm90dG9tKCkpIH07Ci0gICAgICAgICAgICAgICAg ICAgICAgCisKKyAgICBjYW52YXMoKS0+Y2xpcFJlY3QoYm91bmRzKTsKICAgICBjYW52YXMoKS0+ c2F2ZUxheWVyQWxwaGEoJmJvdW5kcywgMjU1LAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzdGF0aWNfY2FzdDxTa0NhbnZhczo6U2F2ZUZsYWdzPihTa0NhbnZhczo6a0hhc0FscGhhTGF5 ZXJfU2F2ZUZsYWcgfCBTa0NhbnZhczo6a0Z1bGxDb2xvckxheWVyX1NhdmVGbGFnKSk7CiAgICAg Ly8gQ29weSBvZmYgdGhlIGltYWdlIGFzIHxpbWFnZUJ1ZmZlcnwgbWF5IGJlIGRlbGV0ZWQgYmVm b3JlIHJlc3RvcmUgaXMgaW52b2tlZC4K