32812 2009-12-20 22:32:44 -0800 Exception on queue status server 2009-12-21 01:07:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue webkit.review.bot oldest_to_newest 173871 0 eric 2009-12-20 22:32:44 -0800 http://webkit-commit-queue.appspot.com/patch/45306 Traceback (most recent call last): File "/base/python_lib/versions/1/google/appengine/ext/webapp/__init__.py", line 507, in __call__ handler.get(*groups) File "/base/data/home/apps/webkit-commit-queue/1.338594379445828621/handlers/patch.py", line 53, in get self.response.out.write(template.render("templates/patch.html", template_values)) File "/base/python_lib/versions/1/google/appengine/ext/webapp/template.py", line 81, in render return t.render(Context(template_dict)) File "/base/python_lib/versions/1/google/appengine/ext/webapp/template.py", line 121, in wrap_render return orig_render(context) File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 178, in render return self.nodelist.render(context) File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 779, in render bits.append(self.render_node(node, context)) File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 792, in render_node return node.render(context) File "/base/python_lib/versions/third_party/django-1.1/django/template/defaulttags.py", line 155, in render nodelist.append(node.render(context)) File "/base/python_lib/versions/third_party/django-1.1/django/template/defaulttags.py", line 155, in render nodelist.append(node.render(context)) File "/base/python_lib/versions/third_party/django-1.1/django/template/defaulttags.py", line 243, in render return self.nodelist_true.render(context) File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 779, in render bits.append(self.render_node(node, context)) File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 792, in render_node return node.render(context) File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 826, in render output = self.filter_expression.resolve(context) File "/base/python_lib/versions/third_party/django-1.1/django/template/__init__.py", line 572, in resolve new_obj = func(obj, *arg_vals) File "/base/python_lib/versions/third_party/django-1.1/django/template/defaultfilters.py", line 40, in _dec return func(*args, **kwargs) File "/base/data/home/apps/webkit-commit-queue/1.338594379445828621/filters/webkit_extras.py", line 59, in results_link return '<a href="/results/' + status.key().id() + '">results</a>' AttributeError: 'unicode' object has no attribute 'key' 173910 1 45311 abarth 2009-12-21 00:48:48 -0800 Created attachment 45311 Patch 173911 2 45311 eric 2009-12-21 00:50:11 -0800 Comment on attachment 45311 Patch 59 return '<a href="/results/' + status_id + '">results</a>' should really use % instead of + Otherwise LGTM. 173912 3 45312 abarth 2009-12-21 00:54:54 -0800 Created attachment 45312 Patch 173913 4 webkit.review.bot 2009-12-21 00:55:58 -0800 style-queue ran check-webkit-style on attachment 45312 without any errors. 173914 5 45312 eric 2009-12-21 00:57:03 -0800 Comment on attachment 45312 Patch LGTM. Eventually we need to come up with unit tests for this side of things too. :) Maybe just doctests. 173916 6 45312 commit-queue 2009-12-21 01:07:45 -0800 Comment on attachment 45312 Patch Clearing flags on attachment: 45312 Committed r52437: <http://trac.webkit.org/changeset/52437> 173917 7 commit-queue 2009-12-21 01:07:51 -0800 All reviewed patches have been landed. Closing bug. 45311 2009-12-21 00:48:48 -0800 2009-12-21 00:54:50 -0800 Patch bug-32812-20091221004847.patch text/plain 2850 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZTM3Zjc3Li5lZGJhNzBmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTkgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBFeGNlcHRpb24gb24gcXVl dWUgc3RhdHVzIHNlcnZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzI4MTIKKworICAgICAgICBUdXJucyBvdXQgd2UgbmVlZCB0byBwYXNzIHRoZSBp ZCB0byB0aGUgZmlsdGVyLgorCisgICAgICAgICogUXVldWVTdGF0dXNTZXJ2ZXIvZmlsdGVycy93 ZWJraXRfZXh0cmFzLnB5OgorICAgICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9w YXRjaC5odG1sOgorICAgICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9yZWNlbnRz dGF0dXMuaHRtbDoKKworMjAwOS0xMi0yMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFtienRd IEF1dG9tYXRlIHRoZSBwcm9jZXNzIG9mIGNhbGxpbmcgcHJlcGFyZS1DaGFuZ2VMb2cKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyODE2CiAKZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2ZpbHRlcnMvd2Via2l0X2V4dHJh cy5weSBiL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2ZpbHRlcnMvd2Via2l0X2V4dHJh cy5weQppbmRleCA4MDFkYTU2Li4xOTUwNTViIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9RdWV1 ZVN0YXR1c1NlcnZlci9maWx0ZXJzL3dlYmtpdF9leHRyYXMucHkKKysrIGIvV2ViS2l0VG9vbHMv UXVldWVTdGF0dXNTZXJ2ZXIvZmlsdGVycy93ZWJraXRfZXh0cmFzLnB5CkBAIC01NSw1ICs1NSw1 IEBAIGRlZiB3ZWJraXRfYXR0YWNobWVudF9pZCh2YWx1ZSk6CiAKIEByZWdpc3Rlci5maWx0ZXIK IEBzdHJpbmdmaWx0ZXIKLWRlZiByZXN1bHRzX2xpbmsoc3RhdHVzKToKLSAgICByZXR1cm4gJzxh IGhyZWY9Ii9yZXN1bHRzLycgKyBzdGF0dXMua2V5KCkuaWQoKSArICciPnJlc3VsdHM8L2E+Jwor ZGVmIHJlc3VsdHNfbGluayhzdGF0dXNfaWQpOgorICAgIHJldHVybiAnPGEgaHJlZj0iL3Jlc3Vs dHMvJyArIHN0YXR1c19pZCArICciPnJlc3VsdHM8L2E+JwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9v bHMvUXVldWVTdGF0dXNTZXJ2ZXIvdGVtcGxhdGVzL3BhdGNoLmh0bWwgYi9XZWJLaXRUb29scy9R dWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvcGF0Y2guaHRtbAppbmRleCBlMmZmZDhkLi5kZTMz NGE1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMv cGF0Y2guaHRtbAorKysgYi9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMv cGF0Y2guaHRtbApAQCAtMTMsNyArMTMsNyBAQAogICA8dWw+eyUgZm9yIHN0YXR1cyBpbiBzdGF0 dXNlcyAlfQogICAgIDxsaT4KICAgICAgIDxzcGFuIGNsYXNzPSJzdGF0dXMtbWVzc2FnZSI+e3sg c3RhdHVzLm1lc3NhZ2V8Zm9yY2VfZXNjYXBlfHVybGl6ZXx3ZWJraXRfbGlua2lmeXxzYWZlIH19 PC9zcGFuPnslIGlmIHN0YXR1cy5yZXN1bHRzX2ZpbGUgJX0KLSAgICAgIDxzcGFuIGNsYXNzPSJz dGF0dXMtcmVzdWx0cyI+W3t7IHN0YXR1c3xyZXN1bHRzX2xpbmt8c2FmZSB9fV08L3NwYW4+eyUg ZW5kaWYgJX0KKyAgICAgIDxzcGFuIGNsYXNzPSJzdGF0dXMtcmVzdWx0cyI+W3t7IHN0YXR1cy5r ZXkuaWR8cmVzdWx0c19saW5rfHNhZmUgfX1dPC9zcGFuPnslIGVuZGlmICV9CiAgICAgICA8c3Bh biBjbGFzcz0ic3RhdHVzLWRhdGUiPnt7IHN0YXR1cy5kYXRlfHRpbWVzaW5jZSB9fSBhZ288L3Nw YW4+CiAgICAgPC9saT57JSBlbmRmb3IgJX0KICAgPC91bD4KZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1F1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9yZWNlbnRzdGF0dXMuaHRtbCBiL1dlYktp dFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9yZWNlbnRzdGF0dXMuaHRtbAppbmRl eCBhNTVlMGE2Li4yYmI5ZmJiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1Nl cnZlci90ZW1wbGF0ZXMvcmVjZW50c3RhdHVzLmh0bWwKKysrIGIvV2ViS2l0VG9vbHMvUXVldWVT dGF0dXNTZXJ2ZXIvdGVtcGxhdGVzL3JlY2VudHN0YXR1cy5odG1sCkBAIC0xNSw3ICsxNSw3IEBA CiAgICAgICAgIHt7IHN0YXR1cy5hY3RpdmVfYnVnX2lkfGZvcmNlX2VzY2FwZXx3ZWJraXRfYnVn X2lkfHNhZmUgfX06CiAgICAgICA8L3NwYW4+eyUgZW5kaWYgJX0KICAgICAgIDxzcGFuIGNsYXNz PSJzdGF0dXMtbWVzc2FnZSI+e3sgc3RhdHVzLm1lc3NhZ2V8Zm9yY2VfZXNjYXBlfHVybGl6ZXx3 ZWJraXRfbGlua2lmeXxzYWZlIH19PC9zcGFuPnslIGlmIHN0YXR1cy5yZXN1bHRzX2ZpbGUgJX0K LSAgICAgIDxzcGFuIGNsYXNzPSJzdGF0dXMtcmVzdWx0cyI+W3t7IHN0YXR1c3xyZXN1bHRzX2xp bmt8c2FmZSB9fV08L3NwYW4+eyUgZW5kaWYgJX0KKyAgICAgIDxzcGFuIGNsYXNzPSJzdGF0dXMt cmVzdWx0cyI+W3t7IHN0YXR1cy5rZXkuaWR8cmVzdWx0c19saW5rfHNhZmUgfX1dPC9zcGFuPnsl IGVuZGlmICV9CiAgICAgICA8c3BhbiBjbGFzcz0ic3RhdHVzLWRhdGUiPnt7IHN0YXR1cy5kYXRl fHRpbWVzaW5jZSB9fSBhZ288L3NwYW4+CiAgICAgPC9saT57JSBlbmRmb3IgJX0KICAgPC91bD4K 45312 2009-12-21 00:54:54 -0800 2009-12-21 01:07:45 -0800 Patch bug-32812-20091221005453.patch text/plain 3348 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1ZTM3Zjc3Li5lZGJhNzBmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMTkgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBFeGNlcHRpb24gb24gcXVl dWUgc3RhdHVzIHNlcnZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzI4MTIKKworICAgICAgICBUdXJucyBvdXQgd2UgbmVlZCB0byBwYXNzIHRoZSBp ZCB0byB0aGUgZmlsdGVyLgorCisgICAgICAgICogUXVldWVTdGF0dXNTZXJ2ZXIvZmlsdGVycy93 ZWJraXRfZXh0cmFzLnB5OgorICAgICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9w YXRjaC5odG1sOgorICAgICAgICAqIFF1ZXVlU3RhdHVzU2VydmVyL3RlbXBsYXRlcy9yZWNlbnRz dGF0dXMuaHRtbDoKKworMjAwOS0xMi0yMSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFtienRd IEF1dG9tYXRlIHRoZSBwcm9jZXNzIG9mIGNhbGxpbmcgcHJlcGFyZS1DaGFuZ2VMb2cKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyODE2CiAKZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2ZpbHRlcnMvd2Via2l0X2V4dHJh cy5weSBiL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2ZpbHRlcnMvd2Via2l0X2V4dHJh cy5weQppbmRleCA4MDFkYTU2Li5iNjQ1Zjc4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9RdWV1 ZVN0YXR1c1NlcnZlci9maWx0ZXJzL3dlYmtpdF9leHRyYXMucHkKKysrIGIvV2ViS2l0VG9vbHMv UXVldWVTdGF0dXNTZXJ2ZXIvZmlsdGVycy93ZWJraXRfZXh0cmFzLnB5CkBAIC00NiwxNCArNDYs MTQgQEAgZGVmIHdlYmtpdF9saW5raWZ5KHZhbHVlKToKIEByZWdpc3Rlci5maWx0ZXIKIEBzdHJp bmdmaWx0ZXIKIGRlZiB3ZWJraXRfYnVnX2lkKHZhbHVlKToKLSAgICByZXR1cm4gJzxhIGhyZWY9 Imh0dHA6Ly93ZWJraXQub3JnL2IvJyArIHZhbHVlICsgJyI+JyArIHZhbHVlICsgJzwvYT4nCisg ICAgcmV0dXJuICc8YSBocmVmPSJodHRwOi8vd2Via2l0Lm9yZy9iLyVzIj4lczwvYT4nICUgKHZh bHVlLCB2YWx1ZSkKIAogQHJlZ2lzdGVyLmZpbHRlcgogQHN0cmluZ2ZpbHRlcgogZGVmIHdlYmtp dF9hdHRhY2htZW50X2lkKHZhbHVlKToKLSAgICByZXR1cm4gJzxhIGhyZWY9Imh0dHBzOi8vYnVn cy53ZWJraXQub3JnL2F0dGFjaG1lbnQuY2dpP2lkPScgKyB2YWx1ZSArICcmYWN0aW9uPXByZXR0 eXBhdGNoIj4nICsgdmFsdWUgKyAnPC9hPicKKyAgICByZXR1cm4gJzxhIGhyZWY9Imh0dHBzOi8v YnVncy53ZWJraXQub3JnL2F0dGFjaG1lbnQuY2dpP2lkPSVzJmFjdGlvbj1wcmV0dHlwYXRjaCI+ JXM8L2E+JyAlICh2YWx1ZSwgdmFsdWUpCiAKIEByZWdpc3Rlci5maWx0ZXIKIEBzdHJpbmdmaWx0 ZXIKLWRlZiByZXN1bHRzX2xpbmsoc3RhdHVzKToKLSAgICByZXR1cm4gJzxhIGhyZWY9Ii9yZXN1 bHRzLycgKyBzdGF0dXMua2V5KCkuaWQoKSArICciPnJlc3VsdHM8L2E+JworZGVmIHJlc3VsdHNf bGluayhzdGF0dXNfaWQpOgorICAgIHJldHVybiAnPGEgaHJlZj0iL3Jlc3VsdHMvJXMiPnJlc3Vs dHM8L2E+JyAlIHN0YXR1c19pZApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNT ZXJ2ZXIvdGVtcGxhdGVzL3BhdGNoLmh0bWwgYi9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZl ci90ZW1wbGF0ZXMvcGF0Y2guaHRtbAppbmRleCBlMmZmZDhkLi5kZTMzNGE1IDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvcGF0Y2guaHRtbAorKysg Yi9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMvcGF0Y2guaHRtbApAQCAt MTMsNyArMTMsNyBAQAogICA8dWw+eyUgZm9yIHN0YXR1cyBpbiBzdGF0dXNlcyAlfQogICAgIDxs aT4KICAgICAgIDxzcGFuIGNsYXNzPSJzdGF0dXMtbWVzc2FnZSI+e3sgc3RhdHVzLm1lc3NhZ2V8 Zm9yY2VfZXNjYXBlfHVybGl6ZXx3ZWJraXRfbGlua2lmeXxzYWZlIH19PC9zcGFuPnslIGlmIHN0 YXR1cy5yZXN1bHRzX2ZpbGUgJX0KLSAgICAgIDxzcGFuIGNsYXNzPSJzdGF0dXMtcmVzdWx0cyI+ W3t7IHN0YXR1c3xyZXN1bHRzX2xpbmt8c2FmZSB9fV08L3NwYW4+eyUgZW5kaWYgJX0KKyAgICAg IDxzcGFuIGNsYXNzPSJzdGF0dXMtcmVzdWx0cyI+W3t7IHN0YXR1cy5rZXkuaWR8cmVzdWx0c19s aW5rfHNhZmUgfX1dPC9zcGFuPnslIGVuZGlmICV9CiAgICAgICA8c3BhbiBjbGFzcz0ic3RhdHVz LWRhdGUiPnt7IHN0YXR1cy5kYXRlfHRpbWVzaW5jZSB9fSBhZ288L3NwYW4+CiAgICAgPC9saT57 JSBlbmRmb3IgJX0KICAgPC91bD4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVz U2VydmVyL3RlbXBsYXRlcy9yZWNlbnRzdGF0dXMuaHRtbCBiL1dlYktpdFRvb2xzL1F1ZXVlU3Rh dHVzU2VydmVyL3RlbXBsYXRlcy9yZWNlbnRzdGF0dXMuaHRtbAppbmRleCBhNTVlMGE2Li4yYmI5 ZmJiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci90ZW1wbGF0ZXMv cmVjZW50c3RhdHVzLmh0bWwKKysrIGIvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvdGVt cGxhdGVzL3JlY2VudHN0YXR1cy5odG1sCkBAIC0xNSw3ICsxNSw3IEBACiAgICAgICAgIHt7IHN0 YXR1cy5hY3RpdmVfYnVnX2lkfGZvcmNlX2VzY2FwZXx3ZWJraXRfYnVnX2lkfHNhZmUgfX06CiAg ICAgICA8L3NwYW4+eyUgZW5kaWYgJX0KICAgICAgIDxzcGFuIGNsYXNzPSJzdGF0dXMtbWVzc2Fn ZSI+e3sgc3RhdHVzLm1lc3NhZ2V8Zm9yY2VfZXNjYXBlfHVybGl6ZXx3ZWJraXRfbGlua2lmeXxz YWZlIH19PC9zcGFuPnslIGlmIHN0YXR1cy5yZXN1bHRzX2ZpbGUgJX0KLSAgICAgIDxzcGFuIGNs YXNzPSJzdGF0dXMtcmVzdWx0cyI+W3t7IHN0YXR1c3xyZXN1bHRzX2xpbmt8c2FmZSB9fV08L3Nw YW4+eyUgZW5kaWYgJX0KKyAgICAgIDxzcGFuIGNsYXNzPSJzdGF0dXMtcmVzdWx0cyI+W3t7IHN0 YXR1cy5rZXkuaWR8cmVzdWx0c19saW5rfHNhZmUgfX1dPC9zcGFuPnslIGVuZGlmICV9CiAgICAg ICA8c3BhbiBjbGFzcz0ic3RhdHVzLWRhdGUiPnt7IHN0YXR1cy5kYXRlfHRpbWVzaW5jZSB9fSBh Z288L3NwYW4+CiAgICAgPC9saT57JSBlbmRmb3IgJX0KICAgPC91bD4K