32796 2009-12-20 09:47:28 -0800 [check-webkit-style] static_cast is not misnamed! 2009-12-20 10:22:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned cjerdonek commit-queue eric hamaji levin webkit.review.bot oldest_to_newest 173769 0 abarth 2009-12-20 09:47:28 -0800 Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/qt/ThreadingQt.cpp:183: static_cast is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 https://bugs.webkit.org/show_bug.cgi?id=32614#c2 173770 1 45285 hamaji 2009-12-20 10:02:41 -0800 Created attachment 45285 Patch v1 173772 2 webkit.review.bot 2009-12-20 10:04:16 -0800 style-queue ran check-webkit-style on attachment 45285 without any errors. 173775 3 45285 abarth 2009-12-20 10:14:19 -0800 Comment on attachment 45285 Patch v1 LGTM! 173776 4 45285 commit-queue 2009-12-20 10:22:19 -0800 Comment on attachment 45285 Patch v1 Clearing flags on attachment: 45285 Committed r52423: <http://trac.webkit.org/changeset/52423> 173777 5 commit-queue 2009-12-20 10:22:25 -0800 All reviewed patches have been landed. Closing bug. 45285 2009-12-20 10:02:41 -0800 2009-12-20 10:22:18 -0800 Patch v1 bug-32796-20091221030239.patch text/plain 1847 hamaji ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3ZmRkMzAzLi44OWQ0ZTA1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTIt MjAgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hlY2std2Via2l0LXN0eWxl XSBzdGF0aWNfY2FzdCBpcyBub3QgbWlzbmFtZWQhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjc5NgorCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVz L2NwcF9zdHlsZS5weToKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0 ZXN0LnB5OgorCiAyMDA5LTEyLTIwICBBbGVqYW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkgYi9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5CmluZGV4IDRmYmE3NzcuLmMzNTUwMDEg MTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weQpAQCAtMjY0Niw3ICsy NjQ2LDcgQEAgZGVmIGNoZWNrX2lkZW50aWZpZXJfbmFtZV9pbl9kZWNsYXJhdGlvbihmaWxlbmFt ZSwgbGluZV9udW1iZXIsIGxpbmUsIGVycm9yKToKICAgICAgIGVycm9yOiBUaGUgZnVuY3Rpb24g dG8gY2FsbCB3aXRoIGFueSBlcnJvcnMgZm91bmQuCiAgICAgIiIiCiAgICAgIyBXZSBkb24ndCBj aGVjayBhIHJldHVybiBzdGF0ZW1lbnQuCi0gICAgaWYgbWF0Y2gocidccypyZXR1cm5cYicsIGxp bmUpOgorICAgIGlmIG1hdGNoKHInXHMqKHJldHVybnxkZWxldGUpXGInLCBsaW5lKToKICAgICAg ICAgcmV0dXJuCiAKICAgICAjIEJhc2ljYWxseSwgYSBkZWNsYXJhdGlvbiBpcyBhIHR5cGUgbmFt ZSBmb2xsb3dlZCBieSB3aGl0ZXNwYWNlcwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9k dWxlcy9jcHBfc3R5bGVfdW5pdHRlc3QucHkKaW5kZXggNTNlMTIwNS4uNWUwM2RmNSAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZV91bml0dGVzdC5weQor KysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CkBA IC0zNjU4LDYgKzM2NTgsNyBAQCBjbGFzcyBXZWJLaXRTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFz ZSk6CiAgICAgICAgICAgICAgICAgICAgICAgICAgJ3VuZGVyX3Njb3JlJyArIG5hbWVfZXJyb3Jf bWVzc2FnZSkKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnZ290byB1bmRlcl9zY29yZTsnLAog ICAgICAgICAgICAgICAgICAgICAgICAgICd1bmRlcl9zY29yZScgKyBuYW1lX2Vycm9yX21lc3Nh Z2UpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ2RlbGV0ZSBzdGF0aWNfY2FzdDxGb28qPihw KTsnLCAnJykKIAogICAgICAgICAjIE11bHRpcGxlIHZhcmlhYmxlcyBpbiBvbmUgbGluZS4KICAg ICAgICAgc2VsZi5hc3NlcnRfbGludCgndm9pZCBteUZ1bmN0aW9uKGludCB2YXJpYWJsZTEsIGlu dCBhbm90aGVyX3ZhcmlhYmxlKTsnLAo=