32786 2009-12-20 03:24:09 -0800 [WML] Compilation errors in WML enabled build. 2009-12-20 19:18:07 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 nayankk webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 173695 0 nayankk 2009-12-20 03:24:09 -0800 Due to the change in change set #52314, following errors are introduced in WebCore wml module. CXX WebCore/wml/libWebCore_la-WMLDocument.lo ../../WebCore/wml/WMLDocument.cpp: In member function ‘virtual void WebCore::WMLDocument::finishedParsing()’: ../../WebCore/wml/WMLDocument.cpp:74: error: invalid use of incomplete type ‘struct WebCore::BackForwardList’ ../../WebCore/page/Page.h:44: error: forward declaration of ‘struct WebCore::BackForwardList’ CXX WebCore/wml/libWebCore_la-WMLPageState.lo In file included from ../../WebCore/wml/WMLPageState.cpp:25: ../../WebCore/wml/WMLPageState.h:35: error: expected initializer before ‘<’ token ../../WebCore/wml/WMLPageState.h:51: error: ‘WMLVariableMap’ has not been declared ../../WebCore/wml/WMLPageState.h:69: error: ‘WMLVariableMap’ does not name a type ../../WebCore/wml/WMLPageState.h: In member function ‘void WebCore::WMLPageState::storeVariable(const WebCore::String&, const WebCore::String&)’: ../../WebCore/wml/WMLPageState.h:50: error: ‘m_variables’ was not declared in this scope ../../WebCore/wml/WMLPageState.h: In member function ‘void WebCore::WMLPageState::storeVariables(int&)’: ../../WebCore/wml/WMLPageState.h:51: error: ‘m_variables’ was not declared in this scope ../../WebCore/wml/WMLPageState.h: In member function ‘WebCore::String WebCore::WMLPageState::getVariable(const WebCore::String&) const’: ../../WebCore/wml/WMLPageState.h:52: error: ‘m_variables’ was not declared in this scope ../../WebCore/wml/WMLPageState.h: In member function ‘bool WebCore::WMLPageState::hasVariables() const’: ../../WebCore/wml/WMLPageState.h:53: error: ‘m_variables’ was not declared in this scope ../../WebCore/wml/WMLPageState.cpp: In destructor ‘virtual WebCore::WMLPageState::~WMLPageState()’: ../../WebCore/wml/WMLPageState.cpp:44: error: ‘m_variables’ was not declared in this scope ../../WebCore/wml/WMLPageState.cpp: In member function ‘void WebCore::WMLPageState::reset()’: ../../WebCore/wml/WMLPageState.cpp:63: error: ‘m_variables’ was not declared in this scope ../../WebCore/wml/WMLPageState.cpp:67: error: invalid use of incomplete type ‘struct WebCore::BackForwardList’ ../../WebCore/page/Page.h:44: error: forward declaration of ‘struct WebCore::BackForwardList’ ../../WebCore/wml/WMLPageState.cpp: In function ‘bool WebCore::tryAccessHistoryURLs(WebCore::Page*, WebCore::KURL&, WebCore::KURL&)’: ../../WebCore/wml/WMLPageState.cpp:127: error: invalid use of incomplete type ‘struct WebCore::BackForwardList’ ../../WebCore/page/Page.h:44: error: forward declaration of ‘struct WebCore::BackForwardList’ ../../WebCore/wml/WMLPageState.cpp:131: error: invalid use of incomplete type ‘struct WebCore::BackForwardList’ ../../WebCore/page/Page.h:44: error: forward declaration of ‘struct WebCore::BackForwardList’ make[1]: *** [WebCore/wml/libWebCore_la-WMLPageState.lo] Error 1 173699 1 45267 nayankk 2009-12-20 03:30:50 -0800 Created attachment 45267 Fix for compilation errors Proposed patch for resolving compilation errors is attached. 173702 2 webkit.review.bot 2009-12-20 03:34:23 -0800 Attachment 45267 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/wml/WMLPageState.cpp:31: Found header this file implements after a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebCore/wml/WMLDocument.cpp:33: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 173763 3 45267 abarth 2009-12-20 09:32:20 -0800 Comment on attachment 45267 Fix for compilation errors Please add these headers in alphabetical order. 173764 4 45284 nayankk 2009-12-20 09:38:17 -0800 Created attachment 45284 Compilation error fix. Proper fix taking care of review-bot output. 173765 5 webkit.review.bot 2009-12-20 09:38:39 -0800 style-queue ran check-webkit-style on attachment 45284 without any errors. 173855 6 45284 commit-queue 2009-12-20 19:18:02 -0800 Comment on attachment 45284 Compilation error fix. Clearing flags on attachment: 45284 Committed r52431: <http://trac.webkit.org/changeset/52431> 173856 7 commit-queue 2009-12-20 19:18:07 -0800 All reviewed patches have been landed. Closing bug. 45267 2009-12-20 03:30:50 -0800 2009-12-20 09:38:17 -0800 Fix for compilation errors Fix_bug_32786.patch text/plain 1487 nayankk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjQxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMjAgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggZm9yIGNvbXBpbGF0aW9uIGVycm9ycyBpbiBXTUwgbW9kdWxlLCBkdWUgdG8gdGhlIGNoYW5n ZXNldCAjNTIzMTQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMjc4NgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBjb21waWxhdGlvbiBl cnJvciBmaXguCisKKyAgICAgICAgKiB3bWwvV01MRG9jdW1lbnQuY3BwOgorICAgICAgICAqIHdt bC9XTUxQYWdlU3RhdGUuY3BwOgorCiAyMDA5LTEyLTIwICBBbmRyZWkgUG9wZXNjdSAgPGFuZHJl aXBAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDog V2ViQ29yZS93bWwvV01MRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dN TERvY3VtZW50LmNwcAkocmV2aXNpb24gNTI0MTEpCisrKyBXZWJDb3JlL3dtbC9XTUxEb2N1bWVu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDcgQEAKICNpbmNsdWRlICJXTUxFcnJv ckhhbmRsaW5nLmgiCiAjaW5jbHVkZSAiV01MUGFnZVN0YXRlLmgiCiAjaW5jbHVkZSAiV01MVGVt cGxhdGVFbGVtZW50LmgiCisjaW5jbHVkZSAiQmFja0ZvcndhcmRMaXN0LmgiCiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIApJbmRleDogV2ViQ29yZS93bWwvV01MUGFnZVN0YXRlLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxQYWdlU3RhdGUuY3BwCShyZXZpc2lvbiA1MjQxMSkKKysr IFdlYkNvcmUvd21sL1dNTFBhZ2VTdGF0ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyLDE0ICsy MiwxNSBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogCiAjaWYgRU5BQkxFKFdNTCkKLSNpbmNsdWRl ICJXTUxQYWdlU3RhdGUuaCIKLQogI2luY2x1ZGUgIkNTdHJpbmcuaCIKICNpbmNsdWRlICJEb2N1 bWVudC5oIgogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiSGlzdG9yeUl0ZW0uaCIKICNp bmNsdWRlICJLVVJMLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgorI2luY2x1ZGUgIldNTFBhZ2VTdGF0 ZS5oIgorI2luY2x1ZGUgIkJhY2tGb3J3YXJkTGlzdC5oIgorCiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAo= 45284 2009-12-20 09:38:17 -0800 2009-12-20 19:18:01 -0800 Compilation error fix. Fix_bug_30989_revisited.patch text/plain 1696 nayankk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjQyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTItMjAgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggZm9yIGNvbXBpbGF0aW9uIGVycm9ycyBpbiBXTUwgbW9kdWxlLCBkdWUgdG8gdGhlIGNoYW5n ZXNldCAjNTIzMTQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMjc4NgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgdGhpcyBpcyBjb21waWxhdGlvbiBl cnJvciBmaXguCisKKyAgICAgICAgKiB3bWwvV01MRG9jdW1lbnQuY3BwOgorICAgICAgICAqIHdt bC9XTUxQYWdlU3RhdGUuY3BwOgorICAgICAgICAqIHdtbC9XTUxQYWdlU3RhdGUuaDoKKwogMjAw OS0xMi0yMCAgS2V2aW4gT2xsaXZpZXIgIDxrZXZpbm9AdGhlb2xsaXZpZXJzLmNvbT4KIAogICAg ICAgICBbd3hdIGJ1aWxkIGZpeGVzIGFmdGVyIHJlY2VudCBjaGFuZ2VzLgpJbmRleDogV2ViQ29y ZS93bWwvV01MRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTERvY3Vt ZW50LmNwcAkocmV2aXNpb24gNTI0MTEpCisrKyBXZWJDb3JlL3dtbC9XTUxEb2N1bWVudC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTIzLDYgKzIzLDcgQEAKICNpZiBFTkFCTEUoV01MKQogI2luY2x1 ZGUgIldNTERvY3VtZW50LmgiCiAKKyNpbmNsdWRlICJCYWNrRm9yd2FyZExpc3QuaCIKICNpbmNs dWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJUb2tlbml6ZXIuaCIK SW5kZXg6IFdlYkNvcmUvd21sL1dNTFBhZ2VTdGF0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS93bWwvV01MUGFnZVN0YXRlLmNwcAkocmV2aXNpb24gNTI0MTEpCisrKyBXZWJDb3JlL3dtbC9X TUxQYWdlU3RhdGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw2ICsyNCw3IEBACiAjaWYgRU5B QkxFKFdNTCkKICNpbmNsdWRlICJXTUxQYWdlU3RhdGUuaCIKIAorI2luY2x1ZGUgIkJhY2tGb3J3 YXJkTGlzdC5oIgogI2luY2x1ZGUgIkNTdHJpbmcuaCIKICNpbmNsdWRlICJEb2N1bWVudC5oIgog I2luY2x1ZGUgIkZyYW1lLmgiCkluZGV4OiBXZWJDb3JlL3dtbC9XTUxQYWdlU3RhdGUuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3dtbC9XTUxQYWdlU3RhdGUuaAkocmV2aXNpb24gNTI0MTEpCisr KyBXZWJDb3JlL3dtbC9XTUxQYWdlU3RhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtMjUsNiArMjUs NyBAQAogCiAjaWYgRU5BQkxFKFdNTCkKICNpbmNsdWRlICJTdHJpbmdIYXNoLmgiCisjaW5jbHVk ZSA8d3RmL0hhc2hNYXAuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCg==