32778 2009-12-19 16:07:27 -0800 Fix Perl equality warning in run-webkit-tests 2009-12-29 00:31:44 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 dbates dbates aroben bweinstein eric webkit.review.bot oldest_to_newest 173610 0 dbates 2009-12-19 16:07:27 -0800 Notice the variable $diffPercentage is initialized to be an empty string on line 711 <http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests?rev=52296#L711>. But on line 770 <http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests?rev=52296#L770> we perform a numerical equality test (==). Instead, we should be performing a string equality test (eq). Otherwise, Perl may throw the following warning: Argument "" isn't numeric in numeric eq (==) at WebKitTools/Scripts/run-webkit-tests line 770. 173611 1 45251 dbates 2009-12-19 16:09:23 -0800 Created attachment 45251 Patch 173612 2 webkit.review.bot 2009-12-19 16:11:35 -0800 style-queue ran check-webkit-style on attachment 45251 without any errors. 173614 3 45251 eric 2009-12-19 16:31:32 -0800 Comment on attachment 45251 Patch Why not converting the string to a number? or using !? 173615 4 45252 dbates 2009-12-19 16:40:28 -0800 Created attachment 45252 Patch Changed $diffPercentage to be a number. 173616 5 webkit.review.bot 2009-12-19 16:42:09 -0800 style-queue ran check-webkit-style on attachment 45252 without any errors. 173617 6 45253 dbates 2009-12-19 16:48:23 -0800 Created attachment 45253 Patch 173618 7 webkit.review.bot 2009-12-19 16:52:29 -0800 style-queue ran check-webkit-style on attachment 45253 without any errors. 173619 8 45253 eric 2009-12-19 17:01:09 -0800 Comment on attachment 45253 Patch LGTM. 173620 9 45253 eric 2009-12-19 17:03:46 -0800 Comment on attachment 45253 Patch As you pointed out on IRC... decimal percentages. 173621 10 45254 dbates 2009-12-19 17:09:54 -0800 Created attachment 45254 Patch Reverted to $1 + 0 as in a previous attached version of the patch so that we can handle decimal percentages. 173622 11 webkit.review.bot 2009-12-19 17:12:55 -0800 style-queue ran check-webkit-style on attachment 45254 without any errors. 173878 12 45254 eric 2009-12-20 23:00:00 -0800 Comment on attachment 45254 Patch Looks OK. 175417 13 eric 2009-12-28 22:41:03 -0800 Attachment 45254 was posted by a committer and has review+, assigning to Daniel Bates for commit. 175476 14 dbates 2009-12-29 00:31:44 -0800 Committed in <http://trac.webkit.org/changeset/52613>. 45251 2009-12-19 16:09:23 -0800 2009-12-19 16:40:28 -0800 Patch Bug32778.patch text/plain 1175 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyMzk1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTItMTkgIERhbmllbCBCYXRlcyAgPGRi YXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjc3OAor CisgICAgICAgIENoYW5nZXMgbnVtZXJpY2FsIGVxdWFsaXR5ICgnPT0nKSB0byBzdHJpbmcgZXF1 YWxpdHkgKGkuZS4gJ2VxJykKKyAgICAgICAgdG8gcmVzb2x2ZSBQZXJsIHdhcm5pbmcgYWJvdXQg Y29tcGFyaW5nIGEgc3RyaW5nIHRvIGEgbnVtYmVyLgorCisgICAgICAgICogU2NyaXB0cy9ydW4t d2Via2l0LXRlc3RzOgorCiAyMDA5LTEyLTE5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0 Lm9yZz4KIApJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwkocmV2aXNpb24g NTIzODQpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMJKHdvcmtpbmcg Y29weSkKQEAgLTc2Nyw3ICs3NjcsNyBAQCBmb3IgbXkgJHRlc3QgKEB0ZXN0cykgewogICAgICAg ICAgICAgICAgICAgICAkZGlmZlJlc3VsdCA9ICQyOwogICAgICAgICAgICAgICAgIH0KICAgICAg ICAgICAgICAgICAKLSAgICAgICAgICAgICAgICBpZiAoJGRpZmZQZXJjZW50YWdlID09IDApIHsK KyAgICAgICAgICAgICAgICBpZiAoJGRpZmZQZXJjZW50YWdlIGVxICIiKSB7CiAgICAgICAgICAg ICAgICAgICAgIHByaW50RmFpbHVyZU1lc3NhZ2VGb3JUZXN0KCR0ZXN0LCAicGl4ZWwgaGFzaCBm YWlsZWQgKGJ1dCBwaXhlbCB0ZXN0IHN0aWxsIHBhc3NlcykiKTsKICAgICAgICAgICAgICAgICB9 CiAgICAgICAgICAgICB9IGVsc2lmICgkdmVyYm9zZSkgewo= 45252 2009-12-19 16:40:28 -0800 2009-12-19 16:48:23 -0800 Patch Bug32778_1.patch text/plain 1616 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyMzk1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTItMTkgIERhbmllbCBCYXRlcyAgPGRi YXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjc3OAor CisgICAgICAgIENoYW5nZXMgbnVtZXJpY2FsIGVxdWFsaXR5ICgnPT0nKSB0byBzdHJpbmcgZXF1 YWxpdHkgKGkuZS4gJ2VxJykKKyAgICAgICAgdG8gcmVzb2x2ZSBQZXJsIHdhcm5pbmcgYWJvdXQg Y29tcGFyaW5nIGEgc3RyaW5nIHRvIGEgbnVtYmVyLgorCisgICAgICAgICogU2NyaXB0cy9ydW4t d2Via2l0LXRlc3RzOgorCiAyMDA5LTEyLTE5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Via2l0 Lm9yZz4KIApJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwkocmV2aXNpb24g NTIzODQpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMJKHdvcmtpbmcg Y29weSkKQEAgLTcwOCw3ICs3MDgsNyBAQCBmb3IgbXkgJHRlc3QgKEB0ZXN0cykgewogCiAgICAg bXkgJGFjdHVhbFBORyA9ICIiOwogICAgIG15ICRkaWZmUE5HID0gIiI7Ci0gICAgbXkgJGRpZmZQ ZXJjZW50YWdlID0gIiI7CisgICAgbXkgJGRpZmZQZXJjZW50YWdlID0gMDsKICAgICBteSAkZGlm ZlJlc3VsdCA9ICJwYXNzZWQiOwogCiAgICAgbXkgJGFjdHVhbEhhc2ggPSAiIjsKQEAgLTc2Miwx MiArNzYyLDEyIEBAIGZvciBteSAkdGVzdCAoQHRlc3RzKSB7CiAgICAgICAgICAgICAgICAgfQog CiAgICAgICAgICAgICAgICAgaWYgKC9eZGlmZjogKC4rKSUgKHBhc3NlZHxmYWlsZWQpLykgewot ICAgICAgICAgICAgICAgICAgICAkZGlmZlBlcmNlbnRhZ2UgPSAkMTsKKyAgICAgICAgICAgICAg ICAgICAgJGRpZmZQZXJjZW50YWdlID0gJDEgKyAwOwogICAgICAgICAgICAgICAgICAgICAkaW1h Z2VEaWZmZXJlbmNlc3skYmFzZX0gPSAkZGlmZlBlcmNlbnRhZ2U7CiAgICAgICAgICAgICAgICAg ICAgICRkaWZmUmVzdWx0ID0gJDI7CiAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAg IAotICAgICAgICAgICAgICAgIGlmICgkZGlmZlBlcmNlbnRhZ2UgPT0gMCkgeworICAgICAgICAg ICAgICAgIGlmICghJGRpZmZQZXJjZW50YWdlKSB7CiAgICAgICAgICAgICAgICAgICAgIHByaW50 RmFpbHVyZU1lc3NhZ2VGb3JUZXN0KCR0ZXN0LCAicGl4ZWwgaGFzaCBmYWlsZWQgKGJ1dCBwaXhl bCB0ZXN0IHN0aWxsIHBhc3NlcykiKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9 IGVsc2lmICgkdmVyYm9zZSkgewo= 45253 2009-12-19 16:48:23 -0800 2009-12-19 17:09:54 -0800 Patch Bug32778_1.patch text/plain 1591 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyMzk1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTItMTkgIERhbmllbCBCYXRlcyAgPGRi YXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjc3OAor CisgICAgICAgIENoYW5nZXMgJGRpZmZQZXJjZW50YWdlIHRvIGJlIGEgbnVtYmVyIHRvIHJlc29s dmUgUGVybAorICAgICAgICB3YXJuaW5nIGFib3V0IGNvbXBhcmluZyBhIHN0cmluZyB0byBhIG51 bWJlci4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0czoKKwogMjAwOS0xMi0x OSAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAKSW5kZXg6IFdlYktpdFRvb2xz L1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3Jp cHRzL3J1bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDUyMzg0KQorKysgV2ViS2l0VG9vbHMvU2Ny aXB0cy9ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC03MDgsNyArNzA4LDcgQEAg Zm9yIG15ICR0ZXN0IChAdGVzdHMpIHsKIAogICAgIG15ICRhY3R1YWxQTkcgPSAiIjsKICAgICBt eSAkZGlmZlBORyA9ICIiOwotICAgIG15ICRkaWZmUGVyY2VudGFnZSA9ICIiOworICAgIG15ICRk aWZmUGVyY2VudGFnZSA9IDA7CiAgICAgbXkgJGRpZmZSZXN1bHQgPSAicGFzc2VkIjsKIAogICAg IG15ICRhY3R1YWxIYXNoID0gIiI7CkBAIC03NjIsMTIgKzc2MiwxMiBAQCBmb3IgbXkgJHRlc3Qg KEB0ZXN0cykgewogICAgICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgICAgIGlmICgvXmRp ZmY6ICguKyklIChwYXNzZWR8ZmFpbGVkKS8pIHsKLSAgICAgICAgICAgICAgICAgICAgJGRpZmZQ ZXJjZW50YWdlID0gJDE7CisgICAgICAgICAgICAgICAgICAgICRkaWZmUGVyY2VudGFnZSA9IGlu dCgkMSk7CiAgICAgICAgICAgICAgICAgICAgICRpbWFnZURpZmZlcmVuY2VzeyRiYXNlfSA9ICRk aWZmUGVyY2VudGFnZTsKICAgICAgICAgICAgICAgICAgICAgJGRpZmZSZXN1bHQgPSAkMjsKICAg ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgCi0gICAgICAgICAgICAgICAgaWYgKCRk aWZmUGVyY2VudGFnZSA9PSAwKSB7CisgICAgICAgICAgICAgICAgaWYgKCEkZGlmZlBlcmNlbnRh Z2UpIHsKICAgICAgICAgICAgICAgICAgICAgcHJpbnRGYWlsdXJlTWVzc2FnZUZvclRlc3QoJHRl c3QsICJwaXhlbCBoYXNoIGZhaWxlZCAoYnV0IHBpeGVsIHRlc3Qgc3RpbGwgcGFzc2VzKSIpOwog ICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0gZWxzaWYgKCR2ZXJib3NlKSB7Cg== 45254 2009-12-19 17:09:54 -0800 2009-12-20 23:00:00 -0800 Patch Bug32778_1.patch text/plain 1590 dbates SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyMzk1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTItMTkgIERhbmllbCBCYXRlcyAgPGRi YXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjc3OAor CisgICAgICAgIENoYW5nZXMgJGRpZmZQZXJjZW50YWdlIHRvIGJlIGEgbnVtYmVyIHRvIHJlc29s dmUgUGVybAorICAgICAgICB3YXJuaW5nIGFib3V0IGNvbXBhcmluZyBhIHN0cmluZyB0byBhIG51 bWJlci4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0czoKKwogMjAwOS0xMi0x OSAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHdlYmtpdC5vcmc+CiAKSW5kZXg6IFdlYktpdFRvb2xz L1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3Jp cHRzL3J1bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDUyMzg0KQorKysgV2ViS2l0VG9vbHMvU2Ny aXB0cy9ydW4td2Via2l0LXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC03MDgsNyArNzA4LDcgQEAg Zm9yIG15ICR0ZXN0IChAdGVzdHMpIHsKIAogICAgIG15ICRhY3R1YWxQTkcgPSAiIjsKICAgICBt eSAkZGlmZlBORyA9ICIiOwotICAgIG15ICRkaWZmUGVyY2VudGFnZSA9ICIiOworICAgIG15ICRk aWZmUGVyY2VudGFnZSA9IDA7CiAgICAgbXkgJGRpZmZSZXN1bHQgPSAicGFzc2VkIjsKIAogICAg IG15ICRhY3R1YWxIYXNoID0gIiI7CkBAIC03NjIsMTIgKzc2MiwxMiBAQCBmb3IgbXkgJHRlc3Qg KEB0ZXN0cykgewogICAgICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgICAgIGlmICgvXmRp ZmY6ICguKyklIChwYXNzZWR8ZmFpbGVkKS8pIHsKLSAgICAgICAgICAgICAgICAgICAgJGRpZmZQ ZXJjZW50YWdlID0gJDE7CisgICAgICAgICAgICAgICAgICAgICRkaWZmUGVyY2VudGFnZSA9ICQx ICsgMDsKICAgICAgICAgICAgICAgICAgICAgJGltYWdlRGlmZmVyZW5jZXN7JGJhc2V9ID0gJGRp ZmZQZXJjZW50YWdlOwogICAgICAgICAgICAgICAgICAgICAkZGlmZlJlc3VsdCA9ICQyOwogICAg ICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICAKLSAgICAgICAgICAgICAgICBpZiAoJGRp ZmZQZXJjZW50YWdlID09IDApIHsKKyAgICAgICAgICAgICAgICBpZiAoISRkaWZmUGVyY2VudGFn ZSkgewogICAgICAgICAgICAgICAgICAgICBwcmludEZhaWx1cmVNZXNzYWdlRm9yVGVzdCgkdGVz dCwgInBpeGVsIGhhc2ggZmFpbGVkIChidXQgcGl4ZWwgdGVzdCBzdGlsbCBwYXNzZXMpIik7CiAg ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfSBlbHNpZiAoJHZlcmJvc2UpIHsK