32753 2009-12-18 16:08:22 -0800 REGRESSION(52325) Chromium build broken due to link failure 2009-12-18 16:33:44 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned mjs pkasting sam oldest_to_newest 173377 0 eric 2009-12-18 16:08:22 -0800 REGRESSION(52325) Chromium build broken due to link failure http://build.chromium.org/buildbot/waterfall.fyi/builders/Webkit%20Mac%20(webkit.org)/builds/11702/steps/compile/logs/stdio Ld /b/slave/webkit-rel-mac-webkit-org/build/src/webkit/tools/test_shell/../../../xcodebuild/Release/test_shell_tests normal i386 cd /b/slave/webkit-rel-mac-webkit-org/build/src/webkit/tools/test_shell setenv MACOSX_DEPLOYMENT_TARGET 10.5 /Developer/usr/bin/g++-4.2 -arch i386 [snip] Undefined symbols: "_wkNoteOpenPanelFiles", referenced from: _wkNoteOpenPanelFiles$non_lazy_ptr in libwebcore.a(WebSystemInterface.o) "_WKNoteOpenPanelFiles", referenced from: _WKNoteOpenPanelFiles$non_lazy_ptr in libwebcore.a(WebSystemInterface.o) ld: symbol(s) not found The failure does not occur on the webkit.org builders yet, because it doesn't link against anything yet. The solution is to include platform.h from WebSystemInterface.m to make sure that we get the right symbol on Leopard. I'm going to make a quick-and-dirty include platform.h fix. Eventually we might wish to use a config.h wrapper around platform.h instead. 173379 1 pkasting 2009-12-18 16:12:38 -0800 Edited IRC log for posterity: <pkasting> othermaciej mentioned the idea of adding a config.h for this section of the project and just having it #include Platform.h <othermaciej> WebCore and JavaScriptCore have a rule that config.h must be the first include in every file <othermaciej> it seems reasonable to me to do that for WebKit too <eseidel> sounds like othermaciej's idea is a good one, as usual :) <eseidel> I think the utility of a non-PCH build has not at least historically been well understood <eseidel> with XCode eventually moving to distcc 3, everyone will want a non-PCH build eventually <pkasting> So is the resolution here that we should, in fact, add a config.h to WebKit, have it #include Platform.h, and add #include config.h to all the source files? <eseidel> I would just add it to the files you need to un-break the build <eseidel> and we can let webkit.org bake on that policy for a while <eseidel> I think it's important to un-break the build, but we can figure out what the final full-scale policy change looks like later 173390 2 45202 eric 2009-12-18 16:25:39 -0800 Created attachment 45202 Patch 173391 3 45202 abarth 2009-12-18 16:26:24 -0800 Comment on attachment 45202 Patch ok 173393 4 45202 pkasting 2009-12-18 16:26:59 -0800 Comment on attachment 45202 Patch > +// Neded builds not using PCH to expose BUILDING_ macros, see bug 32753. "Neded" -> "Needed for" 173395 5 45204 eric 2009-12-18 16:28:07 -0800 Created attachment 45204 Now with moar betr smelling 173398 6 45205 eric 2009-12-18 16:30:27 -0800 Created attachment 45205 I should re-enroll in 3rd grade, clearly. 173401 7 45205 abarth 2009-12-18 16:32:07 -0800 Comment on attachment 45205 I should re-enroll in 3rd grade, clearly. ok. I spelt goood to 173403 8 eric 2009-12-18 16:33:44 -0800 Committed r52356: <http://trac.webkit.org/changeset/52356> 45202 2009-12-18 16:25:39 -0800 2009-12-18 16:28:02 -0800 Patch bug-32753-20091218162537.patch text/plain 1414 eric ZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cK aW5kZXggODAwZTk5OC4uNWU0Zjg4YyAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMi0xOCAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTig1MjMyNSkgQ2hyb21pdW0gYnVpbGQg YnJva2VuIGR1ZSB0byBsaW5rIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMyNzUzCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJT eXN0ZW1JbnRlcmZhY2UubToKKyAgICAgICAgIC0gQ2hyb21pdW0gTWFjIGJ1aWxkcyB1c2UgdGhp cyBmaWxlLCBidXQgZG8gbm90CisgICAgICAgICAgIGVuYWJsZSBQcmUtY29tcGlsZWQgSGVhZGVy IChQQ0gpIGZpbGVzIHNvIHRoYXQKKyAgICAgICAgICAgQ2hyb21pdW0gYnVpbGQgYm90cyBjYW4g dGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIGZhc3RlcgorICAgICAgICAgICBkaXN0Y2MgMy4gIEV2ZW50 dWFsbHkgYWxsIG1hYyBidWlsZHMgd2lsbCBsaWtlbHkgdXNlCisgICAgICAgICAgIGRpc3RjYywg YnV0IGZvciBub3cgd2UnbGwgYWRkIFBsYXRmb3JtLmggaGVyZSBhbmQgZG9jdW1lbnQKKyAgICAg ICAgICAgaXRzIHVzYWdlIHNvIGl0J3Mgbm90IHJlbW92ZWQgYnkgYWNjaWRlbnQuCisKIDIwMDkt MTItMTggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0 L1dlYlN5c3RlbUludGVyZmFjZS5tIGIvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJTeXN0 ZW1JbnRlcmZhY2UubQppbmRleCA3ZGYwZmYwLi44MDlkMGVkIDEwMDY0NAotLS0gYS9XZWJLaXQv bWFjL1dlYkNvcmVTdXBwb3J0L1dlYlN5c3RlbUludGVyZmFjZS5tCisrKyBiL1dlYktpdC9tYWMv V2ViQ29yZVN1cHBvcnQvV2ViU3lzdGVtSW50ZXJmYWNlLm0KQEAgLTMxLDYgKzMxLDkgQEAKICNp bXBvcnQgPFdlYkNvcmUvV2ViQ29yZVN5c3RlbUludGVyZmFjZS5oPgogI2ltcG9ydCA8V2ViS2l0 U3lzdGVtSW50ZXJmYWNlLmg+CiAKKy8vIE5lZGVkIGJ1aWxkcyBub3QgdXNpbmcgUENIIHRvIGV4 cG9zZSBCVUlMRElOR18gbWFjcm9zLCBzZWUgYnVnIDMyNzUzLgorI2luY2x1ZGUgPHd0Zi9QbGF0 Zm9ybS5oPgorCiAjZGVmaW5lIElOSVQoZnVuY3Rpb24pIHdrIyNmdW5jdGlvbiA9IFdLIyNmdW5j dGlvbgogCiB2b2lkIEluaXRXZWJDb3JlU3lzdGVtSW50ZXJmYWNlKHZvaWQpCg== 45204 2009-12-18 16:28:07 -0800 2009-12-18 16:30:22 -0800 Now with moar betr smelling bug-32753-20091218162806.patch text/plain 1415 eric ZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cK aW5kZXggODAwZTk5OC4uNWU0Zjg4YyAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMi0xOCAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTig1MjMyNSkgQ2hyb21pdW0gYnVpbGQg YnJva2VuIGR1ZSB0byBsaW5rIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMyNzUzCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJT eXN0ZW1JbnRlcmZhY2UubToKKyAgICAgICAgIC0gQ2hyb21pdW0gTWFjIGJ1aWxkcyB1c2UgdGhp cyBmaWxlLCBidXQgZG8gbm90CisgICAgICAgICAgIGVuYWJsZSBQcmUtY29tcGlsZWQgSGVhZGVy IChQQ0gpIGZpbGVzIHNvIHRoYXQKKyAgICAgICAgICAgQ2hyb21pdW0gYnVpbGQgYm90cyBjYW4g dGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIGZhc3RlcgorICAgICAgICAgICBkaXN0Y2MgMy4gIEV2ZW50 dWFsbHkgYWxsIG1hYyBidWlsZHMgd2lsbCBsaWtlbHkgdXNlCisgICAgICAgICAgIGRpc3RjYywg YnV0IGZvciBub3cgd2UnbGwgYWRkIFBsYXRmb3JtLmggaGVyZSBhbmQgZG9jdW1lbnQKKyAgICAg ICAgICAgaXRzIHVzYWdlIHNvIGl0J3Mgbm90IHJlbW92ZWQgYnkgYWNjaWRlbnQuCisKIDIwMDkt MTItMTggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0 L1dlYlN5c3RlbUludGVyZmFjZS5tIGIvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJTeXN0 ZW1JbnRlcmZhY2UubQppbmRleCA3ZGYwZmYwLi4zMjQ0ZmFjIDEwMDY0NAotLS0gYS9XZWJLaXQv bWFjL1dlYkNvcmVTdXBwb3J0L1dlYlN5c3RlbUludGVyZmFjZS5tCisrKyBiL1dlYktpdC9tYWMv V2ViQ29yZVN1cHBvcnQvV2ViU3lzdGVtSW50ZXJmYWNlLm0KQEAgLTMxLDYgKzMxLDkgQEAKICNp bXBvcnQgPFdlYkNvcmUvV2ViQ29yZVN5c3RlbUludGVyZmFjZS5oPgogI2ltcG9ydCA8V2ViS2l0 U3lzdGVtSW50ZXJmYWNlLmg+CiAKKy8vIE5lZWRlZCBidWlsZHMgbm90IHVzaW5nIFBDSCB0byBl eHBvc2UgQlVJTERJTkdfIG1hY3Jvcywgc2VlIGJ1ZyAzMjc1My4KKyNpbmNsdWRlIDx3dGYvUGxh dGZvcm0uaD4KKwogI2RlZmluZSBJTklUKGZ1bmN0aW9uKSB3ayMjZnVuY3Rpb24gPSBXSyMjZnVu Y3Rpb24KIAogdm9pZCBJbml0V2ViQ29yZVN5c3RlbUludGVyZmFjZSh2b2lkKQo= 45205 2009-12-18 16:30:27 -0800 2009-12-18 16:32:06 -0800 I should re-enroll in 3rd grade, clearly. bug-32753-20091218163025.patch text/plain 1419 eric ZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cK aW5kZXggODAwZTk5OC4uNWU0Zjg4YyAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMi0xOCAg RXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUkVHUkVTU0lPTig1MjMyNSkgQ2hyb21pdW0gYnVpbGQg YnJva2VuIGR1ZSB0byBsaW5rIGZhaWx1cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMyNzUzCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJT eXN0ZW1JbnRlcmZhY2UubToKKyAgICAgICAgIC0gQ2hyb21pdW0gTWFjIGJ1aWxkcyB1c2UgdGhp cyBmaWxlLCBidXQgZG8gbm90CisgICAgICAgICAgIGVuYWJsZSBQcmUtY29tcGlsZWQgSGVhZGVy IChQQ0gpIGZpbGVzIHNvIHRoYXQKKyAgICAgICAgICAgQ2hyb21pdW0gYnVpbGQgYm90cyBjYW4g dGFrZSBhZHZhbnRhZ2Ugb2YgdGhlIGZhc3RlcgorICAgICAgICAgICBkaXN0Y2MgMy4gIEV2ZW50 dWFsbHkgYWxsIG1hYyBidWlsZHMgd2lsbCBsaWtlbHkgdXNlCisgICAgICAgICAgIGRpc3RjYywg YnV0IGZvciBub3cgd2UnbGwgYWRkIFBsYXRmb3JtLmggaGVyZSBhbmQgZG9jdW1lbnQKKyAgICAg ICAgICAgaXRzIHVzYWdlIHNvIGl0J3Mgbm90IHJlbW92ZWQgYnkgYWNjaWRlbnQuCisKIDIwMDkt MTItMTggIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBbmRlcnMgQ2FybHNzb24uCmRpZmYgLS1naXQgYS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0 L1dlYlN5c3RlbUludGVyZmFjZS5tIGIvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJTeXN0 ZW1JbnRlcmZhY2UubQppbmRleCA3ZGYwZmYwLi45ZGI0NmNjIDEwMDY0NAotLS0gYS9XZWJLaXQv bWFjL1dlYkNvcmVTdXBwb3J0L1dlYlN5c3RlbUludGVyZmFjZS5tCisrKyBiL1dlYktpdC9tYWMv V2ViQ29yZVN1cHBvcnQvV2ViU3lzdGVtSW50ZXJmYWNlLm0KQEAgLTMxLDYgKzMxLDkgQEAKICNp bXBvcnQgPFdlYkNvcmUvV2ViQ29yZVN5c3RlbUludGVyZmFjZS5oPgogI2ltcG9ydCA8V2ViS2l0 U3lzdGVtSW50ZXJmYWNlLmg+CiAKKy8vIE5lZWRlZCBmb3IgYnVpbGRzIG5vdCB1c2luZyBQQ0gg dG8gZXhwb3NlIEJVSUxESU5HXyBtYWNyb3MsIHNlZSBidWcgMzI3NTMuCisjaW5jbHVkZSA8d3Rm L1BsYXRmb3JtLmg+CisKICNkZWZpbmUgSU5JVChmdW5jdGlvbikgd2sjI2Z1bmN0aW9uID0gV0sj I2Z1bmN0aW9uCiAKIHZvaWQgSW5pdFdlYkNvcmVTeXN0ZW1JbnRlcmZhY2Uodm9pZCkK