32741 2009-12-18 14:25:57 -0800 upstream platform/chromium/fast/dom/interval.html 2009-12-22 13:44:12 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke commit-queue darin eric webkit.review.bot oldest_to_newest 173330 0 dpranke 2009-12-18 14:25:57 -0800 Add platform-specific chromium test of the 'chromium.Interval' methods. 173331 1 45187 dpranke 2009-12-18 14:26:41 -0800 Created attachment 45187 Patch 173332 2 webkit.review.bot 2009-12-18 14:28:19 -0800 style-queue ran check-webkit-style on attachment 45187 without any errors. 173574 3 eric 2009-12-19 12:17:25 -0800 What is chromium.Interval? Is it implemented in webkit? 174091 4 dpranke 2009-12-21 14:03:45 -0800 I have no idea what it is, and no, it's not implemented in WebKit. I'd like to upstream the test and then hunt this down after we've gotten rid of all the downstream-only tests. 174360 5 45187 eric 2009-12-22 13:25:54 -0800 Comment on attachment 45187 Patch I'm not really sure what this is for, but it seems non-harmful. 174362 6 dpranke 2009-12-22 13:33:57 -0800 okay, chromium-interval appears to be some sort of v8 extension the network guys added, presumably to do profiling / perf analysis. 174365 7 eric 2009-12-22 13:38:17 -0800 Are there other things tucked behind chromium. ? Do these need to be exposed to all web pages? 174367 8 45187 commit-queue 2009-12-22 13:44:07 -0800 Comment on attachment 45187 Patch Clearing flags on attachment: 45187 Committed r52498: <http://trac.webkit.org/changeset/52498> 174368 9 commit-queue 2009-12-22 13:44:12 -0800 All reviewed patches have been landed. Closing bug. 45187 2009-12-18 14:26:41 -0800 2009-12-22 13:44:07 -0800 Patch bug-32741-20091218142639.patch text/plain 3420 dpranke ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhYWE4YzY5Li45NzYwYWJmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTIt MTggIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHBsYXRmb3JtLXNwZWNpZmljIGNo cm9taXVtIHRlc3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMjc0MQorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9kb20vaW50ZXJ2 YWwtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9mYXN0 L2RvbS9pbnRlcnZhbC5odG1sOiBBZGRlZC4KKwogMjAwOS0xMi0xOCAgS2VubmV0aCBSdXNzZWxs ICA8a2JyQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9kb20vaW50ZXJ2 YWwtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFzdC9kb20v aW50ZXJ2YWwtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LmY2OWZjN2YKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS9mYXN0L2RvbS9pbnRlcnZhbC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw5IEBACitUaGlzIHRl c3RzIHRoYXQgdGhlIGNocm9taXVtLkludGVydmFsIGZ1bmN0aW9uYWxpdHkgd29ya3MgY29ycmVj dGx5LgorCitQQVNTIC0gaW5pdGlhbCB6ZXJvCitQQVNTIC0gc3RhcnQKK1BBU1MgLSByZXN0YXJ0 CitQQVNTIC0gaW5pdGlhbCBzdG9wCitQQVNTIC0gc3RvcAorUEFTUyAtIHN0b3BwZWQKK1BBU1Mg LSByZS1zdG9wcGVkCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9m YXN0L2RvbS9pbnRlcnZhbC5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vZmFz dC9kb20vaW50ZXJ2YWwuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5i MDUwMzZkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0v ZmFzdC9kb20vaW50ZXJ2YWwuaHRtbApAQCAtMCwwICsxLDc2IEBACis8aHRtbD4KKzxib2R5IG9u bG9hZD0idGVzdCgpIj4KKzxkaXYgaWQ9InJlc3VsdCI+Cis8cD4KK1RoaXMgdGVzdHMgdGhhdCB0 aGUgY2hyb21pdW0uSW50ZXJ2YWwgZnVuY3Rpb25hbGl0eSB3b3JrcyBjb3JyZWN0bHkuCis8L3A+ Cis8L2Rpdj4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7Cisg IGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KKwordmFyIHJlc3VsdERpdiA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1bHQiKTsKKworZnVuY3Rpb24gY2hlY2sobmFt ZSwgcGFzc2VkLCBkZWJ1Z19vdXRwdXQpIHsKKyAgaWYgKHBhc3NlZCkgeworICAgIHJlc3VsdERp di5pbm5lckhUTUwgKz0gIlBBU1MgLSAiICsgbmFtZSArICI8YnI+IjsKKyAgfSBlbHNlIHsKKyAg ICByZXN1bHREaXYuaW5uZXJIVE1MICs9ICJGQUlMIC0gIiArIG5hbWUgKyAiLCBkZWJ1Z19vdXRw dXQ6ICIgKyBkZWJ1Z19vdXRwdXQgKyAiPGJyPiI7CisgIH0KK30KKworLy8gU3BpbiBsb29wIGZv ciBhIHNob3J0IHRpbWUKK2Z1bmN0aW9uIHBhdXNlKG1pbGxpc2VjcykgeworICB2YXIgc3RhcnQg PSBuZXcgRGF0ZSgpOworICB3aGlsZSAoKG5ldyBEYXRlKCkgLSBzdGFydCkgPCBtaWxsaXNlY3Mp OworfQorCisKK2Z1bmN0aW9uIHRlc3QoKSB7CisgIHZhciBpbnRlcnZhbCA9IG5ldyBjaHJvbWl1 bS5JbnRlcnZhbCgpOworCisgIC8vIFZlcmlmeSBpbml0aWFsaXphdGlvbi4KKyAgdmFyIG1zID0g aW50ZXJ2YWwubWljcm9zZWNvbmRzKCk7CisgIGNoZWNrKCJpbml0aWFsIHplcm8iLCBtcyA9PSAw LCAiW21zOiAiICsgbXMgKyAiXSIpOworCisgIC8vIFZlcmlmeSB0aGF0IHN0YXJ0aW5nIHRoZSB0 aW1lciB3b3Jrcy4KKyAgaW50ZXJ2YWwuc3RhcnQoKTsKKyAgcGF1c2UoNTApOworICBtcyA9IGlu dGVydmFsLm1pY3Jvc2Vjb25kcygpOworICAvLyBEdWUgdG8gY2xvY2sgc2tldyBhbmQgZ3JhbnVs YXJpdHksIHdlIHNlZSBzcG9yYWRpYyBmYWlsdXJlcyBpZiB3ZSBjaGVjayBmb3IKKyAgLy8gbXMg Pj0gNTAwMDAsIHNvIGFkZCBhIGJpdCBvZiBidWZmZXIuCisgIGNoZWNrKCJzdGFydCIsIG1zID49 IDQ5MDAwLCAiW21zOiAiICsgbXMgKyAiXSIpOworCisgIC8vIFZlcmlmeSB0aGF0IHJlc3RhcnRp bmcgdGhlIGludGVydmFsIHNob3VsZCByZXNldCB0aGUgYmVnaW5uaW5nIHRpbWUKKyAgaW50ZXJ2 YWwuc3RhcnQoKTsKKyAgcGF1c2UoMSk7CisgIG1zID0gaW50ZXJ2YWwubWljcm9zZWNvbmRzKCk7 CisgIGNoZWNrKCJyZXN0YXJ0IiwgbXMgPiAwICYmIG1zIDwgNTAwMDAsICJbbXM6ICIgKyBtcyAr ICJdIik7CisKKyAgLy8gVmVyaWZ5IHRoYXQgY2FsbGluZyBzdG9wKCkgYmVmb3JlIHN0YXJ0KCkg aGFzIG5vIGVmZmVjdC4KKyAgdmFyIGludGVydmFsID0gbmV3IGNocm9taXVtLkludGVydmFsKCk7 CisgIGludGVydmFsLnN0b3AoKTsKKyAgbXMgPSBpbnRlcnZhbC5taWNyb3NlY29uZHMoKTsKKyAg Y2hlY2soImluaXRpYWwgc3RvcCIsIG1zID09IDAsICJbbXM6ICIgKyBtcyArICJdIik7CisKKyAg Ly8gVmVyaWZ5IGEgc3RhcnQvc3RvcCBzZXF1ZW5jZS4KKyAgaW50ZXJ2YWwuc3RhcnQoKTsKKyAg cGF1c2UoNTApOworICBpbnRlcnZhbC5zdG9wKCk7CisgIG1zID0gaW50ZXJ2YWwubWljcm9zZWNv bmRzKCk7CisgIGNoZWNrKCJzdG9wIiwgbXMgPiAwICYmIG1zIDwgMTAwMDAwLCAiW21zOiAiICsg bXMgKyAiXSIpOworCisgIC8vIFZlcmlmeSB0aGF0IHRoZSB0aW1lciBpcyByZWFsbHkgc3RvcHBl ZC4KKyAgdmFyIG1zMiA9IGludGVydmFsLm1pY3Jvc2Vjb25kcygpOworICBjaGVjaygic3RvcHBl ZCIsIG1zID09IG1zMiwgIlttczogIiArIG1zICsgIl0iICsgIlttczI6ICIgKyBtczIgKyAiXSIp OworCisgIC8vIFZlcmlmeSB0aGF0IHJlLXN0b3BwaW5nIHRoZSB0aW1lciB3b3Jrcy4KKyAgcGF1 c2UoNTApOworICBpbnRlcnZhbC5zdG9wKCk7CisgIG1zMiA9IGludGVydmFsLm1pY3Jvc2Vjb25k cygpOworICBjaGVjaygicmUtc3RvcHBlZCIsIG1zMiA+IG1zLCAiW21zOiAiICsgbXMgKyAiXSIg KyAiW21zMjogIiArIG1zMiArICJdIik7Cit9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K