32729 2009-12-18 12:05:08 -0800 move bugzilla.py off of urllib2 2009-12-18 13:46:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 28777 1 eric webkit-unassigned abarth commit-queue webkit.review.bot oldest_to_newest 173251 0 eric 2009-12-18 12:05:08 -0800 move bugzilla.py off of urllib2 This paves the way for us to be able to support security bugs with bugzilla-tool, because our mechanize codepath knows how to authenticate and the urllib2 one did not. I just didn't know python at all when I was writing this code. :) 173253 1 45170 eric 2009-12-18 12:12:25 -0800 Created attachment 45170 Patch 173257 2 webkit.review.bot 2009-12-18 12:17:33 -0800 style-queue ran check-webkit-style on attachment 45170 without any errors. 173311 3 45170 commit-queue 2009-12-18 13:46:01 -0800 Comment on attachment 45170 Patch Clearing flags on attachment: 45170 Committed r52339: <http://trac.webkit.org/changeset/52339> 173312 4 commit-queue 2009-12-18 13:46:06 -0800 All reviewed patches have been landed. Closing bug. 45170 2009-12-18 12:12:25 -0800 2009-12-18 13:46:01 -0800 Patch bug-32729-20091218141223.patch text/plain 2878 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmODM3ODQ3Li5kNzJkNjZlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDktMTIt MTggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIG1vdmUgYnVnemlsbGEucHkgb2ZmIG9mIHVybGxp YjIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNzI5 CisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvYnVnemlsbGEucHk6IHVzZSBtZWNoYW5pemUg Zm9yIGFsbCB1cmwgZmV0Y2hpbmcuCisKIDIwMDktMTItMTggIEd1c3Rhdm8gTm9yb25oYSBTaWx2 YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgUnViYmVyLXN0 YW1wZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2J1Z3ppbGxhLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1Z3ppbGxhLnB5 CmluZGV4IGIzMDY0ODMuLmU1ZGQ2MTMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMv bW9kdWxlcy9idWd6aWxsYS5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVn emlsbGEucHkKQEAgLTMxLDcgKzMxLDYgQEAKIAogaW1wb3J0IHJlCiBpbXBvcnQgc3VicHJvY2Vz cwotaW1wb3J0IHVybGxpYjIKIAogZnJvbSBkYXRldGltZSBpbXBvcnQgZGF0ZXRpbWUgIyB1c2Vk IGluIHRpbWVzdGFtcCgpCiAKQEAgLTExNyw3ICsxMTYsNyBAQCBjbGFzcyBCdWd6aWxsYShvYmpl Y3QpOgogICAgICAgICBidWdfdXJsID0gc2VsZi5idWdfdXJsX2Zvcl9idWdfaWQoYnVnX2lkLCB4 bWw9VHJ1ZSkKICAgICAgICAgbG9nKCJGZXRjaGluZzogJXMiICUgYnVnX3VybCkKIAotICAgICAg ICBwYWdlID0gdXJsbGliMi51cmxvcGVuKGJ1Z191cmwpCisgICAgICAgIHBhZ2UgPSBzZWxmLmJy b3dzZXIub3BlbihidWdfdXJsKQogICAgICAgICBzb3VwID0gQmVhdXRpZnVsU291cChwYWdlKQog CiAgICAgICAgIGF0dGFjaG1lbnRzID0gW10KQEAgLTEzNiw3ICsxMzUsNyBAQCBjbGFzcyBCdWd6 aWxsYShvYmplY3QpOgogICAgIGRlZiBidWdfaWRfZm9yX2F0dGFjaG1lbnRfaWQoc2VsZiwgYXR0 YWNobWVudF9pZCk6CiAgICAgICAgIGF0dGFjaG1lbnRfdXJsID0gc2VsZi5hdHRhY2htZW50X3Vy bF9mb3JfaWQoYXR0YWNobWVudF9pZCwgJ2VkaXQnKQogICAgICAgICBsb2coIkZldGNoaW5nOiAl cyIgJSBhdHRhY2htZW50X3VybCkKLSAgICAgICAgcGFnZSA9IHVybGxpYjIudXJsb3BlbihhdHRh Y2htZW50X3VybCkKKyAgICAgICAgcGFnZSA9IHNlbGYuYnJvd3Nlci5vcGVuKGF0dGFjaG1lbnRf dXJsKQogICAgICAgICByZXR1cm4gc2VsZi5fcGFyc2VfYnVnX2lkX2Zyb21fYXR0YWNobWVudF9w YWdlKHBhZ2UpCiAKICAgICAjIFRoaXMgc2hvdWxkIHJlYWxseSByZXR1cm4gYW4gQXR0YWNobWVu dCBvYmplY3QKQEAgLTE1OCw3ICsxNTcsNyBAQCBjbGFzcyBCdWd6aWxsYShvYmplY3QpOgogCiAg ICAgZGVmIGZldGNoX3RpdGxlX2Zyb21fYnVnKHNlbGYsIGJ1Z19pZCk6CiAgICAgICAgIGJ1Z191 cmwgPSBzZWxmLmJ1Z191cmxfZm9yX2J1Z19pZChidWdfaWQsIHhtbD1UcnVlKQotICAgICAgICBw YWdlID0gdXJsbGliMi51cmxvcGVuKGJ1Z191cmwpCisgICAgICAgIHBhZ2UgPSBzZWxmLmJyb3dz ZXIub3BlbihidWdfdXJsKQogICAgICAgICBzb3VwID0gQmVhdXRpZnVsU291cChwYWdlKQogICAg ICAgICByZXR1cm4gc291cC5maW5kKCdzaG9ydF9kZXNjJykuc3RyaW5nCiAKQEAgLTIzMiw3ICsy MzEsNyBAQCBjbGFzcyBCdWd6aWxsYShvYmplY3QpOgogICAgICAgICByZXR1cm4gY29tbWl0X3F1 ZXVlX3BhdGNoZXMKIAogICAgIGRlZiBfZmV0Y2hfYnVnX2lkc19hZHZhbmNlZF9xdWVyeShzZWxm LCBxdWVyeSk6Ci0gICAgICAgIHBhZ2UgPSB1cmxsaWIyLnVybG9wZW4ocXVlcnkpCisgICAgICAg IHBhZ2UgPSBzZWxmLmJyb3dzZXIub3BlbihxdWVyeSkKICAgICAgICAgc291cCA9IEJlYXV0aWZ1 bFNvdXAocGFnZSkKIAogICAgICAgICBidWdfaWRzID0gW10KQEAgLTI1MCw3ICsyNDksNyBAQCBj bGFzcyBCdWd6aWxsYShvYmplY3QpOgogICAgICAgICByZXR1cm4gW2ludChkaWdpdHMuc2VhcmNo KHRhZ1siaHJlZiJdKS5ncm91cCgwKSkgZm9yIHRhZyBpbiBCZWF1dGlmdWxTb3VwKHBhZ2UsIHBh cnNlT25seVRoZXNlPWF0dGFjaG1lbnRfbGlua3MpXQogCiAgICAgZGVmIF9mZXRjaF9hdHRhY2ht ZW50X2lkc19yZXF1ZXN0X3F1ZXJ5KHNlbGYsIHF1ZXJ5KToKLSAgICAgICAgcmV0dXJuIHNlbGYu X3BhcnNlX2F0dGFjaG1lbnRfaWRzX3JlcXVlc3RfcXVlcnkodXJsbGliMi51cmxvcGVuKHF1ZXJ5 KSkKKyAgICAgICAgcmV0dXJuIHNlbGYuX3BhcnNlX2F0dGFjaG1lbnRfaWRzX3JlcXVlc3RfcXVl cnkoc2VsZi5icm93c2VyLm9wZW4ocXVlcnkpKQogCiAgICAgZGVmIGZldGNoX2J1Z19pZHNfZnJv bV9jb21taXRfcXVldWUoc2VsZik6CiAgICAgICAgIGNvbW1pdF9xdWV1ZV91cmwgPSBzZWxmLmJ1 Z19zZXJ2ZXJfdXJsICsgImJ1Z2xpc3QuY2dpP3F1ZXJ5X2Zvcm1hdD1hZHZhbmNlZCZidWdfc3Rh dHVzPVVOQ09ORklSTUVEJmJ1Z19zdGF0dXM9TkVXJmJ1Z19zdGF0dXM9QVNTSUdORUQmYnVnX3N0 YXR1cz1SRU9QRU5FRCZmaWVsZDAtMC0wPWZsYWd0eXBlcy5uYW1lJnR5cGUwLTAtMD1lcXVhbHMm dmFsdWUwLTAtMD1jb21taXQtcXVldWUlMkIiCg==