32724 2009-12-18 10:53:51 -0800 [Qt] It should be possible to disable inspector 2010-02-16 03:10:33 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 ismail webkit-unassigned commit-queue eric pfeldman timothy webkit.review.bot oldest_to_newest 173219 0 ismail 2009-12-18 10:53:51 -0800 If you disable inspector in Platform.h via #define ENABLE_INSPECTOR 0 build will fail ultimately, mostly because the build system does not handle this case. Disabling such features are important for embedded systems. 173220 1 ismail 2009-12-18 10:54:37 -0800 Btw fixing the sources to handle !ENABLE(INSPECTOR) case is easy but the build system has inspector support hardcoded. 175782 2 45636 laszlo.gombos 2009-12-29 20:50:37 -0800 Created attachment 45636 proposed patch To turn off inspector support built QtWebKit with the following command build-webkit --no-javascript-debugger DEFINES+="ENABLE_INSPECTOR=0" 175784 3 webkit.review.bot 2009-12-29 20:53:29 -0800 style-queue ran check-webkit-style on attachment 45636 without any errors. 175830 4 45636 eric 2009-12-29 23:48:22 -0800 Comment on attachment 45636 proposed patch Should InspectElement even be defined? 20372045 case InspectElement: { Seems we might as well remove that when ENABLE(INSPECTOR) isn't defined (unless it's part of some public API header and difficutl to remove?) In general this looks OK. Why would we even compile InspectorClientQt when ENABLE(INSPECTOR) was not defined? 175835 5 ismail 2009-12-30 00:08:51 -0800 Also --minimal should disable inspector too. 175902 6 45636 hausmann 2009-12-30 06:44:51 -0800 Comment on attachment 45636 proposed patch r=me. I wonder what the gain is for embedded builds, given that we exclude the bulk of data files anyway. 175904 7 ismail 2009-12-30 06:45:56 -0800 Well even 10k matters for me on Windows CE 5.0. Thanks for the patch Laszlo, its appreciated. 175927 8 45636 commit-queue 2009-12-30 08:44:06 -0800 Comment on attachment 45636 proposed patch Clearing flags on attachment: 45636 Committed r52662: <http://trac.webkit.org/changeset/52662> 175928 9 commit-queue 2009-12-30 08:44:11 -0800 All reviewed patches have been landed. Closing bug. 188211 10 ismail 2010-02-05 10:19:09 -0800 The patch misses some ifdefs it seems, I get: ..\..\..\WebCore\rendering\RenderLayerBacking.cpp(1028) : error C2039: 'inspectorTimelineAgent' : is not a member of 'WebCore::Page' see declaration of 'WebCore::Page' 188212 11 48238 ismail 2010-02-05 10:24:53 -0800 Created attachment 48238 Patch to add missing ifdef for the disabled inspector case 188213 12 48239 ismail 2010-02-05 10:26:17 -0800 Created attachment 48239 Patch to add missing ifdef for the disabled inspector case (add the semicolon to make it compile!) 189174 13 ismail 2010-02-09 16:24:31 -0800 Ping? 190631 14 48795 ismail 2010-02-16 01:53:54 -0800 Created attachment 48795 Patch against latest SVN, fix new compilation failures 190632 15 48795 pfeldman 2010-02-16 02:05:49 -0800 Comment on attachment 48795 Patch against latest SVN, fix new compilation failures > > static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer) > { > +#if !ENABLE(INSPECTOR) > + return 0; > +#else > Frame* frame = renderer->document()->frame(); > if (!frame) > return 0; > @@ -1026,6 +1029,7 @@ static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer) > if (!page) > return 0; > return page->inspectorTimelineAgent(); > +#endif > } You should just surround this entire method with if ENABLE(INSPECTOR). Please fix this before landing. > > // Up-call from compositing layer drawing callback. > diff --git a/WebKit/qt/Api/qwebpage.cpp b/WebKit/qt/Api/qwebpage.cpp > index 185a2ee..256d6c4 100644 > --- a/WebKit/qt/Api/qwebpage.cpp > +++ b/WebKit/qt/Api/qwebpage.cpp > @@ -163,27 +163,42 @@ QString QWEBKIT_EXPORT qt_webpage_groupName(QWebPage* page) > > void QWEBKIT_EXPORT qt_drt_webinspector_executeScript(QWebPage* page, long callId, const QString& script) > { Nit: In case these are only used from within DRT, should you hide these methods as well and use guards in layout test controller instead? 190633 16 ismail 2010-02-16 02:07:54 -0800 (In reply to comment #15) > (From update of attachment 48795 [details]) > > > > static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer) > > { > > +#if !ENABLE(INSPECTOR) > > + return 0; > > +#else > > Frame* frame = renderer->document()->frame(); > > if (!frame) > > return 0; > > @@ -1026,6 +1029,7 @@ static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer) > > if (!page) > > return 0; > > return page->inspectorTimelineAgent(); > > +#endif > > } > > > You should just surround this entire method with if ENABLE(INSPECTOR). Please > fix this before landing. Since I cannot land myself anyway, if I just surround with if ENABLE(INSPECTOR) it would give a compiler warning/error saying the function should return a value. 190634 17 pfeldman 2010-02-16 02:09:17 -0800 (In reply to comment #16) > (In reply to comment #15) > > (From update of attachment 48795 [details] [details]) > > > > > > static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer) > > > { > > > +#if !ENABLE(INSPECTOR) > > > + return 0; > > > +#else > > > Frame* frame = renderer->document()->frame(); > > > if (!frame) > > > return 0; > > > @@ -1026,6 +1029,7 @@ static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer) > > > if (!page) > > > return 0; > > > return page->inspectorTimelineAgent(); > > > +#endif > > > } > > > > > > You should just surround this entire method with if ENABLE(INSPECTOR). Please > > fix this before landing. > > Since I cannot land myself anyway, if I just surround with if ENABLE(INSPECTOR) > it would give a compiler warning/error saying the function should return a > value. I mean surround the function, not its body. It should never be referenced if there is no inspector. 190636 18 ismail 2010-02-16 02:10:25 -0800 (In reply to comment #17) > (In reply to comment #16) > > (In reply to comment #15) > > > (From update of attachment 48795 [details] [details] [details]) > > > > > > > > static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer) > > > > { > > > > +#if !ENABLE(INSPECTOR) > > > > + return 0; > > > > +#else > > > > Frame* frame = renderer->document()->frame(); > > > > if (!frame) > > > > return 0; > > > > @@ -1026,6 +1029,7 @@ static InspectorTimelineAgent* inspectorTimelineAgent(RenderObject* renderer) > > > > if (!page) > > > > return 0; > > > > return page->inspectorTimelineAgent(); > > > > +#endif > > > > } > > > > > > > > > You should just surround this entire method with if ENABLE(INSPECTOR). Please > > > fix this before landing. > > > > Since I cannot land myself anyway, if I just surround with if ENABLE(INSPECTOR) > > it would give a compiler warning/error saying the function should return a > > value. > > I mean surround the function, not its body. It should never be referenced if > there is no inspector. That would require patching the header too, isn't that kind of ugly? :-) 190638 19 pfeldman 2010-02-16 02:15:17 -0800 > That would require patching the header too, isn't that kind of ugly? :-) There is no (should be no) header entry for it. It is just a static helper function defined for private use in this cpp. 190639 20 ismail 2010-02-16 02:18:47 -0800 (In reply to comment #19) > > That would require patching the header too, isn't that kind of ugly? :-) > > There is no (should be no) header entry for it. It is just a static helper > function defined for private use in this cpp. I forgot the fact that the function was static, was lame of me. Let me upload a fixed patch. 190641 21 48797 ismail 2010-02-16 02:21:09 -0800 Created attachment 48797 Surround the functions with a ifdef block, this is simpler 190644 22 48797 pfeldman 2010-02-16 02:31:30 -0800 Comment on attachment 48797 Surround the functions with a ifdef block, this is simpler What about static InspectorTimelineAgent* inspectorTimelineAgent It is still not hidden, while it was the only one I really cared about. 190646 23 48798 ismail 2010-02-16 02:52:19 -0800 Created attachment 48798 Simplify the patch 190652 24 48798 commit-queue 2010-02-16 03:10:21 -0800 Comment on attachment 48798 Simplify the patch Clearing flags on attachment: 48798 Committed r54815: <http://trac.webkit.org/changeset/54815> 190653 25 commit-queue 2010-02-16 03:10:33 -0800 All reviewed patches have been landed. Closing bug. 45636 2009-12-29 20:50:37 -0800 2009-12-30 08:44:06 -0800 proposed patch 32724.patch text/plain 7243 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjY0MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDktMTItMjkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gSXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGRpc2FibGUgaW5zcGVjdG9yCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcyNAorCisg ICAgICAgIFRoaXMgbWFrZXMgdGhlIHI0ODQzMCBhdmFpbGFibGUgZm9yIG90aGVyIHBvcnRzIGFz IHdlbGwuCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYXMgdGhlcmUgaXMgbm8gbmV3IGZ1bmN0aW9u YWxpdHkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRIb3N0LmlkbDogR3Vh cmQgdGhlIGludGVyZmFjZSB3aXRoCisgICAgICAgIElOU1BFQ1RPUiBndWFyZC4KKworICAgICAg ICAqIGluc3BlY3Rvci9JbnNwZWN0b3JCYWNrZW5kLmlkbDogRGl0dG8uCisKKyAgICAgICAgKiBp bnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbDogRGl0dG8uCisKIDIwMDktMTItMjkg IEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFkYW0gQmFydGguCkluZGV4OiBXZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEhv c3QuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0SG9z dC5pZGwJKHJldmlzaW9uIDUyNjMzKQorKysgV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3Jp cHRIb3N0LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMzEsNyArMzEsNyBAQAogICovCiAKIG1vZHVs ZSBjb3JlIHsKLSAgICBpbnRlcmZhY2UgSW5qZWN0ZWRTY3JpcHRIb3N0IHsKKyAgICBpbnRlcmZh Y2UgW0NvbmRpdGlvbmFsPUlOU1BFQ1RPUl0gSW5qZWN0ZWRTY3JpcHRIb3N0IHsKICAgICAgICAg W0N1c3RvbV0gRE9NV2luZG93IGluc3BlY3RlZFdpbmRvdygpOwogICAgICAgICBbQ3VzdG9tXSBE T01PYmplY3Qgd3JhcENhbGxiYWNrKGluIERPTU9iamVjdCBjYWxsYmFjayk7CiAgICAgICAgIHZv aWQgY2xlYXJDb25zb2xlTWVzc2FnZXMoKTsKSW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckJhY2tlbmQuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckJhY2tlbmQuaWRsCShyZXZpc2lvbiA1MjYzMykKKysrIFdlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvckJhY2tlbmQuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw3ICszMSw3IEBACiAgKi8KIAog bW9kdWxlIGNvcmUgewotICAgIGludGVyZmFjZSBJbnNwZWN0b3JCYWNrZW5kIHsKKyAgICBpbnRl cmZhY2UgW0NvbmRpdGlvbmFsPUlOU1BFQ1RPUl0gSW5zcGVjdG9yQmFja2VuZCB7CiAgICAgICAg IHZvaWQgc3RvcmVMYXN0QWN0aXZlUGFuZWwoaW4gRE9NU3RyaW5nIHBhbmVsTmFtZSk7CiAKICAg ICAgICAgdm9pZCBzYXZlRnJvbnRlbmRTZXR0aW5ncyhpbiBET01TdHJpbmcgc2V0dGluZ3MpOwpJ bmRleDogV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaWRsCShyZXZp c2lvbiA1MjYzMykKKysrIFdlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5p ZGwJKHdvcmtpbmcgY29weSkKQEAgLTMxLDcgKzMxLDcgQEAKICAqLwogCiBtb2R1bGUgY29yZSB7 Ci0gICAgaW50ZXJmYWNlIEluc3BlY3RvckZyb250ZW5kSG9zdCB7CisgICAgaW50ZXJmYWNlIFtD b25kaXRpb25hbD1JTlNQRUNUT1JdIEluc3BlY3RvckZyb250ZW5kSG9zdCB7CiAgICAgICAgIHZv aWQgbG9hZGVkKCk7CiAgICAgICAgIHZvaWQgYXR0YWNoKCk7CiAgICAgICAgIHZvaWQgZGV0YWNo KCk7CkluZGV4OiBXZWJLaXQvcXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyNjQwKQorKysgV2ViS2l0L3F0L0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI3IEBACisyMDA5LTEyLTI5ICBMYXN6bG8gR29tYm9zICA8bGFz emxvLjEuZ29tYm9zQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbUXRdIEl0IHNob3VsZCBiZSBwb3NzaWJsZSB0byBkaXNhYmxlIGlu c3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzI3MjQKKworICAgICAgICBUaGlzIGNoYW5nZSBmaXhlcyB0aGUgYnVpbGQgYnJlYWsuIFNvbWUg UXRXZWJLaXQgaW50ZXJmYWNlcworICAgICAgICB3aWxsIG5vdCBiZSBmdWxseSBmdW5jdGlvbmFs IChtb3N0IG5vdGFibGUgUVdlYkluc3BlY3RvcikgaWYKKyAgICAgICAgSU5TUEVDVE9SIGlzIGRp c2FibGVkLgorCisgICAgICAgICogQXBpL3F3ZWJpbnNwZWN0b3IuY3BwOgorICAgICAgICAoUVdl Ykluc3BlY3Rvcjo6c2hvd0V2ZW50KToKKyAgICAgICAgKFFXZWJJbnNwZWN0b3I6OmNsb3NlRXZl bnQpOgorICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6CisgICAgICAgICh3ZWJBY3Rpb25Gb3JD b250ZXh0TWVudUFjdGlvbik6CisgICAgICAgIChRV2ViUGFnZVByaXZhdGU6OmdldE9yQ3JlYXRl SW5zcGVjdG9yKToKKyAgICAgICAgKFFXZWJQYWdlUHJpdmF0ZTo6aW5zcGVjdG9yQ29udHJvbGxl cik6CisgICAgICAgIChRV2ViUGFnZTo6dHJpZ2dlckFjdGlvbik6CisgICAgICAgIChRV2ViUGFn ZTo6dXBkYXRlUG9zaXRpb25EZXBlbmRlbnRBY3Rpb25zKToKKyAgICAgICAgKiBXZWJDb3JlU3Vw cG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JD bGllbnRRdDo6c2hvd1dpbmRvdyk6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDbGllbnRR dDo6Y2xvc2VXaW5kb3cpOgorCiAyMDA5LTEyLTI5ICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBcml5YSBIaWRheWF0LgpJbmRleDogV2Vi S2l0L3F0L0FwaS9xd2ViaW5zcGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvcXQvQXBp L3F3ZWJpbnNwZWN0b3IuY3BwCShyZXZpc2lvbiA1MjYzMykKKysrIFdlYktpdC9xdC9BcGkvcXdl Ymluc3BlY3Rvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1MSw5ICsxNTEsMTEgQEAgdm9pZCBR V2ViSW5zcGVjdG9yOjpyZXNpemVFdmVudChRUmVzaXplRQogLyohIFxyZWltcCAqLwogdm9pZCBR V2ViSW5zcGVjdG9yOjpzaG93RXZlbnQoUVNob3dFdmVudCogZXZlbnQpCiB7CisjaWYgRU5BQkxF KElOU1BFQ1RPUikKICAgICAvLyBBbGxvd3MgUVdlYkluc3BlY3Rvcjo6c2hvdygpIHRvIGluaXQg dGhlIGluc3BlY3Rvci4KICAgICBpZiAoZC0+cGFnZSkKICAgICAgICAgZC0+cGFnZS0+ZC0+aW5z cGVjdG9yQ29udHJvbGxlcigpLT5zaG93KCk7CisjZW5kaWYKIH0KIAogLyohIFxyZWltcCAqLwpA QCAtMTY0LDggKzE2NiwxMCBAQCB2b2lkIFFXZWJJbnNwZWN0b3I6OmhpZGVFdmVudChRSGlkZUV2 ZW50CiAvKiEgXHJlaW1wICovCiB2b2lkIFFXZWJJbnNwZWN0b3I6OmNsb3NlRXZlbnQoUUNsb3Nl RXZlbnQqIGV2ZW50KQogeworI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgaWYgKGQtPnBhZ2Up CiAgICAgICAgIGQtPnBhZ2UtPmQtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+c2V0V2luZG93Vmlz aWJsZShmYWxzZSk7CisjZW5kaWYKIH0KIAogLyohIFxpbnRlcm5hbCAqLwpJbmRleDogV2ViS2l0 L3F0L0FwaS9xd2VicGFnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0FwaS9xd2VicGFn ZS5jcHAJKHJldmlzaW9uIDUyNjMzKQorKysgV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQ2Miw3ICs0NjIsOSBAQCBzdGF0aWMgUVdlYlBhZ2U6OldlYkFjdGlv biB3ZWJBY3Rpb25Gb3JDCiAgICAgICAgIGNhc2UgV2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtVGFn Qm9sZDogcmV0dXJuIFFXZWJQYWdlOjpUb2dnbGVCb2xkOwogICAgICAgICBjYXNlIFdlYkNvcmU6 OkNvbnRleHRNZW51SXRlbVRhZ0l0YWxpYzogcmV0dXJuIFFXZWJQYWdlOjpUb2dnbGVJdGFsaWM7 CiAgICAgICAgIGNhc2UgV2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtVGFnVW5kZXJsaW5lOiByZXR1 cm4gUVdlYlBhZ2U6OlRvZ2dsZVVuZGVybGluZTsKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQogICAg ICAgICBjYXNlIFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbVRhZ0luc3BlY3RFbGVtZW50OiByZXR1 cm4gUVdlYlBhZ2U6Okluc3BlY3RFbGVtZW50OworI2VuZGlmCiAgICAgICAgIGRlZmF1bHQ6IGJy ZWFrOwogICAgIH0KICAgICByZXR1cm4gUVdlYlBhZ2U6Ok5vV2ViQWN0aW9uOwpAQCAtMTQ4MCw2 ICsxNDgyLDcgQEAgdm9pZCBRV2ViUGFnZVByaXZhdGU6OnNldEluc3BlY3RvcihRV2ViSQogKi8K IFFXZWJJbnNwZWN0b3IqIFFXZWJQYWdlUHJpdmF0ZTo6Z2V0T3JDcmVhdGVJbnNwZWN0b3IoKQog eworI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgaWYgKCFpbnNwZWN0b3IpIHsKICAgICAgICAg UVdlYkluc3BlY3RvciogaW5zcCA9IG5ldyBRV2ViSW5zcGVjdG9yOwogICAgICAgICBpbnNwLT5z ZXRQYWdlKHEpOwpAQCAtMTQ4NywxMyArMTQ5MCwxOCBAQCBRV2ViSW5zcGVjdG9yKiBRV2ViUGFn ZVByaXZhdGU6OmdldE9yQ3JlCiAKICAgICAgICAgUV9BU1NFUlQoaW5zcGVjdG9yKTsgLy8gQXNz b2NpYXRlZCB0aHJvdWdoIFFXZWJJbnNwZWN0b3I6OnNldFBhZ2UocSkKICAgICB9CisjZW5kaWYK ICAgICByZXR1cm4gaW5zcGVjdG9yOwogfQogCiAvKiEgXGludGVybmFsICovCiBJbnNwZWN0b3JD b250cm9sbGVyKiBRV2ViUGFnZVByaXZhdGU6Omluc3BlY3RvckNvbnRyb2xsZXIoKQogeworI2lm IEVOQUJMRShJTlNQRUNUT1IpCiAgICAgcmV0dXJuIHBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIo KTsKKyNlbHNlCisgICAgcmV0dXJuIDA7CisjZW5kaWYKIH0KIAogCkBAIC0yMDM1LDExICsyMDQz LDEzIEBAIHZvaWQgUVdlYlBhZ2U6OnRyaWdnZXJBY3Rpb24oV2ViQWN0aW9uIGEKICAgICAgICAg ICAgIGVkaXRvci0+c2V0QmFzZVdyaXRpbmdEaXJlY3Rpb24oUmlnaHRUb0xlZnRXcml0aW5nRGly ZWN0aW9uKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIEluc3BlY3RFbGVtZW50 OiB7CisjaWYgRU5BQkxFKElOU1BFQ1RPUikKICAgICAgICAgICAgIGlmICghZC0+aGl0VGVzdFJl c3VsdC5pc051bGwoKSkgewogICAgICAgICAgICAgICAgIGQtPmdldE9yQ3JlYXRlSW5zcGVjdG9y KCk7IC8vIE1ha2Ugc3VyZSB0aGUgaW5zcGVjdG9yIGlzIGNyZWF0ZWQKICAgICAgICAgICAgICAg ICBkLT5pbnNwZWN0b3ItPnNob3coKTsgLy8gVGhlIGluc3BlY3RvciBpcyBleHBlY3RlZCB0byBi ZSBzaG93biBvbiBpbnNwZWN0aW9uCiAgICAgICAgICAgICAgICAgZC0+cGFnZS0+aW5zcGVjdG9y Q29udHJvbGxlcigpLT5pbnNwZWN0KGQtPmhpdFRlc3RSZXN1bHQuZC0+aW5uZXJOb25TaGFyZWRO b2RlLmdldCgpKTsKICAgICAgICAgICAgIH0KKyNlbmRpZgogICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgIH0KICAgICAgICAgZGVmYXVsdDoKQEAgLTI3MzMsOCArMjc0MywxMSBAQCB2b2lkIFFX ZWJQYWdlOjp1cGRhdGVQb3NpdGlvbkRlcGVuZGVudEFjCiAgICAgICAgIGQtPmhpdFRlc3RSZXN1 bHQgPSBRV2ViSGl0VGVzdFJlc3VsdChuZXcgUVdlYkhpdFRlc3RSZXN1bHRQcml2YXRlKHJlc3Vs dCkpOwogICAgIFdlYkNvcmU6OkNvbnRleHRNZW51IG1lbnUocmVzdWx0KTsKICAgICBtZW51LnBv cHVsYXRlKCk7CisgICAgCisjaWYgRU5BQkxFKElOU1BFQ1RPUikKICAgICBpZiAoZC0+cGFnZS0+ aW5zcGVjdG9yQ29udHJvbGxlcigpLT5lbmFibGVkKCkpCiAgICAgICAgIG1lbnUuYWRkSW5zcGVj dEVsZW1lbnRJdGVtKCk7CisjZW5kaWYKIAogICAgIFFCaXRBcnJheSB2aXNpdGVkV2ViQWN0aW9u cyhRV2ViUGFnZTo6V2ViQWN0aW9uQ291bnQpOwogCkluZGV4OiBXZWJLaXQvcXQvV2ViQ29yZVN1 cHBvcnQvSW5zcGVjdG9yQ2xpZW50UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9xdC9XZWJD b3JlU3VwcG9ydC9JbnNwZWN0b3JDbGllbnRRdC5jcHAJKHJldmlzaW9uIDUyNjMzKQorKysgV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L0luc3BlY3RvckNsaWVudFF0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTEyLDEyICsxMTIsMTYgQEAgdm9pZCBJbnNwZWN0b3JDbGllbnRRdDo6c2hvd1dpbmRv dygpCiB7CiAgICAgdXBkYXRlV2luZG93VGl0bGUoKTsKIAorI2lmIEVOQUJMRShJTlNQRUNUT1Ip CiAgICAgbV9pbnNwZWN0ZWRXZWJQYWdlLT5kLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnNldFdp bmRvd1Zpc2libGUodHJ1ZSwgdHJ1ZSk7CisjZW5kaWYKIH0KIAogdm9pZCBJbnNwZWN0b3JDbGll bnRRdDo6Y2xvc2VXaW5kb3coKQogeworI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgbV9pbnNw ZWN0ZWRXZWJQYWdlLT5kLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnNldFdpbmRvd1Zpc2libGUo ZmFsc2UpOworI2VuZGlmCiB9CiAKIHZvaWQgSW5zcGVjdG9yQ2xpZW50UXQ6OmF0dGFjaFdpbmRv dygpCg== 48238 2010-02-05 10:24:53 -0800 2010-02-05 10:26:17 -0800 Patch to add missing ifdef for the disabled inspector case inspector.patch text/plain 1320 ismail ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmQyYzE3Zi4uNTFhYTI4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0wNSAgSXNtYWlsIERvbm1l eiAgPGlzbWFpbEBuYW10cmFjLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2hlbiBpbnNwZWN0b3IgaXMgZGlzYWJs ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcy NAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAg IChXZWJDb3JlOjppbnNwZWN0b3JUaW1lbGluZUFnZW50KToKKwogMjAxMC0wMi0wNSAgU2lkZGhh cnRoIE1hdGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFyaXlhIEhpZGF5YXQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckJhY2tpbmcuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5n LmNwcAppbmRleCA1NDM1YmYxLi5mMDU5YTkzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyQmFja2luZy5jcHAKQEAgLTEwMTksNiArMTAxOSw5IEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNr aW5nOjpwYWludEludG9MYXllcihSZW5kZXJMYXllciogcm9vdExheWVyLCBHcmFwaGljc0NvbnRl eHQqCiAKIHN0YXRpYyBJbnNwZWN0b3JUaW1lbGluZUFnZW50KiBpbnNwZWN0b3JUaW1lbGluZUFn ZW50KFJlbmRlck9iamVjdCogcmVuZGVyZXIpCiB7CisjaWYgIUVOQUJMRShJTlNQRUNUT1IpCisg ICAgcmV0dXJuIDAKKyNlbHNlCiAgICAgRnJhbWUqIGZyYW1lID0gcmVuZGVyZXItPmRvY3VtZW50 KCktPmZyYW1lKCk7CiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuIDA7CkBAIC0xMDI2 LDYgKzEwMjksNyBAQCBzdGF0aWMgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogaW5zcGVjdG9yVGlt ZWxpbmVBZ2VudChSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogICAgIGlmICghcGFnZSkKICAgICAg ICAgcmV0dXJuIDA7CiAgICAgcmV0dXJuIHBhZ2UtPmluc3BlY3RvclRpbWVsaW5lQWdlbnQoKTsK KyNlbmRpZgogfQogCiAvLyBVcC1jYWxsIGZyb20gY29tcG9zaXRpbmcgbGF5ZXIgZHJhd2luZyBj YWxsYmFjay4K 48239 2010-02-05 10:26:17 -0800 2010-02-16 01:53:54 -0800 Patch to add missing ifdef for the disabled inspector case (add the semicolon to make it compile!) inspector.patch text/plain 1321 ismail ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmQyYzE3Zi4uNTFhYTI4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0wNSAgSXNtYWlsIERvbm1l eiAgPGlzbWFpbEBuYW10cmFjLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2hlbiBpbnNwZWN0b3IgaXMgZGlzYWJs ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcy NAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAg IChXZWJDb3JlOjppbnNwZWN0b3JUaW1lbGluZUFnZW50KToKKwogMjAxMC0wMi0wNSAgU2lkZGhh cnRoIE1hdGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFyaXlhIEhpZGF5YXQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJMYXllckJhY2tpbmcuY3BwIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5n LmNwcAppbmRleCA1NDM1YmYxLi40M2Y5YTFlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxh eWVyQmFja2luZy5jcHAKQEAgLTEwMTksNiArMTAxOSw5IEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNr aW5nOjpwYWludEludG9MYXllcihSZW5kZXJMYXllciogcm9vdExheWVyLCBHcmFwaGljc0NvbnRl eHQqCiAKIHN0YXRpYyBJbnNwZWN0b3JUaW1lbGluZUFnZW50KiBpbnNwZWN0b3JUaW1lbGluZUFn ZW50KFJlbmRlck9iamVjdCogcmVuZGVyZXIpCiB7CisjaWYgIUVOQUJMRShJTlNQRUNUT1IpCisg ICAgcmV0dXJuIDA7CisjZWxzZQogICAgIEZyYW1lKiBmcmFtZSA9IHJlbmRlcmVyLT5kb2N1bWVu dCgpLT5mcmFtZSgpOwogICAgIGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybiAwOwpAQCAtMTAy Niw2ICsxMDI5LDcgQEAgc3RhdGljIEluc3BlY3RvclRpbWVsaW5lQWdlbnQqIGluc3BlY3RvclRp bWVsaW5lQWdlbnQoUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKICAgICBpZiAoIXBhZ2UpCiAgICAg ICAgIHJldHVybiAwOwogICAgIHJldHVybiBwYWdlLT5pbnNwZWN0b3JUaW1lbGluZUFnZW50KCk7 CisjZW5kaWYKIH0KIAogLy8gVXAtY2FsbCBmcm9tIGNvbXBvc2l0aW5nIGxheWVyIGRyYXdpbmcg Y2FsbGJhY2suCg== 48795 2010-02-16 01:53:54 -0800 2010-02-16 02:21:09 -0800 Patch against latest SVN, fix new compilation failures inspector-new.patch text/plain 3559 ismail ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODgzZWE3Mi4uNzc1YWU1YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0xNiAgSXNtYWlsIERvbm1l eiAgPGlzbWFpbEBuYW10cmFjLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2l0aCBpbnNwZWN0b3IgZGlzYWJsZWQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcyNAor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjppbnNwZWN0b3JUaW1lbGluZUFnZW50KToKKwogMjAxMC0wMi0xNSAgRGFuIEJlcm5z dGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNl ci4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9n CmluZGV4IDQ1YTI0ZDAuLmYyNjQwYTAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTAyLTE2ICBJ c21haWwgRG9ubWV6ICA8aXNtYWlsQG5hbXRyYWMub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiB3aXRoIGluc3BlY3Rv ciBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMyNzI0CisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAocXRfZHJ0 X3dlYmluc3BlY3Rvcl9leGVjdXRlU2NyaXB0KToKKyAgICAgICAgKHF0X2RydF93ZWJpbnNwZWN0 b3JfY2xvc2UpOgorICAgICAgICAocXRfZHJ0X3dlYmluc3BlY3Rvcl9zaG93KToKKyAgICAgICAg KHF0X2RydF9zZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJsZWQpOgorCiAyMDEwLTAyLTE1ICBOb2Ft IFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQmFja2luZy5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcu Y3BwCmluZGV4IDU0MzViZjEuLjQzZjlhMWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJCYWNraW5nLmNwcApAQCAtMTAxOSw2ICsxMDE5LDkgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tp bmc6OnBhaW50SW50b0xheWVyKFJlbmRlckxheWVyKiByb290TGF5ZXIsIEdyYXBoaWNzQ29udGV4 dCoKIAogc3RhdGljIEluc3BlY3RvclRpbWVsaW5lQWdlbnQqIGluc3BlY3RvclRpbWVsaW5lQWdl bnQoUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKIHsKKyNpZiAhRU5BQkxFKElOU1BFQ1RPUikKKyAg ICByZXR1cm4gMDsKKyNlbHNlCiAgICAgRnJhbWUqIGZyYW1lID0gcmVuZGVyZXItPmRvY3VtZW50 KCktPmZyYW1lKCk7CiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuIDA7CkBAIC0xMDI2 LDYgKzEwMjksNyBAQCBzdGF0aWMgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogaW5zcGVjdG9yVGlt ZWxpbmVBZ2VudChSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogICAgIGlmICghcGFnZSkKICAgICAg ICAgcmV0dXJuIDA7CiAgICAgcmV0dXJuIHBhZ2UtPmluc3BlY3RvclRpbWVsaW5lQWdlbnQoKTsK KyNlbmRpZgogfQogCiAvLyBVcC1jYWxsIGZyb20gY29tcG9zaXRpbmcgbGF5ZXIgZHJhd2luZyBj YWxsYmFjay4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0 L3F0L0FwaS9xd2VicGFnZS5jcHAKaW5kZXggMTg1YTJlZS4uMjU2ZDZjNCAxMDA2NDQKLS0tIGEv V2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5j cHAKQEAgLTE2MywyNyArMTYzLDQyIEBAIFFTdHJpbmcgUVdFQktJVF9FWFBPUlQgcXRfd2VicGFn ZV9ncm91cE5hbWUoUVdlYlBhZ2UqIHBhZ2UpCiAKIHZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0 X3dlYmluc3BlY3Rvcl9leGVjdXRlU2NyaXB0KFFXZWJQYWdlKiBwYWdlLCBsb25nIGNhbGxJZCwg Y29uc3QgUVN0cmluZyYgc2NyaXB0KQogeworI2lmICFFTkFCTEUoSU5TUEVDVE9SKQorICAgIHJl dHVybjsKKyNlbHNlCiAgICAgaWYgKCFwYWdlLT5oYW5kbGUoKS0+cGFnZS0+aW5zcGVjdG9yQ29u dHJvbGxlcigpKQogICAgICAgICByZXR1cm47CiAgICAgcGFnZS0+aGFuZGxlKCktPnBhZ2UtPmlu c3BlY3RvckNvbnRyb2xsZXIoKS0+ZXZhbHVhdGVGb3JUZXN0SW5Gcm9udGVuZChjYWxsSWQsIHNj cmlwdCk7CisjZW5kaWYKIH0KIAogdm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9kcnRfd2ViaW5zcGVj dG9yX2Nsb3NlKFFXZWJQYWdlKiBwYWdlKQogeworI2lmICFFTkFCTEUoSU5TUEVDVE9SKQorICAg IHJldHVybjsKKyNlbHNlCiAgICAgaWYgKCFwYWdlLT5oYW5kbGUoKS0+cGFnZS0+aW5zcGVjdG9y Q29udHJvbGxlcigpKQogICAgICAgICByZXR1cm47CiAgICAgcGFnZS0+aGFuZGxlKCktPnBhZ2Ut Pmluc3BlY3RvckNvbnRyb2xsZXIoKS0+Y2xvc2UoKTsKKyNlbmRpZgogfQogCiB2b2lkIFFXRUJL SVRfRVhQT1JUIHF0X2RydF93ZWJpbnNwZWN0b3Jfc2hvdyhRV2ViUGFnZSogcGFnZSkKIHsKKyNp ZiAhRU5BQkxFKElOU1BFQ1RPUikKKyAgICByZXR1cm47CisjZWxzZQogICAgIGlmICghcGFnZS0+ aGFuZGxlKCktPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKSkKICAgICAgICAgcmV0dXJuOwog ICAgIHBhZ2UtPmhhbmRsZSgpLT5wYWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPnNob3coKTsK KyNlbmRpZgogfQogCiB2b2lkIFFXRUJLSVRfRVhQT1JUIHF0X2RydF9zZXRUaW1lbGluZVByb2Zp bGluZ0VuYWJsZWQoUVdlYlBhZ2UqIHBhZ2UsIGJvb2wgZW5hYmxlZCkKIHsKKyNpZiAhRU5BQkxF KElOU1BFQ1RPUikKKyAgICByZXR1cm47CisjZWxzZQogICAgIEluc3BlY3RvckNvbnRyb2xsZXIq IGNvbnRyb2xsZXIgPSBwYWdlLT5oYW5kbGUoKS0+cGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigp OwogICAgIGlmICghY29udHJvbGxlcikKICAgICAgICAgcmV0dXJuOwpAQCAtMTkxLDYgKzIwNiw3 IEBAIHZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X3NldFRpbWVsaW5lUHJvZmlsaW5nRW5hYmxl ZChRV2ViUGFnZSogcGFnZSwgYm9vbCBlbmFiCiAgICAgICAgIGNvbnRyb2xsZXItPnN0YXJ0VGlt ZWxpbmVQcm9maWxlcigpOwogICAgIGVsc2UKICAgICAgICAgY29udHJvbGxlci0+c3RvcFRpbWVs aW5lUHJvZmlsZXIoKTsKKyNlbmRpZgogfQogCiBjbGFzcyBRV2ViUGFnZVdpZGdldENsaWVudCA6 IHB1YmxpYyBRV2ViUGFnZUNsaWVudCB7Cg== 48797 2010-02-16 02:21:09 -0800 2010-02-16 02:52:19 -0800 Surround the functions with a ifdef block, this is simpler inspector-new.patch text/plain 2665 ismail ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODgzZWE3Mi4uNzc1YWU1YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0xNiAgSXNtYWlsIERvbm1l eiAgPGlzbWFpbEBuYW10cmFjLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2l0aCBpbnNwZWN0b3IgZGlzYWJsZWQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcyNAor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjppbnNwZWN0b3JUaW1lbGluZUFnZW50KToKKwogMjAxMC0wMi0xNSAgRGFuIEJlcm5z dGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNl ci4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9n CmluZGV4IDQ1YTI0ZDAuLmYyNjQwYTAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTAyLTE2ICBJ c21haWwgRG9ubWV6ICA8aXNtYWlsQG5hbXRyYWMub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiB3aXRoIGluc3BlY3Rv ciBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMyNzI0CisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAocXRfZHJ0 X3dlYmluc3BlY3Rvcl9leGVjdXRlU2NyaXB0KToKKyAgICAgICAgKHF0X2RydF93ZWJpbnNwZWN0 b3JfY2xvc2UpOgorICAgICAgICAocXRfZHJ0X3dlYmluc3BlY3Rvcl9zaG93KToKKyAgICAgICAg KHF0X2RydF9zZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJsZWQpOgorCiAyMDEwLTAyLTE1ICBOb2Ft IFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckxheWVyQmFja2luZy5jcHAgYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcu Y3BwCmluZGV4IDU0MzViZjEuLjQzZjlhMWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxheWVyQmFja2luZy5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJCYWNraW5nLmNwcApAQCAtMTAxOSw2ICsxMDE5LDkgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tp bmc6OnBhaW50SW50b0xheWVyKFJlbmRlckxheWVyKiByb290TGF5ZXIsIEdyYXBoaWNzQ29udGV4 dCoKIAogc3RhdGljIEluc3BlY3RvclRpbWVsaW5lQWdlbnQqIGluc3BlY3RvclRpbWVsaW5lQWdl bnQoUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKIHsKKyNpZiAhRU5BQkxFKElOU1BFQ1RPUikKKyAg ICByZXR1cm4gMDsKKyNlbHNlCiAgICAgRnJhbWUqIGZyYW1lID0gcmVuZGVyZXItPmRvY3VtZW50 KCktPmZyYW1lKCk7CiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuIDA7CkBAIC0xMDI2 LDYgKzEwMjksNyBAQCBzdGF0aWMgSW5zcGVjdG9yVGltZWxpbmVBZ2VudCogaW5zcGVjdG9yVGlt ZWxpbmVBZ2VudChSZW5kZXJPYmplY3QqIHJlbmRlcmVyKQogICAgIGlmICghcGFnZSkKICAgICAg ICAgcmV0dXJuIDA7CiAgICAgcmV0dXJuIHBhZ2UtPmluc3BlY3RvclRpbWVsaW5lQWdlbnQoKTsK KyNlbmRpZgogfQogCiAvLyBVcC1jYWxsIGZyb20gY29tcG9zaXRpbmcgbGF5ZXIgZHJhd2luZyBj YWxsYmFjay4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0 L3F0L0FwaS9xd2VicGFnZS5jcHAKaW5kZXggMTg1YTJlZS4uZjc4NTI0ZCAxMDA2NDQKLS0tIGEv V2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5j cHAKQEAgLTE2MSw2ICsxNjEsNyBAQCBRU3RyaW5nIFFXRUJLSVRfRVhQT1JUIHF0X3dlYnBhZ2Vf Z3JvdXBOYW1lKFFXZWJQYWdlKiBwYWdlKQogICAgIHJldHVybiBwYWdlLT5oYW5kbGUoKS0+cGFn ZS0+Z3JvdXBOYW1lKCk7CiB9CiAKKyNpZiAhRU5BQkxFKElOU1BFQ1RPUikKIHZvaWQgUVdFQktJ VF9FWFBPUlQgcXRfZHJ0X3dlYmluc3BlY3Rvcl9leGVjdXRlU2NyaXB0KFFXZWJQYWdlKiBwYWdl LCBsb25nIGNhbGxJZCwgY29uc3QgUVN0cmluZyYgc2NyaXB0KQogewogICAgIGlmICghcGFnZS0+ aGFuZGxlKCktPnBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKSkKQEAgLTE5Miw2ICsxOTMsNyBA QCB2b2lkIFFXRUJLSVRfRVhQT1JUIHF0X2RydF9zZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJsZWQo UVdlYlBhZ2UqIHBhZ2UsIGJvb2wgZW5hYgogICAgIGVsc2UKICAgICAgICAgY29udHJvbGxlci0+ c3RvcFRpbWVsaW5lUHJvZmlsZXIoKTsKIH0KKyNlbmRpZgogCiBjbGFzcyBRV2ViUGFnZVdpZGdl dENsaWVudCA6IHB1YmxpYyBRV2ViUGFnZUNsaWVudCB7CiBwdWJsaWM6Cg== 48798 2010-02-16 02:52:19 -0800 2010-02-16 03:10:20 -0800 Simplify the patch inspector-new.patch text/plain 2792 ismail ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODgzZWE3Mi4uNzc1YWU1YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMi0xNiAgSXNtYWlsIERvbm1l eiAgPGlzbWFpbEBuYW10cmFjLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2l0aCBpbnNwZWN0b3IgZGlzYWJsZWQu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcyNAor CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjppbnNwZWN0b3JUaW1lbGluZUFnZW50KToKKwogMjAxMC0wMi0xNSAgRGFuIEJlcm5z dGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNl ci4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9n CmluZGV4IDQ1YTI0ZDAuLmYyNjQwYTAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTAyLTE2ICBJ c21haWwgRG9ubWV6ICA8aXNtYWlsQG5hbXRyYWMub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiB3aXRoIGluc3BlY3Rv ciBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMyNzI0CisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAocXRfZHJ0 X3dlYmluc3BlY3Rvcl9leGVjdXRlU2NyaXB0KToKKyAgICAgICAgKHF0X2RydF93ZWJpbnNwZWN0 b3JfY2xvc2UpOgorICAgICAgICAocXRfZHJ0X3dlYmluc3BlY3Rvcl9zaG93KToKKyAgICAgICAg KHF0X2RydF9zZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJsZWQpOgorCiAyMDEwLTAyLTE1ICBOb2Ft IFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2Uu Y3BwIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKaW5kZXggMTg1YTJlZS4uMmE4YWNlZCAx MDA2NDQKLS0tIGEvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0Fw aS9xd2VicGFnZS5jcHAKQEAgLTE2MSw2ICsxNjEsNyBAQCBRU3RyaW5nIFFXRUJLSVRfRVhQT1JU IHF0X3dlYnBhZ2VfZ3JvdXBOYW1lKFFXZWJQYWdlKiBwYWdlKQogICAgIHJldHVybiBwYWdlLT5o YW5kbGUoKS0+cGFnZS0+Z3JvdXBOYW1lKCk7CiB9CiAKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQog dm9pZCBRV0VCS0lUX0VYUE9SVCBxdF9kcnRfd2ViaW5zcGVjdG9yX2V4ZWN1dGVTY3JpcHQoUVdl YlBhZ2UqIHBhZ2UsIGxvbmcgY2FsbElkLCBjb25zdCBRU3RyaW5nJiBzY3JpcHQpCiB7CiAgICAg aWYgKCFwYWdlLT5oYW5kbGUoKS0+cGFnZS0+aW5zcGVjdG9yQ29udHJvbGxlcigpKQpAQCAtMTky LDYgKzE5Myw3IEBAIHZvaWQgUVdFQktJVF9FWFBPUlQgcXRfZHJ0X3NldFRpbWVsaW5lUHJvZmls aW5nRW5hYmxlZChRV2ViUGFnZSogcGFnZSwgYm9vbCBlbmFiCiAgICAgZWxzZQogICAgICAgICBj b250cm9sbGVyLT5zdG9wVGltZWxpbmVQcm9maWxlcigpOwogfQorI2VuZGlmCiAKIGNsYXNzIFFX ZWJQYWdlV2lkZ2V0Q2xpZW50IDogcHVibGljIFFXZWJQYWdlQ2xpZW50IHsKIHB1YmxpYzoKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwCmluZGV4IDU0MzViZjEuLjNmNjA1 NTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAK KysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcApAQCAtMTAxNyw2 ICsxMDE3LDcgQEAgdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnBhaW50SW50b0xheWVyKFJlbmRl ckxheWVyKiByb290TGF5ZXIsIEdyYXBoaWNzQ29udGV4dCoKICAgICBBU1NFUlQoIW1fb3duaW5n TGF5ZXItPm1fdXNlZFRyYW5zcGFyZW5jeSk7CiB9CiAKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQog c3RhdGljIEluc3BlY3RvclRpbWVsaW5lQWdlbnQqIGluc3BlY3RvclRpbWVsaW5lQWdlbnQoUmVu ZGVyT2JqZWN0KiByZW5kZXJlcikKIHsKICAgICBGcmFtZSogZnJhbWUgPSByZW5kZXJlci0+ZG9j dW1lbnQoKS0+ZnJhbWUoKTsKQEAgLTEwMjcsNiArMTAyOCw3IEBAIHN0YXRpYyBJbnNwZWN0b3JU aW1lbGluZUFnZW50KiBpbnNwZWN0b3JUaW1lbGluZUFnZW50KFJlbmRlck9iamVjdCogcmVuZGVy ZXIpCiAgICAgICAgIHJldHVybiAwOwogICAgIHJldHVybiBwYWdlLT5pbnNwZWN0b3JUaW1lbGlu ZUFnZW50KCk7CiB9CisjZW5kaWYKIAogLy8gVXAtY2FsbCBmcm9tIGNvbXBvc2l0aW5nIGxheWVy IGRyYXdpbmcgY2FsbGJhY2suCiB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6cGFpbnRDb250ZW50 cyhjb25zdCBHcmFwaGljc0xheWVyKiwgR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0LCBHcmFwaGlj c0xheWVyUGFpbnRpbmdQaGFzZSBwYWludGluZ1BoYXNlLCBjb25zdCBJbnRSZWN0JiBjbGlwKQo=