32712 2009-12-18 07:39:13 -0800 WebKit crashes on svg font-face-uri element with empty href 2009-12-18 08:28:41 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED DUPLICATE 32357 P3 Normal --- 1 cshu cshu darin mitz oldest_to_newest 173149 0 cshu 2009-12-18 07:39:13 -0800 Either DumpRenderTree or any browsers will crash running the following svg page. <?xml version="1.0"?> <?xml-stylesheet href="data:text/css,text%7Bfont-family%3AACID3svgfont%7D"?> <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="100" height="100"> <font-face font-family="ACID3svgfont"> <font-face-src> <font-face-uri xlink:href=""/> </font-face-src> </font-face> <text>X</text> </svg> 173153 1 45149 cshu 2009-12-18 07:55:21 -0800 Created attachment 45149 fix patch I didn't add a layout test for this crash. I feel the layout tests are growing too big if we add test cases for this type of code change. But if the reviewers prefer the other way, I can add it real quick. 173160 2 darin 2009-12-18 08:17:44 -0800 (In reply to comment #1) > I didn't add a layout test for this crash. I feel the layout tests are growing > too big if we add test cases for this type of code change. I do not agree. We do want a test for this kind of crash. 173161 3 45149 darin 2009-12-18 08:17:56 -0800 Comment on attachment 45149 fix patch Please add a test case. 173163 4 mitz 2009-12-18 08:28:41 -0800 This was filed as bug 32357 and fixed about 10 hours ago. *** This bug has been marked as a duplicate of bug 32357 *** 45149 2009-12-18 07:55:21 -0800 2009-12-18 08:17:56 -0800 fix patch bug32712_1.patch text/plain 1500 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjMxMSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMTggIFNodSBDaGFuZyAgPENoYW5nLlNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRnVu Y3Rpb24gRG9jTG9hZGVyOjpyZXF1ZXN0Rm9udCgpIG1heSByZXR1cm4gMCBpbiBtYW55IGNhc2Vz LAorICAgICAgICBzdWNoIGFzIGludmFsaWQgb3IgZW1wdHkgVVJJLiBJdCBpcyBuZWNlc3Nhcnkg dG8gY2hlY2sgYWdhaW5zdAorICAgICAgICBudWxsIHBvaW50ZXIgdG8gYXZvaWQgY3Jhc2guCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcxMgorCisg ICAgICAgICogc3ZnL1NWR0ZvbnRGYWNlVXJpRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpTVkdGb250RmFjZVVyaUVsZW1lbnQ6OmxvYWRGb250KToKKwogMjAwOS0xMi0xOCAgU2ltb24g SGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgVG9yIEFybmUgVmVzdGLDuC4KSW5kZXg6IFdlYkNvcmUvc3ZnL1NWR0ZvbnRGYWNlVXJpRWxl bWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9zdmcvU1ZHRm9udEZhY2VVcmlFbGVtZW50 LmNwcAkocmV2aXNpb24gNTIxMTQpCisrKyBXZWJDb3JlL3N2Zy9TVkdGb250RmFjZVVyaUVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05MSw5ICs5MSwxMSBAQCB2b2lkIFNWR0ZvbnRGYWNl VXJpRWxlbWVudDo6bG9hZEZvbnQoKQogICAgIGlmICghaHJlZi5pc051bGwoKSkgeyAgICAgICAg CiAgICAgICAgIERvY0xvYWRlciogZG9jTG9hZGVyID0gZG9jdW1lbnQoKS0+ZG9jTG9hZGVyKCk7 CiAgICAgICAgIG1fY2FjaGVkRm9udCA9IGRvY0xvYWRlci0+cmVxdWVzdEZvbnQoaHJlZik7Ci0g ICAgICAgIG1fY2FjaGVkRm9udC0+c2V0U1ZHRm9udCh0cnVlKTsKLSAgICAgICAgbV9jYWNoZWRG b250LT5hZGRDbGllbnQodGhpcyk7Ci0gICAgICAgIG1fY2FjaGVkRm9udC0+YmVnaW5Mb2FkSWZO ZWVkZWQoZG9jTG9hZGVyKTsKKyAgICAgICAgaWYgKG1fY2FjaGVkRm9udCkgeworICAgICAgICAg ICAgbV9jYWNoZWRGb250LT5zZXRTVkdGb250KHRydWUpOworICAgICAgICAgICAgbV9jYWNoZWRG b250LT5hZGRDbGllbnQodGhpcyk7CisgICAgICAgICAgICBtX2NhY2hlZEZvbnQtPmJlZ2luTG9h ZElmTmVlZGVkKGRvY0xvYWRlcik7CisgICAgICAgIH0KICAgICB9IGVsc2UKICAgICAgICAgbV9j YWNoZWRGb250ID0gMDsKIH0K