32709 2009-12-18 05:43:18 -0800 [GTK] GRefPtr does not take a reference when assigned a raw pointer 2009-12-18 11:55:39 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mrobinson webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 173128 0 mrobinson 2009-12-18 05:43:18 -0800 GRefPtr should always take a reference unless created via adoptRef. 173135 1 45147 mrobinson 2009-12-18 06:12:11 -0800 Created attachment 45147 Patch for this issue 173136 2 webkit.review.bot 2009-12-18 06:13:50 -0800 style-queue ran check-webkit-style on attachment 45147 without any errors. 173243 3 45147 commit-queue 2009-12-18 11:55:34 -0800 Comment on attachment 45147 Patch for this issue Clearing flags on attachment: 45147 Committed r52328: <http://trac.webkit.org/changeset/52328> 173244 4 commit-queue 2009-12-18 11:55:39 -0800 All reviewed patches have been landed. Closing bug. 45147 2009-12-18 06:12:11 -0800 2009-12-18 11:55:34 -0800 Patch for this issue 0001-Ensure-that-when-assigning-a-raw-pointer-to-a-GRefPt.patch text/plain 2234 mrobinson RnJvbSBkZTNmOTFlZjA1MGZiMDk1NTAxMWFjMWQ2NTk5ZTIwZjk0YTU3NjJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1hcnRpbi5qYW1lcy5yb2JpbnNv bkBnbWFpbC5jb20+CkRhdGU6IEZyaSwgMTggRGVjIDIwMDkgMTQ6NDk6MjYgKzAxMDAKU3ViamVj dDogW1BBVENIXSBFbnN1cmUgdGhhdCB3aGVuIGFzc2lnbmluZyBhIHJhdyBwb2ludGVyIHRvIGEg R1JlZlB0ciwgdGhlIHJlZmVyZW5jZSBjb3VudCBpcyBpbmNyZW1lbnRlZC4gQWxzbyByZW1vdmUg dGhlIEdSZWZQdHIgY29udmVyc2lvbiBvdmVybG9hZCBhcyBHUmVmUHRyIHR5cGVzIGhhdmUgbmVj ZXNzYXJpbHkgaW5jb21wYXRpYmxlIHJlZmVyZW5jZSBjb3VudGluZy4KCi0tLQogSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBKYXZhU2NyaXB0 Q29yZS93dGYvZ3RrL0dSZWZQdHIuaCB8ICAgMTQgKystLS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hh bmdlZCwgMTYgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGM0 MTA0ZGYuLjMyNjE1MmYgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysg Yi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAwOS0xMi0xOCAg TWFydGluIFJvYmluc29uICA8bWFydGluLmphbWVzLnJvYmluc29uQGdtYWlsLmNvbT4KIAorICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBHUmVmUHRy IGRvZXMgbm90IHRha2UgYSByZWZlcmVuY2Ugd2hlbiBhc3NpZ25lZCBhIHJhdyBwb2ludGVyCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcwOQorCisg ICAgICAgIEVuc3VyZSB0aGF0IHdoZW4gYXNzaWduaW5nIGEgcmF3IHBvaW50ZXIgdG8gYSBHUmVm UHRyLCB0aGUgcmVmZXJlbmNlCisgICAgICAgIGNvdW50IGlzIGluY3JlbWVudGVkLiBBbHNvIHJl bW92ZSB0aGUgR1JlZlB0ciBjb252ZXJzaW9uIG92ZXJsb2FkIGFzCisgICAgICAgIEdSZWZQdHIg dHlwZXMgaGF2ZSBuZWNlc3NhcmlseSBpbmNvbXBhdGlibGUgcmVmZXJlbmNlIGNvdW50aW5nLgor CisgICAgICAgICogd3RmL2d0ay9HUmVmUHRyLmg6CisgICAgICAgIChXVEY6OkdSZWZQdHI6Om9w ZXJhdG9yPSk6CisKKzIwMDktMTItMTggIE1hcnRpbiBSb2JpbnNvbiAgPG1hcnRpbi5qYW1lcy5y b2JpbnNvbkBnbWFpbC5jb20+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3Jvbmhh IFNpbHZhLgogCiAgICAgICAgIFtHVEtdIENvbXBpbGUgd2FybmluZyBmcm9tIGxpbmUgMjkgb2Yg R1JlZlB0ci5jcHAKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9ndGsvR1JlZlB0ci5o IGIvSmF2YVNjcmlwdENvcmUvd3RmL2d0ay9HUmVmUHRyLmgKaW5kZXggNWI2MDgxZC4uNjY3Mzll ZiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL2d0ay9HUmVmUHRyLmgKKysrIGIvSmF2 YVNjcmlwdENvcmUvd3RmL2d0ay9HUmVmUHRyLmgKQEAgLTkxLDIxICs5MSwxMSBAQCB0ZW1wbGF0 ZSA8dHlwZW5hbWUgVD4gaW5saW5lIEdSZWZQdHI8VD4mIEdSZWZQdHI8VD46Om9wZXJhdG9yPShj b25zdCBHUmVmUHRyPFQ+JgogICAgIHJldHVybiAqdGhpczsKIH0KIAotdGVtcGxhdGUgPHR5cGVu YW1lIFQ+IHRlbXBsYXRlIDx0eXBlbmFtZSBVPiBpbmxpbmUgR1JlZlB0cjxUPiYgR1JlZlB0cjxU Pjo6b3BlcmF0b3I9KGNvbnN0IEdSZWZQdHI8VT4mIG8pCi17Ci0gICAgVCogb3B0ciA9IG8uZ2V0 KCk7Ci0gICAgaWYgKG9wdHIpCi0gICAgICAgIHJlZkdQdHIob3B0cik7Ci0gICAgVCogcHRyID0g bV9wdHI7Ci0gICAgbV9wdHIgPSBvcHRyOwotICAgIGlmIChwdHIpCi0gICAgICAgIGRlcmVmR1B0 cihwdHIpOwotICAgIHJldHVybiAqdGhpczsKLX0KLQogdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IGlu bGluZSBHUmVmUHRyPFQ+JiBHUmVmUHRyPFQ+OjpvcGVyYXRvcj0oVCogb3B0cikKIHsKICAgICBU KiBwdHIgPSBtX3B0cjsKKyAgICBpZiAob3B0cikKKyAgICAgICAgcmVmR1B0cihvcHRyKTsKICAg ICBtX3B0ciA9IG9wdHI7CiAgICAgaWYgKHB0cikKICAgICAgICAgZGVyZWZHUHRyKHB0cik7Ci0t IAoxLjYuMC40Cgo=