32705 2009-12-18 03:14:26 -0800 [GTK] segfault during controls initialization if not GTK theme is present. 2009-12-18 06:04:03 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned webkit.review.bot oldest_to_newest 173095 0 pnormand 2009-12-18 03:14:26 -0800 You can reproduce this bug by running the tests in Xephyr without any window-manager running. (gdb) bt #0 strlen () at ../sysdeps/i386/i486/strlen.S:69 #1 0x00b0274e in WebCore::CString::CString(char const*) () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #2 0x00e25de8 in WebCore::getThemeIconFileName(char const*, int) () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #3 0x00e25fd0 in WebCore::Image::loadPlatformThemeIcon(char const*, int) () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #4 0x00e32b6b in WebCore::RenderThemeGtk::initMediaStyling(_GtkStyle*, bool) () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #5 0x00e311fd in WebCore::RenderThemeGtk::platformColorsDidChange() () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #6 0x00e30d41 in WebCore::gtkStyleSetCallback(_GtkWidget*, _GtkStyle*, WebCore::RenderTheme*) () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #7 0x0043571c in IA__g_cclosure_marshal_VOID__OBJECT (closure=0x80ea8b0, return_value=0x0, n_param_values=2, param_values=0x80cf568, invocation_hint=0xbfffdc70, marshal_data=0xb6824dc0) at gmarshal.c:636 #8 0x00427452 in IA__g_closure_invoke (closure=0x80ea8b0, return_value=0x0, n_param_values=2, param_values=0x80cf568, invocation_hint=0xbfffdc70) at gclosure.c:767 #9 0x0043df38 in signal_emit_unlocked_R (node=<value optimised out>, detail=<value optimised out>, instance=0x80e50b8, emission_return=0x0, instance_and_params=0x80cf568) at gsignal.c:3247 #10 0x0043f31d in IA__g_signal_emit_valist (instance=0x80e50b8, signal_id=23, detail=0, var_args=0xbfffde30 "\270P\016\b\t") at gsignal.c:2980 #11 0x0043f7d6 in IA__g_signal_emit (instance=0x80e50b8, signal_id=23, detail=0) at gsignal.c:3037 #12 0x02a576f7 in gtk_widget_set_style_internal (widget=0x80e50b8, style=0x80e8390, initial_emission=1) at gtkwidget.c:6584 #13 0x02a5789b in gtk_widget_reset_rc_style (widget=0x80e50b8) at gtkwidget.c:6196 #14 0x02a59234 in IA__gtk_widget_realize (widget=0x80e50b8) at gtkwidget.c:3326 #15 0x00e31197 in WebCore::RenderThemeGtk::gtkContainer() const () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #16 0x00e33033 in WebCore::RenderThemeGtk::RenderThemeGtk() () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #17 0x00e330a3 in WebCore::RenderThemeGtk::create() () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #18 0x00e33125 in WebCore::RenderTheme::themeForPage(WebCore::Page*) () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #19 0x00a911ab in WebCore::Page::Page(WebCore::ChromeClient*, WebCore::ContextMenuClient*, WebCore::EditorClient*, WebCore::DragClient*, WebCore::InspectorClient*, WebCore::PluginHalterClient*, WebCore::GeolocationControllerClient*) () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #20 0x005c1f86 in webkit_web_view_init(_WebKitWebView*) () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #21 0x004491d7 in IA__g_type_create_instance (type=135335816) at gtype.c:1854 #22 0x0042d0b8 in g_object_constructor (type=135335816, n_construct_properties=0, construct_params=0x0) at gobject.c:1393 #23 0x0042e0d8 in IA__g_object_newv (object_type=135335816, n_parameters=0, parameters=0x0) at gobject.c:1176 #24 0x0042efc2 in IA__g_object_new_valist (object_type=135335816, first_property_name=0x0, var_args=0xbfffe3c8 "") at gobject.c:1333 #25 0x0042f13e in IA__g_object_new (object_type=135335816, first_property_name=0x0) at gobject.c:1091 #26 0x005bb213 in webkit_web_view_new () from /home/phil/gst/jhbuild/build/WebKit/.libs/libwebkit-1.0.so.2 #27 0x08053ad6 in createWebView() () #28 0x08055464 in main () 173099 1 45138 pnormand 2009-12-18 03:22:19 -0800 Created attachment 45138 Proposed patch Create empty images for the controls if no GTK theme is set. 173100 2 webkit.review.bot 2009-12-18 03:24:52 -0800 style-queue ran check-webkit-style on attachment 45138 without any errors. 173130 3 45138 xan.lopez 2009-12-18 05:51:36 -0800 Comment on attachment 45138 Proposed patch r=me 173134 4 pnormand 2009-12-18 06:04:03 -0800 Landed as r52309 45138 2009-12-18 03:22:19 -0800 2009-12-18 05:51:35 -0800 Proposed patch -Reviewed-by-NOBODY-OOPS.patch text/plain 3144 pnormand RnJvbSBiMjdjYTJhNzc4MzVjY2ZjYWVhZGZlYzA2MDNlODlkYThhMWZmZjMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDE4IERlYyAyMDA5IDEyOjE5OjMwICswMTAwClN1YmplY3Q6IFtQQVRDSF0g ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgW0dUS10gc2VnZmF1 bHQgZHVyaW5nIGNvbnRyb2xzIGluaXRpYWxpemF0aW9uIGlmIG5vdCBHVEsgdGhlbWUgaXMgcHJl c2VudC4KICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI3 MDUKCiAgICAgICAgQ3JlYXRlIGVtcHR5IGltYWdlcyBmb3IgdGhlIGNvbnRyb2xzIGlmIG5vIEdU SyB0aGVtZSBpcyBzZXQuCgogICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlR3Rr LmNwcDoKICAgICAgICAoV2ViQ29yZTo6Z2V0VGhlbWVJY29uRmlsZU5hbWUpOgogICAgICAgIChX ZWJDb3JlOjpsb2FkSW1hZ2VGcm9tRmlsZSk6Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2d0ay9JbWFnZUd0ay5jcHAgfCAgIDE2ICsrKysrKysrKysrKy0tLS0KIDIgZmls ZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDMyMGYzM2MuLjc2 ODMxNzIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTItMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9y bWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtHVEtdIHNlZ2ZhdWx0IGR1cmluZyBjb250cm9scyBpbml0aWFsaXphdGlvbiBp ZiBub3QgR1RLIHRoZW1lIGlzIHByZXNlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjcwNQorCisgICAgICAgIENyZWF0ZSBlbXB0eSBpbWFnZXMg Zm9yIHRoZSBjb250cm9scyBpZiBubyBHVEsgdGhlbWUgaXMgc2V0LgorCisgICAgICAgICogcGxh dGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmdldFRo ZW1lSWNvbkZpbGVOYW1lKToKKyAgICAgICAgKFdlYkNvcmU6OmxvYWRJbWFnZUZyb21GaWxlKToK KwogMjAwOS0xMi0xOCAgQmVuamFtaW4gT3R0ZSAgPG90dGVAZ25vbWUub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3RrL0ltYWdlR3RrLmNwcAppbmRleCA2MjYzNTc5Li5jNjJkOTg4IDEwMDY0NAotLS0g YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUd0ay5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VHdGsuY3BwCkBAIC00OCwxMyArNDgsMTkgQEAg c3RhdGljIENTdHJpbmcgZ2V0VGhlbWVJY29uRmlsZU5hbWUoY29uc3QgY2hhciogbmFtZSwgaW50 IHNpemUpCiB7CiAgICAgR3RrSWNvbkluZm8qIGljb25JbmZvID0gZ3RrX2ljb25fdGhlbWVfbG9v a3VwX2ljb24oZ3RrX2ljb25fdGhlbWVfZ2V0X2RlZmF1bHQoKSwKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBuYW1lLCBzaXplLCBHVEtfSUNP Tl9MT09LVVBfTk9fU1ZHKTsKKyAgICAvLyBUcnkgdG8gZmFsbGJhY2sgb24gTUlTU0lOR19JTUFH RS4KICAgICBpZiAoIWljb25JbmZvKQogICAgICAgICBpY29uSW5mbyA9IGd0a19pY29uX3RoZW1l X2xvb2t1cF9pY29uKGd0a19pY29uX3RoZW1lX2dldF9kZWZhdWx0KCksCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR1RLX1NUT0NLX01JU1NJTkdfSU1BR0Us IHNpemUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR1RL X0lDT05fTE9PS1VQX05PX1NWRyk7CisgICAgaWYgKGljb25JbmZvKSB7CisgICAgICAgIEdPd25Q dHI8R3RrSWNvbkluZm8+IGluZm8oaWNvbkluZm8pOworICAgICAgICByZXR1cm4gQ1N0cmluZyhn dGtfaWNvbl9pbmZvX2dldF9maWxlbmFtZShpbmZvLmdldCgpKSk7CisgICAgfQogCi0gICAgR093 blB0cjxHdGtJY29uSW5mbz4gaW5mbyhpY29uSW5mbyk7Ci0gICAgcmV0dXJuIENTdHJpbmcoZ3Rr X2ljb25faW5mb19nZXRfZmlsZW5hbWUoaW5mby5nZXQoKSkpOworICAgIC8vIE5vIGljb24gd2Fz IGZvdW5kLCB0aGlzIGNhbiBoYXBwZW4gaWYgbm90IEdUSyB0aGVtZSBpcyBzZXQuIEluCisgICAg Ly8gdGhhdCBjYXNlIGFuIGVtcHR5IEltYWdlIHdpbGwgYmUgY3JlYXRlZC4KKyAgICByZXR1cm4g Q1N0cmluZygpOwogfQogCiBzdGF0aWMgUGFzc1JlZlB0cjxTaGFyZWRCdWZmZXI+IGxvYWRSZXNv dXJjZVNoYXJlZEJ1ZmZlcihDU3RyaW5nIG5hbWUpCkBAIC03OCw4ICs4NCwxMCBAQCB2b2lkIEJp dG1hcEltYWdlOjppbnZhbGlkYXRlUGxhdGZvcm1EYXRhKCkKIFBhc3NSZWZQdHI8SW1hZ2U+IGxv YWRJbWFnZUZyb21GaWxlKENTdHJpbmcgZmlsZU5hbWUpCiB7CiAgICAgUmVmUHRyPEJpdG1hcElt YWdlPiBpbWcgPSBCaXRtYXBJbWFnZTo6Y3JlYXRlKCk7Ci0gICAgUmVmUHRyPFNoYXJlZEJ1ZmZl cj4gYnVmZmVyID0gbG9hZFJlc291cmNlU2hhcmVkQnVmZmVyKGZpbGVOYW1lKTsKLSAgICBpbWct PnNldERhdGEoYnVmZmVyLnJlbGVhc2UoKSwgdHJ1ZSk7CisgICAgaWYgKCFmaWxlTmFtZS5pc051 bGwoKSkgeworICAgICAgICBSZWZQdHI8U2hhcmVkQnVmZmVyPiBidWZmZXIgPSBsb2FkUmVzb3Vy Y2VTaGFyZWRCdWZmZXIoZmlsZU5hbWUpOworICAgICAgICBpbWctPnNldERhdGEoYnVmZmVyLnJl bGVhc2UoKSwgdHJ1ZSk7CisgICAgfQogICAgIHJldHVybiBpbWcucmVsZWFzZSgpOwogfQogCi0t IAoxLjYuMy4z