32686 2009-12-17 17:12:44 -0800 Command.show_in_main_help should default to False 2009-12-17 17:28:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 172996 0 eric 2009-12-17 17:12:44 -0800 Command.show_in_main_help should default to False I initially thought that leaving it out would make the Command sub-classes clearer. Now I realize it just makes them nosier. Removing. 172997 1 45112 eric 2009-12-17 17:17:20 -0800 Created attachment 45112 Patch 172998 2 45112 commit-queue 2009-12-17 17:28:34 -0800 Comment on attachment 45112 Patch Clearing flags on attachment: 45112 Committed r52295: <http://trac.webkit.org/changeset/52295> 172999 3 commit-queue 2009-12-17 17:28:39 -0800 All reviewed patches have been landed. Closing bug. 45112 2009-12-17 17:17:20 -0800 2009-12-17 17:28:34 -0800 Patch bug-32686-20091217191719.patch text/plain 5944 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjNDNkOTFmLi5iZGNmM2RmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MTcgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbW1hbmQuc2hvd19pbl9tYWluX2hlbHAgc2hv dWxkIGRlZmF1bHQgdG8gRmFsc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMyNjg2CisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY29tbWFuZHMv ZG93bmxvYWQucHk6CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1ZXJpZXMu cHk6CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1ZXVlcy5weToKKyAgICAg ICAgKiBTY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvdXBsb2FkLnB5OgorICAgICAgICAqIFNjcmlw dHMvbW9kdWxlcy9tdWx0aWNvbW1hbmR0b29sLnB5OgorCiAyMDA5LTEyLTE3ICBBbGVqYW5kcm8g Ry4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMg U2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRz L2Rvd25sb2FkLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25s b2FkLnB5CmluZGV4IGNkYzgxYzEuLmI4ZmNiMTggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvbW9kdWxlcy9jb21tYW5kcy9kb3dubG9hZC5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY29tbWFuZHMvZG93bmxvYWQucHkKQEAgLTY4LDggKzY4LDYgQEAgY2xhc3Mg QWJzdHJhY3RTZXF1ZW5jZWRDb21tbWFuZChBYnN0cmFjdERlY2xhcmF0aXZlQ29tbW1hbmQpOgog Y2xhc3MgQnVpbGQoQWJzdHJhY3RTZXF1ZW5jZWRDb21tbWFuZCk6CiAgICAgbmFtZSA9ICJidWls ZCIKICAgICBoZWxwX3RleHQgPSAiVXBkYXRlIHdvcmtpbmcgY29weSBhbmQgYnVpbGQiCi0gICAg YXJndW1lbnRfbmFtZXMgPSAiIgotICAgIHNob3dfaW5fbWFpbl9oZWxwID0gRmFsc2UKICAgICBz dGVwcyA9IFsKICAgICAgICAgQ2xlYW5Xb3JraW5nRGlyZWN0b3J5U3RlcCwKICAgICAgICAgVXBk YXRlU3RlcCwKQEAgLTE2Niw3ICsxNjQsNiBAQCBjbGFzcyBDaGVja1N0eWxlKEFic3RyYWN0UGF0 Y2hTZXF1ZW5jaW5nQ29tbWFuZCwgUHJvY2Vzc0F0dGFjaG1lbnRzTWl4aW4pOgogICAgIG5hbWUg PSAiY2hlY2stc3R5bGUiCiAgICAgaGVscF90ZXh0ID0gIlJ1biBjaGVjay13ZWJraXQtc3R5bGUg b24gdGhlIHNwZWNpZmllZCBhdHRhY2htZW50cyIKICAgICBhcmd1bWVudF9uYW1lcyA9ICJBVFRB Q0hNRU5UX0lEIFtBVFRBQ0hNRU5UX0lEU10iCi0gICAgc2hvd19pbl9tYWluX2hlbHAgPSBGYWxz ZQogICAgIG1haW5fc3RlcHMgPSBbCiAgICAgICAgIENsZWFuV29ya2luZ0RpcmVjdG9yeVN0ZXAs CiAgICAgICAgIFVwZGF0ZVN0ZXAsCkBAIC0xNzksNyArMTc2LDYgQEAgY2xhc3MgQnVpbGRBdHRh Y2htZW50KEFic3RyYWN0UGF0Y2hTZXF1ZW5jaW5nQ29tbWFuZCwgUHJvY2Vzc0F0dGFjaG1lbnRz TWl4aW4pOgogICAgIG5hbWUgPSAiYnVpbGQtYXR0YWNobWVudCIKICAgICBoZWxwX3RleHQgPSAi QXBwbHkgYW5kIGJ1aWxkIHBhdGNoZXMgZnJvbSBidWd6aWxsYSIKICAgICBhcmd1bWVudF9uYW1l cyA9ICJBVFRBQ0hNRU5UX0lEIFtBVFRBQ0hNRU5UX0lEU10iCi0gICAgc2hvd19pbl9tYWluX2hl bHAgPSBGYWxzZQogICAgIG1haW5fc3RlcHMgPSBbCiAgICAgICAgIENsZWFuV29ya2luZ0RpcmVj dG9yeVN0ZXAsCiAgICAgICAgIFVwZGF0ZVN0ZXAsCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9T Y3JpcHRzL21vZHVsZXMvY29tbWFuZHMvcXVlcmllcy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv bW9kdWxlcy9jb21tYW5kcy9xdWVyaWVzLnB5CmluZGV4IDk4MzEwZTMuLmVhZGRiMGQgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWVyaWVzLnB5Cisr KyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWVyaWVzLnB5CkBAIC0z OSw3ICszOSw2IEBAIGZyb20gbW9kdWxlcy5tdWx0aWNvbW1hbmR0b29sIGltcG9ydCBDb21tYW5k CiAKIGNsYXNzIEJ1Z3NUb0NvbW1pdChDb21tYW5kKToKICAgICBuYW1lID0gImJ1Z3MtdG8tY29t bWl0IgotICAgIHNob3dfaW5fbWFpbl9oZWxwID0gRmFsc2UKICAgICBkZWYgX19pbml0X18oc2Vs Zik6CiAgICAgICAgIENvbW1hbmQuX19pbml0X18oc2VsZiwgIkxpc3QgYnVncyBpbiB0aGUgY29t bWl0LXF1ZXVlIikKIApAQCAtNTEsNyArNTAsNiBAQCBjbGFzcyBCdWdzVG9Db21taXQoQ29tbWFu ZCk6CiAKIGNsYXNzIFBhdGNoZXNUb0NvbW1pdChDb21tYW5kKToKICAgICBuYW1lID0gInBhdGNo ZXMtdG8tY29tbWl0IgotICAgIHNob3dfaW5fbWFpbl9oZWxwID0gRmFsc2UKICAgICBkZWYgX19p bml0X18oc2VsZik6CiAgICAgICAgIENvbW1hbmQuX19pbml0X18oc2VsZiwgIkxpc3QgcGF0Y2hl cyBpbiB0aGUgY29tbWl0LXF1ZXVlIikKIApAQCAtNjQsNyArNjIsNiBAQCBjbGFzcyBQYXRjaGVz VG9Db21taXQoQ29tbWFuZCk6CiAKIGNsYXNzIFBhdGNoZXNUb0NvbW1pdFF1ZXVlKENvbW1hbmQp OgogICAgIG5hbWUgPSAicGF0Y2hlcy10by1jb21taXQtcXVldWUiCi0gICAgc2hvd19pbl9tYWlu X2hlbHAgPSBGYWxzZQogICAgIGRlZiBfX2luaXRfXyhzZWxmKToKICAgICAgICAgb3B0aW9ucyA9 IFsKICAgICAgICAgICAgIG1ha2Vfb3B0aW9uKCItLWJ1Z3MiLCBhY3Rpb249InN0b3JlX3RydWUi LCBkZXN0PSJidWdzIiwgaGVscD0iT3V0cHV0IGJ1ZyBsaW5rcyBpbnN0ZWFkIG9mIHBhdGNoIGxp bmtzIiksCkBAIC05OSw3ICs5Niw2IEBAIGNsYXNzIFBhdGNoZXNUb0NvbW1pdFF1ZXVlKENvbW1h bmQpOgogCiBjbGFzcyBQYXRjaGVzVG9SZXZpZXcoQ29tbWFuZCk6CiAgICAgbmFtZSA9ICJwYXRj aGVzLXRvLXJldmlldyIKLSAgICBzaG93X2luX21haW5faGVscCA9IEZhbHNlCiAgICAgZGVmIF9f aW5pdF9fKHNlbGYpOgogICAgICAgICBDb21tYW5kLl9faW5pdF9fKHNlbGYsICJMaXN0IHBhdGNo ZXMgdGhhdCBhcmUgcGVuZGluZyByZXZpZXciKQogCkBAIC0xMTIsNyArMTA4LDYgQEAgY2xhc3Mg UGF0Y2hlc1RvUmV2aWV3KENvbW1hbmQpOgogCiBjbGFzcyBSZXZpZXdlZFBhdGNoZXMoQ29tbWFu ZCk6CiAgICAgbmFtZSA9ICJyZXZpZXdlZC1wYXRjaGVzIgotICAgIHNob3dfaW5fbWFpbl9oZWxw ID0gRmFsc2UKICAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIENvbW1hbmQuX19pbml0 X18oc2VsZiwgIkxpc3QgcisnZCBwYXRjaGVzIG9uIGEgYnVnIiwgIkJVR0lEIikKIApkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1ZXVlcy5weSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWV1ZXMucHkKaW5kZXggNjA2NjM2 Zi4uZjhmZWY5NiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1h bmRzL3F1ZXVlcy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMv cXVldWVzLnB5CkBAIC00NCw3ICs0NCw2IEBAIGZyb20gbW9kdWxlcy5zdGVwc2VxdWVuY2UgaW1w b3J0IFN0ZXBTZXF1ZW5jZUVycm9ySGFuZGxlcgogZnJvbSBtb2R1bGVzLndvcmtxdWV1ZSBpbXBv cnQgV29ya1F1ZXVlLCBXb3JrUXVldWVEZWxlZ2F0ZQogCiBjbGFzcyBBYnN0cmFjdFF1ZXVlKENv bW1hbmQsIFdvcmtRdWV1ZURlbGVnYXRlKToKLSAgICBzaG93X2luX21haW5faGVscCA9IEZhbHNl CiAgICAgd2F0Y2hlcnMgPSAid2Via2l0LWJvdC13YXRjaGVyc0Bnb29nbGVncm91cHMuY29tIgog ICAgIGRlZiBfX2luaXRfXyhzZWxmLCBvcHRpb25zPU5vbmUpOiAjIERlZmF1bHQgdmFsdWVzIHNo b3VsZCBuZXZlciBiZSBjb2xsZWN0aW9ucyAobGlrZSBbXSkgYXMgZGVmYXVsdCB2YWx1ZXMgYXJl IHNoYXJlZCBiZXR3ZWVuIGludm9jYXRpb25zCiAgICAgICAgIG9wdGlvbnNfbGlzdCA9IChvcHRp b25zIG9yIFtdKSArIFsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9j b21tYW5kcy91cGxvYWQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMv dXBsb2FkLnB5CmluZGV4IGQyODgzMDEuLmVmOGJhMWUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy91cGxvYWQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9tb2R1bGVzL2NvbW1hbmRzL3VwbG9hZC5weQpAQCAtNDQsNyArNDQsNiBAQCBmcm9tIG1v ZHVsZXMubXVsdGljb21tYW5kdG9vbCBpbXBvcnQgQ29tbWFuZAogIyBGSVhNRTogUmVxdWlyZXMg dW5pdCB0ZXN0LgogY2xhc3MgQ29tbWl0TWVzc2FnZUZvckN1cnJlbnREaWZmKENvbW1hbmQpOgog ICAgIG5hbWUgPSAiY29tbWl0LW1lc3NhZ2UiCi0gICAgc2hvd19pbl9tYWluX2hlbHAgPSBGYWxz ZQogICAgIGRlZiBfX2luaXRfXyhzZWxmKToKICAgICAgICAgQ29tbWFuZC5fX2luaXRfXyhzZWxm LCAiUHJpbnQgYSBjb21taXQgbWVzc2FnZSBzdWl0YWJsZSBmb3IgdGhlIHVuY29tbWl0dGVkIGNo YW5nZXMiKQogCkBAIC01NSw3ICs1NCw2IEBAIGNsYXNzIENvbW1pdE1lc3NhZ2VGb3JDdXJyZW50 RGlmZihDb21tYW5kKToKIAogY2xhc3MgT2Jzb2xldGVBdHRhY2htZW50cyhDb21tYW5kKToKICAg ICBuYW1lID0gIm9ic29sZXRlLWF0dGFjaG1lbnRzIgotICAgIHNob3dfaW5fbWFpbl9oZWxwID0g RmFsc2UKICAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIENvbW1hbmQuX19pbml0X18o c2VsZiwgIk1hcmsgYWxsIGF0dGFjaG1lbnRzIG9uIGEgYnVnIGFzIG9ic29sZXRlIiwgIkJVR0lE IikKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL211bHRpY29tbWFu ZHRvb2wucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvbXVsdGljb21tYW5kdG9vbC5w eQppbmRleCAwNDc1Y2YxLi41MzM4NGQzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRz L21vZHVsZXMvbXVsdGljb21tYW5kdG9vbC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvbXVsdGljb21tYW5kdG9vbC5weQpAQCAtNDAsNyArNDAsNyBAQCBmcm9tIG1vZHVsZXMu bG9nZ2luZyBpbXBvcnQgbG9nCiAKIGNsYXNzIENvbW1hbmQob2JqZWN0KToKICAgICBuYW1lID0g Tm9uZQotICAgICMgc2hvd19pbl9tYWluX2hlbHAgPSBGYWxzZSAjIFN1YmNsYXNzZXMgbXVzdCBk ZWZpbmUgc2hvd19pbl9tYWluX2hlbHAsIHdlIGxlYXZlIGl0IG91dCBoZXJlIHRvIGVuZm9yY2Ug dGhhdC4KKyAgICBzaG93X2luX21haW5faGVscCA9IEZhbHNlCiAgICAgZGVmIF9faW5pdF9fKHNl bGYsIGhlbHBfdGV4dCwgYXJndW1lbnRfbmFtZXM9Tm9uZSwgb3B0aW9ucz1Ob25lLCByZXF1aXJl c19sb2NhbF9jb21taXRzPUZhbHNlKToKICAgICAgICAgc2VsZi5oZWxwX3RleHQgPSBoZWxwX3Rl eHQKICAgICAgICAgc2VsZi5hcmd1bWVudF9uYW1lcyA9IGFyZ3VtZW50X25hbWVzCkBAIC0xMjgs NyArMTI4LDYgQEAgY2xhc3MgSGVscFByaW50aW5nT3B0aW9uUGFyc2VyKE9wdGlvblBhcnNlcik6 CiAKIGNsYXNzIEhlbHBDb21tYW5kKENvbW1hbmQpOgogICAgIG5hbWUgPSAiaGVscCIKLSAgICBz aG93X2luX21haW5faGVscCA9IEZhbHNlCiAKICAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAg ICAgIG9wdGlvbnMgPSBbCg==