32675 2009-12-17 11:34:19 -0800 HTMLInputElement::stepMismatch() uses ambiguous overload of pow() 2009-12-17 23:45:36 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock steveblock commit-queue darin eric mitz steveblock tkent webkit.review.bot oldest_to_newest 172895 0 steveblock 2009-12-17 11:34:19 -0800 HTMLInputElement::stepMismatch() calls pow() with two integer arguments. This causes a compile error due to an ambiguous overload on Android. This was added in http://trac.webkit.org/changeset/51159 172901 1 45099 steveblock 2009-12-17 11:46:57 -0800 Created attachment 45099 Patch 1 for Bug 32675 Cast first argument of pow to double to force 'double pow(double, int)' 172904 2 webkit.review.bot 2009-12-17 11:49:48 -0800 style-queue ran check-webkit-style on attachment 45099 without any errors. 172917 3 45099 eric 2009-12-17 12:49:48 -0800 Comment on attachment 45099 Patch 1 for Bug 32675 This looks OK to me. It would be nice if you could post the error in the bug for posterity, or even in the ChangeLog. It's not clear to me what other signature on Andriod would be causing this error. 172919 4 eric 2009-12-17 12:51:03 -0800 (I CC'd darin adler just because he was one of the primary driving forces behind our MathExtras.h and similar WTF files which deal with x-platform issues similar to this one. I figured he might like to see this go by.) 172949 5 steveblock 2009-12-17 14:19:03 -0800 The build error is ... external/webkit/WebCore/html/HTMLInputElement.cpp:343: error: call of overloaded 'pow(int, int)' is ambiguous bionic/libm/include/math.h:222: note: candidates are: double pow(double, double) external/webkit/WebKit/android/stlport/stl/_cmath.h:443: note: float pow(float, float) external/webkit/WebKit/android/stlport/stl/_cmath.h:443: note: long double pow(long double, long double) external/webkit/WebKit/android/stlport/stl/_cmath.h:448: note: float pow(float, int) external/webkit/WebKit/android/stlport/stl/_cmath.h:455: note: double pow(double, int) external/webkit/WebKit/android/stlport/stl/_cmath.h:468: note: long double pow(long double, int) The problem is that pow(int, int) isn't defined, nor is it in the c standard or c98. 172951 6 eric 2009-12-17 14:26:43 -0800 We have a pow() in MathExtras: http://trac.webkit.org/browser/trunk/JavaScriptCore/wtf/MathExtras.h We also seem to try hard to avoid use of cmath: http://trac.webkit.org/changeset/13104 http://trac.webkit.org/changeset/11667 http://trac.webkit.org/changeset/12225 And sometimes add it? http://trac.webkit.org/changeset/10511 I'm not convinced this is the right work-around. It would be nice if someone who is more familiar with our historical header troubles could comment. 172952 7 eric 2009-12-17 14:28:12 -0800 Actually, I take that back. This change has nothing really to do with cmath. I think it's still fine. 172955 8 45099 commit-queue 2009-12-17 14:37:26 -0800 Comment on attachment 45099 Patch 1 for Bug 32675 Clearing flags on attachment: 45099 Committed r52292: <http://trac.webkit.org/changeset/52292> 172956 9 commit-queue 2009-12-17 14:37:31 -0800 All reviewed patches have been landed. Closing bug. 172988 10 darin 2009-12-17 16:48:12 -0800 I would have preferred the use of the constant, 2.0, which is a double rather than writing it as static_cast<double>(2), which seems less elegant to me. 172992 11 eric 2009-12-17 16:58:45 -0800 Bah! Agreed. Clearly i wans't thinking. I'll fix it. 173055 12 45126 eric 2009-12-17 23:01:43 -0800 Created attachment 45126 constant fix as recommended by Darin 173059 13 eric 2009-12-17 23:08:12 -0800 Going to have the commit-queue land this for me to make sure I didn't make any stupid typos. This laptop is too slow to build on. 173060 14 45126 eric 2009-12-17 23:08:52 -0800 Comment on attachment 45126 constant fix as recommended by Darin Make the commit-queue land this. Since I already filled in the reviewer the commit-queue won't get confused by me marking this r+. 173062 15 mitz 2009-12-17 23:16:31 -0800 And since it’s C++, you could also use numeric_limits<double>::digits() instead of DBL_MANT_DIG 173063 16 45126 commit-queue 2009-12-17 23:17:20 -0800 Comment on attachment 45126 constant fix as recommended by Darin Clearing flags on attachment: 45126 Committed r52302: <http://trac.webkit.org/changeset/52302> 173064 17 commit-queue 2009-12-17 23:17:26 -0800 All reviewed patches have been landed. Closing bug. 173066 18 eric 2009-12-17 23:45:36 -0800 Nifty. I don't actually know what either of those values do. :) But that's OK. That part of this function wasn't touched by either patch. I'm not going to go back and do the limits conversion now, but if I'm ever in that code again I'd be happy to! 45099 2009-12-17 11:46:57 -0800 2009-12-17 23:01:31 -0800 Patch 1 for Bug 32675 pow.txt text/plain 1755 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjI3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTItMTcgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEZpeGVzIEhUTUxJbnB1dEVsZW1lbnQ6OnN0ZXBNaXNtYXRjaCgpIHRvIGF2b2lkIGFtYmlndW91 cyBvdmVybG9hZCBvZiBwb3coKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTMyNjc1CisKKyAgICAgICAgQnVpbGQgZml4IG9ubHksIG5vIG5ldyB0ZXN0 cy4KKworICAgICAgICAqIGh0bWwvSFRNTElucHV0RWxlbWVudC5jcHA6IE1vZGlmaWVkLgorICAg ICAgICAoV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudDo6c3RlcE1pc21hdGNoKTogQ2FzdCBmaXJz dCBhcmd1bWVudCBvZiBwb3cgdG8gZG91YmxlIHRvIGZvcmNlICdkb3VibGUgcG93KGRvdWJsZSwg aW50KScKKwogMjAwOS0xMi0xNyAgWWFhciBTY2huaXRtYW4gIDx5YWFyQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJDb3JlL2h0bWwv SFRNTElucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxJbnB1 dEVsZW1lbnQuY3BwCShyZXZpc2lvbiA1MjI2NykKKysrIFdlYkNvcmUvaHRtbC9IVE1MSW5wdXRF bGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM3LDExICszMzcsMTEgQEAgYm9vbCBIVE1M SW5wdXRFbGVtZW50OjpzdGVwTWlzbWF0Y2goKSBjbwogICAgICAgICAvLyBkb3VibGUncyBmcmFj dGlvbmFsIHBhcnQgc2l6ZSBpcyBEQkxfTUFOX0RJRy1iaXQuICBJZiB0aGUgY3VycmVudAogICAg ICAgICAvLyB2YWx1ZSBpcyBncmVhdGVyIHRoYW4gc3RlcCoyXkRCTF9NQU5UX0RJRywgdGhlIGZv bGxvd2luZyBmbW9kKCkgbWFrZXMKICAgICAgICAgLy8gbm8gc2Vuc2UuCi0gICAgICAgIGlmIChk b3VibGVWYWx1ZSAvIHBvdygyLCBEQkxfTUFOVF9ESUcpID4gc3RlcCkKKyAgICAgICAgaWYgKGRv dWJsZVZhbHVlIC8gcG93KHN0YXRpY19jYXN0PGRvdWJsZT4oMiksIERCTF9NQU5UX0RJRykgPiBz dGVwKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBkb3VibGUgcmVtYWluZGVy ID0gZm1vZChkb3VibGVWYWx1ZSwgc3RlcCk7CiAgICAgICAgIC8vIEFjY2VwdHMgZXJyb3JzIGlu IGxvd2VyIDctYml0LgotICAgICAgICBkb3VibGUgYWNjZXB0YWJsZUVycm9yID0gc3RlcCAvIHBv dygyLCBEQkxfTUFOVF9ESUcgLSA3KTsKKyAgICAgICAgZG91YmxlIGFjY2VwdGFibGVFcnJvciA9 IHN0ZXAgLyBwb3coc3RhdGljX2Nhc3Q8ZG91YmxlPigyKSwgREJMX01BTlRfRElHIC0gNyk7CiAg ICAgICAgIHJldHVybiBhY2NlcHRhYmxlRXJyb3IgPCByZW1haW5kZXIgJiYgcmVtYWluZGVyIDwg KHN0ZXAgLSBhY2NlcHRhYmxlRXJyb3IpOwogICAgIH0KICAgICAvLyBOb24tUkFOR0UgdHlwZXMg c2hvdWxkIGJlIHJlamVjdGVkIGJ5IGdldEFsbG93ZWRWYWx1ZVN0ZXAoKS4K 45126 2009-12-17 23:01:43 -0800 2009-12-17 23:17:20 -0800 constant fix as recommended by Darin bug-32675-20091218010140.patch text/plain 1628 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjdmM2M5Zi4uODk0YzY3OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMi0xNyAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisK KyAgICAgICAgSFRNTElucHV0RWxlbWVudDo6c3RlcE1pc21hdGNoKCkgdXNlcyBhbWJpZ3VvdXMg b3ZlcmxvYWQgb2YgcG93KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMyNjc1CisKKyAgICAgICAgVXNlIHRoZSBkb3VibGUgY29uc3RhbnQgMi4wIGlu c3RlYWQgb2Ygc3RhdGljX2Nhc3Q8ZG91YmxlPigyKS4KKworICAgICAgICAqIGh0bWwvSFRNTElu cHV0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50OjpzdGVw TWlzbWF0Y2gpOgorCiAyMDA5LTEyLTE3ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVs ZW1lbnQuY3BwCmluZGV4IDYwMmIzMzkuLmZmYTRhYWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRt bC9IVE1MSW5wdXRFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVu dC5jcHAKQEAgLTMzNywxMSArMzM3LDExIEBAIGJvb2wgSFRNTElucHV0RWxlbWVudDo6c3RlcE1p c21hdGNoKCkgY29uc3QKICAgICAgICAgLy8gZG91YmxlJ3MgZnJhY3Rpb25hbCBwYXJ0IHNpemUg aXMgREJMX01BTl9ESUctYml0LiAgSWYgdGhlIGN1cnJlbnQKICAgICAgICAgLy8gdmFsdWUgaXMg Z3JlYXRlciB0aGFuIHN0ZXAqMl5EQkxfTUFOVF9ESUcsIHRoZSBmb2xsb3dpbmcgZm1vZCgpIG1h a2VzCiAgICAgICAgIC8vIG5vIHNlbnNlLgotICAgICAgICBpZiAoZG91YmxlVmFsdWUgLyBwb3co c3RhdGljX2Nhc3Q8ZG91YmxlPigyKSwgREJMX01BTlRfRElHKSA+IHN0ZXApCisgICAgICAgIGlm IChkb3VibGVWYWx1ZSAvIHBvdygyLjAsIERCTF9NQU5UX0RJRykgPiBzdGVwKQogICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBkb3VibGUgcmVtYWluZGVyID0gZm1vZChkb3VibGVW YWx1ZSwgc3RlcCk7CiAgICAgICAgIC8vIEFjY2VwdHMgZXJyb3JzIGluIGxvd2VyIDctYml0Lgot ICAgICAgICBkb3VibGUgYWNjZXB0YWJsZUVycm9yID0gc3RlcCAvIHBvdyhzdGF0aWNfY2FzdDxk b3VibGU+KDIpLCBEQkxfTUFOVF9ESUcgLSA3KTsKKyAgICAgICAgZG91YmxlIGFjY2VwdGFibGVF cnJvciA9IHN0ZXAgLyBwb3coMi4wLCBEQkxfTUFOVF9ESUcgLSA3KTsKICAgICAgICAgcmV0dXJu IGFjY2VwdGFibGVFcnJvciA8IHJlbWFpbmRlciAmJiByZW1haW5kZXIgPCAoc3RlcCAtIGFjY2Vw dGFibGVFcnJvcik7CiAgICAgfQogICAgIC8vIE5vbi1SQU5HRSB0eXBlcyBzaG91bGQgYmUgcmVq ZWN0ZWQgYnkgZ2V0QWxsb3dlZFZhbHVlU3RlcCgpLgo=