32669 2009-12-17 10:01:59 -0800 check-webkit-style should not mark moc files inclusion as errors 2009-12-27 01:11:35 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 yael webkit-unassigned abarth commit-queue levin webkit.review.bot oldest_to_newest 172831 0 yael 2009-12-17 10:01:59 -0800 moc files are the "magic" behind Qt's signals and slots. These files must be included at the bottom of the cpp file which includes them, or compilation will fail. check-webkit-style marks including these files as out-of-order. see https://bugs.webkit.org/show_bug.cgi?id=32555#c6 as an example. 174878 1 45493 yael 2009-12-25 11:13:08 -0800 Created attachment 45493 Patch. 174879 2 webkit.review.bot 2009-12-25 11:13:42 -0800 style-queue ran check-webkit-style on attachment 45493 without any errors. 174922 3 45493 darin 2009-12-25 20:07:16 -0800 Comment on attachment 45493 Patch. It would be even better if this rule was specific to Qt platform directories. 175019 4 45493 commit-queue 2009-12-27 01:11:30 -0800 Comment on attachment 45493 Patch. Clearing flags on attachment: 45493 Committed r52575: <http://trac.webkit.org/changeset/52575> 175020 5 commit-queue 2009-12-27 01:11:35 -0800 All reviewed patches have been landed. Closing bug. 45493 2009-12-25 11:13:08 -0800 2009-12-27 01:11:29 -0800 Patch. 32669.patch text/plain 2565 yael SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jcHBfc3R5bGUucHkKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weQkocmV2aXNpb24g NTIzNzIpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY3BwX3N0eWxlLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC0yMzIsNiArMjMyLDcgQEAKIF9DT05GSUdfSEVBREVSID0gMAogX1BSSU1B UllfSEVBREVSID0gMQogX09USEVSX0hFQURFUiA9IDIKK19NT0NfSEVBREVSID0gMwogCiAKICMg VGhlIHJlZ2V4cCBjb21waWxhdGlvbiBjYWNoaW5nIGlzIGlubGluZWQgaW4gYWxsIHJlZ2V4cCBm dW5jdGlvbnMgZm9yCkBAIC0yOTAsNiArMjkxLDcgQEAKICAgICAgICAgX0NPTkZJR19IRUFERVI6 ICdXZWJDb3JlIGNvbmZpZy5oJywKICAgICAgICAgX1BSSU1BUllfSEVBREVSOiAnaGVhZGVyIHRo aXMgZmlsZSBpbXBsZW1lbnRzJywKICAgICAgICAgX09USEVSX0hFQURFUjogJ290aGVyIGhlYWRl cicsCisgICAgICAgIF9NT0NfSEVBREVSOiAnbW9jIGZpbGUnLAogICAgICAgICB9CiAgICAgX1NF Q1RJT05fTkFNRVMgPSB7CiAgICAgICAgIF9JTklUSUFMX1NFQ1RJT046ICIuLi4gbm90aGluZy4i LApAQCAtMzI2LDYgKzMyOCw4IEBACiAgICAgICAgICAgICByZXR1cm4gJ0hlYWRlciBmaWxlIHNo b3VsZCBub3QgY29udGFpbiBXZWJDb3JlIGNvbmZpZy5oLicKICAgICAgICAgaWYgaGVhZGVyX3R5 cGUgPT0gX1BSSU1BUllfSEVBREVSIGFuZCBmaWxlX2lzX2hlYWRlcjoKICAgICAgICAgICAgIHJl dHVybiAnSGVhZGVyIGZpbGUgc2hvdWxkIG5vdCBjb250YWluIGl0c2VsZi4nCisgICAgICAgIGlm IGhlYWRlcl90eXBlID09IF9NT0NfSEVBREVSOgorICAgICAgICAgICAgcmV0dXJuICcnCiAKICAg ICAgICAgZXJyb3JfbWVzc2FnZSA9ICcnCiAgICAgICAgIGlmIHNlbGYuX3NlY3Rpb24gIT0gc2Vs Zi5fT1RIRVJfU0VDVElPTjoKQEAgLTIzMzAsNiArMjMzNCwxMyBAQAogICAgIGVsaWYgaW5jbHVk ZV9zdGF0ZS52aXNpdGVkX3ByaW1hcnlfc2VjdGlvbigpIGFuZCB0YXJnZXRfYmFzZSA9PSBpbmNs dWRlX2Jhc2U6CiAgICAgICAgIHJldHVybiBfUFJJTUFSWV9IRUFERVIKIAorICAgICMgUXQncyBt b2MgZmlsZXMgZG8gbm90IGZvbGxvdyB0aGUgbmFtaW5nIGFuZCBvcmRlcmluZyBydWxlcywgc28g dGhleSBzaG91bGQgYmUgc2tpcHBlZAorICAgIGlmIGluY2x1ZGUuc3RhcnRzd2l0aCgnbW9jXycp IGFuZCBpbmNsdWRlLmVuZHN3aXRoKCcuY3BwJyk6CisgICAgICAgIHJldHVybiBfTU9DX0hFQURF UgorCisgICAgaWYgaW5jbHVkZS5lbmRzd2l0aCgnLm1vYycpOgorICAgICAgICByZXR1cm4gX01P Q19IRUFERVIKKwogICAgIHJldHVybiBfT1RIRVJfSEVBREVSCiAKIApAQCAtMjQwMCw3ICsyNDEx LDcgQEAKICAgICAgICAgICAgICAgICAgICdZb3Ugc2hvdWxkIGFkZCBhIGJsYW5rIGxpbmUgYWZ0 ZXIgaW1wbGVtZW50YXRpb24gZmlsZVwncyBvd24gaGVhZGVyLicpCiAKICAgICAjIENoZWNrIHRv IG1ha2Ugc3VyZSBhbGwgaGVhZGVycyBiZXNpZGVzIGNvbmZpZy5oIGFuZCB0aGUgcHJpbWFyeSBo ZWFkZXIgYXJlCi0gICAgIyBhbHBoYWJldGljYWxseSBzb3J0ZWQuCisgICAgIyBhbHBoYWJldGlj YWxseSBzb3J0ZWQuIFNraXAgUXQncyBtb2MgZmlsZXMuCiAgICAgaWYgbm90IGVycm9yX21lc3Nh Z2UgYW5kIGhlYWRlcl90eXBlID09IF9PVEhFUl9IRUFERVI6CiAgICAgICAgICBwcmV2aW91c19s aW5lX251bWJlciA9IGxpbmVfbnVtYmVyIC0gMTsKICAgICAgICAgIHByZXZpb3VzX2xpbmUgPSBj bGVhbl9saW5lcy5saW5lc1twcmV2aW91c19saW5lX251bWJlcl0KSW5kZXg6IFdlYktpdFRvb2xz L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9u IDUyNTU4KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTQgQEAKKzIwMDktMTItMjUgIFlhZWwgQWhhcm9uICA8eWFlbC5haGFyb25Abm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNr LXdlYmtpdC1zdHlsZSBzaG91bGQgbm90IG1hcmsgbW9jIGZpbGVzIGluY2x1c2lvbiBhcyBlcnJv cnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNjY5 CisKKyAgICAgICAgQWRkIGEgbmV3IGhlYWRlciB0eXBlIGZvciBtb2MgZmlsZXMsIGFuZCBza2lw IHRoZW0gd2hlbiBjaGVja2luZyB0aGUgb3JkZXIgb2YgaGVhZGVyIGZpbGVzLgorCisgICAgICAg ICogU2NyaXB0cy9tb2R1bGVzL2NwcF9zdHlsZS5weToKKwogMjAwOS0xMi0yMyAgRXJpYyBTZWlk ZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4K