32666 2009-12-17 09:30:44 -0800 AX: DRT needs to support URL for accessibility 2009-12-17 11:48:56 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach webkit.review.bot oldest_to_newest 172812 0 cfleizach 2009-12-17 09:30:44 -0800 DRT needs to support the ability to fetch a URL 172817 1 45078 cfleizach 2009-12-17 09:35:29 -0800 Created attachment 45078 patch Simple patch. No use case in open source code yet, but we want it to be down-merged to other platforms 172820 2 webkit.review.bot 2009-12-17 09:37:44 -0800 style-queue ran check-webkit-style on attachment 45078 without any errors. 172897 3 45078 ddkilzer 2009-12-17 11:42:37 -0800 Comment on attachment 45078 patch > Index: WebKitTools/ChangeLog > Index: WebKitTools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp > +JSStringRef AccessibilityUIElement::url() > +{ > + return 0; > +} Please add a FIXME. Also, other "FIXME" methods that return JSStringRef use JSStringCreateWithCharacters(0, 0) instead: // FIXME: implement return JSStringCreateWithCharacters(0, 0); > Index: WebKitTools/DumpRenderTree/win/AccessibilityUIElementWin.cpp > +JSStringRef AccessibilityUIElement::url() > +{ > + return 0; > +} Again, I think this should use JSStringCreateWithCharacters(0, 0): return JSStringCreateWithCharacters(0, 0); r=me with these changes 172902 4 cfleizach 2009-12-17 11:48:56 -0800 http://trac.webkit.org/changeset/52272 45078 2009-12-17 09:35:29 -0800 2009-12-17 11:42:37 -0800 patch patch.txt text/plain 4709 cfleizach SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUyMjU3KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMDktMTItMTcgIENocmlzIEZsZWl6YWNoICA8 Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBWDogRFJUIG5lZWRzIHRvIHN1cHBvcnQgVVJMIGZvciBhY2Nlc3NpYmls aXR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjY2 NgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvQWNjZXNzaWJpbGl0eVVJRWxlbWVudC5jcHA6 CisgICAgICAgIChnZXRVUkxDYWxsYmFjayk6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVt ZW50OjpnZXRKU0NsYXNzKToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5 VUlFbGVtZW50Lmg6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlV SUVsZW1lbnRHdGsuY3BwOgorICAgICAgICAoQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dXJsKToK KyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5t bToKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnVybCk6CisgICAgICAgICogRHVt cFJlbmRlclRyZWUvd2luL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRXaW4uY3BwOgorICAgICAgICAo QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dXJsKToKKwogMjAwOS0xMi0xNyAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1YmJlciBzdGFtcCBieSBTZWlkZWwuCklu ZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5 VUlFbGVtZW50LmNwcAkocmV2aXNpb24gNTIyNTcpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTA0LDYg KzUwNCwxMiBAQCBzdGF0aWMgSlNWYWx1ZVJlZiBnZXREb2N1bWVudFVSSUNhbGxiYWNrCiAgICAg cmV0dXJuIEpTVmFsdWVNYWtlU3RyaW5nKGNvbnRleHQsIGRvY3VtZW50VVJJLmdldCgpKTsKIH0K IAorc3RhdGljIEpTVmFsdWVSZWYgZ2V0VVJMQ2FsbGJhY2soSlNDb250ZXh0UmVmIGNvbnRleHQs IEpTT2JqZWN0UmVmIHRoaXNPYmplY3QsIEpTU3RyaW5nUmVmIHByb3BlcnR5TmFtZSwgSlNWYWx1 ZVJlZiogZXhjZXB0aW9uKQoreworICAgIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiB1cmwoQWRv cHQsIHRvQVhFbGVtZW50KHRoaXNPYmplY3QpLT51cmwoKSk7CisgICAgcmV0dXJuIEpTVmFsdWVN YWtlU3RyaW5nKGNvbnRleHQsIHVybC5nZXQoKSk7Cit9CisKIC8vIERlc3RydWN0aW9uCiAKIHN0 YXRpYyB2b2lkIGZpbmFsaXplKEpTT2JqZWN0UmVmIHRoaXNPYmplY3QpCkBAIC01NDksNiArNTU1 LDcgQEAgSlNDbGFzc1JlZiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpnZXRKUwogICAgICAgICB7 ICJoaWVyYXJjaGljYWxMZXZlbCIsIGhpZXJhcmNoaWNhbExldmVsQ2FsbGJhY2ssIDAsIGtKU1By b3BlcnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZURvbnREZWxldGUg fSwKICAgICAgICAgeyAiZG9jdW1lbnRFbmNvZGluZyIsIGdldERvY3VtZW50RW5jb2RpbmdDYWxs YmFjaywgMCwga0pTUHJvcGVydHlBdHRyaWJ1dGVSZWFkT25seSB8IGtKU1Byb3BlcnR5QXR0cmli dXRlRG9udERlbGV0ZSB9LAogICAgICAgICB7ICJkb2N1bWVudFVSSSIsIGdldERvY3VtZW50VVJJ Q2FsbGJhY2ssIDAsIGtKU1Byb3BlcnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0eUF0 dHJpYnV0ZURvbnREZWxldGUgfSwKKyAgICAgICAgeyAidXJsIiwgZ2V0VVJMQ2FsbGJhY2ssIDAs IGtKU1Byb3BlcnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZURvbnRE ZWxldGUgfSwKICAgICAgICAgeyAiaXNWYWxpZCIsIGdldElzVmFsaWRDYWxsYmFjaywgMCwga0pT UHJvcGVydHlBdHRyaWJ1dGVSZWFkT25seSB8IGtKU1Byb3BlcnR5QXR0cmlidXRlRG9udERlbGV0 ZSB9LAogICAgICAgICB7ICJvcmllbnRhdGlvbiIsIGdldE9yaWVudGF0aW9uQ2FsbGJhY2ssIDAs IGtKU1Byb3BlcnR5QXR0cmlidXRlUmVhZE9ubHkgfCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZURvbnRE ZWxldGUgfSwKICAgICAgICAgeyAiYXJpYUlzR3JhYmJlZCIsIGdldEFSSUFJc0dyYWJiZWRDYWxs YmFjaywgMCwga0pTUHJvcGVydHlBdHRyaWJ1dGVSZWFkT25seSB8IGtKU1Byb3BlcnR5QXR0cmli dXRlRG9udERlbGV0ZSB9LApJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvQWNjZXNz aWJpbGl0eVVJRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnQuaAkocmV2aXNpb24gNTIyNTcpCisrKyBXZWJLaXRU b29scy9EdW1wUmVuZGVyVHJlZS9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50LmgJKHdvcmtpbmcgY29w eSkKQEAgLTExNyw2ICsxMTcsNyBAQCBwdWJsaWM6CiAgICAgZG91YmxlIGNsaWNrUG9pbnRZKCk7 CiAgICAgSlNTdHJpbmdSZWYgZG9jdW1lbnRFbmNvZGluZygpOwogICAgIEpTU3RyaW5nUmVmIGRv Y3VtZW50VVJJKCk7CisgICAgSlNTdHJpbmdSZWYgdXJsKCk7CiAKICAgICAvLyBUYWJsZS1zcGVj aWZpYyBhdHRyaWJ1dGVzCiAgICAgSlNTdHJpbmdSZWYgYXR0cmlidXRlc09mQ29sdW1uSGVhZGVy cygpOwpJbmRleDogV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlV SUVsZW1lbnRHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcAkocmV2aXNpb24gNTIyNTcpCisrKyBX ZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5j cHAJKHdvcmtpbmcgY29weSkKQEAgLTUyOCwzICs1MjgsOCBAQCBKU1N0cmluZ1JlZiBBY2Nlc3Np YmlsaXR5VUlFbGVtZW50Ojpkb2N1CiAKICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVXaXRoVVRG OENTdHJpbmcoYXRrX2RvY3VtZW50X2dldF9hdHRyaWJ1dGVfdmFsdWUoQVRLX0RPQ1VNRU5UKG1f ZWxlbWVudCksICJVUkkiKSk7CiB9CisKK0pTU3RyaW5nUmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1l bnQ6OnVybCgpCit7CisgICAgcmV0dXJuIDA7Cit9CkluZGV4OiBXZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvQWNjZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5t bQkocmV2aXNpb24gNTIyNTcpCisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvQWNj ZXNzaWJpbGl0eVVJRWxlbWVudE1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNzIxLDMgKzcyMSw5 IEBAIEpTU3RyaW5nUmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmRvY3UKIHsKICAgICByZXR1 cm4gSlNTdHJpbmdDcmVhdGVXaXRoQ2hhcmFjdGVycygwLCAwKTsKIH0KKworSlNTdHJpbmdSZWYg QWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6dXJsKCkKK3sKKyAgICBOU1VSTCAqdXJsID0gW21fZWxl bWVudCBhY2Nlc3NpYmlsaXR5QXR0cmlidXRlVmFsdWU6TlNBY2Nlc3NpYmlsaXR5VVJMQXR0cmli dXRlXTsKKyAgICByZXR1cm4gW1t1cmwgYWJzb2x1dGVTdHJpbmddIGNyZWF0ZUpTU3RyaW5nUmVm XTsgICAgCit9CkluZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS93aW4vQWNjZXNzaWJp bGl0eVVJRWxlbWVudFdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvd2luL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRXaW4uY3BwCShyZXZpc2lvbiA1MjI1NykK KysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3dpbi9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50 V2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDc3LDMgKzQ3Nyw5IEBAIEpTU3RyaW5nUmVmIEFj Y2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmRvY3UKIHsKICAgICByZXR1cm4gSlNTdHJpbmdDcmVhdGVX aXRoQ2hhcmFjdGVycygwLCAwKTsKIH0KKworSlNTdHJpbmdSZWYgQWNjZXNzaWJpbGl0eVVJRWxl bWVudDo6dXJsKCkKK3sKKyAgICByZXR1cm4gMDsKK30KKwo=