32663 2009-12-17 07:47:11 -0800 Don't include all JSC headers everywhere 2009-12-17 14:32:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 otte webkit-unassigned aroben eric evan webkit.review.bot oldest_to_newest 172773 0 otte 2009-12-17 07:47:11 -0800 Currently PlatformString.h #include's almost all of JSC. As that is a pretty central header for WebCore, it means JSC headers get included almost everywhere inside a WebCore build. 172778 1 45070 otte 2009-12-17 08:02:42 -0800 Created attachment 45070 patch PlatformString.h included almost all of JSC via runtime/Identifier.h. This patch gets rid of this include by forward-declaring the required classes instead. This reduces the build size of the object files on a Gtk debug build by 10%. The resulting libwebkit.so gets 5% smaller. Somebody should probably make sure it still compiles on mac and qt as PlatformString.h pulled a lot of other headers that must now be included manually (like the one math.h fix for Gtk I have in the patch). 172780 2 webkit.review.bot 2009-12-17 08:04:46 -0800 style-queue ran check-webkit-style on attachment 45070 without any errors. 172785 3 45070 aroben 2009-12-17 08:17:43 -0800 Comment on attachment 45070 patch > -#if USE(JSC) > -#include <runtime/Identifier.h> > -#else > -// runtime/Identifier.h brings in a variety of wtf headers. We explicitly > -// include them in the case of non-JSC builds to keep things consistent. > #include <wtf/HashMap.h> > #include <wtf/HashSet.h> > #include <wtf/OwnPtr.h> > -#endif I think it's worth adding a FIXME here saying that we shouldn't #include these headers, either, unless absolutely necessary. r=me, but commit-queue- so you can consider adding the FIXME. 172852 4 45085 otte 2009-12-17 10:31:30 -0800 Created attachment 45085 another patch Here's a patch that removes all the headers you mentioned. It compiled without a complaint here. I'm filing it as a separate patch so the potential fallout of missing includes can be detected easier. 172853 5 45070 commit-queue 2009-12-17 10:32:14 -0800 Comment on attachment 45070 patch Rejecting patch 45070 from commit-queue. otte@gnome.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. - If you have committer rights please correct the error in WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no review needed) and then set the committer flag again. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. 172884 6 45085 aroben 2009-12-17 11:07:21 -0800 Comment on attachment 45085 another patch Looks good to me. I'll take care of landing these two patches. 172907 7 45070 aroben 2009-12-17 12:02:16 -0800 Comment on attachment 45070 patch Landed in r52275 172914 8 aroben 2009-12-17 12:39:49 -0800 Committed r52278: <http://trac.webkit.org/changeset/52278> 172953 9 eric 2009-12-17 14:32:23 -0800 (In reply to comment #5) > (From update of attachment 45070 [details]) > Rejecting patch 45070 from commit-queue. > > otte@gnome.org does not have committer permissions according to > http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. > > - If you have committer rights please correct the error in > WebKitTools/Scripts/modules/committers.py by adding yourself to the file (no > review needed) and then set the committer flag again. > > - If you do not have committer rights please read > http://webkit.org/coding/contributing.html for instructions on how to use > bugzilla flags. Sorry about the rejection. The bot currently requires a restart after mods to committres.py. I need to update the failure message to note that. I just restarted the bot, so you should be able to set cq+ just fine now. 45070 2009-12-17 08:02:42 -0800 2009-12-17 12:02:15 -0800 patch diff text/plain 3079 otte Y29tbWl0IGQ4NzJiZDU4OTMzZmI5NmQ1OTYwNWM2YmJiMTI2MGVhYmRlYjU1OTMKQXV0aG9yOiBC ZW5qYW1pbiBPdHRlIDxvdHRlQGdub21lLm9yZz4KRGF0ZTogICBUaHUgRGVjIDE3IDE2OjUyOjM2 IDIwMDkgKzAxMDAKCiAgICBEb24ndCBpbmNsdWRlIGFsbCBKU0MgaGVhZGVycyBldmVyeXdoZXJl CiAgICAKICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjY2Mwog ICAgCiAgICBQbGF0Zm9ybVN0cmluZy5oIGluY2x1ZGVkIGFsbW9zdCBhbGwgb2YgSlNDIHZpYSBy dW50aW1lL0lkZW50aWZpZXIuaC4KICAgIFRoaXMgcGF0Y2ggZ2V0cyByaWQgb2YgdGhpcyBpbmNs dWRlIGJ5IGZvcndhcmQtZGVjbGFyaW5nIHRoZSByZXF1aXJlZAogICAgY2xhc3NlcyBpbnN0ZWFk LgogICAgVGhpcyByZWR1Y2VzIHRoZSBidWlsZCBzaXplIG9mIHRoZSBvYmplY3QgZmlsZXMgb24g YSBHdGsgZGVidWcgYnVpbGQKICAgIGJ5IDEwJS4gVGhlIHJlc3VsdGluZyBsaWJ3ZWJraXQuc28g Z2V0cyA1JSBzbWFsbGVyLgogICAgCiAgICBObyBuZXcgdGVzdHMgYXMgaXQncyBqdXN0IGEgYnVp bGQgaW1wcm92ZW1lbnQuCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA1YjliNGE3Li44NDJkMzA2IDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDA5LTEy LTE3ICBCZW5qYW1pbiBPdHRlICA8b3R0ZUBnbm9tZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3QgaW5jbHVkZSBhbGwgSlNDIGhlYWRl cnMgZXZlcnl3aGVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzI2NjMKKworICAgICAgICBQbGF0Zm9ybVN0cmluZy5oIGluY2x1ZGVkIGFsbW9zdCBh bGwgb2YgSlNDIHZpYSBydW50aW1lL0lkZW50aWZpZXIuaC4KKyAgICAgICAgVGhpcyBwYXRjaCBn ZXRzIHJpZCBvZiB0aGlzIGluY2x1ZGUgYnkgZm9yd2FyZC1kZWNsYXJpbmcgdGhlIHJlcXVpcmVk CisgICAgICAgIGNsYXNzZXMgaW5zdGVhZC4KKyAgICAgICAgVGhpcyByZWR1Y2VzIHRoZSBidWls ZCBzaXplIG9mIHRoZSBvYmplY3QgZmlsZXMgb24gYSBHdGsgZGVidWcgYnVpbGQKKyAgICAgICAg YnkgMTAlLiBUaGUgcmVzdWx0aW5nIGxpYndlYmtpdC5zbyBnZXRzIDUlIHNtYWxsZXIuCisKKyAg ICAgICAgTm8gbmV3IHRlc3RzIGFzIGl0J3MganVzdCBhIGJ1aWxkIGltcHJvdmVtZW50LgorCisg ICAgICAgICogcGxhdGZvcm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwOgorICAgICAgICBp bmNsdWRlIG1hdGguaCBoZXJlIChpdCB1c2VkIHRvIGJlIHB1bGxlZCBieSBKU0MpCisgICAgICAg ICogcGxhdGZvcm0vdGV4dC9QbGF0Zm9ybVN0cmluZy5oOgorICAgICAgICAqIHBsYXRmb3JtL3Rl eHQvU3RyaW5nLmNwcDoKKwogMjAwOS0xMS0wNiAgQmVuamFtaW4gT3R0ZSAgPG90dGVAZ25vbWUu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0ay5jcHAgYi9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcAppbmRleCA1ODA5ZTQ3Li4yZDhkZmM0 IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNw cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcApAQCAt MzgsNiArMzgsNyBAQAogCiAjaW5jbHVkZSA8Z2xpYi9naTE4bi1saWIuaD4KICNpbmNsdWRlIDxn dGsvZ3RrLmg+CisjaW5jbHVkZSA8bWF0aC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9QbGF0Zm9ybVN0cmluZy5oIGIvV2ViQ29y ZS9wbGF0Zm9ybS90ZXh0L1BsYXRmb3JtU3RyaW5nLmgKaW5kZXggMjQ3NTM2YS4uYzk4OGMxZCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1BsYXRmb3JtU3RyaW5nLmgKKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1BsYXRmb3JtU3RyaW5nLmgKQEAgLTMxLDE1ICszMSw5IEBA CiAjaW5jbHVkZSA8b2JqYy9vYmpjLmg+CiAjZW5kaWYKIAotI2lmIFVTRShKU0MpCi0jaW5jbHVk ZSA8cnVudGltZS9JZGVudGlmaWVyLmg+Ci0jZWxzZQotLy8gcnVudGltZS9JZGVudGlmaWVyLmgg YnJpbmdzIGluIGEgdmFyaWV0eSBvZiB3dGYgaGVhZGVycy4gIFdlIGV4cGxpY2l0bHkKLS8vIGlu Y2x1ZGUgdGhlbSBpbiB0aGUgY2FzZSBvZiBub24tSlNDIGJ1aWxkcyB0byBrZWVwIHRoaW5ncyBj b25zaXN0ZW50LgogI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hT ZXQuaD4KICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+Ci0jZW5kaWYKIAogI2lmIFBMQVRGT1JNKENG KQogdHlwZWRlZiBjb25zdCBzdHJ1Y3QgX19DRlN0cmluZyAqIENGU3RyaW5nUmVmOwpAQCAtNjAs NiArNTQsMTMgQEAgY2xhc3Mgd3hTdHJpbmc7CiBjbGFzcyBCU3RyaW5nOwogI2VuZGlmCiAKKyNp ZiBVU0UoSlNDKQorbmFtZXNwYWNlIEpTQyB7CitjbGFzcyBJZGVudGlmaWVyOworY2xhc3MgVVN0 cmluZzsKK30KKyNlbmRpZgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIENTdHJpbmc7 CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvU3RyaW5nLmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vdGV4dC9TdHJpbmcuY3BwCmluZGV4IDI0NjU5YTQuLjgzNDJiMGIgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmcuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vdGV4dC9TdHJpbmcuY3BwCkBAIC0zNyw2ICszNyw4IEBACiAjaW5jbHVkZSA8d3RmL3VuaWNv ZGUvVVRGOC5oPgogCiAjaWYgVVNFKEpTQykKKyNpbmNsdWRlIDxydW50aW1lL0lkZW50aWZpZXIu aD4KKwogdXNpbmcgSlNDOjpJZGVudGlmaWVyOwogdXNpbmcgSlNDOjpVU3RyaW5nOwogI2VuZGlm Cg== 45085 2009-12-17 10:31:30 -0800 2009-12-17 11:07:21 -0800 another patch diff text/plain 1579 otte Y29tbWl0IDFkOGFiMjI0ODg5MTcyZDk3MWFlNGM3ZmQ3NmUyMzU5NTJmZDE5N2IKQXV0aG9yOiBC ZW5qYW1pbiBPdHRlIDxvdHRlQGdub21lLm9yZz4KRGF0ZTogICBUaHUgRGVjIDE3IDE5OjI5OjI0 IDIwMDkgKzAxMDAKCiAgICBEb24ndCBpbmNsdWRlIGFsbCBKU0MgaGVhZGVycyBldmVyeXdoZXJl CiAgICAKICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjY2Mwog ICAgCiAgICBSZW1vdmUgSGFzaE1hcCBIYXNoU2V0IGFuZCBPd25QdHIgaW5jbHVkZXMgZnJvbSBQ bGF0Zm9ybVN0cmluZy5oLgogICAgUmVkdWNlcyBjb2RlIHNpemUgb2YgR3RrIGJ1aWxkIGJ5IGFu b3RoZXIgNSUuCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCA3YTE2Y2M3Li5kZjg3Y2QzIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtNSw2ICs1LDE4IEBACiAgICAgICAgIERvbid0 IGluY2x1ZGUgYWxsIEpTQyBoZWFkZXJzIGV2ZXJ5d2hlcmUKICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNjYzCiAKKyAgICAgICAgUmVtb3ZlIEhhc2hN YXAgSGFzaFNldCBhbmQgT3duUHRyIGluY2x1ZGVzIGZyb20gUGxhdGZvcm1TdHJpbmcuaC4KKyAg ICAgICAgUmVkdWNlcyBjb2RlIHNpemUgb2YgR3RrIGJ1aWxkIGJ5IGFub3RoZXIgNSUuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS90ZXh0L1BsYXRmb3JtU3RyaW5nLmg6CisKKzIwMDktMTItMTcgIEJl bmphbWluIE90dGUgIDxvdHRlQGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEb24ndCBpbmNsdWRlIGFsbCBKU0MgaGVhZGVycyBldmVy eXdoZXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MjY2MworCiAgICAgICAgIFBsYXRmb3JtU3RyaW5nLmggaW5jbHVkZWQgYWxtb3N0IGFsbCBvZiBK U0MgdmlhIHJ1bnRpbWUvSWRlbnRpZmllci5oLgogICAgICAgICBUaGlzIHBhdGNoIGdldHMgcmlk IG9mIHRoaXMgaW5jbHVkZSBieSBmb3J3YXJkLWRlY2xhcmluZyB0aGUgcmVxdWlyZWQKICAgICAg ICAgY2xhc3NlcyBpbnN0ZWFkLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1Bs YXRmb3JtU3RyaW5nLmggYi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvUGxhdGZvcm1TdHJpbmcuaApp bmRleCBjOTg4YzFkLi44YTM3OWJlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv UGxhdGZvcm1TdHJpbmcuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvUGxhdGZvcm1TdHJp bmcuaApAQCAtMzEsMTAgKzMxLDYgQEAKICNpbmNsdWRlIDxvYmpjL29iamMuaD4KICNlbmRpZgog Ci0jaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KLSNpbmNsdWRlIDx3dGYvSGFzaFNldC5oPgotI2lu Y2x1ZGUgPHd0Zi9Pd25QdHIuaD4KLQogI2lmIFBMQVRGT1JNKENGKQogdHlwZWRlZiBjb25zdCBz dHJ1Y3QgX19DRlN0cmluZyAqIENGU3RyaW5nUmVmOwogI2VuZGlmCg==