<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>32661</bug_id>
          
          <creation_ts>2009-12-17 07:06:51 -0800</creation_ts>
          <short_desc>[GTK] G_OBJECT() cast is not necessary for signals connection and properties access</short_desc>
          <delta_ts>2010-01-04 03:06:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Philippe Normand">pnormand</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>christian</cc>
    
    <cc>eric</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>172749</commentid>
    <comment_count>0</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2009-12-17 07:06:51 -0800</bug_when>
    <thetext>The MediaPlayerPrivateGstreamer.cpp has those casts at various places of the code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>172765</commentid>
    <comment_count>1</comment_count>
      <attachid>45067</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2009-12-17 07:36:30 -0800</bug_when>
    <thetext>Created attachment 45067
proposed patch

[GTK] G_OBJECT() cast is not necessary for signals connection and properties access
        https://bugs.webkit.org/show_bug.cgi?id=32661

        Removed useless calls to the G_OBJECT() macro.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::hasVideo):
        (WebCore::MediaPlayerPrivate::hasAudio):
        (WebCore::MediaPlayerPrivate::setVolume):
        (WebCore::MediaPlayerPrivate::createGSTPlayBin):</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>172768</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2009-12-17 07:38:12 -0800</bug_when>
    <thetext>Attachment 45067 did not pass style-queue:

Failed to run &quot;WebKitTools/Scripts/check-webkit-style&quot; exit_code: 1
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:415:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:423:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:432:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:928:  Use 0 instead of NULL.  [readability/null] [5]
WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:940:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173675</commentid>
    <comment_count>3</comment_count>
    <who name="Christian Dywan">christian</who>
    <bug_when>2009-12-20 02:01:47 -0800</bug_when>
    <thetext>Looks obviously correct. While you&apos;re at it, it&apos;s probably a good opportunity to use 0 since this is WebCore code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173696</commentid>
    <comment_count>4</comment_count>
      <attachid>45266</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2009-12-20 03:29:21 -0800</bug_when>
    <thetext>Created attachment 45266
updated patch

Replaced the NULL occurences with SENTINEL.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173701</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2009-12-20 03:34:04 -0800</bug_when>
    <thetext>style-queue ran check-webkit-style on attachment 45266 without any errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173989</commentid>
    <comment_count>6</comment_count>
      <attachid>45266</attachid>
    <who name="Xan Lopez">xan.lopez</who>
    <bug_when>2009-12-21 09:44:58 -0800</bug_when>
    <thetext>Comment on attachment 45266
updated patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173993</commentid>
    <comment_count>7</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2009-12-21 09:59:54 -0800</bug_when>
    <thetext>Landed as r52447.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>173997</commentid>
    <comment_count>8</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-21 10:17:52 -0800</bug_when>
    <thetext>Why is SENTINAL a good thing here?  Seems silly to introduce a new NULL.  If you want to use NULL here, please answer my mail on webkit-dev:
https://lists.webkit.org/pipermail/webkit-dev/2009-December/011041.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>174003</commentid>
    <comment_count>9</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2009-12-21 10:47:17 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; Why is SENTINAL a good thing here?  Seems silly to introduce a new NULL.  If
&gt; you want to use NULL here, please answer my mail on webkit-dev:
&gt; https://lists.webkit.org/pipermail/webkit-dev/2009-December/011041.html

Well yes it is silly ;) But if we use 0 instead of NULL in g_object_{get,set} we get compilation warning:

warning: missing sentinel in function call</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>174006</commentid>
    <comment_count>10</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-12-21 10:56:56 -0800</bug_when>
    <thetext>Interesting.  Seems like we should file a bug to have check-webkit-style not warn in this particular case.  It would be great if you could both reply to the thread and file a bug about such. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176614</commentid>
    <comment_count>11</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-01-04 02:09:33 -0800</bug_when>
    <thetext>Will send a patch to remove the SENTINEL stuff introduced by this patch. It is not necessary anymore as the style bot won&apos;t complain about use of NULL in g_object_get/set calls.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176616</commentid>
    <comment_count>12</comment_count>
      <attachid>45787</attachid>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-01-04 02:13:04 -0800</bug_when>
    <thetext>Created attachment 45787
reverted SENTINEL</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176617</commentid>
    <comment_count>13</comment_count>
      <attachid>45787</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-01-04 02:22:28 -0800</bug_when>
    <thetext>Comment on attachment 45787
reverted SENTINEL

OK.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>176639</commentid>
    <comment_count>14</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2010-01-04 03:06:18 -0800</bug_when>
    <thetext>Landed as r52727.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45067</attachid>
            <date>2009-12-17 07:36:30 -0800</date>
            <delta_ts>2009-12-20 03:29:21 -0800</delta_ts>
            <desc>proposed patch</desc>
            <filename>-Reviewed-by-NOBODY-OOPS.patch</filename>
            <type>text/plain</type>
            <size>4133</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA0NWM0NzAwNWY2ODI1NDg5NGJmZTQzZGViZDViYTUwNTgyZGU5MTUyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBUaHUsIDE3IERlYyAyMDA5IDE2OjA5OjA2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgW0dUS10gR19PQkpF
Q1QoKSBjYXN0IGlzIG5vdCBuZWNlc3NhcnkgZm9yIHNpZ25hbHMgY29ubmVjdGlvbiBhbmQgcHJv
cGVydGllcyBhY2Nlc3MKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MzI2NjEKCiAgICAgICAgUmVtb3ZlZCB1c2VsZXNzIGNhbGxzIHRvIHRoZSBHX09CSkVD
VCgpIG1hY3JvLgoKICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclBy
aXZhdGVHU3RyZWFtZXIuY3BwOgogICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6
Omhhc1ZpZGVvKToKICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpoYXNBdWRp
byk6CiAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0Vm9sdW1lKToKICAg
ICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpjcmVhdGVHU1RQbGF5QmluKToKLS0t
CiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAg
MTUgKysrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdT
dHJlYW1lci5jcHAgICB8ICAgMTMgKysrKysrLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMSBp
bnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl
TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWYxMDI2NC4uMDRkZDY1OSAxMDA2NDQKLS0t
IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
OCBAQAorMjAwOS0xMi0xNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10g
R19PQkpFQ1QoKSBjYXN0IGlzIG5vdCBuZWNlc3NhcnkgZm9yIHNpZ25hbHMgY29ubmVjdGlvbiBh
bmQgcHJvcGVydGllcyBhY2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTMyNjYxCisKKyAgICAgICAgUmVtb3ZlZCB1c2VsZXNzIGNhbGxzIHRvIHRo
ZSBHX09CSkVDVCgpIG1hY3JvLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01l
ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBs
YXllclByaXZhdGU6Omhhc1ZpZGVvKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJp
dmF0ZTo6aGFzQXVkaW8pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpz
ZXRWb2x1bWUpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpjcmVhdGVH
U1RQbGF5QmluKToKKwogMjAwOS0xMi0xNSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln
YWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy
LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdT
dHJlYW1lci5jcHAKaW5kZXggNDlmNmM4Ni4uMjk5MTc4OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w
bGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysg
Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt
ZXIuY3BwCkBAIC00MTIsNyArNDEyLDcgQEAgYm9vbCBNZWRpYVBsYXllclByaXZhdGU6Omhhc1Zp
ZGVvKCkgY29uc3QKIHsKICAgICBnaW50IGN1cnJlbnRWaWRlbyA9IC0xOwogICAgIGlmIChtX3Bs
YXlCaW4pCi0gICAgICAgIGdfb2JqZWN0X2dldChHX09CSkVDVChtX3BsYXlCaW4pLCAiY3VycmVu
dC12aWRlbyIsICZjdXJyZW50VmlkZW8sIE5VTEwpOworICAgICAgICBnX29iamVjdF9nZXQobV9w
bGF5QmluLCAiY3VycmVudC12aWRlbyIsICZjdXJyZW50VmlkZW8sIE5VTEwpOwogICAgIHJldHVy
biBjdXJyZW50VmlkZW8gPiAtMTsKIH0KIApAQCAtNDIwLDcgKzQyMCw3IEBAIGJvb2wgTWVkaWFQ
bGF5ZXJQcml2YXRlOjpoYXNBdWRpbygpIGNvbnN0CiB7CiAgICAgZ2ludCBjdXJyZW50QXVkaW8g
PSAtMTsKICAgICBpZiAobV9wbGF5QmluKQotICAgICAgICBnX29iamVjdF9nZXQoR19PQkpFQ1Qo
bV9wbGF5QmluKSwgImN1cnJlbnQtYXVkaW8iLCAmY3VycmVudEF1ZGlvLCBOVUxMKTsKKyAgICAg
ICAgZ19vYmplY3RfZ2V0KG1fcGxheUJpbiwgImN1cnJlbnQtYXVkaW8iLCAmY3VycmVudEF1ZGlv
LCBOVUxMKTsKICAgICByZXR1cm4gY3VycmVudEF1ZGlvID4gLTE7CiB9CiAKQEAgLTQyOSw3ICs0
MjksNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0Vm9sdW1lKGZsb2F0IHZvbHVtZSkK
ICAgICBpZiAoIW1fcGxheUJpbikKICAgICAgICAgcmV0dXJuOwogCi0gICAgZ19vYmplY3Rfc2V0
KEdfT0JKRUNUKG1fcGxheUJpbiksICJ2b2x1bWUiLCBzdGF0aWNfY2FzdDxkb3VibGU+KHZvbHVt
ZSksIE5VTEwpOworICAgIGdfb2JqZWN0X3NldChtX3BsYXlCaW4sICJ2b2x1bWUiLCBzdGF0aWNf
Y2FzdDxkb3VibGU+KHZvbHVtZSksIE5VTEwpOwogfQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0
ZTo6dm9sdW1lQ2hhbmdlZCgpCkBAIC05MjUsMTAgKzkyNSw5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQ
cml2YXRlOjpjcmVhdGVHU1RQbGF5QmluKFN0cmluZyB1cmwpCiAgICAgZ19zaWduYWxfY29ubmVj
dChidXMsICJtZXNzYWdlIiwgR19DQUxMQkFDSyhtZWRpYVBsYXllclByaXZhdGVNZXNzYWdlQ2Fs
bGJhY2spLCB0aGlzKTsKICAgICBnc3Rfb2JqZWN0X3VucmVmKGJ1cyk7CiAKLSAgICBnX29iamVj
dF9zZXQoR19PQkpFQ1QobV9wbGF5QmluKSwgInVyaSIsIHVybC51dGY4KCkuZGF0YSgpLAotICAg
ICAgICAgICAgICAgICBOVUxMKTsKKyAgICBnX29iamVjdF9zZXQobV9wbGF5QmluLCAidXJpIiwg
dXJsLnV0ZjgoKS5kYXRhKCksIE5VTEwpOwogCi0gICAgZ19zaWduYWxfY29ubmVjdChHX09CSkVD
VChtX3BsYXlCaW4pLCAibm90aWZ5Ojp2b2x1bWUiLCBHX0NBTExCQUNLKG1lZGlhUGxheWVyUHJp
dmF0ZVZvbHVtZUNoYW5nZWRDYWxsYmFjayksIHRoaXMpOworICAgIGdfc2lnbmFsX2Nvbm5lY3Qo
bV9wbGF5QmluLCAibm90aWZ5Ojp2b2x1bWUiLCBHX0NBTExCQUNLKG1lZGlhUGxheWVyUHJpdmF0
ZVZvbHVtZUNoYW5nZWRDYWxsYmFjayksIHRoaXMpOwogCiAgICAgbV92aWRlb1NpbmsgPSB3ZWJr
aXRfdmlkZW9fc2lua19uZXcoKTsKIApAQCAtOTM4LDcgKzkzNyw3IEBAIHZvaWQgTWVkaWFQbGF5
ZXJQcml2YXRlOjpjcmVhdGVHU1RQbGF5QmluKFN0cmluZyB1cmwpCiAgICAgaWYgKGNoYW5uZWwt
PnN0YXRlID09IFdURkxvZ0NoYW5uZWxPbikgewogICAgICAgICBtX2Zwc1NpbmsgPSBnc3RfZWxl
bWVudF9mYWN0b3J5X21ha2UoImZwc2Rpc3BsYXlzaW5rIiwgInNpbmsiKTsKICAgICAgICAgaWYg
KGdfb2JqZWN0X2NsYXNzX2ZpbmRfcHJvcGVydHkoR19PQkpFQ1RfR0VUX0NMQVNTKG1fZnBzU2lu
ayksICJ2aWRlby1zaW5rIikpIHsKLSAgICAgICAgICAgIGdfb2JqZWN0X3NldChHX09CSkVDVCht
X2Zwc1NpbmspLCAidmlkZW8tc2luayIsIG1fdmlkZW9TaW5rLCBOVUxMKTsKKyAgICAgICAgICAg
IGdfb2JqZWN0X3NldChtX2Zwc1NpbmssICJ2aWRlby1zaW5rIiwgbV92aWRlb1NpbmssIE5VTEwp
OwogICAgICAgICAgICAgZ19vYmplY3RfcmVmX3NpbmsobV9mcHNTaW5rKTsKICAgICAgICAgICAg
IGdfb2JqZWN0X3NldChtX3BsYXlCaW4sICJ2aWRlby1zaW5rIiwgbV9mcHNTaW5rLCBOVUxMKTsK
ICAgICAgICAgfSBlbHNlIHsKLS0gCjEuNi4zLjM=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45266</attachid>
            <date>2009-12-20 03:29:21 -0800</date>
            <delta_ts>2009-12-21 09:44:58 -0800</delta_ts>
            <desc>updated patch</desc>
            <filename>-Reviewed-by-NOBODY-OOPS.patch</filename>
            <type>text/plain</type>
            <size>6456</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSA4NjUxMGQ1MTAwNzFiYmZiYmI4NTFmZDgzMzk1Mjk0ZDY4YTAyYTEwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBUaHUsIDE3IERlYyAyMDA5IDE2OjA5OjA2ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g
ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgW0dUS10gR19PQkpF
Q1QoKSBjYXN0IGlzIG5vdCBuZWNlc3NhcnkgZm9yIHNpZ25hbHMgY29ubmVjdGlvbiBhbmQgcHJv
cGVydGllcyBhY2Nlc3MKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j
Z2k/aWQ9MzI2NjEKCiAgICAgICAgUmVtb3ZlZCB1c2VsZXNzIGNhbGxzIHRvIHRoZSBHX09CSkVD
VCgpIG1hY3JvIGFuZCByZXBsYWNlZCBOVUxMCiAgICAgICAgb2NjdXJlbmNlcyB3aXRoIGEgU0VO
VElORUwgbWFjcm8uCgogICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVy
UHJpdmF0ZUdTdHJlYW1lci5jcHA6CiAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0
ZTo6aGFzVmlkZW8pOgogICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6Omhhc0F1
ZGlvKToKICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpzZXRWb2x1bWUpOgog
ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6OmNyZWF0ZUdTVFBsYXlCaW4pOgot
LS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg
ICAxNiArKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl
YW1lci5jcHAgICB8ICAgMzEgKysrKysrKysrKy0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAz
MiBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0No
YW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDk0MGViM2UuLjZlMGViZDggMTAwNjQ0
Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg
KzEsMTkgQEAKKzIwMDktMTItMTcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEu
Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtH
VEtdIEdfT0JKRUNUKCkgY2FzdCBpcyBub3QgbmVjZXNzYXJ5IGZvciBzaWduYWxzIGNvbm5lY3Rp
b24gYW5kIHByb3BlcnRpZXMgYWNjZXNzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0zMjY2MQorCisgICAgICAgIFJlbW92ZWQgdXNlbGVzcyBjYWxscyB0
byB0aGUgR19PQkpFQ1QoKSBtYWNybyBhbmQgcmVwbGFjZWQgTlVMTAorICAgICAgICBvY2N1cmVu
Y2VzIHdpdGggYSBTRU5USU5FTCBtYWNyby4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz
L2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6
TWVkaWFQbGF5ZXJQcml2YXRlOjpoYXNWaWRlbyk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBs
YXllclByaXZhdGU6Omhhc0F1ZGlvKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJp
dmF0ZTo6c2V0Vm9sdW1lKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6
Y3JlYXRlR1NUUGxheUJpbik6CisKIDIwMDktMTItMTkgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJr
aXQub3JnPgogCiAgICAgICAgIE5vIHJldmlldywgcm9sbGluZyBvdXQgcjUyMzk1LgpkaWZmIC0t
Z2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0
cmVhbWVyLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp
dmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggNDlmNmM4Ni4uMzg0ZjlmNiAxMDA2NDQKLS0tIGEvV2Vi
Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw
cAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVH
U3RyZWFtZXIuY3BwCkBAIC00OCw2ICs0OCw4IEBACiAjaW5jbHVkZSA8bWF0aC5oPgogI2luY2x1
ZGUgPHd0Zi9ndGsvR093blB0ci5oPgogCisjZGVmaW5lIFNFTlRJTkVMICh2b2lkKikgMAorCiB1
c2luZyBuYW1lc3BhY2Ugc3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0xMzAsOCArMTMy
LDggQEAgc3RhdGljIGZsb2F0IHBsYXliYWNrUG9zaXRpb24oR3N0RWxlbWVudCogcGxheWJpbikK
ICAgICBnaW50NjQgcG9zaXRpb247CiAgICAgZ3N0X3F1ZXJ5X3BhcnNlX3Bvc2l0aW9uKHF1ZXJ5
LCAwLCAmcG9zaXRpb24pOwogCi0gICAgLy8gUG9zaXRpb24gaXMgYXZhaWxhYmxlIG9ubHkgaWYg
dGhlIHBpcGVsaW5lIGlzIG5vdCBpbiBOVUxMIG9yCi0gICAgLy8gUkVBRFkgc3RhdGUuCisgICAg
Ly8gUG9zaXRpb24gaXMgYXZhaWxhYmxlIG9ubHkgaWYgdGhlIHBpcGVsaW5lIGlzIG5vdCBpbiBH
U1RfU1RBVEVfTlVMTCBvcgorICAgIC8vIEdTVF9TVEFURV9SRUFEWSBzdGF0ZS4KICAgICBpZiAo
cG9zaXRpb24gIT0gIHN0YXRpY19jYXN0PGdpbnQ2ND4oR1NUX0NMT0NLX1RJTUVfTk9ORSkpCiAg
ICAgICAgIHJldCA9IHN0YXRpY19jYXN0PGZsb2F0Pihwb3NpdGlvbikgLyBzdGF0aWNfY2FzdDxm
bG9hdD4oR1NUX1NFQ09ORCk7CiAKQEAgLTQxMiw3ICs0MTQsNyBAQCBib29sIE1lZGlhUGxheWVy
UHJpdmF0ZTo6aGFzVmlkZW8oKSBjb25zdAogewogICAgIGdpbnQgY3VycmVudFZpZGVvID0gLTE7
CiAgICAgaWYgKG1fcGxheUJpbikKLSAgICAgICAgZ19vYmplY3RfZ2V0KEdfT0JKRUNUKG1fcGxh
eUJpbiksICJjdXJyZW50LXZpZGVvIiwgJmN1cnJlbnRWaWRlbywgTlVMTCk7CisgICAgICAgIGdf
b2JqZWN0X2dldChtX3BsYXlCaW4sICJjdXJyZW50LXZpZGVvIiwgJmN1cnJlbnRWaWRlbywgU0VO
VElORUwpOwogICAgIHJldHVybiBjdXJyZW50VmlkZW8gPiAtMTsKIH0KIApAQCAtNDIwLDcgKzQy
Miw3IEBAIGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRlOjpoYXNBdWRpbygpIGNvbnN0CiB7CiAgICAg
Z2ludCBjdXJyZW50QXVkaW8gPSAtMTsKICAgICBpZiAobV9wbGF5QmluKQotICAgICAgICBnX29i
amVjdF9nZXQoR19PQkpFQ1QobV9wbGF5QmluKSwgImN1cnJlbnQtYXVkaW8iLCAmY3VycmVudEF1
ZGlvLCBOVUxMKTsKKyAgICAgICAgZ19vYmplY3RfZ2V0KG1fcGxheUJpbiwgImN1cnJlbnQtYXVk
aW8iLCAmY3VycmVudEF1ZGlvLCBTRU5USU5FTCk7CiAgICAgcmV0dXJuIGN1cnJlbnRBdWRpbyA+
IC0xOwogfQogCkBAIC00MjksNyArNDMxLDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OnNl
dFZvbHVtZShmbG9hdCB2b2x1bWUpCiAgICAgaWYgKCFtX3BsYXlCaW4pCiAgICAgICAgIHJldHVy
bjsKIAotICAgIGdfb2JqZWN0X3NldChHX09CSkVDVChtX3BsYXlCaW4pLCAidm9sdW1lIiwgc3Rh
dGljX2Nhc3Q8ZG91YmxlPih2b2x1bWUpLCBOVUxMKTsKKyAgICBnX29iamVjdF9zZXQobV9wbGF5
QmluLCAidm9sdW1lIiwgc3RhdGljX2Nhc3Q8ZG91YmxlPih2b2x1bWUpLCBTRU5USU5FTCk7CiB9
CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjp2b2x1bWVDaGFuZ2VkKCkKQEAgLTQ4Nyw3ICs0
ODksNyBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0UmF0ZShmbG9hdCByYXRlKQogICAg
ICAgICAgICAgICAgICAgICAgICAgICBHU1RfU0VFS19UWVBFX1NFVCwgZW5kKSkKICAgICAgICAg
TE9HX1ZFUkJPU0UoTWVkaWEsICJTZXQgcmF0ZSB0byAlZiBmYWlsZWQiLCByYXRlKTsKICAgICBl
bHNlCi0gICAgICAgIGdfb2JqZWN0X3NldChtX3BsYXlCaW4sICJtdXRlIiwgbXV0ZSwgTlVMTCk7
CisgICAgICAgIGdfb2JqZWN0X3NldChtX3BsYXlCaW4sICJtdXRlIiwgbXV0ZSwgU0VOVElORUwp
OwogfQogCiBpbnQgTWVkaWFQbGF5ZXJQcml2YXRlOjpkYXRhUmF0ZSgpIGNvbnN0CkBAIC01NTAs
NyArNTUyLDcgQEAgdW5zaWduZWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpieXRlc0xvYWRlZCgpIGNv
bnN0CiAgICAgaWYgKCFkdXIpCiAgICAgICAgIHJldHVybiAwOyovCiAKLSAgICByZXR1cm4gMTsv
L3RvdGFsQnl0ZXMoKSAqIG1heFRpbWUgLyBkdXI7CisgICAgcmV0dXJuIDE7IC8vIHRvdGFsQnl0
ZXMoKSAqIG1heFRpbWUgLyBkdXI7CiB9CiAKIGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRlOjp0b3Rh
bEJ5dGVzS25vd24oKSBjb25zdApAQCAtNjM0LDcgKzYzNiw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQ
cml2YXRlOjp1cGRhdGVTdGF0ZXMoKQogCiAgICAgICAgIG1fbmV0d29ya1N0YXRlID0gTWVkaWFQ
bGF5ZXI6OkxvYWRlZDsKIAotICAgICAgICBnX29iamVjdF9nZXQobV9wbGF5QmluLCAic291cmNl
IiwgJm1fc291cmNlLCBOVUxMKTsKKyAgICAgICAgZ19vYmplY3RfZ2V0KG1fcGxheUJpbiwgInNv
dXJjZSIsICZtX3NvdXJjZSwgU0VOVElORUwpOwogICAgICAgICBpZiAoIW1fc291cmNlKQogICAg
ICAgICAgICAgTE9HX1ZFUkJPU0UoTWVkaWEsICJtX3NvdXJjZSBpcyAwIik7CiAgICAgICAgIGJy
ZWFrOwpAQCAtOTI1LDEwICs5MjcsOSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6Y3JlYXRl
R1NUUGxheUJpbihTdHJpbmcgdXJsKQogICAgIGdfc2lnbmFsX2Nvbm5lY3QoYnVzLCAibWVzc2Fn
ZSIsIEdfQ0FMTEJBQ0sobWVkaWFQbGF5ZXJQcml2YXRlTWVzc2FnZUNhbGxiYWNrKSwgdGhpcyk7
CiAgICAgZ3N0X29iamVjdF91bnJlZihidXMpOwogCi0gICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNU
KG1fcGxheUJpbiksICJ1cmkiLCB1cmwudXRmOCgpLmRhdGEoKSwKLSAgICAgICAgICAgICAgICAg
TlVMTCk7CisgICAgZ19vYmplY3Rfc2V0KG1fcGxheUJpbiwgInVyaSIsIHVybC51dGY4KCkuZGF0
YSgpLCBTRU5USU5FTCk7CiAKLSAgICBnX3NpZ25hbF9jb25uZWN0KEdfT0JKRUNUKG1fcGxheUJp
biksICJub3RpZnk6OnZvbHVtZSIsIEdfQ0FMTEJBQ0sobWVkaWFQbGF5ZXJQcml2YXRlVm9sdW1l
Q2hhbmdlZENhbGxiYWNrKSwgdGhpcyk7CisgICAgZ19zaWduYWxfY29ubmVjdChtX3BsYXlCaW4s
ICJub3RpZnk6OnZvbHVtZSIsIEdfQ0FMTEJBQ0sobWVkaWFQbGF5ZXJQcml2YXRlVm9sdW1lQ2hh
bmdlZENhbGxiYWNrKSwgdGhpcyk7CiAKICAgICBtX3ZpZGVvU2luayA9IHdlYmtpdF92aWRlb19z
aW5rX25ldygpOwogCkBAIC05MzgsMTYgKzkzOSwxNiBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0
ZTo6Y3JlYXRlR1NUUGxheUJpbihTdHJpbmcgdXJsKQogICAgIGlmIChjaGFubmVsLT5zdGF0ZSA9
PSBXVEZMb2dDaGFubmVsT24pIHsKICAgICAgICAgbV9mcHNTaW5rID0gZ3N0X2VsZW1lbnRfZmFj
dG9yeV9tYWtlKCJmcHNkaXNwbGF5c2luayIsICJzaW5rIik7CiAgICAgICAgIGlmIChnX29iamVj
dF9jbGFzc19maW5kX3Byb3BlcnR5KEdfT0JKRUNUX0dFVF9DTEFTUyhtX2Zwc1NpbmspLCAidmlk
ZW8tc2luayIpKSB7Ci0gICAgICAgICAgICBnX29iamVjdF9zZXQoR19PQkpFQ1QobV9mcHNTaW5r
KSwgInZpZGVvLXNpbmsiLCBtX3ZpZGVvU2luaywgTlVMTCk7CisgICAgICAgICAgICBnX29iamVj
dF9zZXQobV9mcHNTaW5rLCAidmlkZW8tc2luayIsIG1fdmlkZW9TaW5rLCBTRU5USU5FTCk7CiAg
ICAgICAgICAgICBnX29iamVjdF9yZWZfc2luayhtX2Zwc1NpbmspOwotICAgICAgICAgICAgZ19v
YmplY3Rfc2V0KG1fcGxheUJpbiwgInZpZGVvLXNpbmsiLCBtX2Zwc1NpbmssIE5VTEwpOworICAg
ICAgICAgICAgZ19vYmplY3Rfc2V0KG1fcGxheUJpbiwgInZpZGVvLXNpbmsiLCBtX2Zwc1Npbmss
IFNFTlRJTkVMKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIG1fZnBzU2luayA9IDA7
Ci0gICAgICAgICAgICBnX29iamVjdF9zZXQobV9wbGF5QmluLCAidmlkZW8tc2luayIsIG1fdmlk
ZW9TaW5rLCBOVUxMKTsKKyAgICAgICAgICAgIGdfb2JqZWN0X3NldChtX3BsYXlCaW4sICJ2aWRl
by1zaW5rIiwgbV92aWRlb1NpbmssIFNFTlRJTkVMKTsKICAgICAgICAgICAgIExPRyhNZWRpYSwg
IkNhbid0IGRpc3BsYXkgRlBTIHN0YXRpc3RpY3MsIHlvdSBuZWVkIGdzdC1wbHVnaW5zLWJhZCA+
PSAwLjEwLjE4Iik7CiAgICAgICAgIH0KICAgICB9IGVsc2UKLSAgICAgICAgZ19vYmplY3Rfc2V0
KG1fcGxheUJpbiwgInZpZGVvLXNpbmsiLCBtX3ZpZGVvU2luaywgTlVMTCk7CisgICAgICAgIGdf
b2JqZWN0X3NldChtX3BsYXlCaW4sICJ2aWRlby1zaW5rIiwgbV92aWRlb1NpbmssIFNFTlRJTkVM
KTsKIAogICAgIGdfc2lnbmFsX2Nvbm5lY3QobV92aWRlb1NpbmssICJyZXBhaW50LXJlcXVlc3Rl
ZCIsIEdfQ0FMTEJBQ0sobWVkaWFQbGF5ZXJQcml2YXRlUmVwYWludENhbGxiYWNrKSwgdGhpcyk7
CiB9Ci0tIAoxLjYuMy4z
</data>
<flag name="review"
          id="27271"
          type_id="1"
          status="+"
          setter="xan.lopez"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>45787</attachid>
            <date>2010-01-04 02:13:04 -0800</date>
            <delta_ts>2010-01-04 02:22:28 -0800</delta_ts>
            <desc>reverted SENTINEL</desc>
            <filename>reverted-SENTINEL.patch</filename>
            <type>text/plain</type>
            <size>5064</size>
            <attacher name="Philippe Normand">pnormand</attacher>
            
              <data encoding="base64">RnJvbSBhNTRjNzU1ODllMWRhNmNkZTc1MWUzODk1MTY5NzVkMjE5NWYzODFmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t
PgpEYXRlOiBUdWUsIDIyIERlYyAyMDA5IDExOjE5OjE0ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g
cmV2ZXJ0ZWQgU0VOVElORUwKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgfCAgIDE4ICsrKysrKysrKysrKysrKysKIC4uLi9ncmFwaGljcy9n
dGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCAgIHwgICAyMiArKysrKysrKystLS0t
LS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygt
KQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k
ZXggOTA3MjJmZC4uNGI3MDU4YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv
V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0xMi0yMiAgUGhpbGlwcGUg
Tm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gR19PQkpFQ1QoKSBjYXN0IGlzIG5vdCBuZWNl
c3NhcnkgZm9yIHNpZ25hbHMgY29ubmVjdGlvbiBhbmQgcHJvcGVydGllcyBhY2Nlc3MKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNjYxCisKKyAgICAg
ICAgUmV2ZXJ0ZWQgdGhlIFNFTlRJTkVMIC8gTlVMTCBjcmFwIDopIEhvcGVmdWxseSB0aGUgc3R5
bGUtYm90IHdvbid0CisgICAgICAgIGNvbXBsYWluIGFib3V0IE5VTEwgdXNhZ2UgaW4gZ19vYmpl
Y3Rfe2dldCxzZXR9IGFueW1vcmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsv
TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh
UGxheWVyUHJpdmF0ZTo6aGFzVmlkZW8pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ
cml2YXRlOjpoYXNBdWRpbyk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6
OnNldFZvbHVtZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6OnNldFJh
dGUpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjp1cGRhdGVTdGF0ZXMp
OgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpjcmVhdGVHU1RQbGF5Qmlu
KToKKwogMjAwOS0xMi0xNyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+
CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9XZWJD
b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3Bw
IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh
bWVyLmNwcAppbmRleCAzODRmOWY2Li4wOTg0YTQ2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm
b3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1dl
YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5j
cHAKQEAgLTQ4LDggKzQ4LDYgQEAKICNpbmNsdWRlIDxtYXRoLmg+CiAjaW5jbHVkZSA8d3RmL2d0
ay9HT3duUHRyLmg+CiAKLSNkZWZpbmUgU0VOVElORUwgKHZvaWQqKSAwCi0KIHVzaW5nIG5hbWVz
cGFjZSBzdGQ7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTQxNCw3ICs0MTIsNyBAQCBib29s
IE1lZGlhUGxheWVyUHJpdmF0ZTo6aGFzVmlkZW8oKSBjb25zdAogewogICAgIGdpbnQgY3VycmVu
dFZpZGVvID0gLTE7CiAgICAgaWYgKG1fcGxheUJpbikKLSAgICAgICAgZ19vYmplY3RfZ2V0KG1f
cGxheUJpbiwgImN1cnJlbnQtdmlkZW8iLCAmY3VycmVudFZpZGVvLCBTRU5USU5FTCk7CisgICAg
ICAgIGdfb2JqZWN0X2dldChtX3BsYXlCaW4sICJjdXJyZW50LXZpZGVvIiwgJmN1cnJlbnRWaWRl
bywgTlVMTCk7CiAgICAgcmV0dXJuIGN1cnJlbnRWaWRlbyA+IC0xOwogfQogCkBAIC00MjIsNyAr
NDIwLDcgQEAgYm9vbCBNZWRpYVBsYXllclByaXZhdGU6Omhhc0F1ZGlvKCkgY29uc3QKIHsKICAg
ICBnaW50IGN1cnJlbnRBdWRpbyA9IC0xOwogICAgIGlmIChtX3BsYXlCaW4pCi0gICAgICAgIGdf
b2JqZWN0X2dldChtX3BsYXlCaW4sICJjdXJyZW50LWF1ZGlvIiwgJmN1cnJlbnRBdWRpbywgU0VO
VElORUwpOworICAgICAgICBnX29iamVjdF9nZXQobV9wbGF5QmluLCAiY3VycmVudC1hdWRpbyIs
ICZjdXJyZW50QXVkaW8sIE5VTEwpOwogICAgIHJldHVybiBjdXJyZW50QXVkaW8gPiAtMTsKIH0K
IApAQCAtNDMxLDcgKzQyOSw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpzZXRWb2x1bWUo
ZmxvYXQgdm9sdW1lKQogICAgIGlmICghbV9wbGF5QmluKQogICAgICAgICByZXR1cm47CiAKLSAg
ICBnX29iamVjdF9zZXQobV9wbGF5QmluLCAidm9sdW1lIiwgc3RhdGljX2Nhc3Q8ZG91YmxlPih2
b2x1bWUpLCBTRU5USU5FTCk7CisgICAgZ19vYmplY3Rfc2V0KG1fcGxheUJpbiwgInZvbHVtZSIs
IHN0YXRpY19jYXN0PGRvdWJsZT4odm9sdW1lKSwgTlVMTCk7CiB9CiAKIHZvaWQgTWVkaWFQbGF5
ZXJQcml2YXRlOjp2b2x1bWVDaGFuZ2VkKCkKQEAgLTQ4OSw3ICs0ODcsNyBAQCB2b2lkIE1lZGlh
UGxheWVyUHJpdmF0ZTo6c2V0UmF0ZShmbG9hdCByYXRlKQogICAgICAgICAgICAgICAgICAgICAg
ICAgICBHU1RfU0VFS19UWVBFX1NFVCwgZW5kKSkKICAgICAgICAgTE9HX1ZFUkJPU0UoTWVkaWEs
ICJTZXQgcmF0ZSB0byAlZiBmYWlsZWQiLCByYXRlKTsKICAgICBlbHNlCi0gICAgICAgIGdfb2Jq
ZWN0X3NldChtX3BsYXlCaW4sICJtdXRlIiwgbXV0ZSwgU0VOVElORUwpOworICAgICAgICBnX29i
amVjdF9zZXQobV9wbGF5QmluLCAibXV0ZSIsIG11dGUsIE5VTEwpOwogfQogCiBpbnQgTWVkaWFQ
bGF5ZXJQcml2YXRlOjpkYXRhUmF0ZSgpIGNvbnN0CkBAIC02MzYsNyArNjM0LDcgQEAgdm9pZCBN
ZWRpYVBsYXllclByaXZhdGU6OnVwZGF0ZVN0YXRlcygpCiAKICAgICAgICAgbV9uZXR3b3JrU3Rh
dGUgPSBNZWRpYVBsYXllcjo6TG9hZGVkOwogCi0gICAgICAgIGdfb2JqZWN0X2dldChtX3BsYXlC
aW4sICJzb3VyY2UiLCAmbV9zb3VyY2UsIFNFTlRJTkVMKTsKKyAgICAgICAgZ19vYmplY3RfZ2V0
KG1fcGxheUJpbiwgInNvdXJjZSIsICZtX3NvdXJjZSwgTlVMTCk7CiAgICAgICAgIGlmICghbV9z
b3VyY2UpCiAgICAgICAgICAgICBMT0dfVkVSQk9TRShNZWRpYSwgIm1fc291cmNlIGlzIDAiKTsK
ICAgICAgICAgYnJlYWs7CkBAIC05MjcsNyArOTI1LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZh
dGU6OmNyZWF0ZUdTVFBsYXlCaW4oU3RyaW5nIHVybCkKICAgICBnX3NpZ25hbF9jb25uZWN0KGJ1
cywgIm1lc3NhZ2UiLCBHX0NBTExCQUNLKG1lZGlhUGxheWVyUHJpdmF0ZU1lc3NhZ2VDYWxsYmFj
ayksIHRoaXMpOwogICAgIGdzdF9vYmplY3RfdW5yZWYoYnVzKTsKIAotICAgIGdfb2JqZWN0X3Nl
dChtX3BsYXlCaW4sICJ1cmkiLCB1cmwudXRmOCgpLmRhdGEoKSwgU0VOVElORUwpOworICAgIGdf
b2JqZWN0X3NldChtX3BsYXlCaW4sICJ1cmkiLCB1cmwudXRmOCgpLmRhdGEoKSwgTlVMTCk7CiAK
ICAgICBnX3NpZ25hbF9jb25uZWN0KG1fcGxheUJpbiwgIm5vdGlmeTo6dm9sdW1lIiwgR19DQUxM
QkFDSyhtZWRpYVBsYXllclByaXZhdGVWb2x1bWVDaGFuZ2VkQ2FsbGJhY2spLCB0aGlzKTsKIApA
QCAtOTM5LDE2ICs5MzcsMTYgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OmNyZWF0ZUdTVFBs
YXlCaW4oU3RyaW5nIHVybCkKICAgICBpZiAoY2hhbm5lbC0+c3RhdGUgPT0gV1RGTG9nQ2hhbm5l
bE9uKSB7CiAgICAgICAgIG1fZnBzU2luayA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiZnBz
ZGlzcGxheXNpbmsiLCAic2luayIpOwogICAgICAgICBpZiAoZ19vYmplY3RfY2xhc3NfZmluZF9w
cm9wZXJ0eShHX09CSkVDVF9HRVRfQ0xBU1MobV9mcHNTaW5rKSwgInZpZGVvLXNpbmsiKSkgewot
ICAgICAgICAgICAgZ19vYmplY3Rfc2V0KG1fZnBzU2luaywgInZpZGVvLXNpbmsiLCBtX3ZpZGVv
U2luaywgU0VOVElORUwpOworICAgICAgICAgICAgZ19vYmplY3Rfc2V0KG1fZnBzU2luaywgInZp
ZGVvLXNpbmsiLCBtX3ZpZGVvU2luaywgTlVMTCk7CiAgICAgICAgICAgICBnX29iamVjdF9yZWZf
c2luayhtX2Zwc1NpbmspOwotICAgICAgICAgICAgZ19vYmplY3Rfc2V0KG1fcGxheUJpbiwgInZp
ZGVvLXNpbmsiLCBtX2Zwc1NpbmssIFNFTlRJTkVMKTsKKyAgICAgICAgICAgIGdfb2JqZWN0X3Nl
dChtX3BsYXlCaW4sICJ2aWRlby1zaW5rIiwgbV9mcHNTaW5rLCBOVUxMKTsKICAgICAgICAgfSBl
bHNlIHsKICAgICAgICAgICAgIG1fZnBzU2luayA9IDA7Ci0gICAgICAgICAgICBnX29iamVjdF9z
ZXQobV9wbGF5QmluLCAidmlkZW8tc2luayIsIG1fdmlkZW9TaW5rLCBTRU5USU5FTCk7CisgICAg
ICAgICAgICBnX29iamVjdF9zZXQobV9wbGF5QmluLCAidmlkZW8tc2luayIsIG1fdmlkZW9TaW5r
LCBOVUxMKTsKICAgICAgICAgICAgIExPRyhNZWRpYSwgIkNhbid0IGRpc3BsYXkgRlBTIHN0YXRp
c3RpY3MsIHlvdSBuZWVkIGdzdC1wbHVnaW5zLWJhZCA+PSAwLjEwLjE4Iik7CiAgICAgICAgIH0K
ICAgICB9IGVsc2UKLSAgICAgICAgZ19vYmplY3Rfc2V0KG1fcGxheUJpbiwgInZpZGVvLXNpbmsi
LCBtX3ZpZGVvU2luaywgU0VOVElORUwpOworICAgICAgICBnX29iamVjdF9zZXQobV9wbGF5Qmlu
LCAidmlkZW8tc2luayIsIG1fdmlkZW9TaW5rLCBOVUxMKTsKIAogICAgIGdfc2lnbmFsX2Nvbm5l
Y3QobV92aWRlb1NpbmssICJyZXBhaW50LXJlcXVlc3RlZCIsIEdfQ0FMTEJBQ0sobWVkaWFQbGF5
ZXJQcml2YXRlUmVwYWludENhbGxiYWNrKSwgdGhpcyk7CiB9Ci0tIAoxLjYuMy4z
</data>
<flag name="review"
          id="27914"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>