32660 2009-12-17 07:06:02 -0800 Allow custom memory allocation control for inspector's classes 2009-12-17 16:51:26 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 172748 0 zoltan 2009-12-17 07:06:02 -0800 Inherits the following classes from Noncopyable because these are instantiated by 'new' and no need to be copyable: class name - instantiated at: WebCore/'location' class JavaScriptDebugServer - inspector/JavaScriptDebugServer.cpp:72 class ConsoleMessage - inspector/InspectorController.cpp:329 class InspectorController - page/Page.cpp:119 172750 1 45063 zoltan 2009-12-17 07:07:03 -0800 Created attachment 45063 proposed patch 172752 2 webkit.review.bot 2009-12-17 07:11:52 -0800 style-queue ran check-webkit-style on attachment 45063 without any errors. 172987 3 45063 darin 2009-12-17 16:39:17 -0800 Comment on attachment 45063 proposed patch > - class JavaScriptDebugServer : JSC::Debugger { > + class JavaScriptDebugServer : JSC::Debugger, public Noncopyable { I think it would be better to change DEFINE_STATIC_LOCAL to use fastNew rather than changing all the classes using it to inherit from Noncopyable and FastAllocBase. I'm not sure why I didn't think of this earlier. r=me on this, but it seems it would be worthwhile to do that 172989 4 45063 commit-queue 2009-12-17 16:51:20 -0800 Comment on attachment 45063 proposed patch Clearing flags on attachment: 45063 Committed r52294: <http://trac.webkit.org/changeset/52294> 172990 5 commit-queue 2009-12-17 16:51:26 -0800 All reviewed patches have been landed. Closing bug. 45063 2009-12-17 07:07:03 -0800 2009-12-17 16:51:20 -0800 proposed patch inspector.patch text/plain 2848 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjI1MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMTItMTcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIGluc3BlY3RvcidzIGNs YXNzZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMy NjYwICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIAorCisgICAgICAgIEluaGVyaXRzIHRo ZSBmb2xsb3dpbmcgY2xhc3NlcyBmcm9tIE5vbmNvcHlhYmxlIGJlY2F1c2UgdGhlc2UgYXJlCisg ICAgICAgIGluc3RhbnRpYXRlZCBieSAnbmV3JyBhbmQgbm8gbmVlZCB0byBiZSBjb3B5YWJsZTog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCisKKyAgICAgICAgY2xh c3MgbmFtZSAgICAgICAgICAgICAgICAgIC0gaW5zdGFudGlhdGVkIGF0OiAgV2ViQ29yZS8nbG9j YXRpb24nCisKKyAgICAgICAgY2xhc3MgSmF2YVNjcmlwdERlYnVnU2VydmVyIC0gaW5zcGVjdG9y L0phdmFTY3JpcHREZWJ1Z1NlcnZlci5jcHA6NzIKKyAgICAgICAgY2xhc3MgQ29uc29sZU1lc3Nh Z2UgICAgICAgIC0gaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOjMyOSAKKyAgICAg ICAgY2xhc3MgSW5zcGVjdG9yQ29udHJvbGxlciAgIC0gcGFnZS9QYWdlLmNwcDoxMTkKKworICAg ICAgICAqIGluc3BlY3Rvci9Db25zb2xlTWVzc2FnZS5oOgorICAgICAgICAqIGluc3BlY3Rvci9J bnNwZWN0b3JDb250cm9sbGVyLmg6CisgICAgICAgICogaW5zcGVjdG9yL0phdmFTY3JpcHREZWJ1 Z1NlcnZlci5oOgorCiAyMDA5LTEyLTE1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdh bGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCkluZGV4OiBXZWJDb3Jl L2luc3BlY3Rvci9KYXZhU2NyaXB0RGVidWdTZXJ2ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2luc3BlY3Rvci9KYXZhU2NyaXB0RGVidWdTZXJ2ZXIuaAkocmV2aXNpb24gNTIyNTIpCisrKyBX ZWJDb3JlL2luc3BlY3Rvci9KYXZhU2NyaXB0RGVidWdTZXJ2ZXIuaAkod29ya2luZyBjb3B5KQpA QCAtNTIsNyArNTIsNyBAQAogICAgIGNsYXNzIEphdmFTY3JpcHRDYWxsRnJhbWU7CiAgICAgY2xh c3MgSmF2YVNjcmlwdERlYnVnTGlzdGVuZXI7CiAKLSAgICBjbGFzcyBKYXZhU2NyaXB0RGVidWdT ZXJ2ZXIgOiBKU0M6OkRlYnVnZ2VyIHsKKyAgICBjbGFzcyBKYXZhU2NyaXB0RGVidWdTZXJ2ZXIg OiBKU0M6OkRlYnVnZ2VyLCBwdWJsaWMgTm9uY29weWFibGUgewogICAgIHB1YmxpYzoKICAgICAg ICAgc3RhdGljIEphdmFTY3JpcHREZWJ1Z1NlcnZlciYgc2hhcmVkKCk7CiAKSW5kZXg6IFdlYkNv cmUvaW5zcGVjdG9yL0NvbnNvbGVNZXNzYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9pbnNw ZWN0b3IvQ29uc29sZU1lc3NhZ2UuaAkocmV2aXNpb24gNTIyNTIpCisrKyBXZWJDb3JlL2luc3Bl Y3Rvci9Db25zb2xlTWVzc2FnZS5oCSh3b3JraW5nIGNvcHkpCkBAIC00Miw3ICs0Miw3IEBACiAg ICAgY2xhc3MgU2NyaXB0Q2FsbFN0YWNrOwogICAgIGNsYXNzIFNjcmlwdFN0cmluZzsKIAotICAg IGNsYXNzIENvbnNvbGVNZXNzYWdlIHsKKyAgICBjbGFzcyBDb25zb2xlTWVzc2FnZSA6IHB1Ymxp YyBOb25jb3B5YWJsZSB7CiAgICAgcHVibGljOgogICAgICAgICBDb25zb2xlTWVzc2FnZShNZXNz YWdlU291cmNlLCBNZXNzYWdlVHlwZSwgTWVzc2FnZUxldmVsLCBjb25zdCBTdHJpbmcmIG0sIHVu c2lnbmVkIGxpLCBjb25zdCBTdHJpbmcmIHUsIHVuc2lnbmVkIGcpOyAgICAgICAgCiAgICAgICAg IENvbnNvbGVNZXNzYWdlKE1lc3NhZ2VTb3VyY2UsIE1lc3NhZ2VUeXBlLCBNZXNzYWdlTGV2ZWws IFNjcmlwdENhbGxTdGFjayosIHVuc2lnbmVkIGcsIGJvb2wgc3RvcmVUcmFjZSA9IGZhbHNlKTsK SW5kZXg6IFdlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmgJKHJldmlzaW9uIDUy MjUyKQorKysgV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCSh3b3JraW5n IGNvcHkpCkBAIC04OSw3ICs4OSw5IEBACiAKIGNsYXNzIEluc3BlY3RvckNvbnRyb2xsZXIKICNp ZiBFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikKLSAgICAgICAgICAgICAgICAgICAgICAgICAg OiBKYXZhU2NyaXB0RGVidWdMaXN0ZW5lcgorICAgICAgICAgICAgICAgICAgICAgICAgICA6IEph dmFTY3JpcHREZWJ1Z0xpc3RlbmVyLCBwdWJsaWMgTm9uY29weWFibGUKKyNlbHNlCisgICAgICAg ICAgICAgICAgICAgICAgICAgIDogcHVibGljIE5vbmNvcHlhYmxlCiAjZW5kaWYKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB7CiBwdWJsaWM6Cg==