32655 2009-12-17 04:47:48 -0800 Allow custom memory allocation control for js bindings 2009-12-17 13:09:53 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 172719 0 zoltan 2009-12-17 04:47:48 -0800 Inherits the following classes from Noncopyable because these are instantiated by 'new' and no need to be copyable: class name - instantiated at: WebCore/'location' class ScriptCachedFrameData - history/CachedFrame.cpp:117 class WebCoreJSClientData - bindings/js/JSDOMWindowBase.cpp:162 class ScheduledAction - bindings/js/ScheduledAction.cpp:58 172721 1 45054 zoltan 2009-12-17 04:49:15 -0800 Created attachment 45054 proposed patch 172722 2 webkit.review.bot 2009-12-17 04:53:11 -0800 style-queue ran check-webkit-style on attachment 45054 without any errors. 172930 3 45054 eric 2009-12-17 12:57:40 -0800 Comment on attachment 45054 proposed patch LGTM. 172935 4 45054 commit-queue 2009-12-17 13:09:48 -0800 Comment on attachment 45054 proposed patch Clearing flags on attachment: 45054 Committed r52281: <http://trac.webkit.org/changeset/52281> 172936 5 commit-queue 2009-12-17 13:09:53 -0800 All reviewed patches have been landed. Closing bug. 45054 2009-12-17 04:49:15 -0800 2009-12-17 13:09:48 -0800 proposed patch bindings.patch text/plain 2696 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjI0NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMTItMTcgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIGpzIGJpbmRpbmdzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjY1NQorCisg ICAgICAgIEluaGVyaXRzIHRoZSBmb2xsb3dpbmcgY2xhc3NlcyBmcm9tIE5vbmNvcHlhYmxlIGJl Y2F1c2UgdGhlc2UgYXJlIGluc3RhbnRpYXRlZCAKKyAgICAgICAgYnkgJ25ldycgYW5kIG5vIG5l ZWQgdG8gYmUgY29weWFibGU6CisKKyAgICAgICAgY2xhc3MgbmFtZSAgICAgICAgICAgICAgICAg IC0gaW5zdGFudGlhdGVkIGF0OiAgV2ViQ29yZS8nbG9jYXRpb24nCisKKyAgICAgICAgY2xhc3Mg U2NyaXB0Q2FjaGVkRnJhbWVEYXRhIC0gaGlzdG9yeS9DYWNoZWRGcmFtZS5jcHA6MTE3CisgICAg ICAgIGNsYXNzIFdlYkNvcmVKU0NsaWVudERhdGEgICAtIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93 QmFzZS5jcHA6MTYyCisgICAgICAgIGNsYXNzIFNjaGVkdWxlZEFjdGlvbiAgICAgICAtIGJpbmRp bmdzL2pzL1NjaGVkdWxlZEFjdGlvbi5jcHA6NTgKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pT RE9NQmluZGluZy5oOgorICAgICAgICAqIGJpbmRpbmdzL2pzL1NjaGVkdWxlZEFjdGlvbi5oOgor ICAgICAgICAqIGJpbmRpbmdzL2pzL1NjcmlwdENhY2hlZEZyYW1lRGF0YS5oOgorCiAyMDA5LTEx LTExICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEgU2lsdmEuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdz L2pzL1NjcmlwdENhY2hlZEZyYW1lRGF0YS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGlu Z3MvanMvU2NyaXB0Q2FjaGVkRnJhbWVEYXRhLmgJKHJldmlzaW9uIDUyMjQ3KQorKysgV2ViQ29y ZS9iaW5kaW5ncy9qcy9TY3JpcHRDYWNoZWRGcmFtZURhdGEuaAkod29ya2luZyBjb3B5KQpAQCAt NDAsNyArNDAsNyBAQAogICAgIGNsYXNzIERPTVdpbmRvdzsKICAgICBjbGFzcyBET01XcmFwcGVy V29ybGQ7CiAKLSAgICBjbGFzcyBTY3JpcHRDYWNoZWRGcmFtZURhdGEgIHsKKyAgICBjbGFzcyBT Y3JpcHRDYWNoZWRGcmFtZURhdGEgIDogcHVibGljIE5vbmNvcHlhYmxlIHsKICAgICAgICAgdHlw ZWRlZiBIYXNoTWFwPCBSZWZQdHI8RE9NV3JhcHBlcldvcmxkPiwgSlNDOjpQcm90ZWN0ZWRQdHI8 SlNET01XaW5kb3c+ID4gSlNET01XaW5kb3dTZXQ7CiAKICAgICBwdWJsaWM6CkluZGV4OiBXZWJD b3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmlu ZGluZ3MvanMvSlNET01CaW5kaW5nLmgJKHJldmlzaW9uIDUyMjQ3KQorKysgV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RPTUJpbmRpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtMTgyLDcgKzE4Miw3IEBA CiAgICAgICAgIEhhc2hNYXA8Y29uc3QgSlNDOjpIYXNoVGFibGUqLCBKU0M6Okhhc2hUYWJsZT4g bV9tYXA7CiAgICAgfTsKIAotICAgIGNsYXNzIFdlYkNvcmVKU0NsaWVudERhdGEgOiBwdWJsaWMg SlNDOjpKU0dsb2JhbERhdGE6OkNsaWVudERhdGEgeworICAgIGNsYXNzIFdlYkNvcmVKU0NsaWVu dERhdGEgOiBwdWJsaWMgSlNDOjpKU0dsb2JhbERhdGE6OkNsaWVudERhdGEsIHB1YmxpYyBOb25j b3B5YWJsZSB7CiAgICAgICAgIGZyaWVuZCBjbGFzcyBKU0dsb2JhbERhdGFXb3JsZEl0ZXJhdG9y OwogCiAgICAgcHVibGljOgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy9qcy9TY2hlZHVsZWRBY3Rp b24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjaGVkdWxlZEFjdGlvbi5o CShyZXZpc2lvbiA1MjI0NykKKysrIFdlYkNvcmUvYmluZGluZ3MvanMvU2NoZWR1bGVkQWN0aW9u LmgJKHdvcmtpbmcgY29weSkKQEAgLTQwLDcgKzQwLDcgQEAKICAgICAqIHRpbWUgaW50ZXJ2YWws IGVpdGhlciBvbmNlIG9yIHJlcGVhdGVkbHkuIFVzZWQgZm9yIHdpbmRvdy5zZXRUaW1lb3V0KCkK ICAgICAqIGFuZCB3aW5kb3cuc2V0SW50ZXJ2YWwoKQogICAgICovCi0gICAgY2xhc3MgU2NoZWR1 bGVkQWN0aW9uIHsKKyAgICBjbGFzcyBTY2hlZHVsZWRBY3Rpb24gOiBwdWJsaWMgTm9uY29weWFi bGUgewogICAgIHB1YmxpYzoKICAgICAgICAgc3RhdGljIFNjaGVkdWxlZEFjdGlvbiogY3JlYXRl KEpTQzo6RXhlY1N0YXRlKiwgY29uc3QgSlNDOjpBcmdMaXN0JiwgRE9NV3JhcHBlcldvcmxkKiBp c29sYXRlZFdvcmxkKTsKIAo=