32637 2009-12-16 15:24:25 -0800 [V8] Generate most named property getters. 2009-12-16 16:04:16 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32455 1 dglazkov dglazkov abarth eric webkit.review.bot oldest_to_newest 172551 0 dglazkov 2009-12-16 15:24:25 -0800 The only ones that will be left are those that require looking at inheritance of the IDL interfaces. 172552 1 45021 dglazkov 2009-12-16 15:38:19 -0800 Created attachment 45021 Generate most named property getters. 172554 2 webkit.review.bot 2009-12-16 15:43:36 -0800 style-queue ran check-webkit-style on attachment 45021 without any errors. 172560 3 dglazkov 2009-12-16 16:04:16 -0800 Landed as http://trac.webkit.org/changeset/52224. 45021 2009-12-16 15:38:19 -0800 2009-12-16 15:58:57 -0800 Generate most named property getters. bug-32637-20091216153817.patch text/plain 7226 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTVhMGJhZi4uMTJmZDljMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0xMi0xNiAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMjYzNworICAgICAgICBbVjhdIEdlbmVyYXRlIG1vc3QgbmFtZWQgcHJvcGVydHkgZ2V0 dGVycy4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICog YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06IEFkZGVkIGdlbmVyYXRpb24gb2Yg U2V0TmFtZWRQcm9wZXJ0eUhhbmRsZXIgY2FsbC4KKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERP TVdyYXBwZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjpnZXRUZW1wbGF0 ZSk6IFJlbW92ZWQgbm93LWdlbmVyYXRlZCBTZXROYW1lZFByb3BlcnR5SGFuZGxlciBjYWxsc2l0 ZXMuCisKKzIwMDktMTItMTYgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9y Zz4KKwogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgogCiAgICAgICAgIFtWOF0gU3dp dGNoIGFsbCBpbmRleGVycyB0byBiZSBnZW5lcmF0ZWQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3Jp cHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCA1OTYxOTQ2Li43NTA3ZmNiIDEwMDY0NAotLS0g YS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KQEAgLTExNjQsMTQgKzExNjQs MzEgQEAgc3ViIEdlbmVyYXRlSW1wbGVtZW50YXRpb25OYW1lZFByb3BlcnR5R2V0dGVyCiAgICAg bXkgJG5hbWVkUHJvcGVydHlHZXR0ZXIgPSBzaGlmdDsKICAgICBteSAkaW50ZXJmYWNlTmFtZSA9 ICRkYXRhTm9kZS0+bmFtZTsKIAotICAgIGlmICgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRl cy0+eyJIYXNOYW1lR2V0dGVyIn0gJiYgISRuYW1lZFByb3BlcnR5R2V0dGVyLT5leHRlbmRlZEF0 dHJpYnV0ZXMtPnsiQ3VzdG9tIn0pIHsKKyAgICBteSAkaGFzR2V0dGVyID0gJGRhdGFOb2RlLT5l eHRlbmRlZEF0dHJpYnV0ZXMtPnsiSGFzTmFtZUdldHRlciJ9IHx8ICRuYW1lZFByb3BlcnR5R2V0 dGVyOworICAgIGlmICghJGhhc0dldHRlcikgeworICAgICAgICByZXR1cm47CisgICAgfQorCisg ICAgaWYgKCRuYW1lZFByb3BlcnR5R2V0dGVyICYmICRuYW1lZFByb3BlcnR5R2V0dGVyLT50eXBl IG5lICJOb2RlIiAmJiAhJG5hbWVkUHJvcGVydHlHZXR0ZXItPmV4dGVuZGVkQXR0cmlidXRlcy0+ eyJDdXN0b20ifSkgewogICAgICAgICAkaW1wbEluY2x1ZGVzeyJWOENvbGxlY3Rpb24uaCJ9ID0g MTsKICAgICAgICAgbXkgJHR5cGUgPSAkbmFtZWRQcm9wZXJ0eUdldHRlci0+dHlwZTsKICAgICAg ICAgbXkgJGNsYXNzSW5kZXggPSB1YygkdHlwZSk7CiAgICAgICAgIHB1c2goQGltcGxDb250ZW50 LCA8PEVORCk7CiAgIHNldENvbGxlY3Rpb25OYW1lZEdldHRlcjwke2ludGVyZmFjZU5hbWV9LCAk e3R5cGV9PihkZXNjLCBWOENsYXNzSW5kZXg6OiR7Y2xhc3NJbmRleH0pOwogRU5ECisgICAgICAg IHJldHVybjsKICAgICB9CisKKyAgICBteSAkaGFzU2V0dGVyID0gJGRhdGFOb2RlLT5leHRlbmRl ZEF0dHJpYnV0ZXMtPnsiRGVsZWdhdGluZ1B1dEZ1bmN0aW9uIn07CisgICAgbXkgJGhhc0RlbGV0 ZXIgPSAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21EZWxldGVQcm9wZXJ0 eSJ9OworICAgIG15ICRoYXNFbnVtZXJhdG9yID0gJGRhdGFOb2RlLT5leHRlbmRlZEF0dHJpYnV0 ZXMtPnsiQ3VzdG9tR2V0UHJvcGVydHlOYW1lcyJ9OworCisgICAgcHVzaChAaW1wbENvbnRlbnQs ICIgIGRlc2MtPkluc3RhbmNlVGVtcGxhdGUoKS0+U2V0TmFtZWRQcm9wZXJ0eUhhbmRsZXIoVjhD dXN0b206OnY4JHtpbnRlcmZhY2VOYW1lfU5hbWVkUHJvcGVydHlHZXR0ZXIsICIpOworICAgIHB1 c2goQGltcGxDb250ZW50LCAkaGFzU2V0dGVyID8gIlY4Q3VzdG9tOjp2OCR7aW50ZXJmYWNlTmFt ZX1OYW1lZFByb3BlcnR5U2V0dGVyLCAiIDogIjAsICIpOworICAgIHB1c2goQGltcGxDb250ZW50 LCAiMCAsIik7ICMgTmFtZWRQcm9wZXJ0eVF1ZXJ5IC0tIG5vdCBiZWluZyB1c2VkIGF0IHRoZSBt b21lbnQuCisgICAgcHVzaChAaW1wbENvbnRlbnQsICRoYXNEZWxldGVyID8gIlY4Q3VzdG9tOjp2 OCR7aW50ZXJmYWNlTmFtZX1OYW1lZFByb3BlcnR5RGVsZXRlciwgIiA6ICIwLCAiKTsKKyAgICBw dXNoKEBpbXBsQ29udGVudCwgJGhhc0VudW1lcmF0b3IgPyAiVjhDdXN0b206OnY4JHtpbnRlcmZh Y2VOYW1lfU5hbWVkUHJvcGVydHlFbnVtZXJhdG9yIiA6ICIwIik7CisgICAgcHVzaChAaW1wbENv bnRlbnQsICIpO1xuIik7CiB9CiAKIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCkBAIC0xNDY3 LDcgKzE0ODQsNyBAQCBFTkQKICAgICB9CiAKICAgICBHZW5lcmF0ZUltcGxlbWVudGF0aW9uSW5k ZXhlcigkZGF0YU5vZGUsICRpbmRleGVyKSBpZiAkaW5kZXhlcjsKLSAgICBHZW5lcmF0ZUltcGxl bWVudGF0aW9uTmFtZWRQcm9wZXJ0eUdldHRlcigkZGF0YU5vZGUsICRuYW1lZFByb3BlcnR5R2V0 dGVyKSBpZiAkbmFtZWRQcm9wZXJ0eUdldHRlcjsKKyAgICBHZW5lcmF0ZUltcGxlbWVudGF0aW9u TmFtZWRQcm9wZXJ0eUdldHRlcigkZGF0YU5vZGUsICRuYW1lZFByb3BlcnR5R2V0dGVyKTsKIAog ICAgICMgRGVmaW5lIG91ciBmdW5jdGlvbnMgd2l0aCBTZXQoKSBvciBTZXRBY2Nlc3NvcigpCiAg ICAgJHRvdGFsX2Z1bmN0aW9ucyA9IDA7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4RE9NV3JhcHBlci5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAK aW5kZXggNDBiNjkyMy4uYzNjZDYxNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9W OERPTVdyYXBwZXIuY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNw cApAQCAtMjcxLDE2ICsyNzEsOSBAQCB2ODo6UGVyc2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0 ZT4gVjhET01XcmFwcGVyOjpnZXRUZW1wbGF0ZShWOENsYXNzSW5kZXg6OlY4VwogICAgICAgICB0 b1N0cmluZ1RlbXBsYXRlID0gdjg6OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9uVGVtcGxhdGU+OjpO ZXcodjg6OkZ1bmN0aW9uVGVtcGxhdGU6Ok5ldyhDb25zdHJ1Y3RvclRvU3RyaW5nKSk7CiAgICAg ZGVzY3JpcHRvci0+U2V0KEdldFRvU3RyaW5nTmFtZSgpLCB0b1N0cmluZ1RlbXBsYXRlKTsKICAg ICBzd2l0Y2ggKHR5cGUpIHsKLSAgICBjYXNlIFY4Q2xhc3NJbmRleDo6Q1NTU1RZTEVERUNMQVJB VElPTjoKLSAgICAgICAgLy8gVGhlIG5hbWVkIHByb3BlcnR5IGhhbmRsZXIgZm9yIHN0eWxlIGRl Y2xhcmF0aW9ucyBoYXMgYQotICAgICAgICAvLyBzZXR0ZXIuIFRoZXJlZm9yZSwgdGhlIGludGVy Y2VwdG9yIGhhcyB0byBiZSBvbiB0aGUgb2JqZWN0Ci0gICAgICAgIC8vIGl0c2VsZiBhbmQgbm90 IG9uIHRoZSBwcm90b3R5cGUgb2JqZWN0LgotICAgICAgICBkZXNjcmlwdG9yLT5JbnN0YW5jZVRl bXBsYXRlKCktPlNldE5hbWVkUHJvcGVydHlIYW5kbGVyKCBVU0VfTkFNRURfUFJPUEVSVFlfR0VU VEVSKENTU1N0eWxlRGVjbGFyYXRpb24pLCBVU0VfTkFNRURfUFJPUEVSVFlfU0VUVEVSKENTU1N0 eWxlRGVjbGFyYXRpb24pKTsKLSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBWOENsYXNzSW5kZXg6 OkhUTUxBTExDT0xMRUNUSU9OOgogICAgICAgICBkZXNjcmlwdG9yLT5JbnN0YW5jZVRlbXBsYXRl KCktPk1hcmtBc1VuZGV0ZWN0YWJsZSgpOyAvLyBmYWxsIHRocm91Z2gKICAgICBjYXNlIFY4Q2xh c3NJbmRleDo6SFRNTENPTExFQ1RJT046Ci0gICAgICAgIGRlc2NyaXB0b3ItPkluc3RhbmNlVGVt cGxhdGUoKS0+U2V0TmFtZWRQcm9wZXJ0eUhhbmRsZXIoVVNFX05BTUVEX1BST1BFUlRZX0dFVFRF UihIVE1MQ29sbGVjdGlvbikpOwogICAgICAgICBkZXNjcmlwdG9yLT5JbnN0YW5jZVRlbXBsYXRl KCktPlNldENhbGxBc0Z1bmN0aW9uSGFuZGxlcihVU0VfQ0FMTEJBQ0soSFRNTENvbGxlY3Rpb25D YWxsQXNGdW5jdGlvbikpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFY4Q2xhc3NJbmRleDo6 SFRNTE9QVElPTlNDT0xMRUNUSU9OOgpAQCAtMjg5LDcgKzI4Miw2IEBAIHY4OjpQZXJzaXN0ZW50 PHY4OjpGdW5jdGlvblRlbXBsYXRlPiBWOERPTVdyYXBwZXI6OmdldFRlbXBsYXRlKFY4Q2xhc3NJ bmRleDo6VjhXCiAgICAgICAgIGRlc2NyaXB0b3ItPkluc3RhbmNlVGVtcGxhdGUoKS0+U2V0Q2Fs bEFzRnVuY3Rpb25IYW5kbGVyKFVTRV9DQUxMQkFDSyhIVE1MQ29sbGVjdGlvbkNhbGxBc0Z1bmN0 aW9uKSk7CiAgICAgICAgIGJyZWFrOwogICAgIGNhc2UgVjhDbGFzc0luZGV4OjpIVE1MU0VMRUNU RUxFTUVOVDoKLSAgICAgICAgZGVzY3JpcHRvci0+SW5zdGFuY2VUZW1wbGF0ZSgpLT5TZXROYW1l ZFByb3BlcnR5SGFuZGxlcihVU0VfTkFNRURfUFJPUEVSVFlfR0VUVEVSKEhUTUxTZWxlY3RFbGVt ZW50KSk7CiAgICAgICAgIGRlc2NyaXB0b3ItPkluc3RhbmNlVGVtcGxhdGUoKS0+U2V0SW5kZXhl ZFByb3BlcnR5SGFuZGxlcihVU0VfSU5ERVhFRF9QUk9QRVJUWV9HRVRURVIoSFRNTFNlbGVjdEVs ZW1lbnQpLCBVU0VfSU5ERVhFRF9QUk9QRVJUWV9TRVRURVIoSFRNTFNlbGVjdEVsZW1lbnQpLCAw LCAwLCBub2RlQ29sbGVjdGlvbkluZGV4ZWRQcm9wZXJ0eUVudW1lcmF0b3I8SFRNTFNlbGVjdEVs ZW1lbnQ+LCB2ODo6SW50ZWdlcjo6TmV3KFY4Q2xhc3NJbmRleDo6Tk9ERSkpOwogICAgICAgICBi cmVhazsKICAgICBjYXNlIFY4Q2xhc3NJbmRleDo6SFRNTERPQ1VNRU5UOiB7CkBAIC0zNTEsMjIg KzM0MywxNCBAQCB2ODo6UGVyc2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gVjhET01XcmFw cGVyOjpnZXRUZW1wbGF0ZShWOENsYXNzSW5kZXg6OlY4VwogICAgICAgICB2ODo6TG9jYWw8djg6 Ok9iamVjdFRlbXBsYXRlPiBpbnN0YW5jZVRlbXBsYXRlID0gZGVzY3JpcHRvci0+SW5zdGFuY2VU ZW1wbGF0ZSgpOwogICAgICAgICBBU1NFUlQoaW5zdGFuY2VUZW1wbGF0ZS0+SW50ZXJuYWxGaWVs ZENvdW50KCkgPT0gVjhDdXN0b206OmtEZWZhdWx0V3JhcHBlckludGVybmFsRmllbGRDb3VudCk7 CiAgICAgICAgIGluc3RhbmNlVGVtcGxhdGUtPlNldEludGVybmFsRmllbGRDb3VudChWOEN1c3Rv bTo6a05hbWVkTm9kZU1hcEludGVybmFsRmllbGRDb3VudCk7Ci0gICAgICAgIGluc3RhbmNlVGVt cGxhdGUtPlNldE5hbWVkUHJvcGVydHlIYW5kbGVyKFVTRV9OQU1FRF9QUk9QRVJUWV9HRVRURVIo TmFtZWROb2RlTWFwKSk7CiAgICAgICAgIGluc3RhbmNlVGVtcGxhdGUtPlNldEluZGV4ZWRQcm9w ZXJ0eUhhbmRsZXIoVVNFX0lOREVYRURfUFJPUEVSVFlfR0VUVEVSKE5hbWVkTm9kZU1hcCksIDAs IDAsIDAsIGNvbGxlY3Rpb25JbmRleGVkUHJvcGVydHlFbnVtZXJhdG9yPE5hbWVkTm9kZU1hcD4s IHY4OjpJbnRlZ2VyOjpOZXcoVjhDbGFzc0luZGV4OjpOT0RFKSk7CiAgICAgICAgIGJyZWFrOwog ICAgIH0KICNpZiBFTkFCTEUoRE9NX1NUT1JBR0UpCiAgICAgY2FzZSBWOENsYXNzSW5kZXg6OlNU T1JBR0U6Ci0gICAgICAgIGRlc2NyaXB0b3ItPkluc3RhbmNlVGVtcGxhdGUoKS0+U2V0TmFtZWRQ cm9wZXJ0eUhhbmRsZXIoVVNFX05BTUVEX1BST1BFUlRZX0dFVFRFUihTdG9yYWdlKSwgVVNFX05B TUVEX1BST1BFUlRZX1NFVFRFUihTdG9yYWdlKSwgMCwgVVNFX05BTUVEX1BST1BFUlRZX0RFTEVU RVIoU3RvcmFnZSksIFY4Q3VzdG9tOjp2OFN0b3JhZ2VOYW1lZFByb3BlcnR5RW51bWVyYXRvcik7 CiAgICAgICAgIGRlc2NyaXB0b3ItPkluc3RhbmNlVGVtcGxhdGUoKS0+U2V0SW5kZXhlZFByb3Bl cnR5SGFuZGxlcihVU0VfSU5ERVhFRF9QUk9QRVJUWV9HRVRURVIoU3RvcmFnZSksIFVTRV9JTkRF WEVEX1BST1BFUlRZX1NFVFRFUihTdG9yYWdlKSwgMCwgVVNFX0lOREVYRURfUFJPUEVSVFlfREVM RVRFUihTdG9yYWdlKSk7CiAgICAgICAgIGJyZWFrOwogI2VuZGlmCi0gICAgY2FzZSBWOENsYXNz SW5kZXg6Ok5PREVMSVNUOgotICAgICAgICBkZXNjcmlwdG9yLT5JbnN0YW5jZVRlbXBsYXRlKCkt PlNldE5hbWVkUHJvcGVydHlIYW5kbGVyKFVTRV9OQU1FRF9QUk9QRVJUWV9HRVRURVIoTm9kZUxp c3QpKTsKLSAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBWOENsYXNzSW5kZXg6OlNUWUxFU0hFRVRM SVNUOgotICAgICAgICBkZXNjcmlwdG9yLT5JbnN0YW5jZVRlbXBsYXRlKCktPlNldE5hbWVkUHJv cGVydHlIYW5kbGVyKFVTRV9OQU1FRF9QUk9QRVJUWV9HRVRURVIoU3R5bGVTaGVldExpc3QpKTsK LSAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBWOENsYXNzSW5kZXg6OkRPTVdJTkRPVzogewogICAg ICAgICB2ODo6TG9jYWw8djg6OlNpZ25hdHVyZT4gZGVmYXVsdFNpZ25hdHVyZSA9IHY4OjpTaWdu YXR1cmU6Ok5ldyhkZXNjcmlwdG9yKTsKIApAQCAtNTYzLDExICs1NDcsNiBAQCB2ODo6UGVyc2lz dGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gVjhET01XcmFwcGVyOjpnZXRUZW1wbGF0ZShWOENs YXNzSW5kZXg6OlY4VwogICAgIGNhc2UgVjhDbGFzc0luZGV4OjpYU0xUUFJPQ0VTU09SOgogICAg ICAgICBkZXNjcmlwdG9yLT5TZXRDYWxsSGFuZGxlcihVU0VfQ0FMTEJBQ0soWFNMVFByb2Nlc3Nv ckNvbnN0cnVjdG9yKSk7CiAgICAgICAgIGJyZWFrOwotI2lmIEVOQUJMRShEQVRBR1JJRCkKLSAg ICBjYXNlIFY4Q2xhc3NJbmRleDo6REFUQUdSSURDT0xVTU5MSVNUOgotICAgICAgICBkZXNjcmlw dG9yLT5JbnN0YW5jZVRlbXBsYXRlKCktPlNldE5hbWVkUHJvcGVydHlIYW5kbGVyKFVTRV9OQU1F RF9QUk9QRVJUWV9HRVRURVIoRGF0YUdyaWRDb2x1bW5MaXN0KSk7Ci0gICAgICAgIGJyZWFrOwot I2VuZGlmCiAgICAgZGVmYXVsdDoKICAgICAgICAgYnJlYWs7CiAgICAgfQo=