32629 2009-12-16 12:52:19 -0800 EWS should support Gtk build 2009-12-16 23:41:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan webkit-unassigned abarth webkit.review.bot oldest_to_newest 172481 0 45009 evan 2009-12-16 12:52:19 -0800 Created attachment 45009 Patch The EWS should support WebKit GTK. 172484 1 abarth 2009-12-16 13:03:11 -0800 This looks great. Can you add a ChangeLog and a unit test for the GtkPort (there are examples in webkitport_unittest)? We don't have a good way of testing the GtkEWS class yet. 172519 2 45011 evan 2009-12-16 13:45:45 -0800 Created attachment 45011 patch that passes unit test 172520 3 webkit.review.bot 2009-12-16 13:49:56 -0800 style-queue ran check-webkit-style on attachment 45011 without any errors. 172530 4 45011 abarth 2009-12-16 14:04:30 -0800 Comment on attachment 45011 patch that passes unit test Awesome. Thanks! 172653 5 45011 abarth 2009-12-16 23:41:20 -0800 Comment on attachment 45011 patch that passes unit test Clearing flags on attachment: 45011 Committed r52240: <http://trac.webkit.org/changeset/52240> 172654 6 abarth 2009-12-16 23:41:26 -0800 All reviewed patches have been landed. Closing bug. 45009 2009-12-16 12:52:19 -0800 2009-12-16 13:45:38 -0800 Patch 20091216125213.patch text/plain 1889 evan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9lYXJseV93 YXJuaW5nX3N5c3RlbS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9l YXJseV93YXJuaW5nX3N5c3RlbS5weQppbmRleCBlOGVmNDA4Li41YzkwN2FkIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvZWFybHlfd2FybmluZ19zeXN0 ZW0ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Vhcmx5X3dh cm5pbmdfc3lzdGVtLnB5CkBAIC01Niw2ICs1NiwxMSBAQCBjbGFzcyBBYnN0cmFjdEVhcmx5V2Fy bmluZ1N5c3RlbShBYnN0cmFjdFJldmlld1F1ZXVlKToKICAgICAgICAgc2VsZi5fcGF0Y2hlcy5k aWRfcGFzcyhwYXRjaCkKIAogCitjbGFzcyBHdGtFV1MoQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0 ZW0pOgorICAgIG5hbWUgPSAiZ3RrLWV3cyIKKyAgICBwb3J0X25hbWUgPSAiZ3RrIgorCisKIGNs YXNzIFF0RVdTKEFic3RyYWN0RWFybHlXYXJuaW5nU3lzdGVtKToKICAgICBuYW1lID0gInF0LWV3 cyIKICAgICBwb3J0X25hbWUgPSAicXQiCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRz L21vZHVsZXMvd2Via2l0cG9ydC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy93ZWJr aXRwb3J0LnB5CmluZGV4IDg0OWFjNGIuLjNlMWRkODEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy93ZWJraXRwb3J0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMv bW9kdWxlcy93ZWJraXRwb3J0LnB5CkBAIC00MCwxNCArNDAsMTQgQEAgY2xhc3MgV2ViS2l0UG9y dCgpOgogCiAgICAgQHN0YXRpY21ldGhvZAogICAgIGRlZiBwb3J0KHBvcnRfbmFtZSk6Ci0gICAg ICAgIGlmIHBvcnRfbmFtZSA9PSAibWFjIjoKLSAgICAgICAgICAgIHJldHVybiBNYWNQb3J0Ci0g ICAgICAgIGlmIHBvcnRfbmFtZSA9PSAicXQiOgotICAgICAgICAgICAgcmV0dXJuIFF0UG9ydAot ICAgICAgICBpZiBwb3J0X25hbWUgPT0gImNocm9taXVtIjoKLSAgICAgICAgICAgIHJldHVybiBD aHJvbWl1bVBvcnQKKyAgICAgICAgcG9ydHMgPSB7CisgICAgICAgICAgICAiY2hyb21pdW0iOiBD aHJvbWl1bVBvcnQsCisgICAgICAgICAgICAiZ3RrIjogR3RrUG9ydCwKKyAgICAgICAgICAgICJt YWMiOiBNYWNQb3J0LAorICAgICAgICAgICAgInF0IjogUXRQb3J0LAorICAgICAgICB9CiAgICAg ICAgICMgRklYTUU6IFdlIHNob3VsZCBkZWZhdWx0IHRvIFdpblBvcnQgb24gV2luZG93cy4KLSAg ICAgICAgcmV0dXJuIE1hY1BvcnQKKyAgICAgICAgcmV0dXJuIHBvcnRzLmdldChwb3J0X25hbWUs IE1hY1BvcnQpCiAKICAgICBAY2xhc3NtZXRob2QKICAgICBkZWYgbmFtZShjbHMpOgpAQCAtODAs NiArODAsMjIgQEAgY2xhc3MgTWFjUG9ydChXZWJLaXRQb3J0KToKICAgICAgICAgcmV0dXJuICIt LXBvcnQ9bWFjIgogCiAKK2NsYXNzIEd0a1BvcnQoV2ViS2l0UG9ydCk6CisgICAgQGNsYXNzbWV0 aG9kCisgICAgZGVmIG5hbWUoY2xzKToKKyAgICAgICAgcmV0dXJuICJHdGsiCisKKyAgICBAY2xh c3NtZXRob2QKKyAgICBkZWYgZmxhZyhjbHMpOgorICAgICAgICByZXR1cm4gIi0tcG9ydD1ndGsi CisKKyAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgYnVpbGRfd2Via2l0X2NvbW1hbmQoY2xzKToK KyAgICAgICAgY29tbWFuZCA9IFdlYktpdFBvcnQuYnVpbGRfd2Via2l0X2NvbW1hbmQoKQorICAg ICAgICBjb21tYW5kLmFwcGVuZCgiLS1ndGsiKQorICAgICAgICByZXR1cm4gY29tbWFuZAorCisK IGNsYXNzIFF0UG9ydChXZWJLaXRQb3J0KToKICAgICBAY2xhc3NtZXRob2QKICAgICBkZWYgbmFt ZShjbHMpOgo= 45011 2009-12-16 13:45:45 -0800 2009-12-16 23:41:20 -0800 patch that passes unit test bug-32629-20091216134541.patch text/plain 3988 evan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MzU5ZDE5Li43MDhiYmRmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTIt MTYgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEd0ayB0byB0aGUgZWFybHkgd2Fybmlu ZyBzeXN0ZW0gV2ViS2l0IHBvcnQgbGlzdC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI2MjkKKworICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9j b21tYW5kcy9lYXJseV93YXJuaW5nX3N5c3RlbS5weToKKyAgICAgICAgKiBTY3JpcHRzL21vZHVs ZXMvd2Via2l0cG9ydC5weToKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvd2Via2l0cG9ydF91 bml0dGVzdC5weToKKwogMjAwOS0xMi0xNiAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFu bkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZyZXl0aGVyLgpkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Vhcmx5X3dhcm5p bmdfc3lzdGVtLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Vhcmx5 X3dhcm5pbmdfc3lzdGVtLnB5CmluZGV4IGU4ZWY0MDguLjVjOTA3YWQgMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9lYXJseV93YXJuaW5nX3N5c3RlbS5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvZWFybHlfd2Fybmlu Z19zeXN0ZW0ucHkKQEAgLTU2LDYgKzU2LDExIEBAIGNsYXNzIEFic3RyYWN0RWFybHlXYXJuaW5n U3lzdGVtKEFic3RyYWN0UmV2aWV3UXVldWUpOgogICAgICAgICBzZWxmLl9wYXRjaGVzLmRpZF9w YXNzKHBhdGNoKQogCiAKK2NsYXNzIEd0a0VXUyhBYnN0cmFjdEVhcmx5V2FybmluZ1N5c3RlbSk6 CisgICAgbmFtZSA9ICJndGstZXdzIgorICAgIHBvcnRfbmFtZSA9ICJndGsiCisKKwogY2xhc3Mg UXRFV1MoQWJzdHJhY3RFYXJseVdhcm5pbmdTeXN0ZW0pOgogICAgIG5hbWUgPSAicXQtZXdzIgog ICAgIHBvcnRfbmFtZSA9ICJxdCIKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9k dWxlcy93ZWJraXRwb3J0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3dlYmtpdHBv cnQucHkKaW5kZXggODQ5YWM0Yi4uOTllYTE3NCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy9tb2R1bGVzL3dlYmtpdHBvcnQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL3dlYmtpdHBvcnQucHkKQEAgLTQwLDE0ICs0MCwxNCBAQCBjbGFzcyBXZWJLaXRQb3J0KCk6 CiAKICAgICBAc3RhdGljbWV0aG9kCiAgICAgZGVmIHBvcnQocG9ydF9uYW1lKToKLSAgICAgICAg aWYgcG9ydF9uYW1lID09ICJtYWMiOgotICAgICAgICAgICAgcmV0dXJuIE1hY1BvcnQKLSAgICAg ICAgaWYgcG9ydF9uYW1lID09ICJxdCI6Ci0gICAgICAgICAgICByZXR1cm4gUXRQb3J0Ci0gICAg ICAgIGlmIHBvcnRfbmFtZSA9PSAiY2hyb21pdW0iOgotICAgICAgICAgICAgcmV0dXJuIENocm9t aXVtUG9ydAorICAgICAgICBwb3J0cyA9IHsKKyAgICAgICAgICAgICJjaHJvbWl1bSI6IENocm9t aXVtUG9ydCwKKyAgICAgICAgICAgICJndGsiOiBHdGtQb3J0LAorICAgICAgICAgICAgIm1hYyI6 IE1hY1BvcnQsCisgICAgICAgICAgICAicXQiOiBRdFBvcnQsCisgICAgICAgIH0KICAgICAgICAg IyBGSVhNRTogV2Ugc2hvdWxkIGRlZmF1bHQgdG8gV2luUG9ydCBvbiBXaW5kb3dzLgotICAgICAg ICByZXR1cm4gTWFjUG9ydAorICAgICAgICByZXR1cm4gcG9ydHMuZ2V0KHBvcnRfbmFtZSwgTWFj UG9ydCkKIAogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBuYW1lKGNscyk6CkBAIC04MCw2ICs4 MCwyOCBAQCBjbGFzcyBNYWNQb3J0KFdlYktpdFBvcnQpOgogICAgICAgICByZXR1cm4gIi0tcG9y dD1tYWMiCiAKIAorY2xhc3MgR3RrUG9ydChXZWJLaXRQb3J0KToKKyAgICBAY2xhc3NtZXRob2QK KyAgICBkZWYgbmFtZShjbHMpOgorICAgICAgICByZXR1cm4gIkd0ayIKKworICAgIEBjbGFzc21l dGhvZAorICAgIGRlZiBmbGFnKGNscyk6CisgICAgICAgIHJldHVybiAiLS1wb3J0PWd0ayIKKwor ICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiBidWlsZF93ZWJraXRfY29tbWFuZChjbHMpOgorICAg ICAgICBjb21tYW5kID0gV2ViS2l0UG9ydC5idWlsZF93ZWJraXRfY29tbWFuZCgpCisgICAgICAg IGNvbW1hbmQuYXBwZW5kKCItLWd0ayIpCisgICAgICAgIHJldHVybiBjb21tYW5kCisKKyAgICBA Y2xhc3NtZXRob2QKKyAgICBkZWYgcnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKGNscyk6CisgICAg ICAgIGNvbW1hbmQgPSBXZWJLaXRQb3J0LnJ1bl93ZWJraXRfdGVzdHNfY29tbWFuZCgpCisgICAg ICAgIGNvbW1hbmQuYXBwZW5kKCItLWd0ayIpCisgICAgICAgIHJldHVybiBjb21tYW5kCisKKwog Y2xhc3MgUXRQb3J0KFdlYktpdFBvcnQpOgogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBuYW1l KGNscyk6CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvd2Via2l0cG9y dF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy93ZWJraXRwb3J0X3Vu aXR0ZXN0LnB5CmluZGV4IGM3MTNlODMuLmU0NGI5YTYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy93ZWJraXRwb3J0X3VuaXR0ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy93ZWJraXRwb3J0X3VuaXR0ZXN0LnB5CkBAIC0yOSw3ICsyOSw3IEBA CiAKIGltcG9ydCB1bml0dGVzdAogCi1mcm9tIG1vZHVsZXMud2Via2l0cG9ydCBpbXBvcnQgV2Vi S2l0UG9ydCwgTWFjUG9ydCwgUXRQb3J0LCBDaHJvbWl1bVBvcnQKK2Zyb20gbW9kdWxlcy53ZWJr aXRwb3J0IGltcG9ydCBXZWJLaXRQb3J0LCBNYWNQb3J0LCBHdGtQb3J0LCBRdFBvcnQsIENocm9t aXVtUG9ydAogCiBjbGFzcyBXZWJLaXRQb3J0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAg ZGVmIHRlc3RfbWFjX3BvcnQoc2VsZik6CkBAIC0zOCw2ICszOCwxMiBAQCBjbGFzcyBXZWJLaXRQ b3J0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKE1h Y1BvcnQucnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKCksIFtXZWJLaXRQb3J0LnNjcmlwdF9wYXRo KCJydW4td2Via2l0LXRlc3RzIildKQogICAgICAgICBzZWxmLmFzc2VydEVxdWFscyhNYWNQb3J0 LmJ1aWxkX3dlYmtpdF9jb21tYW5kKCksIFtXZWJLaXRQb3J0LnNjcmlwdF9wYXRoKCJidWlsZC13 ZWJraXQiKV0pCiAKKyAgICBkZWYgdGVzdF9ndGtfcG9ydChzZWxmKToKKyAgICAgICAgc2VsZi5h c3NlcnRFcXVhbHMoR3RrUG9ydC5uYW1lKCksICJHdGsiKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFscyhHdGtQb3J0LmZsYWcoKSwgIi0tcG9ydD1ndGsiKQorICAgICAgICBzZWxmLmFzc2VydEVx dWFscyhHdGtQb3J0LnJ1bl93ZWJraXRfdGVzdHNfY29tbWFuZCgpLCBbV2ViS2l0UG9ydC5zY3Jp cHRfcGF0aCgicnVuLXdlYmtpdC10ZXN0cyIpLCAiLS1ndGsiXSkKKyAgICAgICAgc2VsZi5hc3Nl cnRFcXVhbHMoR3RrUG9ydC5idWlsZF93ZWJraXRfY29tbWFuZCgpLCBbV2ViS2l0UG9ydC5zY3Jp cHRfcGF0aCgiYnVpbGQtd2Via2l0IiksICItLWd0ayJdKQorCiAgICAgZGVmIHRlc3RfcXRfcG9y dChzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoUXRQb3J0Lm5hbWUoKSwgIlF0IikK ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoUXRQb3J0LmZsYWcoKSwgIi0tcG9ydD1xdCIpCg==