32625 2009-12-16 11:55:09 -0800 Early Warning System doesn't obey system locale 2009-12-16 13:40:24 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 evan webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 172443 0 evan 2009-12-16 11:55:09 -0800 http://webkit-commit-queue.appspot.com/results/127615 Has some mojibake on it. ../../WebCore/page/SecurityOrigin.cpp: In member function ‘bool WebCore::SecurityOrigin::canAccess(const WebCore::SecurityOrigin*) const’: (bugzilla may eat that) It's because the builder is running in a UTF-8 locale, so it is outputting UTF-8. Since Mac/Win will only output ASCII, probably putting a UTF-8 encoding header on the page will probably be the easiest fix. 172448 1 abarth 2009-12-16 12:01:37 -0800 That should be easy to do. The web service is in WebKitTools/QueueStatusServer. Eric or I can re-deploy after the patch lands. 172452 2 45001 evan 2009-12-16 12:09:19 -0800 Created attachment 45001 patch for great justice 172454 3 evan 2009-12-16 12:11:36 -0800 (completely untested, btw, still getting started here) 172455 4 webkit.review.bot 2009-12-16 12:12:03 -0800 style-queue ran check-webkit-style on attachment 45001 without any errors. 172464 5 evan 2009-12-16 12:18:05 -0800 fail. equals sign instead of hyphen 172465 6 45003 evan 2009-12-16 12:19:00 -0800 Created attachment 45003 patch for great justice 172466 7 webkit.review.bot 2009-12-16 12:22:26 -0800 style-queue ran check-webkit-style on attachment 45003 without any errors. 172469 8 45005 evan 2009-12-16 12:29:56 -0800 Created attachment 45005 patch for great justice 172470 9 webkit.review.bot 2009-12-16 12:33:06 -0800 style-queue ran check-webkit-style on attachment 45005 without any errors. 172488 10 45005 abarth 2009-12-16 13:10:19 -0800 Comment on attachment 45005 patch for great justice Thanks! 172489 11 abarth 2009-12-16 13:11:27 -0800 Eric might be closer to the redeploy button than me. 172502 12 eric 2009-12-16 13:20:43 -0800 I'm just gonna add Evan to the deploy list. He's a committer, no reason he shouldn't be able to deploy the app. Anyone who's hacking on the bots should have full access to deploy them, and I'm happy to make that a reality. 172503 13 eric 2009-12-16 13:22:03 -0800 Invited Evan to developer access on http://webkit-commit-queue.appspot.com/ 172506 14 45005 commit-queue 2009-12-16 13:24:15 -0800 Comment on attachment 45005 patch for great justice Clearing flags on attachment: 45005 Committed r52218: <http://trac.webkit.org/changeset/52218> 172507 15 commit-queue 2009-12-16 13:24:22 -0800 All reviewed patches have been landed. Closing bug. 172514 16 eric 2009-12-16 13:31:44 -0800 Our handling of file data on the server might also be screwing you here: http://trac.webkit.org/browser/trunk/WebKitTools/QueueStatusServer/queue_status.py#L148 the str() call was added to work around a bug where Blob() can't handle u"" strings. Maybe we need to use BinaryBlob or something. 172515 17 evan 2009-12-16 13:36:57 -0800 (In reply to comment #13) > Invited Evan to developer access on http://webkit-commit-queue.appspot.com/ I don't see this. Did you invite evan@chromium.org? 172516 18 eric 2009-12-16 13:40:24 -0800 No, I invited your gmail account. I'm happy to invite whichever account you like 45001 2009-12-16 12:09:19 -0800 2009-12-16 12:18:53 -0800 patch for great justice bug-32625-20091216120914.patch text/plain 1094 evan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MzU5ZDE5Li5hZDAzNDE2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTIt MTYgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWFybHkgd2FybmluZyBzeXN0ZW0gc2VydmVy IHNob3VsZCBkaXNwbGF5IG91dHB1dCBhcyBVVEYtOC4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI2MjUKKworICAgICAgICAqIFF1ZXVlU3RhdHVz U2VydmVyL3F1ZXVlX3N0YXR1cy5weToKKwogMjAwOS0xMi0xNiAgU2ltb24gSGF1c21hbm4gIDxz aW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZy ZXl0aGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvcXVldWVf c3RhdHVzLnB5IGIvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvcXVldWVfc3RhdHVzLnB5 CmluZGV4IDhjYzgxNWQuLmIyZDI0OTUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1F1ZXVlU3Rh dHVzU2VydmVyL3F1ZXVlX3N0YXR1cy5weQorKysgYi9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1Nl cnZlci9xdWV1ZV9zdGF0dXMucHkKQEAgLTE1Niw3ICsxNTYsNyBAQCBjbGFzcyBTaG93UmVzdWx0 cyh3ZWJhcHAuUmVxdWVzdEhhbmRsZXIpOgogICAgICAgICBpZiBub3Qgc3RhdHVzOgogICAgICAg ICAgICAgc2VsZi5lcnJvcig0MDQpCiAgICAgICAgICAgICByZXR1cm4KLSAgICAgICAgc2VsZi5y ZXNwb25zZS5oZWFkZXJzWyJDb250ZW50LVR5cGUiXSA9ICJ0ZXh0L3BsYWluIgorICAgICAgICBz ZWxmLnJlc3BvbnNlLmhlYWRlcnNbIkNvbnRlbnQtVHlwZSJdID0gInRleHQvcGxhaW47IGNoYXJz ZXQ9dXRmPTgiCiAgICAgICAgIHNlbGYucmVzcG9uc2Uub3V0LndyaXRlKHN0YXR1cy5yZXN1bHRz X2ZpbGUpCiAKIAo= 45003 2009-12-16 12:19:00 -0800 2009-12-16 12:29:47 -0800 patch for great justice bug-32625-20091216121856.patch text/plain 1716 evan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MzU5ZDE5Li5hZDAzNDE2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTIt MTYgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWFybHkgd2FybmluZyBzeXN0ZW0gc2VydmVy IHNob3VsZCBkaXNwbGF5IG91dHB1dCBhcyBVVEYtOC4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI2MjUKKworICAgICAgICAqIFF1ZXVlU3RhdHVz U2VydmVyL3F1ZXVlX3N0YXR1cy5weToKKwogMjAwOS0xMi0xNiAgU2ltb24gSGF1c21hbm4gIDxz aW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZy ZXl0aGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvaW5kZXgu eWFtbCBiL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL2luZGV4LnlhbWwKaW5kZXggYmYx MTI2Mi4uMmExMjA1NiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIv aW5kZXgueWFtbAorKysgYi9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1NlcnZlci9pbmRleC55YW1s CkBAIC0xMCw2ICsxMCw3IEBAIGluZGV4ZXM6CiAjIGF1dG9tYXRpY2FsbHkgdXBsb2FkZWQgdG8g dGhlIGFkbWluIGNvbnNvbGUgd2hlbiB5b3UgbmV4dCBkZXBsb3kKICMgeW91ciBhcHBsaWNhdGlv biB1c2luZyBhcHBjZmcucHkuCiAKKyMgVW51c2VkIGluIHF1ZXJ5IGhpc3RvcnkgLS0gY29waWVk IGZyb20gaW5wdXQuCiAtIGtpbmQ6IFF1ZXVlU3RhdHVzCiAgIHByb3BlcnRpZXM6CiAgIC0gbmFt ZTogYWN0aXZlX3BhdGNoX2lkCkBAIC0xNyw2ICsxOCw3IEBAIGluZGV4ZXM6CiAgIC0gbmFtZTog ZGF0ZQogICAgIGRpcmVjdGlvbjogZGVzYwogCisjIFVzZWQgb25jZSBpbiBxdWVyeSBoaXN0b3J5 LgogLSBraW5kOiBRdWV1ZVN0YXR1cwogICBwcm9wZXJ0aWVzOgogICAtIG5hbWU6IHF1ZXVlX25h bWUKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL3F1ZXVlX3N0YXR1 cy5weSBiL1dlYktpdFRvb2xzL1F1ZXVlU3RhdHVzU2VydmVyL3F1ZXVlX3N0YXR1cy5weQppbmRl eCA4Y2M4MTVkLi5kMGY4ZTQ3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1Nl cnZlci9xdWV1ZV9zdGF0dXMucHkKKysrIGIvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIv cXVldWVfc3RhdHVzLnB5CkBAIC0xNTYsNyArMTU2LDcgQEAgY2xhc3MgU2hvd1Jlc3VsdHMod2Vi YXBwLlJlcXVlc3RIYW5kbGVyKToKICAgICAgICAgaWYgbm90IHN0YXR1czoKICAgICAgICAgICAg IHNlbGYuZXJyb3IoNDA0KQogICAgICAgICAgICAgcmV0dXJuCi0gICAgICAgIHNlbGYucmVzcG9u c2UuaGVhZGVyc1siQ29udGVudC1UeXBlIl0gPSAidGV4dC9wbGFpbiIKKyAgICAgICAgc2VsZi5y ZXNwb25zZS5oZWFkZXJzWyJDb250ZW50LVR5cGUiXSA9ICJ0ZXh0L3BsYWluOyBjaGFyc2V0PXV0 Zi04IgogICAgICAgICBzZWxmLnJlc3BvbnNlLm91dC53cml0ZShzdGF0dXMucmVzdWx0c19maWxl KQogCiAK 45005 2009-12-16 12:29:56 -0800 2009-12-16 13:24:15 -0800 patch for great justice bug-32625-20091216122952.patch text/plain 1094 evan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MzU5ZDE5Li5hZDAzNDE2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTIt MTYgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRWFybHkgd2FybmluZyBzeXN0ZW0gc2VydmVy IHNob3VsZCBkaXNwbGF5IG91dHB1dCBhcyBVVEYtOC4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI2MjUKKworICAgICAgICAqIFF1ZXVlU3RhdHVz U2VydmVyL3F1ZXVlX3N0YXR1cy5weToKKwogMjAwOS0xMi0xNiAgU2ltb24gSGF1c21hbm4gIDxz aW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZy ZXl0aGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvcXVldWVf c3RhdHVzLnB5IGIvV2ViS2l0VG9vbHMvUXVldWVTdGF0dXNTZXJ2ZXIvcXVldWVfc3RhdHVzLnB5 CmluZGV4IDhjYzgxNWQuLmQwZjhlNDcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1F1ZXVlU3Rh dHVzU2VydmVyL3F1ZXVlX3N0YXR1cy5weQorKysgYi9XZWJLaXRUb29scy9RdWV1ZVN0YXR1c1Nl cnZlci9xdWV1ZV9zdGF0dXMucHkKQEAgLTE1Niw3ICsxNTYsNyBAQCBjbGFzcyBTaG93UmVzdWx0 cyh3ZWJhcHAuUmVxdWVzdEhhbmRsZXIpOgogICAgICAgICBpZiBub3Qgc3RhdHVzOgogICAgICAg ICAgICAgc2VsZi5lcnJvcig0MDQpCiAgICAgICAgICAgICByZXR1cm4KLSAgICAgICAgc2VsZi5y ZXNwb25zZS5oZWFkZXJzWyJDb250ZW50LVR5cGUiXSA9ICJ0ZXh0L3BsYWluIgorICAgICAgICBz ZWxmLnJlc3BvbnNlLmhlYWRlcnNbIkNvbnRlbnQtVHlwZSJdID0gInRleHQvcGxhaW47IGNoYXJz ZXQ9dXRmLTgiCiAgICAgICAgIHNlbGYucmVzcG9uc2Uub3V0LndyaXRlKHN0YXR1cy5yZXN1bHRz X2ZpbGUpCiAKIAo=