32607 2009-12-16 05:45:57 -0800 [Qt] Code cleanup: Make better separation between QJavaScript's "public" and "private" classes 2010-01-04 06:29:25 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED INVALID Qt P2 Normal --- 32565 32608 32657 1 jedrzej.nowacki jedrzej.nowacki jedrzej.nowacki kent.hansen oldest_to_newest 172265 0 jedrzej.nowacki 2009-12-16 05:45:57 -0800 The QJavaScript API implementation is small enough to keep clear separation between a "public" and a "private" classes. For implementation simplicity we should assume that a "public" class should only propagate functions calls and convert a data (from "private" to "public" and from "public" to "private"). The bug apply only if the bug 32565 will be accepted to commit. 172268 1 44966 jedrzej.nowacki 2009-12-16 05:51:53 -0800 Created attachment 44966 patch v1 The patch should be landed after bug 32565. 176673 2 jedrzej.nowacki 2010-01-04 06:29:25 -0800 The base patch (bug 32565) wasn't accepted, so the bug is not valid. 44966 2009-12-16 05:51:53 -0800 2009-12-18 08:17:16 -0800 patch v1 sparationV1.diff text/plain 4601 jedrzej.nowacki ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBjMTI2M2EzLi5kNzBkYjI3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjgg QEAKKzIwMDktMTItMTYgIEplZHJ6ZWogTm93YWNraSAgPGplZHJ6ZWoubm93YWNraUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFr ZSBiZXR0ZXIgc2VwYXJhdGlvbiBiZXR3ZWVuIGEgInB1YmxpYyIgYW5kIGEgInByaXZhdGUiIGNs YXNzZXMuCisgICAgICAgIAorICAgICAgICBUaGUgUUphdmFTY3JpcHQgQVBJIGltcGxlbWVudGF0 aW9uIGlzIHNtYWxsIGVub3VnaCB0byBrZWVwIGNsZWFyCisgICAgICAgIHNlcGFyYXRpb24gYmV0 d2VlbiBhICJwdWJsaWMiIGFuZCBhICJwcml2YXRlIiBjbGFzc2VzLiBGb3IgaW1wbGVtZW50YXRp b24KKyAgICAgICAgc2ltcGxpY2l0eSB3ZSBzaG91bGQgYXNzdW1lIHRoYXQgYSAicHVibGljIiBj bGFzcyBzaG91bGQgb25seQorICAgICAgICBwcm9wYWdhdGUgZnVuY3Rpb25zIGNhbGxzIGFuZCBj b252ZXJ0IGEgZGF0YSAoZnJvbSAicHJpdmF0ZSIgdG8KKyAgICAgICAgInB1YmxpYyIgYW5kIGZy b20gInB1YmxpYyIgdG8gInByaXZhdGUiKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBidWcgaXMg YSBwYXJ0IG9mIFFKYXZhU2NyaXB0IEFQSSBjb25zdHJ1Y3Rpb24gKGJ1ZyAzMTg2MykuCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNjA3CisKKyAg ICAgICAgKiBxdC9hcGkvcWphdmFzY3JpcHRlbmdpbmUuY3BwOgorICAgICAgICAoUUphdmFTY3Jp cHRFbmdpbmU6OmV2YWx1YXRlKToKKyAgICAgICAgKFFKYXZhU2NyaXB0RW5naW5lUHJpdmF0ZTo6 ZXZhbHVhdGUpOgorICAgICAgICAqIHF0L2FwaS9xamF2YXNjcmlwdGVuZ2luZV9wLmg6CisgICAg ICAgICogcXQvYXBpL3FqYXZhc2NyaXB0dmFsdWUuY3BwOgorICAgICAgICAoUUphdmFTY3JpcHRW YWx1ZTo6ZW5naW5lKToKKyAgICAgICAgKFFKYXZhU2NyaXB0VmFsdWVQcml2YXRlOjplbmdpbmUp OgorICAgICAgICAqIHF0L2FwaS9xamF2YXNjcmlwdHZhbHVlX3AuaDoKKwogMjAwOS0xMi0xNSAg SmVkcnplaiBOb3dhY2tpICA8amVkcnplai5ub3dhY2tpQG5va2lhLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3F0 L2FwaS9xamF2YXNjcmlwdGVuZ2luZS5jcHAgYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcWphdmFz Y3JpcHRlbmdpbmUuY3BwCmluZGV4IDNkYzQ5MWYuLjJhMGI3NmYgMTAwNzU1Ci0tLSBhL0phdmFT Y3JpcHRDb3JlL3F0L2FwaS9xamF2YXNjcmlwdGVuZ2luZS5jcHAKKysrIGIvSmF2YVNjcmlwdENv cmUvcXQvYXBpL3FqYXZhc2NyaXB0ZW5naW5lLmNwcApAQCAtOTUsMTcgKzk1LDE3IEBAIFFKYXZh U2NyaXB0RW5naW5lUHJpdmF0ZTo6flFKYXZhU2NyaXB0RW5naW5lUHJpdmF0ZSgpCiAvKiogRXZh bHVhdGVzIHByb2dyYW0gYW5kIHJldHVybnMgdGhlIHJlc3VsdCBvZiB0aGUgZXZhbHVhdGlvbi4g Ki8KIFFKYXZhU2NyaXB0VmFsdWUgUUphdmFTY3JpcHRFbmdpbmU6OmV2YWx1YXRlKGNvbnN0IFFT dHJpbmcmIHByb2dyYW0pCiB7Ci0gICAgcmV0dXJuIGRfcHRyLT5ldmFsdWF0ZShwcm9ncmFtKTsK KyAgICByZXR1cm4gUUphdmFTY3JpcHRWYWx1ZVByaXZhdGU6OmdldChkX3B0ci0+ZXZhbHVhdGUo cHJvZ3JhbSkpOwogfQogCiAvKiogRXZhbHVhdGVzIHByb2dyYW0gYW5kIHJldHVybnMgdGhlIHJl c3VsdCBvZiB0aGUgZXZhbHVhdGlvbi4KIEBpbnRlcm5hbAogKi8KLVFKYXZhU2NyaXB0VmFsdWUg UUphdmFTY3JpcHRFbmdpbmVQcml2YXRlOjpldmFsdWF0ZShjb25zdCBRU3RyaW5nJiBwcm9ncmFt KQorUUphdmFTY3JpcHRWYWx1ZVB0ciBRSmF2YVNjcmlwdEVuZ2luZVByaXZhdGU6OmV2YWx1YXRl KGNvbnN0IFFTdHJpbmcmIHByb2dyYW0pCiB7CiAgICAgSlNTdHJpbmdSZWYgc2NyaXB0ID0gcVN0 cmluZ1RvSlNTdHJpbmdSZWYocHJvZ3JhbSk7CiAgICAgSlNWYWx1ZVJlZiByZXN1bHQgPSBKU0V2 YWx1YXRlU2NyaXB0KG1fY29udGV4dCwgc2NyaXB0LCAwLCAwLCAwLCAwKTsKLSAgICByZXR1cm4g UUphdmFTY3JpcHRWYWx1ZVByaXZhdGU6OmdldChuZXcgUUphdmFTY3JpcHRWYWx1ZVByaXZhdGUo dGhpcywgcmVzdWx0KSk7CisgICAgcmV0dXJuIFFKYXZhU2NyaXB0VmFsdWVQdHIobmV3IFFKYXZh U2NyaXB0VmFsdWVQcml2YXRlKHRoaXMsIHJlc3VsdCkpOwogfQogCiAvKiogUnVucyB0aGUgZ2Fy YmFnZSBjb2xsZWN0b3IuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9xdC9hcGkvcWphdmFz Y3JpcHRlbmdpbmVfcC5oIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FqYXZhc2NyaXB0ZW5naW5l X3AuaAppbmRleCBhNjhhMDYwLi44MGNiMjdiIDEwMDc1NQotLS0gYS9KYXZhU2NyaXB0Q29yZS9x dC9hcGkvcWphdmFzY3JpcHRlbmdpbmVfcC5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3F0L2FwaS9x amF2YXNjcmlwdGVuZ2luZV9wLmgKQEAgLTIxLDEyICsyMSwxMiBAQAogI2RlZmluZSBRSkFWQVND UklQVEVOR0lORV9QX0gKIAogI2luY2x1ZGUgInFqYXZhc2NyaXB0ZW5naW5lLmgiCisjaW5jbHVk ZSAicWphdmFzY3JpcHR2YWx1ZS5oIgogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0phdmFTY3Jp cHQuaD4KICNpbmNsdWRlIDxRU2hhcmVkRGF0YT4KICNpbmNsdWRlIDxRU3RyaW5nPgogCiAKLWNs YXNzIFFKYXZhU2NyaXB0VmFsdWU7CiBjbGFzcyBRSmF2YVNjcmlwdEVuZ2luZTsKIAogY2xhc3Mg UUphdmFTY3JpcHRFbmdpbmVQcml2YXRlCkBAIC0zOCw3ICszOCw3IEBAIHB1YmxpYzoKIAogICAg IFFKYXZhU2NyaXB0RW5naW5lUHJpdmF0ZSgpOwogICAgIH5RSmF2YVNjcmlwdEVuZ2luZVByaXZh dGUoKTsKLSAgICBRSmF2YVNjcmlwdFZhbHVlIGV2YWx1YXRlKGNvbnN0IFFTdHJpbmcmKTsKKyAg ICBRSmF2YVNjcmlwdFZhbHVlUHRyIGV2YWx1YXRlKGNvbnN0IFFTdHJpbmcmKTsKICAgICB2b2lk IGNvbGxlY3RHYXJiYWdlKCk7CiAgICAgSlNHbG9iYWxDb250ZXh0UmVmIGNvbnRleHQoKSB7IHJl dHVybiBtX2NvbnRleHQ7IH0KIApkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3Fq YXZhc2NyaXB0dmFsdWUuY3BwIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3FqYXZhc2NyaXB0dmFs dWUuY3BwCmluZGV4IDE1ODQzMTguLjhmM2JiN2EgMTAwNzU1Ci0tLSBhL0phdmFTY3JpcHRDb3Jl L3F0L2FwaS9xamF2YXNjcmlwdHZhbHVlLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9xdC9hcGkv cWphdmFzY3JpcHR2YWx1ZS5jcHAKQEAgLTg0LDE2ICs4NCwxNiBAQCBRSmF2YVNjcmlwdFZhbHVl Ojp+UUphdmFTY3JpcHRWYWx1ZSgpCiBpcyBub3QgYXNzb2NpYXRlZCB3aXRoIGEgcGFydGljdWxh ciBlbmdpbmUsIGFuIGludmFsaWQgZW5naW5lIHdpbGwgYmUgcmV0dXJuZWQuICovCiBRSmF2YVNj cmlwdEVuZ2luZSBRSmF2YVNjcmlwdFZhbHVlOjplbmdpbmUoKQogewotICAgIHJldHVybiBkX3B0 ci0+ZW5naW5lKCk7CisgICAgcmV0dXJuIFFKYXZhU2NyaXB0RW5naW5lUHJpdmF0ZTo6Z2V0KGRf cHRyLT5lbmdpbmUoKSk7CiB9CiAKIC8qKiBSZXR1cm4gUUphdmFTY3JpcHRFbmdpbmUgYXNzb3Np YXRlZCB3aXRoIHRoZSB2YWx1ZS4gSWYgdGhpcyBRU2NyaXB0VmFsdWUgaXMgaW52YWxpZCBvciB0 aGUgdmFsdWUKIGlzIG5vdCBhc3NvY2lhdGVkIHdpdGggYSBwYXJ0aWN1bGFyIGVuZ2luZSwgYW4g aW52YWxpZCBlbmdpbmUgd2lsbCBiZSByZXR1cm5lZC4KIEBpbnRlcm5hbAogKi8KLVFKYXZhU2Ny aXB0RW5naW5lIFFKYXZhU2NyaXB0VmFsdWVQcml2YXRlOjplbmdpbmUoKQorUUphdmFTY3JpcHRF bmdpbmVQdHIgUUphdmFTY3JpcHRWYWx1ZVByaXZhdGU6OmVuZ2luZSgpCiB7Ci0gICAgcmV0dXJu IFFKYXZhU2NyaXB0RW5naW5lUHJpdmF0ZTo6Z2V0KG1fZW5naW5lKTsKKyAgICByZXR1cm4gbV9l bmdpbmU7CiB9CiAKIC8qKiBSZXR1cm5zIHRydWUgaWYgdGhpcyBRU2NyaXB0VmFsdWUgaXMgdmFs aWQ7IG90aGVyd2lzZSByZXR1cm5zIGZhbHNlLiAqLwpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENv cmUvcXQvYXBpL3FqYXZhc2NyaXB0dmFsdWVfcC5oIGIvSmF2YVNjcmlwdENvcmUvcXQvYXBpL3Fq YXZhc2NyaXB0dmFsdWVfcC5oCmluZGV4IDg4ZTYxYjguLjc0OThkYWMgMTAwNzU1Ci0tLSBhL0ph dmFTY3JpcHRDb3JlL3F0L2FwaS9xamF2YXNjcmlwdHZhbHVlX3AuaAorKysgYi9KYXZhU2NyaXB0 Q29yZS9xdC9hcGkvcWphdmFzY3JpcHR2YWx1ZV9wLmgKQEAgLTU0LDcgKzU0LDcgQEAgcHVibGlj OgogICAgICAgICAsIG1fdmFsaWQodHJ1ZSkKICAgICB7fQogCi0gICAgUUphdmFTY3JpcHRFbmdp bmUgZW5naW5lKCk7CisgICAgUUphdmFTY3JpcHRFbmdpbmVQdHIgZW5naW5lKCk7CiAgICAgYm9v bCBpc1ZhbGlkKCk7CiAKICAgICBRU3RyaW5nIHRvUVN0cmluZygpOwo=