32598 2009-12-16 00:02:10 -0800 Flakiness in WebSocket handshake console message 2009-12-16 22:27:08 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ukai webkit-unassigned ap eric webkit.review.bot oldest_to_newest 172193 0 ukai 2009-12-16 00:02:10 -0800 In chromium port, handshake-error.html may outputs 3 lines of CONSOLE MESSAGE: line 0: Unexpected response code:101 172204 1 44952 ukai 2009-12-16 00:20:15 -0800 Created attachment 44952 Fix flakiness in WebSocket handshake console message. 172207 2 webkit.review.bot 2009-12-16 00:25:06 -0800 style-queue ran check-webkit-style on attachment 44952 without any errors. 172633 3 44952 ap 2009-12-16 21:16:55 -0800 Comment on attachment 44952 Fix flakiness in WebSocket handshake console message. r=me Is it be possible to make a reliable test for this? That would involve sending a large response that no reasonable implementation would coalesce into one didReceiveData call. 172641 4 ukai 2009-12-16 22:19:22 -0800 Committed r52234: <http://trac.webkit.org/changeset/52234> 172642 5 ukai 2009-12-16 22:27:08 -0800 (In reply to comment #3) > (From update of attachment 44952 [details]) > r=me > > Is it be possible to make a reliable test for this? That would involve sending > a large response that no reasonable implementation would coalesce into one > didReceiveData call. I think it would be difficult to make a reliable test. It must send several chunks for handshake response header and each chunk should be delivered as following order - first chunk. containing first line with bad response code, but not finished whole handshake message - bad response code, so it closes the SocketStreamHandle. - before didClose comes, it receives second chunk, which would be already queued while it is processing the first chunk. 44952 2009-12-16 00:20:15 -0800 2009-12-16 21:16:54 -0800 Fix flakiness in WebSocket handshake console message. bug-32598-20091216172013.patch text/plain 5081 ukai ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTZhMmE0Yi4uZThhNGFmMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAwOS0xMi0xNiAgRnVtaXRvc2hpIFVr YWkgIDx1a2FpQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggZmxha2luZXNzIGluIFdlYlNvY2tldCBoYW5kc2hha2UgY29u c29sZSBtZXNzYWdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzI1OTgKKworICAgICAgICBJbiBjaHJvbWl1bSwgTGF5b3V0VGVzdHMvd2Vic29ja2V0 L3Rlc3RzL2hhbmRzaGFrZS1lcnJvci5odG1sIGlzCisgICAgICAgIGZsYWt5LCBiZWNhdXNlIGl0 IG91dHB1dHMgdGhlIGZvbGxvd2luZyBjb25zb2xlIG1lc3NhZ2Ugc2V2ZXJhbCB0aW1lczoKKyAg ICAgICAgICBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMDogVW5leHBlY3RlZCByZXNwb25zZSBjb2Rl OjEwMQorICAgICAgICBVcGRhdGUgbV9tb2RlIGluIFdlYlNvY2tldEhhbmRzaGFrZSBjb3JyZWN0 bHk6IE9uY2UgaXQgZmluZHMKKyAgICAgICAgZXJyb3IgaW4gaGFuZHNoYWtlIG1lc3NhZ2UsIHNl dCBtX21vZGUgdG8gRmFpbGVkIGFuZCBkb24ndCB0cnkKKyAgICAgICAgcmVhZGluZyBoYW5kc2hh a2UgbWVzc2FnZSBhZ2Fpbi4gIElmIGhhbmRzaGFrZSBtZXNzYWdlIGlzIG5vdCB5ZXQKKyAgICAg ICAgZnVsbHkgcmVjZWl2ZWQsIHNldCBtX21vZGUgdG8gSW5jb21wbGV0ZSwgc28gbmV4dCBkaWRS ZWNlaXZlRGF0YSgpCisgICAgICAgIHdpbGwgdHJ5IHRvIGNoZWNrIGhhbmRzaGFrZSBtZXNzYWdl IGFnYWluLgorCisgICAgICAgICogd2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OldlYlNvY2tldENoYW5uZWw6OmRpZFJlY2VpdmVEYXRhKToKKyAgICAg ICAgKiB3ZWJzb2NrZXRzL1dlYlNvY2tldEhhbmRzaGFrZS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpXZWJTb2NrZXRIYW5kc2hha2U6OnJlYWRTZXJ2ZXJIYW5kc2hha2UpOgorCiAyMDA5LTEyLTEz ICBSb2xhbmQgU3RlaW5lciAgPHJvbGFuZHN0ZWluZXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3dlYnNvY2tldHMv V2ViU29ja2V0Q2hhbm5lbC5jcHAgYi9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5l bC5jcHAKaW5kZXggMDdiNjNkMS4uNWMwZjRjMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS93ZWJzb2Nr ZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCisrKyBiL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2Nr ZXRDaGFubmVsLmNwcApAQCAtMTUwLDcgKzE1MCw3IEBAIHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6 ZGlkUmVjZWl2ZURhdGEoU29ja2V0U3RyZWFtSGFuZGxlKiBoYW5kbGUsIGNvbnN0IGNoYXIqIGRh CiAgICAgICAgIGhhbmRsZS0+Y2xvc2UoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSAgICBp ZiAobV9oYW5kc2hha2UubW9kZSgpICE9IFdlYlNvY2tldEhhbmRzaGFrZTo6Q29ubmVjdGVkKSB7 CisgICAgaWYgKG1faGFuZHNoYWtlLm1vZGUoKSA9PSBXZWJTb2NrZXRIYW5kc2hha2U6OkluY29t cGxldGUpIHsKICAgICAgICAgaW50IGhlYWRlckxlbmd0aCA9IG1faGFuZHNoYWtlLnJlYWRTZXJ2 ZXJIYW5kc2hha2UobV9idWZmZXIsIG1fYnVmZmVyU2l6ZSk7CiAgICAgICAgIGlmIChoZWFkZXJM ZW5ndGggPD0gMCkKICAgICAgICAgICAgIHJldHVybjsKQEAgLTE3OSw2ICsxNzksOCBAQCB2b2lk IFdlYlNvY2tldENoYW5uZWw6OmRpZFJlY2VpdmVEYXRhKFNvY2tldFN0cmVhbUhhbmRsZSogaGFu ZGxlLCBjb25zdCBjaGFyKiBkYQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICBMT0coTmV0 d29yaywgInJlbWFpbmluZyBpbiByZWFkIGJ1ZiAldWwiLCBtX2J1ZmZlclNpemUpOwogICAgIH0K KyAgICBpZiAobV9oYW5kc2hha2UubW9kZSgpICE9IFdlYlNvY2tldEhhbmRzaGFrZTo6Q29ubmVj dGVkKQorICAgICAgICByZXR1cm47CiAKICAgICBjb25zdCBjaGFyKiBuZXh0RnJhbWUgPSBtX2J1 ZmZlcjsKICAgICBjb25zdCBjaGFyKiBwID0gbV9idWZmZXI7CmRpZmYgLS1naXQgYS9XZWJDb3Jl L3dlYnNvY2tldHMvV2ViU29ja2V0SGFuZHNoYWtlLmNwcCBiL1dlYkNvcmUvd2Vic29ja2V0cy9X ZWJTb2NrZXRIYW5kc2hha2UuY3BwCmluZGV4IGMyMWQxZDcuLmE1NjhjMmIgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXRIYW5kc2hha2UuY3BwCisrKyBiL1dlYkNvcmUv d2Vic29ja2V0cy9XZWJTb2NrZXRIYW5kc2hha2UuY3BwCkBAIC0yMjAsMTQgKzIyMCwxNyBAQCBp bnQgV2ViU29ja2V0SGFuZHNoYWtlOjpyZWFkU2VydmVySGFuZHNoYWtlKGNvbnN0IGNoYXIqIGhl YWRlciwgc2l6ZV90IGxlbikKICAgICAgICAgICAgIHJldHVybiAtMTsKICAgICAgICAgfQogICAg ICAgICBpZiAoY29kZS5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAgIG1fbW9kZSA9IEZhaWxlZDsK ICAgICAgICAgICAgIG1fY29udGV4dC0+YWRkTWVzc2FnZShDb25zb2xlRGVzdGluYXRpb24sIEpT TWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUsIEVycm9yTWVzc2FnZUxldmVsLCAiTm8gcmVz cG9uc2UgY29kZSBmb3VuZDogIiArIFN0cmluZyhoZWFkZXIsIGxlbiksIDAsIGNsaWVudE9yaWdp bigpKTsKICAgICAgICAgICAgIHJldHVybiBsZW47CiAgICAgICAgIH0KICAgICAgICAgTE9HKE5l dHdvcmssICJyZXNwb25zZSBjb2RlOiAlcyIsIGNvZGUudXRmOCgpLmRhdGEoKSk7CiAgICAgICAg IGlmIChjb2RlID09ICI0MDEiKSB7CisgICAgICAgICAgICBtX21vZGUgPSBGYWlsZWQ7CiAgICAg ICAgICAgICBtX2NvbnRleHQtPmFkZE1lc3NhZ2UoQ29uc29sZURlc3RpbmF0aW9uLCBKU01lc3Nh Z2VTb3VyY2UsIExvZ01lc3NhZ2VUeXBlLCBFcnJvck1lc3NhZ2VMZXZlbCwgIkF1dGhlbnRpY2F0 aW9uIHJlcXVpcmVkLCBidXQgbm90IGltcGxlbWVudGVkIHlldC4iLCAwLCBjbGllbnRPcmlnaW4o KSk7CiAgICAgICAgICAgICByZXR1cm4gbGVuOwogICAgICAgICB9IGVsc2UgeworICAgICAgICAg ICAgbV9tb2RlID0gRmFpbGVkOwogICAgICAgICAgICAgbV9jb250ZXh0LT5hZGRNZXNzYWdlKENv bnNvbGVEZXN0aW5hdGlvbiwgSlNNZXNzYWdlU291cmNlLCBMb2dNZXNzYWdlVHlwZSwgRXJyb3JN ZXNzYWdlTGV2ZWwsICJVbmV4cGVjdGVkIHJlc3BvbnNlIGNvZGU6IiArIGNvZGUsIDAsIGNsaWVu dE9yaWdpbigpKTsKICAgICAgICAgICAgIHJldHVybiBsZW47CiAgICAgICAgIH0KQEAgLTIzNywx OCArMjQwLDI0IEBAIGludCBXZWJTb2NrZXRIYW5kc2hha2U6OnJlYWRTZXJ2ZXJIYW5kc2hha2Uo Y29uc3QgY2hhciogaGVhZGVyLCBzaXplX3QgbGVuKQogCiAgICAgaWYgKG1fbW9kZSA9PSBOb3Jt YWwpIHsKICAgICAgICAgc2l6ZV90IGhlYWRlclNpemUgPSBlbmQgLSBwOwotICAgICAgICBpZiAo aGVhZGVyU2l6ZSA8IHNpemVvZih3ZWJTb2NrZXRVcGdyYWRlSGVhZGVyKSAtIDEpCisgICAgICAg IGlmIChoZWFkZXJTaXplIDwgc2l6ZW9mKHdlYlNvY2tldFVwZ3JhZGVIZWFkZXIpIC0gMSkgewor ICAgICAgICAgICAgbV9tb2RlID0gSW5jb21wbGV0ZTsKICAgICAgICAgICAgIHJldHVybiAwOwor ICAgICAgICB9CiAgICAgICAgIGlmIChtZW1jbXAocCwgd2ViU29ja2V0VXBncmFkZUhlYWRlciwg c2l6ZW9mKHdlYlNvY2tldFVwZ3JhZGVIZWFkZXIpIC0gMSkpIHsKKyAgICAgICAgICAgIG1fbW9k ZSA9IEZhaWxlZDsKICAgICAgICAgICAgIG1fY29udGV4dC0+YWRkTWVzc2FnZShDb25zb2xlRGVz dGluYXRpb24sIEpTTWVzc2FnZVNvdXJjZSwgTG9nTWVzc2FnZVR5cGUsIEVycm9yTWVzc2FnZUxl dmVsLCAiQmFkIFVwZ3JhZGUgaGVhZGVyOiAiICsgU3RyaW5nKHAsIGVuZCAtIHApLCAwLCBjbGll bnRPcmlnaW4oKSk7CiAgICAgICAgICAgICByZXR1cm4gcCAtIGhlYWRlciArIHNpemVvZih3ZWJT b2NrZXRVcGdyYWRlSGVhZGVyKSAtIDE7CiAgICAgICAgIH0KICAgICAgICAgcCArPSBzaXplb2Yo d2ViU29ja2V0VXBncmFkZUhlYWRlcikgLSAxOwogCiAgICAgICAgIGhlYWRlclNpemUgPSBlbmQg LSBwOwotICAgICAgICBpZiAoaGVhZGVyU2l6ZSA8IHNpemVvZih3ZWJTb2NrZXRDb25uZWN0aW9u SGVhZGVyKSAtIDEpCisgICAgICAgIGlmIChoZWFkZXJTaXplIDwgc2l6ZW9mKHdlYlNvY2tldENv bm5lY3Rpb25IZWFkZXIpIC0gMSkgeworICAgICAgICAgICAgbV9tb2RlID0gSW5jb21wbGV0ZTsK ICAgICAgICAgICAgIHJldHVybiAtMTsKKyAgICAgICAgfQogICAgICAgICBpZiAobWVtY21wKHAs IHdlYlNvY2tldENvbm5lY3Rpb25IZWFkZXIsIHNpemVvZih3ZWJTb2NrZXRDb25uZWN0aW9uSGVh ZGVyKSAtIDEpKSB7CisgICAgICAgICAgICBtX21vZGUgPSBGYWlsZWQ7CiAgICAgICAgICAgICBt X2NvbnRleHQtPmFkZE1lc3NhZ2UoQ29uc29sZURlc3RpbmF0aW9uLCBKU01lc3NhZ2VTb3VyY2Us IExvZ01lc3NhZ2VUeXBlLCBFcnJvck1lc3NhZ2VMZXZlbCwgIkJhZCBDb25uZWN0aW9uIGhlYWRl cjogIiArIFN0cmluZyhwLCBlbmQgLSBwKSwgMCwgY2xpZW50T3JpZ2luKCkpOwogICAgICAgICAg ICAgcmV0dXJuIHAgLSBoZWFkZXIgKyBzaXplb2Yod2ViU29ja2V0Q29ubmVjdGlvbkhlYWRlcikg LSAxOwogICAgICAgICB9CkBAIC0yNTcsNiArMjY2LDcgQEAgaW50IFdlYlNvY2tldEhhbmRzaGFr ZTo6cmVhZFNlcnZlckhhbmRzaGFrZShjb25zdCBjaGFyKiBoZWFkZXIsIHNpemVfdCBsZW4pCiAK ICAgICBpZiAoIXN0cm5zdHIocCwgIlxyXG5cclxuIiwgZW5kIC0gcCkpIHsKICAgICAgICAgLy8g SnVzdCBoYXNuJ3QgYmVlbiByZWNlaXZlZCBmdWxseSB5ZXQuCisgICAgICAgIG1fbW9kZSA9IElu Y29tcGxldGU7CiAgICAgICAgIHJldHVybiAtMTsKICAgICB9CiAgICAgSFRUUEhlYWRlck1hcCBo ZWFkZXJzOwo=