32582 2009-12-15 14:33:00 -0800 svn-create-patch should print a warning for large patches 2010-04-09 16:19:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P4 Normal --- 1 cjerdonek zoltan ap dbates eric zoltan oldest_to_newest 172045 0 cjerdonek 2009-12-15 14:33:00 -0800 The svn-create-patch script should display a warning for large patches (e.g. > 20K). This idea is inspired by the following suggestion to modify bugs.webkit.org: https://bugs.webkit.org/show_bug.cgi?id=25877 200691 1 50895 zoltan 2010-03-17 04:55:27 -0700 Created attachment 50895 Patch 200809 2 50895 darin 2010-03-17 08:42:04 -0700 Comment on attachment 50895 Patch > Larger patches than 20k are unlikely to be reviewed! I've reviewed hundreds of patches that are >20k and had hundreds of >20k patches reviewed, so the phrase above is overstating the case. Maybe we can word a more positive way and be precise: "Patches 20k or smaller are more likely to be reviewed. Larger patches may sit unreviewed for a long time." 200823 3 50913 zoltan 2010-03-17 09:21:57 -0700 Created attachment 50913 Patch 200824 4 zoltan 2010-03-17 09:23:41 -0700 Yes, it sounds much friendly. I filed the new patch. 203580 5 dbates 2010-03-24 14:27:02 -0700 For your consideration, maybe the message should explicitly suggest that the person split up their patch into smaller sized patches, such as: "Note, this patch is larger than 20 KB. Consider separating this patch into smaller patches that are more manageable to review." 203864 6 50913 eric 2010-03-25 00:30:03 -0700 Comment on attachment 50913 Patch Recommending people break up their patches is good. But this looks OK. 203957 7 50913 zoltan 2010-03-25 02:47:06 -0700 Comment on attachment 50913 Patch Clearing flags on attachment: 50913 Committed r56524: <http://trac.webkit.org/changeset/56524> 203958 8 zoltan 2010-03-25 02:47:15 -0700 All reviewed patches have been landed. Closing bug. 210994 9 53008 zoltan 2010-04-09 15:55:51 -0700 Created attachment 53008 fix 2 issues patch Fix 2 issues what was introduced by the change. 210995 10 53008 darin 2010-04-09 15:57:14 -0700 Comment on attachment 53008 fix 2 issues patch > Index: WebKitTools/Scripts/svn-create-patch > =================================================================== > --- WebKitTools/Scripts/svn-create-patch (revision 57374) > +++ WebKitTools/Scripts/svn-create-patch (working copy) > @@ -218,10 +218,10 @@ > my $file = File::Spec->catdir($prefix, $fileData->{path}); > > if ($ignoreChangelogs && basename($file) eq "ChangeLog") { > - return; > + return 0; > } > > - my $patch; > + my $patch = ""; > if ($fileData->{modificationType} eq "additionWithHistory") { > manufacturePatchForAdditionWithHistory($fileData); > } > @@ -233,7 +233,7 @@ > } > close DIFF; > $patch = fixChangeLogPatch($patch) if basename($file) eq "ChangeLog"; > - print $patch if $patch; > + This used to say "print $patch" and now does nothing! Can that really be right? 210997 11 53008 ap 2010-04-09 16:03:45 -0700 Comment on attachment 53008 fix 2 issues patch > - print $patch if $patch; > + I don't see how this can be correct - some code needs to print the patch. 211003 12 53012 zoltan 2010-04-09 16:09:59 -0700 Created attachment 53012 fix 2 issues patch vol2. 211010 13 53012 ap 2010-04-09 16:15:56 -0700 Comment on attachment 53012 fix 2 issues patch vol2. r=me 211011 14 53012 zoltan 2010-04-09 16:19:07 -0700 Comment on attachment 53012 fix 2 issues patch vol2. Clearing flags on attachment: 53012 Committed r57380: <http://trac.webkit.org/changeset/57380> 211012 15 zoltan 2010-04-09 16:19:17 -0700 All reviewed patches have been landed. Closing bug. 50895 2010-03-17 04:55:27 -0700 2010-03-17 09:21:52 -0700 Patch bug-32582-20100317125524.patch text/plain 1586 zoltan SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU2MTA0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMTcgIFpvbHRhbiBIb3J2YXRoICA8 em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgc3ZuLWNyZWF0ZS1wYXRjaCBwcmludHMgYSB3YXJuaW5nIGZvciBsYXJnZSBw YXRjaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MjU4MgorCisgICAgICAgIHN2bi1jcmVhdGUtcGF0Y2ggcHJpbnRzIGEgd2FybmluZyBtZXNzYWdl IGZvciBsYXJnZXIgcGF0Y2hlcyB0aGFuIDIway4KKworICAgICAgICAqIFNjcmlwdHMvc3ZuLWNy ZWF0ZS1wYXRjaDoKKwogMjAxMC0wMy0xNiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCiAgICAgICAgIE5vIHJldmlldywgcm9sbGluZyBvdXQgcjU2MDQ0LgpJbmRleDogV2ViS2l0 VG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xz L1NjcmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaAkocmV2aXNpb24gNTYxMDMpCisrKyBXZWJLaXRUb29s cy9TY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2gJKHdvcmtpbmcgY29weSkKQEAgLTEwMSw5ICsxMDEs MTUgQEAgZm9yIG15ICRwYXRoIChrZXlzICVwYXRocykgewogbXkgJHN2blJvb3QgPSBkZXRlcm1p bmVTVk5Sb290KCk7CiBteSAkcHJlZml4ID0gY2hkaXJSZXR1cm5pbmdSZWxhdGl2ZVBhdGgoJHN2 blJvb3QpOwogCitteSAkcGF0Y2hTaXplID0gMDsKKwogIyBHZW5lcmF0ZSB0aGUgZGlmZnMsIGlu IGEgb3JkZXIgY2hvc2VuIGZvciBlYXN5IHJldmlld2luZy4KIGZvciBteSAkcGF0aCAoc29ydCBw YXRjaHBhdGhjbXAgdmFsdWVzICVkaWZmRmlsZXMpIHsKLSAgICBnZW5lcmF0ZURpZmYoJHBhdGgs ICRwcmVmaXgpOworICAgICRwYXRjaFNpemUgKz0gZ2VuZXJhdGVEaWZmKCRwYXRoLCAkcHJlZml4 KTsKK30KKworaWYgKCRwYXRjaFNpemUgPiAyMDQ4MCkgeworICAgIHByaW50IFNUREVSUiAiV0FS TklORzogUGF0Y2gncyBzaXplIGlzICIgLiBpbnQoJHBhdGNoU2l6ZS8xMDI0KSAuICIga2J5dGVz LiBMYXJnZXIgcGF0Y2hlcyB0aGFuIDIwayBhcmUgdW5saWtlbHkgdG8gYmUgcmV2aWV3ZWQhXG4i OwogfQogCiBleGl0IDA7CkBAIC0yMzEsNiArMjM3LDcgQEAgc3ViIGdlbmVyYXRlRGlmZigkJCkK ICAgICAgICAgcHJpbnQgIlxuIiBpZiAoJHBhdGNoICYmICRwYXRjaCA9fiBtL1xuXFMrJC9tKTsK ICAgICAgICAgb3V0cHV0QmluYXJ5Q29udGVudCgkZmlsZSk7CiAgICAgfQorICAgIHJldHVybiBs ZW5ndGgoJHBhdGNoKTsKIH0KIAogc3ViIGdlbmVyYXRlRmlsZUxpc3QoJFwlKQo= 50913 2010-03-17 09:21:57 -0700 2010-04-09 15:55:51 -0700 Patch bug-32582-20100317172155.patch text/plain 1660 zoltan SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU2MTEzKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDMtMTcgIFpvbHRhbiBIb3J2YXRoICA8 em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgc3ZuLWNyZWF0ZS1wYXRjaCBwcmludHMgYSB3YXJuaW5nIGZvciBsYXJnZSBw YXRjaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MjU4MgorCisgICAgICAgIHN2bi1jcmVhdGUtcGF0Y2ggcHJpbnRzIGEgd2FybmluZyBtZXNzYWdl IGZvciBsYXJnZXIgcGF0Y2hlcyB0aGFuIDIway4KKworICAgICAgICAqIFNjcmlwdHMvc3ZuLWNy ZWF0ZS1wYXRjaDoKKwogMjAxMC0wMy0xNyAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYktpdFRv b2xzL1NjcmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9T Y3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2gJKHJldmlzaW9uIDU2MTEzKQorKysgV2ViS2l0VG9vbHMv U2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCSh3b3JraW5nIGNvcHkpCkBAIC0xMDEsOSArMTAxLDE2 IEBAIGZvciBteSAkcGF0aCAoa2V5cyAlcGF0aHMpIHsKIG15ICRzdm5Sb290ID0gZGV0ZXJtaW5l U1ZOUm9vdCgpOwogbXkgJHByZWZpeCA9IGNoZGlyUmV0dXJuaW5nUmVsYXRpdmVQYXRoKCRzdm5S b290KTsKIAorbXkgJHBhdGNoU2l6ZSA9IDA7CisKICMgR2VuZXJhdGUgdGhlIGRpZmZzLCBpbiBh IG9yZGVyIGNob3NlbiBmb3IgZWFzeSByZXZpZXdpbmcuCiBmb3IgbXkgJHBhdGggKHNvcnQgcGF0 Y2hwYXRoY21wIHZhbHVlcyAlZGlmZkZpbGVzKSB7Ci0gICAgZ2VuZXJhdGVEaWZmKCRwYXRoLCAk cHJlZml4KTsKKyAgICAkcGF0Y2hTaXplICs9IGdlbmVyYXRlRGlmZigkcGF0aCwgJHByZWZpeCk7 Cit9CisKK2lmICgkcGF0Y2hTaXplID4gMjA0ODApIHsKKyAgICBwcmludCBTVERFUlIgIldBUk5J Tkc6IFBhdGNoJ3Mgc2l6ZSBpcyAiIC4gaW50KCRwYXRjaFNpemUvMTAyNCkgLiAiIGtieXRlcy5c biI7CisgICAgcHJpbnQgU1RERVJSICJQYXRjaGVzIDIwayBvciBzbWFsbGVyIGFyZSBtb3JlIGxp a2VseSB0byBiZSByZXZpZXdlZC4gTGFyZ2VyIHBhdGNoZXMgbWF5IHNpdCB1bnJldmlld2VkIGZv ciBhIGxvbmcgdGltZS5cbiI7CiB9CiAKIGV4aXQgMDsKQEAgLTIzMSw2ICsyMzgsNyBAQCBzdWIg Z2VuZXJhdGVEaWZmKCQkKQogICAgICAgICBwcmludCAiXG4iIGlmICgkcGF0Y2ggJiYgJHBhdGNo ID1+IG0vXG5cUyskL20pOwogICAgICAgICBvdXRwdXRCaW5hcnlDb250ZW50KCRmaWxlKTsKICAg ICB9CisgICAgcmV0dXJuIGxlbmd0aCgkcGF0Y2gpOwogfQogCiBzdWIgZ2VuZXJhdGVGaWxlTGlz dCgkXCUpCg== 53008 2010-04-09 15:55:51 -0700 2010-04-09 16:09:59 -0700 fix 2 issues patch svncreatefix.patch text/plain 1543 zoltan SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9TY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2gJKHJldmlzaW9uIDU3Mzc0KQor KysgV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCSh3b3JraW5nIGNvcHkpCkBA IC0yMTgsMTAgKzIxOCwxMCBAQAogICAgIG15ICRmaWxlID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKCRw cmVmaXgsICRmaWxlRGF0YS0+e3BhdGh9KTsKICAgICAKICAgICBpZiAoJGlnbm9yZUNoYW5nZWxv Z3MgJiYgYmFzZW5hbWUoJGZpbGUpIGVxICJDaGFuZ2VMb2ciKSB7Ci0gICAgICAgIHJldHVybjsK KyAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogICAgIAotICAgIG15ICRwYXRjaDsKKyAgICBteSAk cGF0Y2ggPSAiIjsKICAgICBpZiAoJGZpbGVEYXRhLT57bW9kaWZpY2F0aW9uVHlwZX0gZXEgImFk ZGl0aW9uV2l0aEhpc3RvcnkiKSB7CiAgICAgICAgIG1hbnVmYWN0dXJlUGF0Y2hGb3JBZGRpdGlv bldpdGhIaXN0b3J5KCRmaWxlRGF0YSk7CiAgICAgfQpAQCAtMjMzLDcgKzIzMyw3IEBACiAgICAg fQogICAgIGNsb3NlIERJRkY7CiAgICAgJHBhdGNoID0gZml4Q2hhbmdlTG9nUGF0Y2goJHBhdGNo KSBpZiBiYXNlbmFtZSgkZmlsZSkgZXEgIkNoYW5nZUxvZyI7Ci0gICAgcHJpbnQgJHBhdGNoIGlm ICRwYXRjaDsKKyAgICAKICAgICBpZiAoJGZpbGVEYXRhLT57aXNCaW5hcnl9KSB7CiAgICAgICAg IHByaW50ICJcbiIgaWYgKCRwYXRjaCAmJiAkcGF0Y2ggPX4gbS9cblxTKyQvbSk7CiAgICAgICAg IG91dHB1dEJpbmFyeUNvbnRlbnQoJGZpbGUpOwpJbmRleDogV2ViS2l0VG9vbHMvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNTczNzQpCisr KyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAor MjAxMC0wNC0wOSAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggMiBpc3N1ZXMgKHdo YXQgd2VyZSBpbnRyb2R1Y2VkIGluIHI1NjUyNCkgaW4gc3ZuLWNyZWF0ZS1wYXRjaCdzIGdlbmVy YXRlRGlmZigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMjU4MgorCisgICAgICAgIEFkZCBtaXNzaW5nIHJldHVybiB2YXJpYWJsZS4gSW5pdGlhbGl6 ZSAkcGF0Y2ggdmFyaWFibGUgYW5kIHJlbW92ZSB1bm5lY2Vzc2FyeSBjb25kaXRpb24uCisKKyAg ICAgICAgKiBTY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2g6CisKIDIwMTAtMDQtMDkgIFNhbSBXZWlu aWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNz b24uCg== 53012 2010-04-09 16:09:59 -0700 2010-04-09 16:19:07 -0700 fix 2 issues patch vol2. svncreatefix.patch text/plain 1556 zoltan SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvc3ZuLWNyZWF0ZS1wYXRjaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXRUb29scy9TY3JpcHRzL3N2bi1jcmVhdGUtcGF0Y2gJKHJldmlzaW9uIDU3Mzc0KQor KysgV2ViS2l0VG9vbHMvU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoCSh3b3JraW5nIGNvcHkpCkBA IC0yMTgsMTAgKzIxOCwxMCBAQAogICAgIG15ICRmaWxlID0gRmlsZTo6U3BlYy0+Y2F0ZGlyKCRw cmVmaXgsICRmaWxlRGF0YS0+e3BhdGh9KTsKICAgICAKICAgICBpZiAoJGlnbm9yZUNoYW5nZWxv Z3MgJiYgYmFzZW5hbWUoJGZpbGUpIGVxICJDaGFuZ2VMb2ciKSB7Ci0gICAgICAgIHJldHVybjsK KyAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogICAgIAotICAgIG15ICRwYXRjaDsKKyAgICBteSAk cGF0Y2ggPSAiIjsKICAgICBpZiAoJGZpbGVEYXRhLT57bW9kaWZpY2F0aW9uVHlwZX0gZXEgImFk ZGl0aW9uV2l0aEhpc3RvcnkiKSB7CiAgICAgICAgIG1hbnVmYWN0dXJlUGF0Y2hGb3JBZGRpdGlv bldpdGhIaXN0b3J5KCRmaWxlRGF0YSk7CiAgICAgfQpAQCAtMjMzLDcgKzIzMyw3IEBACiAgICAg fQogICAgIGNsb3NlIERJRkY7CiAgICAgJHBhdGNoID0gZml4Q2hhbmdlTG9nUGF0Y2goJHBhdGNo KSBpZiBiYXNlbmFtZSgkZmlsZSkgZXEgIkNoYW5nZUxvZyI7Ci0gICAgcHJpbnQgJHBhdGNoIGlm ICRwYXRjaDsKKyAgICBwcmludCAkcGF0Y2g7CiAgICAgaWYgKCRmaWxlRGF0YS0+e2lzQmluYXJ5 fSkgewogICAgICAgICBwcmludCAiXG4iIGlmICgkcGF0Y2ggJiYgJHBhdGNoID1+IG0vXG5cUysk L20pOwogICAgICAgICBvdXRwdXRCaW5hcnlDb250ZW50KCRmaWxlKTsKSW5kZXg6IFdlYktpdFRv b2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlz aW9uIDU3Mzc0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTAtMDQtMDkgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4 IDIgaXNzdWVzICh3aGF0IHdlcmUgaW50cm9kdWNlZCBpbiByNTY1MjQpIGluIHN2bi1jcmVhdGUt cGF0Y2gncyBnZW5lcmF0ZURpZmYoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzI1ODIKKworICAgICAgICBBZGQgbWlzc2luZyByZXR1cm4gdmFyaWFi bGUuIEluaXRpYWxpemUgJHBhdGNoIHZhcmlhYmxlIGFuZCByZW1vdmUgdW5uZWNlc3NhcnkgY29u ZGl0aW9uLgorCisgICAgICAgICogU2NyaXB0cy9zdm4tY3JlYXRlLXBhdGNoOgorCiAyMDEwLTA0 LTA5ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QW5kZXJzIENhcmxzc29uLgo=