32578 2009-12-15 13:27:10 -0800 Web Inspector: No Need for ?="" now that we have context menus 2009-12-15 13:37:04 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein bweinstein joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 171998 0 bweinstein 2009-12-15 13:27:10 -0800 In the Elements Tree Outline, we needed a way to add new attributes, so we had ?="" show up on mouseover, so the user could double click. Now that we have context menus with an "Add Attribute" item, we don't need this anymore. 172001 1 44905 bweinstein 2009-12-15 13:31:37 -0800 Created attachment 44905 [PATCH] Fix 172002 2 bweinstein 2009-12-15 13:37:04 -0800 Landed in r52168. 44905 2009-12-15 13:31:37 -0800 2009-12-15 13:35:08 -0800 [PATCH] Fix no_new_attr_hover.patch text/plain 3761 bweinstein SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjE2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTItMTUgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeGVzIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI1Nzg+ LgorICAgICAgICBXZWIgSW5zcGVjdG9yOiBObyBOZWVkIGZvciA/PSIiIG5vdyB0aGF0IHdlIGhh dmUgY29udGV4dCBtZW51cy4KKyAgICAgICAgCisgICAgICAgIFJlbW92ZSB0aGUgdG9nZ2xlTmV3 QXR0cmlidXRlQnV0dG9uIGZ1bmN0aW9uIGFuZCBjYWxsZXJzIHRvIGl0LCBhcworICAgICAgICB3 ZSBkb24ndCBuZWVkIHRoaXMgYmVoYXZpb3IgYW55bW9yZSwgbm93IHRoYXQgd2UgaGF2ZSBjb250 ZXh0IG1lbnVzLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1RyZWVP dXRsaW5lLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJv dG90eXBlLnNldCBob3ZlcmVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVF bGVtZW50LnByb3RvdHlwZS50b2dnbGVOZXdBdHRyaWJ1dGVCdXR0b24pOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLkVsZW1lbnRzVHJlZUVsZW1lbnQucHJvdG90eXBlLl9zdGFydEVkaXRpbmcpOgor CiAyMDA5LTEyLTE1ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBXZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5qcwkocmV2aXNpb24gNTIx MTcpCisrKyBXZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRWxlbWVudHNUcmVlT3V0bGluZS5q cwkod29ya2luZyBjb3B5KQpAQCAtMzM1LDE1ICszMzUsOCBAQCBXZWJJbnNwZWN0b3IuRWxlbWVu dHNUcmVlRWxlbWVudC5wcm90b3R5CiAgICAgICAgICAgICBpZiAoeCkgewogICAgICAgICAgICAg ICAgIHRoaXMudXBkYXRlU2VsZWN0aW9uKCk7CiAgICAgICAgICAgICAgICAgdGhpcy5saXN0SXRl bUVsZW1lbnQuYWRkU3R5bGVDbGFzcygiaG92ZXJlZCIpOwotICAgICAgICAgICAgICAgIGlmICh0 aGlzLl9jYW5BZGRBdHRyaWJ1dGVzKQotICAgICAgICAgICAgICAgICAgICB0aGlzLl9wZW5kaW5n VG9nZ2xlTmV3QXR0cmlidXRlID0gc2V0VGltZW91dCh0aGlzLnRvZ2dsZU5ld0F0dHJpYnV0ZUJ1 dHRvbi5iaW5kKHRoaXMsIHRydWUpLCA1MDApOwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAg ICAgICAgICAgICB0aGlzLmxpc3RJdGVtRWxlbWVudC5yZW1vdmVTdHlsZUNsYXNzKCJob3ZlcmVk Iik7Ci0gICAgICAgICAgICAgICAgaWYgKHRoaXMuX3BlbmRpbmdUb2dnbGVOZXdBdHRyaWJ1dGUp IHsKLSAgICAgICAgICAgICAgICAgICAgY2xlYXJUaW1lb3V0KHRoaXMuX3BlbmRpbmdUb2dnbGVO ZXdBdHRyaWJ1dGUpOwotICAgICAgICAgICAgICAgICAgICBkZWxldGUgdGhpcy5fcGVuZGluZ1Rv Z2dsZU5ld0F0dHJpYnV0ZTsKLSAgICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICAgICAgdGhp cy50b2dnbGVOZXdBdHRyaWJ1dGVCdXR0b24oZmFsc2UpOwogICAgICAgICAgICAgfQogICAgICAg ICB9CiAgICAgfSwKQEAgLTM2OCwzMCArMzYxLDYgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzVHJl ZUVsZW1lbnQucHJvdG90eQogICAgICAgICBXZWJJbnNwZWN0b3IuT2JqZWN0UHJveHkuZ2V0UHJv cGVydGllc0FzeW5jKG9iamVjdFByb3h5LCBbIm5hdHVyYWxIZWlnaHQiLCAibmF0dXJhbFdpZHRo IiwgIm9mZnNldEhlaWdodCIsICJvZmZzZXRXaWR0aCJdLCBjcmVhdGVUb29sdGlwVGhlbkNhbGxi YWNrKTsKICAgICB9LAogCi0gICAgdG9nZ2xlTmV3QXR0cmlidXRlQnV0dG9uOiBmdW5jdGlvbih2 aXNpYmxlKQotICAgIHsKLSAgICAgICAgZnVuY3Rpb24gcmVtb3ZlQWRkQXR0cmlidXRlU3Bhbigp Ci0gICAgICAgIHsKLSAgICAgICAgICAgIGlmICh0aGlzLl9hZGRBdHRyaWJ1dGVFbGVtZW50ICYm IHRoaXMuX2FkZEF0dHJpYnV0ZUVsZW1lbnQucGFyZW50Tm9kZSkKLSAgICAgICAgICAgICAgICB0 aGlzLl9hZGRBdHRyaWJ1dGVFbGVtZW50LnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQodGhpcy5fYWRk QXR0cmlidXRlRWxlbWVudCk7Ci0gICAgICAgICAgICBkZWxldGUgdGhpcy5fYWRkQXR0cmlidXRl RWxlbWVudDsKLQotICAgICAgICAgICAgdGhpcy51cGRhdGVTZWxlY3Rpb24oKTsKLSAgICAgICAg fQotCi0gICAgICAgIGlmICghdGhpcy5fYWRkQXR0cmlidXRlRWxlbWVudCAmJiB2aXNpYmxlICYm ICF0aGlzLl9lZGl0aW5nKSB7Ci0gICAgICAgICAgICB2YXIgc3BhbiA9IGRvY3VtZW50LmNyZWF0 ZUVsZW1lbnQoInNwYW4iKTsKLSAgICAgICAgICAgIHNwYW4uY2xhc3NOYW1lID0gImFkZC1hdHRy aWJ1dGUgd2Via2l0LWh0bWwtYXR0cmlidXRlLW5hbWUiOwotICAgICAgICAgICAgc3Bhbi50ZXh0 Q29udGVudCA9ICIgPz1cIlwiIjsKLSAgICAgICAgICAgIHNwYW4uYWRkRXZlbnRMaXN0ZW5lcigi ZGJsY2xpY2siLCByZW1vdmVBZGRBdHRyaWJ1dGVTcGFuLmJpbmQodGhpcyksIGZhbHNlKTsKLSAg ICAgICAgICAgIHRoaXMuX2FkZEF0dHJpYnV0ZUVsZW1lbnQgPSBzcGFuOwotCi0gICAgICAgICAg ICB2YXIgdGFnID0gdGhpcy5saXN0SXRlbUVsZW1lbnQuZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgi d2Via2l0LWh0bWwtdGFnIilbMF07Ci0gICAgICAgICAgICB0aGlzLl9pbnNlcnRJbkxhc3RBdHRy aWJ1dGVQb3NpdGlvbih0YWcsIHNwYW4pOwotICAgICAgICB9IGVsc2UgaWYgKCF2aXNpYmxlICYm IHRoaXMuX2FkZEF0dHJpYnV0ZUVsZW1lbnQpCi0gICAgICAgICAgICByZW1vdmVBZGRBdHRyaWJ1 dGVTcGFuLmNhbGwodGhpcyk7Ci0gICAgfSwKLQogICAgIHVwZGF0ZVNlbGVjdGlvbjogZnVuY3Rp b24oKQogICAgIHsKICAgICAgICAgdmFyIGxpc3RJdGVtRWxlbWVudCA9IHRoaXMubGlzdEl0ZW1F bGVtZW50OwpAQCAtNjUwLDcgKzYxOSw2IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVFbGVt ZW50LnByb3RvdHkKICAgICAgICAgdmFyIGxpc3RJdGVtID0gdGhpcy5fbGlzdEl0ZW1Ob2RlOwog CiAgICAgICAgIGlmICh0aGlzLl9jYW5BZGRBdHRyaWJ1dGVzKSB7Ci0gICAgICAgICAgICB0aGlz LnRvZ2dsZU5ld0F0dHJpYnV0ZUJ1dHRvbihmYWxzZSk7CiAgICAgICAgICAgICB2YXIgYXR0cmli dXRlID0gbGlzdEl0ZW0uZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgid2Via2l0LWh0bWwtYXR0cmli dXRlIilbMF07CiAgICAgICAgICAgICBpZiAoYXR0cmlidXRlKQogICAgICAgICAgICAgICAgIHJl dHVybiB0aGlzLl9zdGFydEVkaXRpbmdBdHRyaWJ1dGUoYXR0cmlidXRlLCBhdHRyaWJ1dGUuZ2V0 RWxlbWVudHNCeUNsYXNzTmFtZSgid2Via2l0LWh0bWwtYXR0cmlidXRlLXZhbHVlIilbMF0pOwo=