32577 2009-12-15 13:22:57 -0800 Web Inspector: Display request headers for main resource having redirects. 2009-12-15 13:45:03 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy webkit.review.bot oldest_to_newest 171993 0 pfeldman 2009-12-15 13:22:57 -0800 It is currently blank. The reason is that when identifierForInitialRequest is called, there are no headers available in request yet. 171995 1 44904 pfeldman 2009-12-15 13:25:48 -0800 Created attachment 44904 [PATC] Proposed fix. 171997 2 webkit.review.bot 2009-12-15 13:26:25 -0800 style-queue ran check-webkit-style on attachment 44904 without any errors. 172004 3 pfeldman 2009-12-15 13:45:03 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorResource.cpp M WebCore/inspector/InspectorResource.h Committed r52169 44904 2009-12-15 13:25:48 -0800 2009-12-15 13:29:05 -0800 [PATC] Proposed fix. main_request text/plain 7173 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTNkNDViYS4uZjRmYjhmZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNSBAQAogMjAwOS0xMi0xNSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBEaXNwbGF5IHJlcXVlc3QgaGVhZGVy cyBmb3IgbWFpbiByZXNvdXJjZQorICAgICAgICBoYXZpbmcgcmVkaXJlY3RzLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjU3NworCisgICAgICAg ICogaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SW5zcGVjdG9yQ29udHJvbGxlcjo6aWRlbnRpZmllckZvckluaXRpYWxSZXF1ZXN0KToKKyAgICAg ICAgKFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXI6OndpbGxTZW5kUmVxdWVzdCk6CisgICAg ICAgICogaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okluc3BlY3RvclJlc291cmNlOjpJbnNwZWN0b3JSZXNvdXJjZSk6CisgICAgICAgIChXZWJDb3Jl OjpJbnNwZWN0b3JSZXNvdXJjZTo6YXBwZW5kUmVkaXJlY3QpOgorICAgICAgICAoV2ViQ29yZTo6 SW5zcGVjdG9yUmVzb3VyY2U6OmNyZWF0ZUNhY2hlZCk6CisgICAgICAgIChXZWJDb3JlOjpJbnNw ZWN0b3JSZXNvdXJjZTo6dXBkYXRlUmVxdWVzdCk6CisgICAgICAgICogaW5zcGVjdG9yL0luc3Bl Y3RvclJlc291cmNlLmg6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JSZXNvdXJjZTo6Y3Jl YXRlKToKKworMjAwOS0xMi0xNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9y Zz4KKwogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogRG8gbm90IGxvc2UgSFRUUCByZWRpcmVjdCBpbmZvcm1hdGlvbiwgZGlzcGxh eSBpdApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5j cHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCA2NTlh MjNlLi40OGRmYjhkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250 cm9sbGVyLmNwcAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNw cApAQCAtODc3LDkgKzg3Nyw3IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6aWRlbnRpZmll ckZvckluaXRpYWxSZXF1ZXN0KHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwKICAgICBpZiAoIWlz TWFpblJlc291cmNlICYmICFtX3Jlc291cmNlVHJhY2tpbmdFbmFibGVkKQogICAgICAgICByZXR1 cm47CiAKLSAgICBSZWZQdHI8SW5zcGVjdG9yUmVzb3VyY2U+IHJlc291cmNlID0gSW5zcGVjdG9y UmVzb3VyY2U6OmNyZWF0ZShpZGVudGlmaWVyLCBsb2FkZXIpOwotCi0gICAgcmVzb3VyY2UtPnVw ZGF0ZVJlcXVlc3QocmVxdWVzdCk7CisgICAgUmVmUHRyPEluc3BlY3RvclJlc291cmNlPiByZXNv dXJjZSA9IEluc3BlY3RvclJlc291cmNlOjpjcmVhdGUoaWRlbnRpZmllciwgbG9hZGVyLCByZXF1 ZXN0LnVybCgpKTsKIAogICAgIGlmIChpc01haW5SZXNvdXJjZSkgewogICAgICAgICBtX21haW5S ZXNvdXJjZSA9IHJlc291cmNlOwpAQCAtOTMyLDkgKzkzMCwxMyBAQCB2b2lkIEluc3BlY3RvckNv bnRyb2xsZXI6OndpbGxTZW5kUmVxdWVzdCh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0 IFJlc291cgogICAgICAgICByZXR1cm47CiAKICAgICBpZiAoIXJlZGlyZWN0UmVzcG9uc2UuaXNO dWxsKCkpIHsKKyAgICAgICAgcmVzb3VyY2UtPm1hcmtSZXNwb25zZVJlY2VpdmVkVGltZSgpOwor ICAgICAgICByZXNvdXJjZS0+ZW5kVGltaW5nKCk7CisgICAgICAgIHJlc291cmNlLT51cGRhdGVS ZXNwb25zZShyZWRpcmVjdFJlc3BvbnNlKTsKKwogICAgICAgICAvLyBXZSBhbHdheXMgc3RvcmUg bGFzdCByZWRpcmVjdCBieSB0aGUgb3JpZ2luYWwgaWQga2V5LiBSZXN0IG9mIHRoZSByZWRpcmVj dHMgYXJlIHN0b3JlZCB3aXRoaW4gdGhlIGxhc3Qgb25lLgogICAgICAgICB1bnNpZ25lZCBsb25n IGlkID0gbV9pbnNwZWN0ZWRQYWdlLT5wcm9ncmVzcygpLT5jcmVhdGVVbmlxdWVJZGVudGlmaWVy KCk7Ci0gICAgICAgIFJlZlB0cjxJbnNwZWN0b3JSZXNvdXJjZT4gd2l0aFJlZGlyZWN0ID0gcmVz b3VyY2UtPmFwcGVuZFJlZGlyZWN0KGlkLCByZXF1ZXN0LCByZWRpcmVjdFJlc3BvbnNlKTsKKyAg ICAgICAgUmVmUHRyPEluc3BlY3RvclJlc291cmNlPiB3aXRoUmVkaXJlY3QgPSByZXNvdXJjZS0+ YXBwZW5kUmVkaXJlY3QoaWQsIHJlcXVlc3QudXJsKCkpOwogICAgICAgICByZW1vdmVSZXNvdXJj ZShyZXNvdXJjZS5nZXQoKSk7CiAgICAgICAgIGFkZFJlc291cmNlKHdpdGhSZWRpcmVjdC5nZXQo KSk7CiAgICAgICAgIGlmIChpc01haW5SZXNvdXJjZSkgewpAQCAtOTQ1LDYgKzk0Nyw4IEBAIHZv aWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6d2lsbFNlbmRSZXF1ZXN0KHVuc2lnbmVkIGxvbmcgaWRl bnRpZmllciwgY29uc3QgUmVzb3VyCiAgICAgfQogCiAgICAgcmVzb3VyY2UtPnN0YXJ0VGltaW5n KCk7CisgICAgcmVzb3VyY2UtPnVwZGF0ZVJlcXVlc3QocmVxdWVzdCk7CisKICAgICBpZiAocmVz b3VyY2UgIT0gbV9tYWluUmVzb3VyY2UgJiYgd2luZG93VmlzaWJsZSgpKQogICAgICAgICByZXNv dXJjZS0+dXBkYXRlU2NyaXB0T2JqZWN0KG1fZnJvbnRlbmQuZ2V0KCkpOwogfQpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2UuY3BwIGIvV2ViQ29yZS9pbnNw ZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2UuY3BwCmluZGV4IDJlODNkMDIuLjY3NTQ3YmEgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlLmNwcAorKysgYi9XZWJD b3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZS5jcHAKQEAgLTQ2LDEwICs0NiwxMSBAQAog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLUluc3BlY3RvclJlc291cmNlOjpJbnNwZWN0b3JSZXNv dXJjZSh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIERvY3VtZW50TG9hZGVyKiBsb2FkZXIpCitJ bnNwZWN0b3JSZXNvdXJjZTo6SW5zcGVjdG9yUmVzb3VyY2UodW5zaWduZWQgbG9uZyBpZGVudGlm aWVyLCBEb2N1bWVudExvYWRlciogbG9hZGVyLCBjb25zdCBLVVJMJiByZXF1ZXN0VVJMKQogICAg IDogbV9pZGVudGlmaWVyKGlkZW50aWZpZXIpCiAgICAgLCBtX2xvYWRlcihsb2FkZXIpCiAgICAg LCBtX2ZyYW1lKGxvYWRlci0+ZnJhbWUoKSkKKyAgICAsIG1fcmVxdWVzdFVSTChyZXF1ZXN0VVJM KQogICAgICwgbV9leHBlY3RlZENvbnRlbnRMZW5ndGgoMCkKICAgICAsIG1fY2FjaGVkKGZhbHNl KQogICAgICwgbV9maW5pc2hlZChmYWxzZSkKQEAgLTY5LDMwICs3MCwyNSBAQCBJbnNwZWN0b3JS ZXNvdXJjZTo6fkluc3BlY3RvclJlc291cmNlKCkKIHsKIH0KIAotUGFzc1JlZlB0cjxJbnNwZWN0 b3JSZXNvdXJjZT4gSW5zcGVjdG9yUmVzb3VyY2U6OmFwcGVuZFJlZGlyZWN0KHVuc2lnbmVkIGxv bmcgaWRlbnRpZmllciwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBSZXNv dXJjZVJlc3BvbnNlJiByZWRpcmVjdFJlc3BvbnNlKQorUGFzc1JlZlB0cjxJbnNwZWN0b3JSZXNv dXJjZT4gSW5zcGVjdG9yUmVzb3VyY2U6OmFwcGVuZFJlZGlyZWN0KHVuc2lnbmVkIGxvbmcgaWRl bnRpZmllciwgY29uc3QgS1VSTCYgcmVkaXJlY3RVUkwpCiB7CiAgICAgLy8gTGFzdCByZWRpcmVj dCBpcyBhbHdheXMgYSBjb250YWluZXIgb2YgYWxsIHByZXZpb3VzIG9uZXMuIFBhc3MgdGhpcyBj b250YWluZXIgaGVyZS4KLSAgICBSZWZQdHI8SW5zcGVjdG9yUmVzb3VyY2U+IHJlZGlyZWN0ID0g SW5zcGVjdG9yUmVzb3VyY2U6OmNyZWF0ZShtX2lkZW50aWZpZXIsIG1fbG9hZGVyLmdldCgpKTsK KyAgICBSZWZQdHI8SW5zcGVjdG9yUmVzb3VyY2U+IHJlZGlyZWN0ID0gSW5zcGVjdG9yUmVzb3Vy Y2U6OmNyZWF0ZShtX2lkZW50aWZpZXIsIG1fbG9hZGVyLmdldCgpLCByZWRpcmVjdFVSTCk7CiAg ICAgcmVkaXJlY3QtPm1fcmVkaXJlY3RzID0gbV9yZWRpcmVjdHM7CiAgICAgcmVkaXJlY3QtPm1f cmVkaXJlY3RzLmFwcGVuZCh0aGlzKTsKICAgICByZWRpcmVjdC0+bV9jaGFuZ2VzLnNldChSZWRp cmVjdHNDaGFuZ2UpOwotICAgIHJlZGlyZWN0LT51cGRhdGVSZXF1ZXN0KHJlcXVlc3QpOwogCiAg ICAgbV9pZGVudGlmaWVyID0gaWRlbnRpZmllcjsKICAgICBtX3JlZGlyZWN0cy5jbGVhcigpOwot ICAgIHVwZGF0ZVJlc3BvbnNlKHJlZGlyZWN0UmVzcG9uc2UpOwotICAgIG1hcmtSZXNwb25zZVJl Y2VpdmVkVGltZSgpOwotICAgIGVuZFRpbWluZygpOwogICAgIHJldHVybiByZWRpcmVjdDsKIH0K IAogUGFzc1JlZlB0cjxJbnNwZWN0b3JSZXNvdXJjZT4gSW5zcGVjdG9yUmVzb3VyY2U6OmNyZWF0 ZUNhY2hlZCh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIERvY3VtZW50TG9hZGVyKiBsb2FkZXIs IGNvbnN0IENhY2hlZFJlc291cmNlKiBjYWNoZWRSZXNvdXJjZSkKIHsKLSAgICBQYXNzUmVmUHRy PEluc3BlY3RvclJlc291cmNlPiByZXNvdXJjZSA9IGNyZWF0ZShpZGVudGlmaWVyLCBsb2FkZXIp OworICAgIFBhc3NSZWZQdHI8SW5zcGVjdG9yUmVzb3VyY2U+IHJlc291cmNlID0gY3JlYXRlKGlk ZW50aWZpZXIsIGxvYWRlciwgS1VSTChQYXJzZWRVUkxTdHJpbmcsIGNhY2hlZFJlc291cmNlLT51 cmwoKSkpOwogCiAgICAgcmVzb3VyY2UtPm1fZmluaXNoZWQgPSB0cnVlOwogCi0gICAgcmVzb3Vy Y2UtPm1fcmVxdWVzdFVSTCA9IEtVUkwoUGFyc2VkVVJMU3RyaW5nLCBjYWNoZWRSZXNvdXJjZS0+ dXJsKCkpOwogICAgIHJlc291cmNlLT51cGRhdGVSZXNwb25zZShjYWNoZWRSZXNvdXJjZS0+cmVz cG9uc2UoKSk7CiAKICAgICByZXNvdXJjZS0+bV9sZW5ndGggPSBjYWNoZWRSZXNvdXJjZS0+ZW5j b2RlZFNpemUoKTsKQEAgLTEwOSw3ICsxMDUsNiBAQCBQYXNzUmVmUHRyPEluc3BlY3RvclJlc291 cmNlPiBJbnNwZWN0b3JSZXNvdXJjZTo6Y3JlYXRlQ2FjaGVkKHVuc2lnbmVkIGxvbmcgaWRlbgog dm9pZCBJbnNwZWN0b3JSZXNvdXJjZTo6dXBkYXRlUmVxdWVzdChjb25zdCBSZXNvdXJjZVJlcXVl c3QmIHJlcXVlc3QpCiB7CiAgICAgbV9yZXF1ZXN0SGVhZGVyRmllbGRzID0gcmVxdWVzdC5odHRw SGVhZGVyRmllbGRzKCk7Ci0gICAgbV9yZXF1ZXN0VVJMID0gcmVxdWVzdC51cmwoKTsKICAgICBt X3JlcXVlc3RNZXRob2QgPSByZXF1ZXN0Lmh0dHBNZXRob2QoKTsKICAgICBpZiAocmVxdWVzdC5o dHRwQm9keSgpICYmICFyZXF1ZXN0Lmh0dHBCb2R5KCktPmlzRW1wdHkoKSkKICAgICAgICAgbV9y ZXF1ZXN0Rm9ybURhdGEgPSByZXF1ZXN0Lmh0dHBCb2R5KCktPmZsYXR0ZW5Ub1N0cmluZygpOwpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2UuaCBiL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvclJlc291cmNlLmgKaW5kZXggNDM4YTNkNi4uY2U4NmRkNyAx MDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUmVzb3VyY2UuaAorKysgYi9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZS5oCkBAIC02OCwxNiArNjgsMTYgQEAg bmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgT3RoZXIKICAgICAgICAgfTsKIAotICAg ICAgICBzdGF0aWMgUGFzc1JlZlB0cjxJbnNwZWN0b3JSZXNvdXJjZT4gY3JlYXRlKHVuc2lnbmVk IGxvbmcgaWRlbnRpZmllciwgRG9jdW1lbnRMb2FkZXIqIGxvYWRlcikKKyAgICAgICAgc3RhdGlj IFBhc3NSZWZQdHI8SW5zcGVjdG9yUmVzb3VyY2U+IGNyZWF0ZSh1bnNpZ25lZCBsb25nIGlkZW50 aWZpZXIsIERvY3VtZW50TG9hZGVyKiBsb2FkZXIsIGNvbnN0IEtVUkwmIHJlcXVlc3RVUkwpCiAg ICAgICAgIHsKLSAgICAgICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgSW5zcGVjdG9yUmVzb3Vy Y2UoaWRlbnRpZmllciwgbG9hZGVyKSk7CisgICAgICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3 IEluc3BlY3RvclJlc291cmNlKGlkZW50aWZpZXIsIGxvYWRlciwgcmVxdWVzdFVSTCkpOwogICAg ICAgICB9CiAKICAgICAgICAgc3RhdGljIFBhc3NSZWZQdHI8SW5zcGVjdG9yUmVzb3VyY2U+IGNy ZWF0ZUNhY2hlZCh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIERvY3VtZW50TG9hZGVyKiwgY29u c3QgQ2FjaGVkUmVzb3VyY2UqKTsKIAogICAgICAgICB+SW5zcGVjdG9yUmVzb3VyY2UoKTsKIAot ICAgICAgICBQYXNzUmVmUHRyPEluc3BlY3RvclJlc291cmNlPiBhcHBlbmRSZWRpcmVjdCh1bnNp Z25lZCBsb25nIGlkZW50aWZpZXIsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYsIGNvbnN0IFJlc291 cmNlUmVzcG9uc2UmIHJlZGlyZWN0UmVzcG9uc2UpOworICAgICAgICBQYXNzUmVmUHRyPEluc3Bl Y3RvclJlc291cmNlPiBhcHBlbmRSZWRpcmVjdCh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIGNv bnN0IEtVUkwmIHJlZGlyZWN0VVJMKTsKICAgICAgICAgdm9pZCB1cGRhdGVTY3JpcHRPYmplY3Qo SW5zcGVjdG9yRnJvbnRlbmQqIGZyb250ZW5kKTsKICAgICAgICAgdm9pZCByZWxlYXNlU2NyaXB0 T2JqZWN0KEluc3BlY3RvckZyb250ZW5kKiBmcm9udGVuZCwgYm9vbCBjYWxsUmVtb3ZlUmVzb3Vy Y2UpOwogCkBAIC0xNDYsNyArMTQ2LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAg ICAgQ2hhbmdlVHlwZSBtX2NoYW5nZTsKICAgICAgICAgfTsKIAotICAgICAgICBJbnNwZWN0b3JS ZXNvdXJjZSh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIERvY3VtZW50TG9hZGVyKik7CisgICAg ICAgIEluc3BlY3RvclJlc291cmNlKHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwgRG9jdW1lbnRM b2FkZXIqLCBjb25zdCBLVVJMJiByZXF1ZXN0VVJMKTsKICAgICAgICAgVHlwZSB0eXBlKCkgY29u c3Q7CiAKICAgICAgICAgVHlwZSBjYWNoZWRSZXNvdXJjZVR5cGUoKSBjb25zdDsK