32562 2009-12-15 09:04:38 -0800 [V8] Generate trivial named property getters. 2009-12-15 11:56:03 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 32455 1 dglazkov dglazkov abarth eric jens webkit.review.bot oldest_to_newest 171889 0 dglazkov 2009-12-15 09:04:38 -0800 This is essentially a mirror patch to the one on bug 32455, only for named property getters. Small steps. 171892 1 44881 dglazkov 2009-12-15 09:09:12 -0800 Created attachment 44881 Generate trivial named property getters, v1. 171896 2 webkit.review.bot 2009-12-15 09:12:15 -0800 style-queue ran check-webkit-style on attachment 44881 without any errors. 171940 3 44881 eric 2009-12-15 11:22:35 -0800 Comment on attachment 44881 Generate trivial named property getters, v1. toAtomicWebCoreStringWithNullCheck is the only confusing part. Looks good though! 171951 4 jens 2009-12-15 11:35:53 -0800 Looks good. 171967 5 dglazkov 2009-12-15 11:56:03 -0800 Landed as http://trac.webkit.org/changeset/52166. 44881 2009-12-15 09:09:12 -0800 2009-12-15 11:22:35 -0800 Generate trivial named property getters, v1. bug-32562-20091215090910.patch text/plain 4916 dglazkov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTU3NTgxMC4uZTgxZDU5NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0xMi0xNSAgRGltaXRyaSBHbGF6 a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtWOF0gR2VuZXJhdGUgdHJpdmlhbCBuYW1lZCBwcm9wZXJ0 eSBnZXR0ZXJzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzI1NjIKKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06IEFkZGVkIEdlbmVyYXRlSW1w bGVtZW50YXRpb25OYW1lZFByb3BlcnR5R2V0dGVyLgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4 Q29sbGVjdGlvbi5oOgorICAgICAgICAoV2ViQ29yZTo6Z2V0TmFtZWRQcm9wZXJ0eU9mQ29sbGVj dGlvbik6IEZpeGVkIGEgYm9vYm9vIGJ5IHVzaW5nIEF0b21pY1N0cmluZyBsaWtlIHdlJ3JlIHN1 cHBvc2VkIHRvLgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6OmdldFRlbXBsYXRlKTogUmVtb3ZlZCBjb2RlIHRo YXQncyBub3cgZ2VuZXJhdGVkLgorCiAyMDA5LTEyLTE0ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xh emtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCA5YjYzNDlm Li41OTYxOTQ2IDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvclY4LnBtCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG0KQEAgLTExNTgsNiArMTE1OCwyMiBAQCBFTkQKICAgICB9CiB9CiAKK3N1YiBHZW5lcmF0ZUlt cGxlbWVudGF0aW9uTmFtZWRQcm9wZXJ0eUdldHRlcgoreworICAgIG15ICRkYXRhTm9kZSA9IHNo aWZ0OworICAgIG15ICRuYW1lZFByb3BlcnR5R2V0dGVyID0gc2hpZnQ7CisgICAgbXkgJGludGVy ZmFjZU5hbWUgPSAkZGF0YU5vZGUtPm5hbWU7CisKKyAgICBpZiAoJGRhdGFOb2RlLT5leHRlbmRl ZEF0dHJpYnV0ZXMtPnsiSGFzTmFtZUdldHRlciJ9ICYmICEkbmFtZWRQcm9wZXJ0eUdldHRlci0+ ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1c3RvbSJ9KSB7CisgICAgICAgICRpbXBsSW5jbHVkZXN7 IlY4Q29sbGVjdGlvbi5oIn0gPSAxOworICAgICAgICBteSAkdHlwZSA9ICRuYW1lZFByb3BlcnR5 R2V0dGVyLT50eXBlOworICAgICAgICBteSAkY2xhc3NJbmRleCA9IHVjKCR0eXBlKTsKKyAgICAg ICAgcHVzaChAaW1wbENvbnRlbnQsIDw8RU5EKTsKKyAgc2V0Q29sbGVjdGlvbk5hbWVkR2V0dGVy PCR7aW50ZXJmYWNlTmFtZX0sICR7dHlwZX0+KGRlc2MsIFY4Q2xhc3NJbmRleDo6JHtjbGFzc0lu ZGV4fSk7CitFTkQKKyAgICB9Cit9CisKIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiB7CiAg ICAgbXkgJG9iamVjdCA9IHNoaWZ0OwpAQCAtMTI0Nyw2ICsxMjYzLDcgQEAgc3ViIEdlbmVyYXRl SW1wbGVtZW50YXRpb24KICAgICB9CiAKICAgICBteSAkaW5kZXhlcjsKKyAgICBteSAkbmFtZWRQ cm9wZXJ0eUdldHRlcjsKICAgICAjIEdlbmVyYXRlIG1ldGhvZHMgZm9yIGZ1bmN0aW9ucy4KICAg ICBmb3JlYWNoIG15ICRmdW5jdGlvbiAoQHskZGF0YU5vZGUtPmZ1bmN0aW9uc30pIHsKICAgICAg ICAgIyBoYWNrIGZvciBhZGRFdmVudExpc3RlbmVyL1JlbW92ZUV2ZW50TGlzdGVuZXIKQEAgLTEy NjEsNiArMTI3OCwxMCBAQCBzdWIgR2VuZXJhdGVJbXBsZW1lbnRhdGlvbgogICAgICAgICAgICAg JGluZGV4ZXIgPSAkZnVuY3Rpb24tPnNpZ25hdHVyZTsKICAgICAgICAgfQogCisgICAgICAgIGlm ICgkZnVuY3Rpb24tPnNpZ25hdHVyZS0+bmFtZSBlcSAibmFtZWRJdGVtIikgeworICAgICAgICAg ICAgJG5hbWVkUHJvcGVydHlHZXR0ZXIgPSAkZnVuY3Rpb24tPnNpZ25hdHVyZTsKKyAgICAgICAg fQorCiAgICAgICAgICMgSWYgdGhlIGZ1bmN0aW9uIGRvZXMgbm90IG5lZWQgZG9tYWluIHNlY3Vy aXR5IGNoZWNrLCB3ZSBuZWVkIHRvCiAgICAgICAgICMgZ2VuZXJhdGUgYW4gYWNjZXNzIGdldHRl ciB0aGF0IHJldHVybnMgZGlmZmVyZW50IGZ1bmN0aW9uIG9iamVjdHMKICAgICAgICAgIyBmb3Ig ZGlmZmVyZW50IGNhbGxpbmcgY29udGV4dC4KQEAgLTE0NDYsNiArMTQ2Nyw3IEBAIEVORAogICAg IH0KIAogICAgIEdlbmVyYXRlSW1wbGVtZW50YXRpb25JbmRleGVyKCRkYXRhTm9kZSwgJGluZGV4 ZXIpIGlmICRpbmRleGVyOworICAgIEdlbmVyYXRlSW1wbGVtZW50YXRpb25OYW1lZFByb3BlcnR5 R2V0dGVyKCRkYXRhTm9kZSwgJG5hbWVkUHJvcGVydHlHZXR0ZXIpIGlmICRuYW1lZFByb3BlcnR5 R2V0dGVyOwogCiAgICAgIyBEZWZpbmUgb3VyIGZ1bmN0aW9ucyB3aXRoIFNldCgpIG9yIFNldEFj Y2Vzc29yKCkKICAgICAkdG90YWxfZnVuY3Rpb25zID0gMDsKZGlmZiAtLWdpdCBhL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhDb2xsZWN0aW9uLmggYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Q29sbGVj dGlvbi5oCmluZGV4IDhkZWE4MzkuLjY5NjFkNWEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhDb2xsZWN0aW9uLmgKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOENvbGxlY3Rp b24uaApAQCAtNjUsNyArNjUsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIFY4Q2xh c3NJbmRleDo6VjhXcmFwcGVyVHlwZSB3cmFwcGVyVHlwZSA9IFY4RE9NV3JhcHBlcjo6ZG9tV3Jh cHBlclR5cGUob2JqZWN0KTsKICAgICAgICAgQVNTRVJUKHdyYXBwZXJUeXBlICE9IFY4Q2xhc3NJ bmRleDo6Tk9ERSk7CiAgICAgICAgIENvbGxlY3Rpb24qIGNvbGxlY3Rpb24gPSBWOERPTVdyYXBw ZXI6OmNvbnZlcnRUb05hdGl2ZU9iamVjdDxDb2xsZWN0aW9uPih3cmFwcGVyVHlwZSwgb2JqZWN0 KTsKLSAgICAgICAgU3RyaW5nIHByb3BlcnR5TmFtZSA9IHRvV2ViQ29yZVN0cmluZyhuYW1lKTsK KyAgICAgICAgQXRvbWljU3RyaW5nIHByb3BlcnR5TmFtZSA9IHRvQXRvbWljV2ViQ29yZVN0cmlu Z1dpdGhOdWxsQ2hlY2sobmFtZSk7CiAgICAgICAgIHJldHVybiBnZXRWOE9iamVjdDxJdGVtVHlw ZT4oY29sbGVjdGlvbi0+bmFtZWRJdGVtKHByb3BlcnR5TmFtZSksIGltcGxlbWVudGF0aW9uVHlw ZSk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBl ci5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKaW5kZXggNDI2M2U3 My4uMjljNzcyNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIu Y3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcApAQCAtMzQ3LDkg KzM0Nyw2IEBAIHY4OjpQZXJzaXN0ZW50PHY4OjpGdW5jdGlvblRlbXBsYXRlPiBWOERPTVdyYXBw ZXI6OmdldFRlbXBsYXRlKFY4Q2xhc3NJbmRleDo6VjhXCiAgICAgICAgIGluc3RhbmNlVGVtcGxh dGUtPlNldEludGVybmFsRmllbGRDb3VudChWOEN1c3RvbTo6a1N0eWxlU2hlZXRJbnRlcm5hbEZp ZWxkQ291bnQpOwogICAgICAgICBicmVhazsKICAgICB9Ci0gICAgY2FzZSBWOENsYXNzSW5kZXg6 Ok1JTUVUWVBFQVJSQVk6Ci0gICAgICAgIHNldENvbGxlY3Rpb25OYW1lZEdldHRlcjxNaW1lVHlw ZUFycmF5LCBNaW1lVHlwZT4oZGVzY3JpcHRvciwgVjhDbGFzc0luZGV4OjpNSU1FVFlQRSk7Ci0g ICAgICAgIGJyZWFrOwogICAgIGNhc2UgVjhDbGFzc0luZGV4OjpOQU1FRE5PREVNQVA6IHsKICAg ICAgICAgLy8gV2UgYWRkIGFuIGV4dHJhIGludGVybmFsIGZpZWxkIHRvIGhvbGQgYSByZWZlcmVu Y2UgdG8gdGhlIG93bmVyIG5vZGUuCiAgICAgICAgIHY4OjpMb2NhbDx2ODo6T2JqZWN0VGVtcGxh dGU+IGluc3RhbmNlVGVtcGxhdGUgPSBkZXNjcmlwdG9yLT5JbnN0YW5jZVRlbXBsYXRlKCk7CkBA IC0zNjgsMTIgKzM2NSw2IEBAIHY4OjpQZXJzaXN0ZW50PHY4OjpGdW5jdGlvblRlbXBsYXRlPiBW OERPTVdyYXBwZXI6OmdldFRlbXBsYXRlKFY4Q2xhc3NJbmRleDo6VjhXCiAgICAgY2FzZSBWOENs YXNzSW5kZXg6Ok5PREVMSVNUOgogICAgICAgICBkZXNjcmlwdG9yLT5JbnN0YW5jZVRlbXBsYXRl KCktPlNldE5hbWVkUHJvcGVydHlIYW5kbGVyKFVTRV9OQU1FRF9QUk9QRVJUWV9HRVRURVIoTm9k ZUxpc3QpKTsKICAgICAgICAgYnJlYWs7Ci0gICAgY2FzZSBWOENsYXNzSW5kZXg6OlBMVUdJTjoK LSAgICAgICAgc2V0Q29sbGVjdGlvbk5hbWVkR2V0dGVyPFBsdWdpbiwgTWltZVR5cGU+KGRlc2Ny aXB0b3IsIFY4Q2xhc3NJbmRleDo6TUlNRVRZUEUpOwotICAgICAgICBicmVhazsKLSAgICBjYXNl IFY4Q2xhc3NJbmRleDo6UExVR0lOQVJSQVk6Ci0gICAgICAgIHNldENvbGxlY3Rpb25OYW1lZEdl dHRlcjxQbHVnaW5BcnJheSwgUGx1Z2luPihkZXNjcmlwdG9yLCBWOENsYXNzSW5kZXg6OlBMVUdJ Tik7Ci0gICAgICAgIGJyZWFrOwogICAgIGNhc2UgVjhDbGFzc0luZGV4OjpTVFlMRVNIRUVUTElT VDoKICAgICAgICAgZGVzY3JpcHRvci0+SW5zdGFuY2VUZW1wbGF0ZSgpLT5TZXROYW1lZFByb3Bl cnR5SGFuZGxlcihVU0VfTkFNRURfUFJPUEVSVFlfR0VUVEVSKFN0eWxlU2hlZXRMaXN0KSk7CiAg ICAgICAgIGJyZWFrOwo=