32560 2009-12-15 07:21:57 -0800 [GTK] display FPS stats for video element 2009-12-17 06:28:55 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 pnormand webkit-unassigned webkit.review.bot oldest_to_newest 171853 0 pnormand 2009-12-15 07:21:57 -0800 It can sometimes be useful to display video FPS statistics when debugging. Setting WEBKIT_DEBUG to Media should enable this feature, stats would be displayed on the video. 171854 1 44877 pnormand 2009-12-15 07:25:34 -0800 Created attachment 44877 display FPS statistics if WEBKIT_DEBUG environment variable is set. 171855 2 webkit.review.bot 2009-12-15 07:30:23 -0800 Attachment 44877 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:924: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:926: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:929: Use 0 instead of NULL. [readability/null] [5] WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:933: Use 0 instead of NULL. [readability/null] [5] Total errors found: 4 172716 3 44877 xan.lopez 2009-12-17 04:33:45 -0800 Comment on attachment 44877 display FPS statistics if WEBKIT_DEBUG environment variable is set. r=me 172740 4 pnormand 2009-12-17 06:28:55 -0800 Landed as r52251 44877 2009-12-15 07:25:34 -0800 2009-12-17 04:33:45 -0800 display FPS statistics if WEBKIT_DEBUG environment variable is set. display-FPS-statistics-if-WEBKITDEBUG-environment-.patch text/plain 4021 pnormand RnJvbSA0YzM2NjA2YWIwNjZlNDMxYTAyZjZhNWQ3MTExNTI4MGYyODBiZjAyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDEwIERlYyAyMDA5IDE4OjQ5OjQ4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g ZGlzcGxheSBGUFMgc3RhdGlzdGljcyBpZiBXRUJLSVRfREVCVUcgZW52aXJvbm1lbnQgdmFyaWFi bGUgaXMgc2V0LgoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgMTcgKysrKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvZ3RrL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICB8ICAgMjIgKysrKysrKysrKysrKysrKysrKy0K IC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmggICAgIHwgICAg MSArCiAzIGZpbGVzIGNoYW5nZWQsIDM5IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3 OWZlYTNhLi5hNmRjZWFiIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDA5LTEyLTE1ICBQaGlsaXBwZSBOb3Jt YW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbR1RLXSBkaXNwbGF5IEZQUyBzdGF0cyBmb3IgdmlkZW8gZWxl bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI1 NjAKKworICAgICAgICBEaXNwbGF5IEZQUyBzdGF0aXN0aWNzIGlmIFdFQktJVF9ERUJVRyBlbnZp cm9ubWVudCB2YXJpYWJsZQorICAgICAgICBjb250YWlucyB0aGUgTWVkaWEgbG9nIGNhdGVnb3J5 LiBUaGlzIGZlYXR1cmUgcmVxdWlyZXMgYSB2ZXJ5CisgICAgICAgIHJlY2VudCAoPj0gMC4xMC4x OCkgdmVyc2lvbiBvZiBnc3QtcGx1Z2lucy1iYWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6TWVkaWFQbGF5ZXJQcml2YXRlKToKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6fk1lZGlhUGxheWVyUHJpdmF0ZSk6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6OmNyZWF0ZUdTVFBsYXlCaW4pOgorICAgICAg ICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaDoK KwogMjAwOS0xMi0xNSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAg Tm8gcmV2aWV3LCByb2xsaW5nIG91dCByNTIxNDAuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApp bmRleCBmYjc5Mzc0Li5iNjM4ZTUxIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTE5 NSw2ICsxOTUsNyBAQCBNZWRpYVBsYXllclByaXZhdGU6Ok1lZGlhUGxheWVyUHJpdmF0ZShNZWRp YVBsYXllciogcGxheWVyKQogICAgIDogbV9wbGF5ZXIocGxheWVyKQogICAgICwgbV9wbGF5Qmlu KDApCiAgICAgLCBtX3ZpZGVvU2luaygwKQorICAgICwgbV9mcHNTaW5rKDApCiAgICAgLCBtX3Nv dXJjZSgwKQogICAgICwgbV9zZWVrVGltZSgwKQogICAgICwgbV9jaGFuZ2luZ1JhdGUoZmFsc2Up CkBAIC0yMjcsNiArMjI4LDExIEBAIE1lZGlhUGxheWVyUHJpdmF0ZTo6fk1lZGlhUGxheWVyUHJp dmF0ZSgpCiAgICAgICAgIGdfb2JqZWN0X3VucmVmKG1fdmlkZW9TaW5rKTsKICAgICAgICAgbV92 aWRlb1NpbmsgPSAwOwogICAgIH0KKworICAgIGlmIChtX2Zwc1NpbmspIHsKKyAgICAgICAgZ19v YmplY3RfdW5yZWYobV9mcHNTaW5rKTsKKyAgICAgICAgbV9mcHNTaW5rID0gMDsKKyAgICB9CiB9 CiAKIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpsb2FkKGNvbnN0IFN0cmluZyYgdXJsKQpAQCAt OTEwLDcgKzkxNiwyMSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6Y3JlYXRlR1NUUGxheUJp bihTdHJpbmcgdXJsKQogICAgIG1fdmlkZW9TaW5rID0gd2Via2l0X3ZpZGVvX3NpbmtfbmV3KCk7 CiAKICAgICBnX29iamVjdF9yZWZfc2luayhtX3ZpZGVvU2luayk7Ci0gICAgZ19vYmplY3Rfc2V0 KG1fcGxheUJpbiwgInZpZGVvLXNpbmsiLCBtX3ZpZGVvU2luaywgTlVMTCk7CisKKyAgICBXVEZM b2dDaGFubmVsKiBjaGFubmVsID0gZ2V0Q2hhbm5lbEZyb21OYW1lKCJNZWRpYSIpOworICAgIGlm IChjaGFubmVsLT5zdGF0ZSA9PSBXVEZMb2dDaGFubmVsT24pIHsKKyAgICAgICAgbV9mcHNTaW5r ID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJmcHNkaXNwbGF5c2luayIsICJzaW5rIik7Cisg ICAgICAgIGlmIChnX29iamVjdF9jbGFzc19maW5kX3Byb3BlcnR5KEdfT0JKRUNUX0dFVF9DTEFT UyhtX2Zwc1NpbmspLCAidmlkZW8tc2luayIpKSB7CisgICAgICAgICAgICBnX29iamVjdF9zZXQo R19PQkpFQ1QobV9mcHNTaW5rKSwgInZpZGVvLXNpbmsiLCBtX3ZpZGVvU2luaywgTlVMTCk7Cisg ICAgICAgICAgICBnX29iamVjdF9yZWZfc2luayhtX2Zwc1NpbmspOworICAgICAgICAgICAgZ19v YmplY3Rfc2V0KG1fcGxheUJpbiwgInZpZGVvLXNpbmsiLCBtX2Zwc1NpbmssIE5VTEwpOworICAg ICAgICB9IGVsc2UgeworICAgICAgICAgICAgbV9mcHNTaW5rID0gMDsKKyAgICAgICAgICAgIGdf b2JqZWN0X3NldChtX3BsYXlCaW4sICJ2aWRlby1zaW5rIiwgbV92aWRlb1NpbmssIE5VTEwpOwor ICAgICAgICAgICAgTE9HKE1lZGlhLCAiQ2FuJ3QgZGlzcGxheSBGUFMgc3RhdGlzdGljcywgeW91 IG5lZWQgZ3N0LXBsdWdpbnMtYmFkID49IDAuMTAuMTgiKTsKKyAgICAgICAgfQorICAgIH0gZWxz ZQorICAgICAgICBnX29iamVjdF9zZXQobV9wbGF5QmluLCAidmlkZW8tc2luayIsIG1fdmlkZW9T aW5rLCBOVUxMKTsKIAogICAgIGdfc2lnbmFsX2Nvbm5lY3QobV92aWRlb1NpbmssICJyZXBhaW50 LXJlcXVlc3RlZCIsIEdfQ0FMTEJBQ0sobWVkaWFQbGF5ZXJQcml2YXRlUmVwYWludENhbGxiYWNr KSwgdGhpcyk7CiB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCmluZGV4IDkxYzk3ZmMuLjUyMDI3NWMg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC0xMjMsNiArMTIzLDcgQEAgY2xhc3MgTWVkaWFQ bGF5ZXJQcml2YXRlIDogcHVibGljIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSB7CiAgICAg ICAgICAgICBNZWRpYVBsYXllciogbV9wbGF5ZXI7CiAgICAgICAgICAgICBHc3RFbGVtZW50KiBt X3BsYXlCaW47CiAgICAgICAgICAgICBHc3RFbGVtZW50KiBtX3ZpZGVvU2luazsKKyAgICAgICAg ICAgIEdzdEVsZW1lbnQqIG1fZnBzU2luazsKICAgICAgICAgICAgIEdzdEVsZW1lbnQqIG1fc291 cmNlOwogICAgICAgICAgICAgR3N0Q2xvY2tUaW1lIG1fc2Vla1RpbWU7CiAgICAgICAgICAgICBi b29sIG1fY2hhbmdpbmdSYXRlOwotLSAKMS42LjMuMw==