32549 2009-12-15 04:33:10 -0800 Allow custom memory allocation control for AnimationControllerPrivate and FillLayerPropertyWrapperGetter 2009-12-15 08:44:28 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 171808 0 zoltan 2009-12-15 04:33:10 -0800 Inherits AnimationControllerPrivate and FillLayerPropertyWrapperGetter classes from Noncopyable because these are instantiated by 'new' and no need to be copyable: class/struct name - instantiated at: WebCore/'location' AnimationControllerPrivate - page/animation/AnimationController.cpp:439 FillLayerPropertyWrapperGetter - (its child class) page/animation/AnimationBase.cpp:464 171809 1 44864 zoltan 2009-12-15 04:35:12 -0800 Created attachment 44864 proposed patch 171810 2 webkit.review.bot 2009-12-15 04:39:45 -0800 style-queue ran check-webkit-style on attachment 44864 without any errors. 171877 3 44864 commit-queue 2009-12-15 08:44:20 -0800 Comment on attachment 44864 proposed patch Clearing flags on attachment: 44864 Committed r52155: <http://trac.webkit.org/changeset/52155> 171878 4 commit-queue 2009-12-15 08:44:28 -0800 All reviewed patches have been landed. Closing bug. 44864 2009-12-15 04:35:12 -0800 2009-12-15 08:44:20 -0800 proposed patch animation.patch text/plain 2169 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjE0OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMTItMTUgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIEFuaW1hdGlvbkNvbnRy b2xsZXJQcml2YXRlIGFuZCBGaWxsTGF5ZXJQcm9wZXJ0eVdyYXBwZXJHZXR0ZXIKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNTQ5CisKKyAgICAgICAg SW5oZXJpdHMgQW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGUgYW5kIEZpbGxMYXllclByb3BlcnR5 V3JhcHBlckdldHRlcgorICAgICAgICBjbGFzc2VzIGZyb20gTm9uY29weWFibGUgYmVjYXVzZSB0 aGVzZSBhcmUgaW5zdGFudGlhdGVkIGJ5ICduZXcnIGFuZCBubyBuZWVkIHRvIGJlIGNvcHlhYmxl OgorCisgICAgICAgIGNsYXNzL3N0cnVjdCBuYW1lICAgICAgICAgICAgICAtIGluc3RhbnRpYXRl ZCBhdDogV2ViQ29yZS8nbG9jYXRpb24nCisKKyAgICAgICAgQW5pbWF0aW9uQ29udHJvbGxlclBy aXZhdGUgICAgIC0gcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQ29udHJvbGxlci5jcHA6NDM5Cisg ICAgICAgIEZpbGxMYXllclByb3BlcnR5V3JhcHBlckdldHRlciAtIChpdHMgY2hpbGQgY2xhc3Mp IHBhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwOjQ2NAorCisgICAgICAgICogcGFnZS9h bmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHA6CisgICAgICAgICogcGFnZS9hbmltYXRpb24vQW5p bWF0aW9uQ29udHJvbGxlclByaXZhdGUuaDoKKwogMjAwOS0xMi0xNSAgQWxleGFuZGVyIFBhdmxv diAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZl bGRtYW4uCkluZGV4OiBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkNvbnRyb2xsZXJQ cml2YXRlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25D b250cm9sbGVyUHJpdmF0ZS5oCShyZXZpc2lvbiA1MjE0OSkKKysrIFdlYkNvcmUvcGFnZS9hbmlt YXRpb24vQW5pbWF0aW9uQ29udHJvbGxlclByaXZhdGUuaAkod29ya2luZyBjb3B5KQpAQCAtNDks NyArNDksNyBAQAogY2xhc3MgUmVuZGVyT2JqZWN0OwogY2xhc3MgUmVuZGVyU3R5bGU7CiAKLWNs YXNzIEFuaW1hdGlvbkNvbnRyb2xsZXJQcml2YXRlIHsKK2NsYXNzIEFuaW1hdGlvbkNvbnRyb2xs ZXJQcml2YXRlIDogcHVibGljIE5vbmNvcHlhYmxlIHsKIHB1YmxpYzoKICAgICBBbmltYXRpb25D b250cm9sbGVyUHJpdmF0ZShGcmFtZSopOwogICAgIH5BbmltYXRpb25Db250cm9sbGVyUHJpdmF0 ZSgpOwpJbmRleDogV2ViQ29yZS9wYWdlL2FuaW1hdGlvbi9BbmltYXRpb25CYXNlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0FuaW1hdGlvbkJhc2UuY3BwCShyZXZp c2lvbiA1MjE0OSkKKysrIFdlYkNvcmUvcGFnZS9hbmltYXRpb24vQW5pbWF0aW9uQmFzZS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQwNyw3ICs0MDcsNyBAQAogfTsKIAogdGVtcGxhdGUgPHR5cGVu YW1lIFQ+Ci1jbGFzcyBGaWxsTGF5ZXJQcm9wZXJ0eVdyYXBwZXJHZXR0ZXIgOiBwdWJsaWMgRmls bExheWVyUHJvcGVydHlXcmFwcGVyQmFzZSB7CitjbGFzcyBGaWxsTGF5ZXJQcm9wZXJ0eVdyYXBw ZXJHZXR0ZXIgOiBwdWJsaWMgRmlsbExheWVyUHJvcGVydHlXcmFwcGVyQmFzZSwgcHVibGljIE5v bmNvcHlhYmxlIHsKIHB1YmxpYzoKICAgICBGaWxsTGF5ZXJQcm9wZXJ0eVdyYXBwZXJHZXR0ZXIo VCAoRmlsbExheWVyOjoqZ2V0dGVyKSgpIGNvbnN0KQogICAgICAgICA6IG1fZ2V0dGVyKGdldHRl cikK