32547 2009-12-15 04:00:57 -0800 Allow custom memory allocation control for WeakGCMap classes 2009-12-15 13:55:19 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 171799 0 zoltan 2009-12-15 04:00:57 -0800 Inherits WeakGCMap from Noncopyable because it is instantiated by 'new' at: WebCore/dom/Document.cpp:512 and don't need to be copyable. 171800 1 44861 zoltan 2009-12-15 04:06:21 -0800 Created attachment 44861 proposed patch 171802 2 webkit.review.bot 2009-12-15 04:08:37 -0800 style-queue ran check-webkit-style on attachment 44861 without any errors. 171873 3 44861 darin 2009-12-15 08:30:05 -0800 Comment on attachment 44861 proposed patch HashMap is copyable, so I’m not sure why we would treat this as noncopyable. Please use FastAllocBase instead. 171917 4 44887 zoltan 2009-12-15 10:34:08 -0800 Created attachment 44887 updated to FastAllocBase I chose Noncopyable because it is copied nowhere now, okay I filed the FastAllocBase-d version! 171918 5 webkit.review.bot 2009-12-15 10:34:50 -0800 style-queue ran check-webkit-style on attachment 44887 without any errors. 172010 6 44887 commit-queue 2009-12-15 13:55:15 -0800 Comment on attachment 44887 updated to FastAllocBase Clearing flags on attachment: 44887 Committed r52171: <http://trac.webkit.org/changeset/52171> 172011 7 commit-queue 2009-12-15 13:55:19 -0800 All reviewed patches have been landed. Closing bug. 44861 2009-12-15 04:06:21 -0800 2009-12-15 10:34:08 -0800 proposed patch weakgcmap.patch text/plain 1229 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha0dDTWFwLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvcnVudGltZS9XZWFrR0NNYXAuaAkocmV2aXNpb24gNTIxNDYpCisrKyBK YXZhU2NyaXB0Q29yZS9ydW50aW1lL1dlYWtHQ01hcC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw3 ICszNCw3IEBACiAKIC8vIEEgSGFzaE1hcCB3aG9zZSBnZXQoKSBmdW5jdGlvbiByZXR1cm5zIGVt cHR5VmFsdWUoKSBmb3IgY2VsbHMgYXdhaXRpbmcgZGVzdHJ1Y3Rpb24uCiB0ZW1wbGF0ZTx0eXBl bmFtZSBLZXlUeXBlLCB0eXBlbmFtZSBNYXBwZWRUeXBlPgotY2xhc3MgV2Vha0dDTWFwIHsKK2Ns YXNzIFdlYWtHQ01hcCA6IHB1YmxpYyBOb25jb3B5YWJsZSB7CiAgICAgLyoKICAgICBJbnZhcmlh bnRzOgogICAgICAgICAqIEEgdmFsdWUgZW50ZXJzIHRoZSBXZWFrR0NNYXAgbWFya2VkLiAoR3Vh cmFudGVlZCBieSBzZXQoKS4pCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MjE0NykKKysrIEph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisy MDA5LTEyLTE1ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFsbG93IGN1c3RvbSBtZW1v cnkgYWxsb2NhdGlvbiBjb250cm9sIGZvciBXZWFrR0NNYXAgY2xhc3MKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNTQ3CisKKyAgICAgICAgSW5oZXJp dHMgV2Vha0dDTWFwIGZyb20gTm9uY29weWFibGUgYmVjYXVzZSBpdCBpcyBpbnN0YW50aWF0ZWQg YnkKKyAgICAgICAgJ25ldycgYXQ6IFdlYkNvcmUvZG9tL0RvY3VtZW50LmNwcDo1MTIgYW5kIGRv bid0IG5lZWQgdG8gYmUgY29weWFibGUuCisKKyAgICAgICAgKiBydW50aW1lL1dlYWtHQ01hcC5o OgorCiAyMDA5LTEyLTE0ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgo= 44887 2009-12-15 10:34:08 -0800 2009-12-15 13:55:14 -0800 updated to FastAllocBase weakgcmap.patch text/plain 1203 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvV2Vha0dDTWFwLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvcnVudGltZS9XZWFrR0NNYXAuaAkocmV2aXNpb24gNTIxNjEpCisrKyBK YXZhU2NyaXB0Q29yZS9ydW50aW1lL1dlYWtHQ01hcC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw3 ICszNCw3IEBACiAKIC8vIEEgSGFzaE1hcCB3aG9zZSBnZXQoKSBmdW5jdGlvbiByZXR1cm5zIGVt cHR5VmFsdWUoKSBmb3IgY2VsbHMgYXdhaXRpbmcgZGVzdHJ1Y3Rpb24uCiB0ZW1wbGF0ZTx0eXBl bmFtZSBLZXlUeXBlLCB0eXBlbmFtZSBNYXBwZWRUeXBlPgotY2xhc3MgV2Vha0dDTWFwIHsKK2Ns YXNzIFdlYWtHQ01hcCA6IHB1YmxpYyBGYXN0QWxsb2NCYXNlIHsKICAgICAvKgogICAgIEludmFy aWFudHM6CiAgICAgICAgICogQSB2YWx1ZSBlbnRlcnMgdGhlIFdlYWtHQ01hcCBtYXJrZWQuIChH dWFyYW50ZWVkIGJ5IHNldCgpLikKSW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyMTYxKQorKysg SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMDktMTItMTUgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxsb3cgY3VzdG9tIG1l bW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIFdlYWtHQ01hcCBjbGFzcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI1NDcKKworICAgICAgICBJbmhl cml0cyBXZWFrR0NNYXAgZnJvbSBGYXN0QWxsb2NCYXNlIGJlY2F1c2UgaXQgaXMgaW5zdGFudGlh dGVkIGJ5CisgICAgICAgICduZXcnIGF0OiBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHA6NTEyLgor CisgICAgICAgICogcnVudGltZS9XZWFrR0NNYXAuaDoKKwogMjAwOS0xMi0xNCAgR2VvZmZyZXkg R2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZy YXNlci4K