32539 2009-12-14 22:07:08 -0800 Kill _create_step_sequence 2009-12-15 01:07:12 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric webkit.review.bot oldest_to_newest 171713 0 abarth 2009-12-14 22:07:08 -0800 Eric asked me to remove this in an earlier review comment, but I delayed applying his advice until now. 171714 1 44843 abarth 2009-12-14 22:08:37 -0800 Created attachment 44843 Patch 171715 2 webkit.review.bot 2009-12-14 22:09:28 -0800 style-queue ran check-webkit-style on attachment 44843 without any errors. 171716 3 44844 abarth 2009-12-14 22:12:31 -0800 Created attachment 44844 Patch 171718 4 44844 eric 2009-12-14 22:13:34 -0800 Comment on attachment 44844 Patch LGTM! 171751 5 eric 2009-12-15 01:07:12 -0800 http://trac.webkit.org/changeset/52136 44843 2009-12-14 22:08:37 -0800 2009-12-14 22:12:26 -0800 Patch bug-32539-20091214220835.patch text/plain 3316 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmNGM2YTllLi5kZDE3NjM4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMDktMTIt MTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBLaWxsIF9jcmVhdGVfc3RlcF9zZXF1ZW5jZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI1MzkKKwor ICAgICAgICBJdCdzIGNsZWFuZXIgdG8gcmVwcmVzZW50IG5vdCBoYXZpbmcgdGhlc2Ugc2VxdWVu Y2VzIGFzIGFuIGVtcHR5CisgICAgICAgIHNlcXVlbmNlIGluc3RlYWQgb2YgTm9uZS4KKworICAg ICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9kb3dubG9hZC5weToKKyAgICAgICAgKiBT Y3JpcHRzL21vZHVsZXMvc3RlcHNlcXVlbmNlLnB5OgorCisyMDA5LTEyLTE0ICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgVW5yZXZpZXdlZC4gIEFkZHJlc3MgcmV2 aWV3ZXIgY29tbWVudHMgZnJvbSBhbiBlYXJsaWVyIHBhdGNoLiAgSSBkaWRuJ3QKICAgICAgICAg ZG8gdGhpcyBlYXJsaWVyIGJlY2F1c2UgSSB3YXMgd29ycmllZCBhYm91dCBjb25mbGljdHMgaW4g ZGVwZW5kZW50CiAgICAgICAgIHBhdGNoZXMuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY29tbWFuZHMvZG93bmxvYWQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvY29tbWFuZHMvZG93bmxvYWQucHkKaW5kZXggODUwMzM3YS4uY2RjODFjMSAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkLnB5Cisr KyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9kb3dubG9hZC5weQpAQCAt MTMyLDI4ICsxMzIsMTkgQEAgY2xhc3MgQWJzdHJhY3RQYXRjaFNlcXVlbmNpbmdDb21tYW5kKEFi c3RyYWN0UGF0Y2hQcm9jZXNzaW5nQ29tbWFuZCk6CiAgICAgcHJlcGFyZV9zdGVwcyA9IE5vbmUK ICAgICBtYWluX3N0ZXBzID0gTm9uZQogCi0gICAgQHN0YXRpY21ldGhvZAotICAgIGRlZiBfY3Jl YXRlX3N0ZXBfc2VxdWVuY2Uoc3RlcHMpOgotICAgICAgICBpZiBub3Qgc3RlcHM6Ci0gICAgICAg ICAgICByZXR1cm4gTm9uZSwgW10KLSAgICAgICAgc3RlcF9zZXF1ZW5jZSA9IFN0ZXBTZXF1ZW5j ZShzdGVwcykKLSAgICAgICAgcmV0dXJuIHN0ZXBfc2VxdWVuY2UsIHN0ZXBfc2VxdWVuY2Uub3B0 aW9ucygpCi0KICAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIG9wdGlvbnMgPSBbXQot ICAgICAgICBzZWxmLl9wcmVwYXJlX3NlcXVlbmNlLCBwcmVwYXJlX29wdGlvbnMgPSBzZWxmLl9j cmVhdGVfc3RlcF9zZXF1ZW5jZShzZWxmLnByZXBhcmVfc3RlcHMpCi0gICAgICAgIHNlbGYuX21h aW5fc2VxdWVuY2UsIG1haW5fb3B0aW9ucyA9IHNlbGYuX2NyZWF0ZV9zdGVwX3NlcXVlbmNlKHNl bGYubWFpbl9zdGVwcykKLSAgICAgICAgb3B0aW9ucyA9IHNvcnRlZChzZXQocHJlcGFyZV9vcHRp b25zICsgbWFpbl9vcHRpb25zKSkKKyAgICAgICAgc2VsZi5fcHJlcGFyZV9zZXF1ZW5jZSA9IFN0 ZXBTZXF1ZW5jZShzZWxmLnByZXBhcmVfc3RlcHMpCisgICAgICAgIHNlbGYuX21haW5fc2VxdWVu Y2UgPSBTdGVwU2VxdWVuY2Uoc2VsZi5tYWluX3N0ZXBzKQorICAgICAgICBvcHRpb25zID0gc29y dGVkKHNldChzZWxmLl9wcmVwYXJlX3NlcXVlbmNlLm9wdGlvbnMoKSArIHNlbGYuX21haW5fc2Vx dWVuY2Uub3B0aW9ucygpKSkKICAgICAgICAgQWJzdHJhY3RQYXRjaFByb2Nlc3NpbmdDb21tYW5k Ll9faW5pdF9fKHNlbGYsIG9wdGlvbnMpCiAKICAgICBkZWYgX3ByZXBhcmVfdG9fcHJvY2Vzcyhz ZWxmLCBvcHRpb25zLCBhcmdzLCB0b29sKToKLSAgICAgICAgaWYgc2VsZi5fcHJlcGFyZV9zZXF1 ZW5jZToKLSAgICAgICAgICAgIHNlbGYuX3ByZXBhcmVfc2VxdWVuY2UucnVuX2FuZF9oYW5kbGVf ZXJyb3JzKHRvb2wsIG9wdGlvbnMpCisgICAgICAgIHNlbGYuX3ByZXBhcmVfc2VxdWVuY2UucnVu X2FuZF9oYW5kbGVfZXJyb3JzKHRvb2wsIG9wdGlvbnMpCiAKICAgICBkZWYgX3Byb2Nlc3NfcGF0 Y2goc2VsZiwgcGF0Y2gsIG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgotICAgICAgICBpZiBzZWxmLl9t YWluX3NlcXVlbmNlOgotICAgICAgICAgICAgc3RhdGUgPSB7ICJwYXRjaCIgOiBwYXRjaCB9Ci0g ICAgICAgICAgICBzZWxmLl9tYWluX3NlcXVlbmNlLnJ1bl9hbmRfaGFuZGxlX2Vycm9ycyh0b29s LCBvcHRpb25zLCBzdGF0ZSkKKyAgICAgICAgc3RhdGUgPSB7ICJwYXRjaCIgOiBwYXRjaCB9Cisg ICAgICAgIHNlbGYuX21haW5fc2VxdWVuY2UucnVuX2FuZF9oYW5kbGVfZXJyb3JzKHRvb2wsIG9w dGlvbnMsIHN0YXRlKQogCiAKIGNsYXNzIFByb2Nlc3NBdHRhY2htZW50c01peGluKG9iamVjdCk6 CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc3RlcHNlcXVlbmNlLnB5 IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3N0ZXBzZXF1ZW5jZS5weQppbmRleCAwZTQz YzM0Li4yMWZhM2RhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc3Rl cHNlcXVlbmNlLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zdGVwc2VxdWVu Y2UucHkKQEAgLTQ0LDYgKzQ0LDggQEAgY2xhc3MgU3RlcFNlcXVlbmNlKG9iamVjdCk6CiAgICAg ICAgIHNlbGYuX3N0ZXBzID0gc3RlcHMKIAogICAgIGRlZiBvcHRpb25zKHNlbGYpOgorICAgICAg ICBpZiBub3Qgc2VsZi5fc3RlcHM6CisgICAgICAgICAgICByZXR1cm4gW10KICAgICAgICAgY29s bGVjdGVkX29wdGlvbnMgPSBbCiAgICAgICAgICAgICBDb21tYW5kT3B0aW9ucy5wYXJlbnRfY29t bWFuZCwKICAgICAgICAgICAgIENvbW1hbmRPcHRpb25zLnF1aWV0LApAQCAtNTUsNiArNTcsOCBA QCBjbGFzcyBTdGVwU2VxdWVuY2Uob2JqZWN0KToKICAgICAgICAgcmV0dXJuIGNvbGxlY3RlZF9v cHRpb25zCiAKICAgICBkZWYgX3J1bihzZWxmLCB0b29sLCBvcHRpb25zLCBzdGF0ZSk6CisgICAg ICAgIGlmIG5vdCBzZWxmLl9zdGVwczoKKyAgICAgICAgICAgIHJldHVybgogICAgICAgICBmb3Ig c3RlcCBpbiBzZWxmLl9zdGVwczoKICAgICAgICAgICAgIHN0ZXAodG9vbCwgb3B0aW9ucykucnVu KHN0YXRlKQogCg== 44844 2009-12-14 22:12:31 -0800 2009-12-14 22:13:33 -0800 Patch bug-32539-20091214221230.patch text/plain 3035 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmNGM2YTllLi5kZDE3NjM4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMDktMTIt MTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBLaWxsIF9jcmVhdGVfc3RlcF9zZXF1ZW5jZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI1MzkKKwor ICAgICAgICBJdCdzIGNsZWFuZXIgdG8gcmVwcmVzZW50IG5vdCBoYXZpbmcgdGhlc2Ugc2VxdWVu Y2VzIGFzIGFuIGVtcHR5CisgICAgICAgIHNlcXVlbmNlIGluc3RlYWQgb2YgTm9uZS4KKworICAg ICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9kb3dubG9hZC5weToKKyAgICAgICAgKiBT Y3JpcHRzL21vZHVsZXMvc3RlcHNlcXVlbmNlLnB5OgorCisyMDA5LTEyLTE0ICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAgVW5yZXZpZXdlZC4gIEFkZHJlc3MgcmV2 aWV3ZXIgY29tbWVudHMgZnJvbSBhbiBlYXJsaWVyIHBhdGNoLiAgSSBkaWRuJ3QKICAgICAgICAg ZG8gdGhpcyBlYXJsaWVyIGJlY2F1c2UgSSB3YXMgd29ycmllZCBhYm91dCBjb25mbGljdHMgaW4g ZGVwZW5kZW50CiAgICAgICAgIHBhdGNoZXMuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY29tbWFuZHMvZG93bmxvYWQucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvY29tbWFuZHMvZG93bmxvYWQucHkKaW5kZXggODUwMzM3YS4uY2RjODFjMSAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkLnB5Cisr KyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9kb3dubG9hZC5weQpAQCAt MTMyLDI4ICsxMzIsMTkgQEAgY2xhc3MgQWJzdHJhY3RQYXRjaFNlcXVlbmNpbmdDb21tYW5kKEFi c3RyYWN0UGF0Y2hQcm9jZXNzaW5nQ29tbWFuZCk6CiAgICAgcHJlcGFyZV9zdGVwcyA9IE5vbmUK ICAgICBtYWluX3N0ZXBzID0gTm9uZQogCi0gICAgQHN0YXRpY21ldGhvZAotICAgIGRlZiBfY3Jl YXRlX3N0ZXBfc2VxdWVuY2Uoc3RlcHMpOgotICAgICAgICBpZiBub3Qgc3RlcHM6Ci0gICAgICAg ICAgICByZXR1cm4gTm9uZSwgW10KLSAgICAgICAgc3RlcF9zZXF1ZW5jZSA9IFN0ZXBTZXF1ZW5j ZShzdGVwcykKLSAgICAgICAgcmV0dXJuIHN0ZXBfc2VxdWVuY2UsIHN0ZXBfc2VxdWVuY2Uub3B0 aW9ucygpCi0KICAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIG9wdGlvbnMgPSBbXQot ICAgICAgICBzZWxmLl9wcmVwYXJlX3NlcXVlbmNlLCBwcmVwYXJlX29wdGlvbnMgPSBzZWxmLl9j cmVhdGVfc3RlcF9zZXF1ZW5jZShzZWxmLnByZXBhcmVfc3RlcHMpCi0gICAgICAgIHNlbGYuX21h aW5fc2VxdWVuY2UsIG1haW5fb3B0aW9ucyA9IHNlbGYuX2NyZWF0ZV9zdGVwX3NlcXVlbmNlKHNl bGYubWFpbl9zdGVwcykKLSAgICAgICAgb3B0aW9ucyA9IHNvcnRlZChzZXQocHJlcGFyZV9vcHRp b25zICsgbWFpbl9vcHRpb25zKSkKKyAgICAgICAgc2VsZi5fcHJlcGFyZV9zZXF1ZW5jZSA9IFN0 ZXBTZXF1ZW5jZShzZWxmLnByZXBhcmVfc3RlcHMpCisgICAgICAgIHNlbGYuX21haW5fc2VxdWVu Y2UgPSBTdGVwU2VxdWVuY2Uoc2VsZi5tYWluX3N0ZXBzKQorICAgICAgICBvcHRpb25zID0gc29y dGVkKHNldChzZWxmLl9wcmVwYXJlX3NlcXVlbmNlLm9wdGlvbnMoKSArIHNlbGYuX21haW5fc2Vx dWVuY2Uub3B0aW9ucygpKSkKICAgICAgICAgQWJzdHJhY3RQYXRjaFByb2Nlc3NpbmdDb21tYW5k Ll9faW5pdF9fKHNlbGYsIG9wdGlvbnMpCiAKICAgICBkZWYgX3ByZXBhcmVfdG9fcHJvY2Vzcyhz ZWxmLCBvcHRpb25zLCBhcmdzLCB0b29sKToKLSAgICAgICAgaWYgc2VsZi5fcHJlcGFyZV9zZXF1 ZW5jZToKLSAgICAgICAgICAgIHNlbGYuX3ByZXBhcmVfc2VxdWVuY2UucnVuX2FuZF9oYW5kbGVf ZXJyb3JzKHRvb2wsIG9wdGlvbnMpCisgICAgICAgIHNlbGYuX3ByZXBhcmVfc2VxdWVuY2UucnVu X2FuZF9oYW5kbGVfZXJyb3JzKHRvb2wsIG9wdGlvbnMpCiAKICAgICBkZWYgX3Byb2Nlc3NfcGF0 Y2goc2VsZiwgcGF0Y2gsIG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgotICAgICAgICBpZiBzZWxmLl9t YWluX3NlcXVlbmNlOgotICAgICAgICAgICAgc3RhdGUgPSB7ICJwYXRjaCIgOiBwYXRjaCB9Ci0g ICAgICAgICAgICBzZWxmLl9tYWluX3NlcXVlbmNlLnJ1bl9hbmRfaGFuZGxlX2Vycm9ycyh0b29s LCBvcHRpb25zLCBzdGF0ZSkKKyAgICAgICAgc3RhdGUgPSB7ICJwYXRjaCIgOiBwYXRjaCB9Cisg ICAgICAgIHNlbGYuX21haW5fc2VxdWVuY2UucnVuX2FuZF9oYW5kbGVfZXJyb3JzKHRvb2wsIG9w dGlvbnMsIHN0YXRlKQogCiAKIGNsYXNzIFByb2Nlc3NBdHRhY2htZW50c01peGluKG9iamVjdCk6 CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc3RlcHNlcXVlbmNlLnB5 IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3N0ZXBzZXF1ZW5jZS5weQppbmRleCAwZTQz YzM0Li4wODU4ZjkxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc3Rl cHNlcXVlbmNlLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9zdGVwc2VxdWVu Y2UucHkKQEAgLTQxLDcgKzQxLDcgQEAgY2xhc3MgU3RlcFNlcXVlbmNlRXJyb3JIYW5kbGVyKCk6 CiAKIGNsYXNzIFN0ZXBTZXF1ZW5jZShvYmplY3QpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBz dGVwcyk6Ci0gICAgICAgIHNlbGYuX3N0ZXBzID0gc3RlcHMKKyAgICAgICAgc2VsZi5fc3RlcHMg PSBzdGVwcyBvciBbXQogCiAgICAgZGVmIG9wdGlvbnMoc2VsZik6CiAgICAgICAgIGNvbGxlY3Rl ZF9vcHRpb25zID0gWwo=