32524 2009-12-14 09:57:31 -0800 REGRESSION(52084): fast/dom/prototypes.html failing two CSS tests 2009-12-14 10:55:36 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric ggaren ggaren hausmann ossy webkit.review.bot oldest_to_newest 171453 0 eric 2009-12-14 09:57:31 -0800 REGRESSION(52084?): fast/dom/prototypes.html failing two CSS tests Buildbot seems to think that: http://trac.webkit.org/changeset/52084 is the cause, but that change seems unrelated. http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r52096%20(8321)/fast/dom/prototypes-pretty-diff.html 171454 1 eric 2009-12-14 09:59:32 -0800 The build for r52083 had 2 failures, but they were unrelated to this one: http://build.webkit.org/builders/Leopard%20Intel%20Release%20(Tests)/builds/8305 171458 2 ggaren 2009-12-14 10:17:49 -0800 I think the parentheses in http://trac.webkit.org/changeset/52084 may have been wrong. If so, it's definitely related. 171465 3 ggaren 2009-12-14 10:27:32 -0800 Confirmed. http://trac.webkit.org/changeset/52084 was bogus. 171467 4 44807 ggaren 2009-12-14 10:32:53 -0800 Created attachment 44807 patch 171469 5 ossy 2009-12-14 10:33:44 -0800 Ooops, sorry. "+" has really higher precedence than "&". 171470 6 webkit.review.bot 2009-12-14 10:34:30 -0800 style-queue ran check-webkit-style on attachment 44807 without any errors. 171474 7 ggaren 2009-12-14 10:41:41 -0800 http://trac.webkit.org/changeset/52101 171478 8 ggaren 2009-12-14 10:55:36 -0800 This should also fix a GC test failure on Windows. 44807 2009-12-14 10:32:53 -0800 2009-12-14 10:34:39 -0800 patch ro.txt text/plain 1374 ggaren SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyMTAwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTItMTQgIEdlb2ZmcmV5 IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzI1MjQKKyAgICAgICAgUkVHUkVTU0lPTig1MjA4NCk6IGZhc3QvZG9tL3Byb3RvdHlwZXMu aHRtbCBmYWlsaW5nIHR3byBDU1MgdGVzdHMKKworICAgICAgICAqIHd0Zi9TdGRMaWJFeHRyYXMu aDoKKyAgICAgICAgKFdURjo6Yml0Q291bnQpOiBUaGUgb3JpZ2luYWwgcGF0Y2ggcHV0IHRoZSBw YXJlbnRoZXNlcyBpbiB0aGUgd3JvbmcKKyAgICAgICAgcGxhY2UsIGNvbXBsZXRlbHkgY2hhbmdp bmcgdGhlIGNhbGN1bGF0aW9uIGFuZCBtYWtpbmcgaXQgYWxtb3N0IGFsd2F5cworICAgICAgICB3 cm9uZy4gTW92ZWQgdGhlIHBhcmVudGhlc2VzIGFyb3VuZCB0aGUgJysnIG9wZXJhdGlvbiwgbGlr ZSB0aGUgb3JpZ2luYWwKKyAgICAgICAgY29tcGlsZXIgd2FybmluZyBzdWdnZXN0ZWQuCisKIDIw MDktMTItMTQgIEdhYm9yIExva2kgIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBV bnJldmlld2VkIHRyaXZpYWwgYnVpbGRmaXguCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvU3Rk TGliRXh0cmFzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1N0ZExpYkV4dHJh cy5oCShyZXZpc2lvbiA1MjEwMCkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9TdGRMaWJFeHRyYXMu aAkod29ya2luZyBjb3B5KQpAQCAtNzQsNyArNzQsNyBAQCBuYW1lc3BhY2UgV1RGIHsKICAgICB7 CiAgICAgICAgIGJpdHMgPSBiaXRzIC0gKChiaXRzID4+IDEpICYgMHg1NTU1NTU1NSk7CiAgICAg ICAgIGJpdHMgPSAoYml0cyAmIDB4MzMzMzMzMzMpICsgKChiaXRzID4+IDIpICYgMHgzMzMzMzMz Myk7Ci0gICAgICAgIHJldHVybiAoKGJpdHMgKyAoKGJpdHMgPj4gNCkgJiAweEYwRjBGMEYpKSAq IDB4MTAxMDEwMSkgPj4gMjQ7CisgICAgICAgIHJldHVybiAoKChiaXRzICsgKGJpdHMgPj4gNCkp ICYgMHhGMEYwRjBGKSAqIDB4MTAxMDEwMSkgPj4gMjQ7CiAgICAgfQogCiB9IC8vIG5hbWVzcGFj ZSBXVEYK