32517 2009-12-14 07:23:12 -0800 Web Inspector: Need to implement InjectedScript.evaluateOnSelf() 2009-12-14 12:21:25 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 apavlov webkit-unassigned bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy webkit.review.bot oldest_to_newest 171397 0 apavlov 2009-12-14 07:23:12 -0800 A method to evaluate JavaScript code in the utility context (InjectedScript) is necessary for audits dealing with the inspected page DOM. 171399 1 44796 apavlov 2009-12-14 07:33:25 -0800 Created attachment 44796 patch 171401 2 webkit.review.bot 2009-12-14 07:35:03 -0800 style-queue ran check-webkit-style on attachment 44796 without any errors. 171405 3 44796 pfeldman 2009-12-14 07:55:54 -0800 Comment on attachment 44796 patch Please add a note on what this is needed for into the bug. 171407 4 apavlov 2009-12-14 08:05:17 -0800 (In reply to comment #3) > (From update of attachment 44796 [details]) > Please add a note on what this is needed for into the bug. I'm starting to commit the Audits panel step by step (the change is rather big), and this is the first bit. 171500 5 44796 commit-queue 2009-12-14 12:21:20 -0800 Comment on attachment 44796 patch Clearing flags on attachment: 44796 Committed r52108: <http://trac.webkit.org/changeset/52108> 171501 6 commit-queue 2009-12-14 12:21:25 -0800 All reviewed patches have been landed. Closing bug. 44796 2009-12-14 07:33:25 -0800 2009-12-14 12:21:20 -0800 patch evalonself.patch text/plain 1919 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTA0NDk4Yi4uZWQ0MjAxNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMi0xNCAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBJbmplY3RlZFNjcmlwdC5ldmFsdWF0ZU9u U2VsZigpIHRoYXQgZXZhbHVhdGVzIGZ1bmN0aW9ucyBpbiB0aGUgSW5qZWN0ZWRTY3JpcHQgY29u dGV4dC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMy NTE3CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzOgor ICAgICAgICAoSW5qZWN0ZWRTY3JpcHQuZXZhbHVhdGVPblNlbGYpOgorICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHRBY2Nlc3MuanM6CisKIDIwMDktMTItMDMgIEhv bGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8emVja2VAc2VsZmlzaC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvSW5qZWN0ZWRTY3JpcHQuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvSW5qZWN0ZWRTY3JpcHQuanMKaW5kZXggMjA5ZTk5Zi4uNGY0MTY4YiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0LmpzCisrKyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdC5qcwpAQCAtMTA3OSw2ICsxMDc5 LDExIEBAIEluamVjdGVkU2NyaXB0LmNyZWF0ZVByb3h5T2JqZWN0ID0gZnVuY3Rpb24ob2JqZWN0 LCBvYmplY3RJZCwgYWJicmV2aWF0ZSkKICAgICByZXR1cm4gcmVzdWx0OwogfQogCitJbmplY3Rl ZFNjcmlwdC5ldmFsdWF0ZU9uU2VsZiA9IGZ1bmN0aW9uKGZ1bmNCb2R5KQoreworICAgIHJldHVy biB3aW5kb3cuZXZhbCgiKCIgKyBmdW5jQm9keSArICIpKCk7Iik7Cit9CisKIEluamVjdGVkU2Ny aXB0LkNhbGxGcmFtZVByb3h5ID0gZnVuY3Rpb24oaWQsIGNhbGxGcmFtZSkKIHsKICAgICB0aGlz LmlkID0gaWQ7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0 ZWRTY3JpcHRBY2Nlc3MuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvSW5qZWN0ZWRT Y3JpcHRBY2Nlc3MuanMKaW5kZXggMTRhM2E2Yi4uZTFmMmEzNiAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0luamVjdGVkU2NyaXB0QWNjZXNzLmpzCisrKyBiL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9JbmplY3RlZFNjcmlwdEFjY2Vzcy5qcwpAQCAtNzYsNiAr NzYsNyBAQCBJbmplY3RlZFNjcmlwdEFjY2Vzcy5faW5zdGFsbEhhbmRsZXIoInNldFByb3BlcnR5 VmFsdWUiKTsKIEluamVjdGVkU2NyaXB0QWNjZXNzLl9pbnN0YWxsSGFuZGxlcigic2V0U3R5bGVQ cm9wZXJ0eSIpOwogSW5qZWN0ZWRTY3JpcHRBY2Nlc3MuX2luc3RhbGxIYW5kbGVyKCJzZXRTdHls ZVRleHQiKTsKIEluamVjdGVkU2NyaXB0QWNjZXNzLl9pbnN0YWxsSGFuZGxlcigidG9nZ2xlU3R5 bGVFbmFibGVkIik7CitJbmplY3RlZFNjcmlwdEFjY2Vzcy5faW5zdGFsbEhhbmRsZXIoImV2YWx1 YXRlT25TZWxmIik7CiAKIC8vIFNvbWUgbWV0aG9kcyBjYW4ndCBydW4gc3luY2hyb25vdXNseSBl dmVuIG9uIHRoZSBpbmplY3RlZCBzY3JpcHQgc2lkZSAoc3VjaCBhcyBEQiB0cmFuc2FjdGlvbnMp LgogLy8gTWFyayB0aGVtIGFzIGFzeW5jaHJvbm91cyBoZXJlLgo=