32491 2009-12-13 10:29:47 -0800 [Qt] The test tst_QWebPage::inputMethods(QWebView) fails 2009-12-14 12:35:44 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt P2 Normal --- 32216 1 benjamin kling benjamin commit-queue kling webkit.review.bot oldest_to_newest 171217 0 benjamin 2009-12-13 10:29:47 -0800 The autotest tst_QWebPage::inputMethods(QWebView) is failing: FAIL! : tst_QWebPage::inputMethods(QWebView) Compared values are not the same Actual (QString("-webkit-serif")): -webkit-serif Expected (font.family()): Times New Roman Loc: [/home/ikipou/dev/webkit/qtwebkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1411)] FAIL! : tst_QWebPage::inputMethods(QGraphicsWebView) Compared values are not the same Actual (QString("-webkit-serif")): -webkit-serif Expected (font.family()): Times New Roman Loc: [/home/ikipou/dev/webkit/qtwebkit/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(1411)] 171381 1 44792 kling 2009-12-14 06:40:12 -0800 Created attachment 44792 Update the test to expect the correct behavior 171383 2 44793 kling 2009-12-14 06:41:32 -0800 Created attachment 44793 Update the test to expect the correct behavior Same patch with a minor tweak to the changelog entry. 171388 3 webkit.review.bot 2009-12-14 06:48:46 -0800 style-queue ran check-webkit-style on attachment 44793 without any errors. 171417 4 44793 hausmann 2009-12-14 08:26:46 -0800 Comment on attachment 44793 Update the test to expect the correct behavior r=me, thanks! 171508 5 44793 commit-queue 2009-12-14 12:35:39 -0800 Comment on attachment 44793 Update the test to expect the correct behavior Clearing flags on attachment: 44793 Committed r52110: <http://trac.webkit.org/changeset/52110> 171509 6 commit-queue 2009-12-14 12:35:44 -0800 All reviewed patches have been landed. Closing bug. 44792 2009-12-14 06:40:12 -0800 2009-12-14 06:41:32 -0800 Update the test to expect the correct behavior bug-32491.diff text/plain 1705 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDA5MDI0OTIuLmVmYzU1MDEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTEyLTE0ICBBbmRy ZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSBRV2ViUGFnZSBpbnB1dE1ldGhv ZHMoKSBhZnRlciByNTE3NTgKKyAgICAgICAgdG8gY29tcGFyZSB0aGUgUXQ6OkltRm9udCBwcm9w ZXJ0eSdzIGZhbWlseSBhZ2FpbnN0IGFuIGV4cGxpY2l0bHkKKyAgICAgICAgcHJldmlvdXNseSBj b25maWd1cmVkIGZhbWlseS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzI0OTEKKworICAgICAgICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFn ZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6OmlucHV0TWV0aG9kcyk6CisKIDIwMDktMTIt MTMgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC90 ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdl L3RzdF9xd2VicGFnZS5jcHAKaW5kZXggMmE1MjYzMS4uZTY4YzIxMCAxMDA2NDQKLS0tIGEvV2Vi S2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L3Rl c3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKQEAgLTEzNzMsNiArMTM3Myw3IEBAIHZvaWQg dHN0X1FXZWJQYWdlOjppbnB1dE1ldGhvZHMoKQogICAgIGVsc2UKICAgICAgICAgUVZFUklGWTIo ZmFsc2UsICJVbmtub3duIHZpZXcgdHlwZSIpOwogCisgICAgcGFnZS0+c2V0dGluZ3MoKS0+c2V0 Rm9udEZhbWlseShRV2ViU2V0dGluZ3M6OlNlcmlmRm9udCwgIkZvb1NlcmlmRm9udCIpOwogICAg IHBhZ2UtPm1haW5GcmFtZSgpLT5zZXRIdG1sKCI8aHRtbD48Ym9keT4iIFwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxpbnB1dCB0eXBlPSd0ZXh0JyBpZD0n aW5wdXQxJyBzdHlsZT0nZm9udC1mYW1pbHk6IHNlcmlmJyB2YWx1ZT0nJyBtYXhsZW5ndGg9JzIw Jy8+PGJyPiIgXAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi PGlucHV0IHR5cGU9J3Bhc3N3b3JkJy8+IiBcCkBAIC0xNDA4LDcgKzE0MDksNyBAQCB2b2lkIHRz dF9RV2ViUGFnZTo6aW5wdXRNZXRob2RzKCkKICAgICAvL0ltRm9udAogICAgIHZhcmlhbnQgPSBw YWdlLT5pbnB1dE1ldGhvZFF1ZXJ5KFF0OjpJbUZvbnQpOwogICAgIFFGb250IGZvbnQgPSB2YXJp YW50LnZhbHVlPFFGb250PigpOwotICAgIFFDT01QQVJFKFFTdHJpbmcoIi13ZWJraXQtc2VyaWYi KSwgZm9udC5mYW1pbHkoKSk7CisgICAgUUNPTVBBUkUocGFnZS0+c2V0dGluZ3MoKS0+Zm9udEZh bWlseShRV2ViU2V0dGluZ3M6OlNlcmlmRm9udCksIGZvbnQuZmFtaWx5KCkpOwogCiAgICAgUUxp c3Q8UUlucHV0TWV0aG9kRXZlbnQ6OkF0dHJpYnV0ZT4gaW5wdXRBdHRyaWJ1dGVzOwogCg== 44793 2009-12-14 06:41:32 -0800 2009-12-14 12:35:39 -0800 Update the test to expect the correct behavior bug-32491.diff text/plain 1714 kling ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDA5MDI0OTIuLmVmYzU1MDEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTEyLTE0ICBBbmRy ZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSBRV2ViUGFnZSBpbnB1dE1ldGhv ZHMoKSBhdXRvdGVzdCBhZnRlciByNTE3NTgKKyAgICAgICAgdG8gY29tcGFyZSB0aGUgUXQ6Oklt Rm9udCBwcm9wZXJ0eSdzIGZhbWlseSBhZ2FpbnN0IGFuIGV4cGxpY2l0bHkKKyAgICAgICAgcHJl dmlvdXNseSBjb25maWd1cmVkIGZhbWlseS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI0OTEKKworICAgICAgICAqIHRlc3RzL3F3ZWJwYWdlL3Rz dF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6OmlucHV0TWV0aG9kcyk6CisK IDIwMDktMTItMTMgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dl YktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L3Rlc3Rz L3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKaW5kZXggMmE1MjYzMS4uZTY4YzIxMCAxMDA2NDQK LS0tIGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKKysrIGIvV2Vi S2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKQEAgLTEzNzMsNiArMTM3Myw3 IEBAIHZvaWQgdHN0X1FXZWJQYWdlOjppbnB1dE1ldGhvZHMoKQogICAgIGVsc2UKICAgICAgICAg UVZFUklGWTIoZmFsc2UsICJVbmtub3duIHZpZXcgdHlwZSIpOwogCisgICAgcGFnZS0+c2V0dGlu Z3MoKS0+c2V0Rm9udEZhbWlseShRV2ViU2V0dGluZ3M6OlNlcmlmRm9udCwgIkZvb1NlcmlmRm9u dCIpOwogICAgIHBhZ2UtPm1haW5GcmFtZSgpLT5zZXRIdG1sKCI8aHRtbD48Ym9keT4iIFwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIjxpbnB1dCB0eXBlPSd0 ZXh0JyBpZD0naW5wdXQxJyBzdHlsZT0nZm9udC1mYW1pbHk6IHNlcmlmJyB2YWx1ZT0nJyBtYXhs ZW5ndGg9JzIwJy8+PGJyPiIgXAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAiPGlucHV0IHR5cGU9J3Bhc3N3b3JkJy8+IiBcCkBAIC0xNDA4LDcgKzE0MDksNyBA QCB2b2lkIHRzdF9RV2ViUGFnZTo6aW5wdXRNZXRob2RzKCkKICAgICAvL0ltRm9udAogICAgIHZh cmlhbnQgPSBwYWdlLT5pbnB1dE1ldGhvZFF1ZXJ5KFF0OjpJbUZvbnQpOwogICAgIFFGb250IGZv bnQgPSB2YXJpYW50LnZhbHVlPFFGb250PigpOwotICAgIFFDT01QQVJFKFFTdHJpbmcoIi13ZWJr aXQtc2VyaWYiKSwgZm9udC5mYW1pbHkoKSk7CisgICAgUUNPTVBBUkUocGFnZS0+c2V0dGluZ3Mo KS0+Zm9udEZhbWlseShRV2ViU2V0dGluZ3M6OlNlcmlmRm9udCksIGZvbnQuZmFtaWx5KCkpOwog CiAgICAgUUxpc3Q8UUlucHV0TWV0aG9kRXZlbnQ6OkF0dHJpYnV0ZT4gaW5wdXRBdHRyaWJ1dGVz OwogCg==