32481 2009-12-13 01:47:59 -0800 [WML] Compilation error in wml enabled builds. 2009-12-14 12:14:06 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 nayankk webkit-unassigned commit-queue darin eric webkit.review.bot zimmermann oldest_to_newest 171179 0 nayankk 2009-12-13 01:47:59 -0800 WML enabled builds are now failing with following error, DerivedSources/WMLElementFactory.cpp: In function ‘WTF::PassRefPtr<WebCore::WMLElement> WebCore::inputConstructor(const WebCore::QualifiedName&, WebCore::Document*, bool)’: DerivedSources/WMLElementFactory.cpp:124: error: cannot allocate an object of abstract type ‘WebCore::WMLInputElement’ ../../WebCore/wml/WMLInputElement.h:32: note: because the following virtual functions are pure within ‘WebCore::WMLInputElement’: ../../WebCore/dom/InputElement.h:51: note: virtual void WebCore::InputElement::setValue(const WebCore::String&, bool) ../../WebCore/dom/InputElement.h:52: note: virtual void WebCore::InputElement::setValueForUser(const WebCore::String&) make[1]: *** [DerivedSources/libWebCore_la-WMLElementFactory.lo] Error 1 make[1]: Leaving directory `/home/nayankk/Browsers/webkit/WebKitBuild/Release' make: *** [all] Error 2 Failed to build WebKit using 'make'! Version of WebKit used is, nayankk@dreams:~/Browsers/webkit$ svn info Path: . URL: http://svn.webkit.org/repository/webkit/trunk Repository Root: http://svn.webkit.org/repository/webkit Repository UUID: 268f45cc-cd09-0410-ab3c-d52691b4dbfc Revision: 52059 Node Kind: directory Schedule: normal Last Changed Author: eric.carlson@apple.com Last Changed Rev: 52059 Last Changed Date: 2009-12-13 08:58:42 +0530 (Sun, 13 Dec 2009) 171180 1 nayankk 2009-12-13 01:55:06 -0800 This error is due to the changes committed with http://trac.webkit.org/changeset/51602. With this changeset, signature of 'WebCore::InputElement::setValue' is changed and 'WebCore::InputElement::setValueForUser' pure virtual function is added to 'InputElement' class. 'InputElement' class is the parent class for 'HTMLInputElement' and 'WMLInputElement' class. With 51602 changeset, changes in HTMLInputElement were done, but WMLInputElement wasn't changed to define these virtual functions and hence resulting in compilation errors. 171181 2 44751 nayankk 2009-12-13 02:08:10 -0800 Created attachment 44751 Proposed patch Proposed patch to resolve compilation error is attached for review. This simply changes the signature of 'setValue' function and defines 'setValueForUser' function in WMLInputElement class. 171182 3 webkit.review.bot 2009-12-13 02:11:41 -0800 style-queue ran check-webkit-style on attachment 44751 without any errors. 171188 4 44751 eric 2009-12-13 02:43:26 -0800 Comment on attachment 44751 Proposed patch Should we just change setValueForUser to have a default implementation instead of being pure virtual? Is it really only useful to HTML? Otherwise this looks fine. 171194 5 nayankk 2009-12-13 03:55:14 -0800 (In reply to comment #4) > (From update of attachment 44751 [details]) > Should we just change setValueForUser to have a default implementation instead > of being pure virtual? Is it really only useful to HTML? Otherwise this looks > fine. Thanks Eric for the review comments. Looks like, changes in changeset 51602 were done to detect a login form AutoFill from JavaScript. Since WML with Javascript is a rare scenario, I doubt these changes are required in WML. I guess Darin/Timothy will have some inputs here. 171497 6 44751 commit-queue 2009-12-14 12:13:58 -0800 Comment on attachment 44751 Proposed patch Clearing flags on attachment: 44751 Committed r52107: <http://trac.webkit.org/changeset/52107> 171498 7 commit-queue 2009-12-14 12:14:06 -0800 All reviewed patches have been landed. Closing bug. 44751 2009-12-13 02:08:10 -0800 2009-12-14 12:13:57 -0800 Proposed patch 32481_Compilation_error_fix.patch text/plain 2367 nayankk SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjA2NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTItMTMgIE5heWFuIEt1bWFyIEsgIDxuYXlhbmtrQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG aXggZm9yIGNvbXBpbGF0aW9uIGVycm9ycyBpbiBXTUwgZW5hYmxlZCBidWlsZHMuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyNDgxCisKKyAgICAg ICAgKiB3bWwvV01MSW5wdXRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldNTElucHV0 RWxlbWVudDo6c2V0VmFsdWUpOgorICAgICAgICAoV2ViQ29yZTo6V01MSW5wdXRFbGVtZW50Ojpz ZXRWYWx1ZUZvclVzZXIpOgorICAgICAgICAqIHdtbC9XTUxJbnB1dEVsZW1lbnQuaDoKKwogMjAw OS0xMi0xMyAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAg ICBObyByZXZpZXcsIHJvbGxpbmcgb3V0IHI1MjA1OSB1bnRpbCBJIGNhbiBnZW5lcmF0ZSBuZXcg VGlnZXIKSW5kZXg6IFdlYkNvcmUvd21sL1dNTElucHV0RWxlbWVudC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS93bWwvV01MSW5wdXRFbGVtZW50LmNwcAkocmV2aXNpb24gNTIwNjUpCisrKyBX ZWJDb3JlL3dtbC9XTUxJbnB1dEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzIsNyAr MTMyLDcgQEAgU3RyaW5nIFdNTElucHV0RWxlbWVudDo6dmFsdWUoKSBjb25zdAogICAgIHJldHVy biB2YWx1ZTsKIH0KIAotdm9pZCBXTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVlKGNvbnN0IFN0cmlu ZyYgdmFsdWUpCit2b2lkIFdNTElucHV0RWxlbWVudDo6c2V0VmFsdWUoY29uc3QgU3RyaW5nJiB2 YWx1ZSwgYm9vbCBzZW5kQ2hhbmdlRXZlbnQpCiB7CiAgICAgc2V0Rm9ybUNvbnRyb2xWYWx1ZU1h dGNoZXNSZW5kZXJlcihmYWxzZSk7CiAgICAgbV9kYXRhLnNldFZhbHVlKGNvbnN0cmFpblZhbHVl KHZhbHVlKSk7CkBAIC0xNTEsNiArMTUxLDEzIEBAIHZvaWQgV01MSW5wdXRFbGVtZW50OjpzZXRW YWx1ZShjb25zdCBTdHIKICAgICBJbnB1dEVsZW1lbnQ6Om5vdGlmeUZvcm1TdGF0ZUNoYW5nZWQo dGhpcyk7CiB9CiAKK3ZvaWQgV01MSW5wdXRFbGVtZW50OjpzZXRWYWx1ZUZvclVzZXIoY29uc3Qg U3RyaW5nJiB2YWx1ZSkKK3sKKyAgICAvKiBJbnB1dEVsZW1lbnQgY2xhc3MgZGVmaW5lcyBwdXJl IHZpcnR1YWwgZnVuY3Rpb24gJ3NldFZhbHVlRm9yVXNlcicsIHdoaWNoIAorICAgICAgIHdpbGwg YmUgdXNlZnVsIG9ubHkgaW4gSFRNTElucHV0RWxlbWVudC4gRG8gbm90aGluZyBpbiAnV01MSW5w dXRFbGVtZW50Jy4KKyAgICAgKi8KK30KKwogdm9pZCBXTUxJbnB1dEVsZW1lbnQ6OnNldFZhbHVl RnJvbVJlbmRlcmVyKGNvbnN0IFN0cmluZyYgdmFsdWUpCiB7CiAgICAgSW5wdXRFbGVtZW50Ojpz ZXRWYWx1ZUZyb21SZW5kZXJlcihtX2RhdGEsIHRoaXMsIHRoaXMsIHZhbHVlKTsKSW5kZXg6IFdl YkNvcmUvd21sL1dNTElucHV0RWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dN TElucHV0RWxlbWVudC5oCShyZXZpc2lvbiA1MjA2NSkKKysrIFdlYkNvcmUvd21sL1dNTElucHV0 RWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC01Nyw3ICs1Nyw4IEBAIHB1YmxpYzoKICAgICB2 aXJ0dWFsIGNvbnN0IEF0b21pY1N0cmluZyYgZm9ybUNvbnRyb2xUeXBlKCkgY29uc3Q7CiAgICAg dmlydHVhbCBjb25zdCBBdG9taWNTdHJpbmcmIGZvcm1Db250cm9sTmFtZSgpIGNvbnN0OwogICAg IHZpcnR1YWwgU3RyaW5nIHZhbHVlKCkgY29uc3Q7Ci0gICAgdmlydHVhbCB2b2lkIHNldFZhbHVl KGNvbnN0IFN0cmluZyYpOworICAgIHZpcnR1YWwgdm9pZCBzZXRWYWx1ZShjb25zdCBTdHJpbmcm LCBib29sIHNlbmRDaGFuZ2VFdmVudCA9IGZhbHNlKTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0VmFs dWVGb3JVc2VyKGNvbnN0IFN0cmluZyYpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRWYWx1ZUZyb21S ZW5kZXJlcihjb25zdCBTdHJpbmcmKTsKIAogICAgIHZpcnR1YWwgYm9vbCBzYXZlRm9ybUNvbnRy b2xTdGF0ZShTdHJpbmcmIHZhbHVlKSBjb25zdDsK