<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>3244</bug_id>
          
          <creation_ts>2005-06-01 16:13:02 -0700</creation_ts>
          <short_desc>Support the &apos;label&apos; element in HTML forms</short_desc>
          <delta_ts>2007-04-25 10:21:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Forms</component>
          <version>412</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc>http://www.robinlionheart.com/stds/html4/forms.html</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>4223</blocked>
    
    <blocked>7671</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Dave Hyatt">hyatt</reporter>
          <assigned_to name="Dave Hyatt">hyatt</assigned_to>
          <cc>accessibleweb</cc>
    
    <cc>bugs-webkit</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>ian</cc>
    
    <cc>jhurshman</cc>
    
    <cc>kanda</cc>
    
    <cc>mark.thomas</cc>
    
    <cc>martin.davidsson</cc>
    
    <cc>mitz</cc>
    
    <cc>rsesek</cc>
    
    <cc>shinyplasticbag</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>10441</commentid>
    <comment_count>0</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2005-06-01 16:13:02 -0700</bug_when>
    <thetext>If a form element has a label defined, then clicking that label should click/check/etc. the form element.
Example at http://www.robinlionheart.com/stds/html4/forms.html

5/3/05 4:17 PM Dave Hyatt:
Sadly I completely implemented this and then lost the patch.  I will have to re-code it.


5/3/05 5:04 PM Jeff Clites:
Take a look at 4105639 also: It would be nice for the implementation of this label behavior to match 
how radio button labels in Mac OS X work, in particular with regard to mouse-down on the label 
&quot;highlighting&quot; the corresponding form element. (That is, mouse-down highlights, click selects.)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>10442</commentid>
    <comment_count>1</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2005-06-01 16:13:50 -0700</bug_when>
    <thetext>Apple Bug: rdar://3044177/
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>15702</commentid>
    <comment_count>2</comment_count>
    <who name="Patrick H. Lauke">redux</who>
    <bug_when>2005-08-02 07:35:22 -0700</bug_when>
    <thetext>this came up in a discussion on the (Australian) Web Standards Group list this
afternoon (see thread
http://www.mail-archive.com/wsg%40webstandardsgroup.org/msg19456.html and in
particular my reply later on
http://www.mail-archive.com/wsg%40webstandardsgroup.org/msg19484.html ).

In short: unless I&apos;m misreading W3C WAI UAAG guideline 7, this should be
implemented in accordance with the operating system convention on OS X (and
should also work with both implicit and explicit labels).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>19022</commentid>
    <comment_count>3</comment_count>
      <attachid>3799</attachid>
    <who name="Martin Davidsson">martin.davidsson</who>
    <bug_when>2005-09-07 12:42:42 -0700</bug_when>
    <thetext>Created attachment 3799
Proposed patch for the partial implementation of LABEL element support

I&apos;ve attached a patch that enables the basic onclick functionality of a label
element (not including mousedown events). I&apos;m not conforming to the standard
procedure of how to contribute code because I have no idea if my code is the
correct way to do things in the WebCore. I&apos;d love to hear some feedback though.
If this patch is workable, I&apos;ll gladly look into writing a test for it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>21618</commentid>
    <comment_count>4</comment_count>
      <attachid>3799</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2005-10-09 12:48:47 -0700</bug_when>
    <thetext>Comment on attachment 3799
Proposed patch for the partial implementation of LABEL element support

Someone forgot to mark this for review...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>21621</commentid>
    <comment_count>5</comment_count>
      <attachid>3799</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-10-09 13:39:11 -0700</bug_when>
    <thetext>Comment on attachment 3799
Proposed patch for the partial implementation of LABEL element support

HTMLInputElementImpl* is incorrect formatting. There&apos;s spposed to be a space
before the *.

I don&apos;t undersand the purpose of this line of code:

+		 inputElt-&gt;setChecked(inputElt-&gt;checked());

Also, there should not be braces around single-line if statements.

Otherwise, this looks like a good start; I think the basic approach is pretty
good. Please do add a test and keep working on it!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>21643</commentid>
    <comment_count>6</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2005-10-09 18:07:26 -0700</bug_when>
    <thetext>I actually implemented this feature and then sadly lost the patch.  I do not actually agree with this 
approach.  The approach I took was to actually hook in at the mouse event level and change the target of 
the RenderLayer hit test to be the form control that the label is attached to.

You need an approach like this so that :hover and :active work properly on the controls and so that all the 
mouse event handlers (and not just click) fire on the control.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>24836</commentid>
    <comment_count>7</comment_count>
    <who name="Mark Thomas">mark.thomas</who>
    <bug_when>2005-11-29 03:13:40 -0800</bug_when>
    <thetext>Does this patch also update any accessability information which is sent back, so the label and radio button 
are 1 item on the Item Chooser for example ?

Also how do we move forward on this ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>24837</commentid>
    <comment_count>8</comment_count>
    <who name="Mark Thomas">mark.thomas</who>
    <bug_when>2005-11-29 03:31:28 -0800</bug_when>
    <thetext>Re-reading the coments here, but is just mouse event level is that enough ?, as I think here about the 
keyboard control via tab/cursor keys need to work as well correctly with/without accessability being on ?

I agree that to get the highlighting correct needs the mouse event method as suggested by Dave H.

Sorry but this first time on the contributing here, but once I understand how all this work will contribute 
more over time.

Thanks
Mark.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>25459</commentid>
    <comment_count>9</comment_count>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-12-03 15:27:09 -0800</bug_when>
    <thetext>In Radar as &lt;rdar://problem/3044177&gt; HTML4: clicking on the label should do the same thing clicking 
on the form element does</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>46114</commentid>
    <comment_count>10</comment_count>
    <who name="David Carson">dacarson</who>
    <bug_when>2006-06-17 15:30:43 -0700</bug_when>
    <thetext>Additional info for label: http://www.w3schools.com/tags/tag_label.asp</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>47073</commentid>
    <comment_count>11</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2006-06-24 19:16:04 -0700</bug_when>
    <thetext>Reassigning to webkit-unassigned for more exposure.

</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55347</commentid>
    <comment_count>12</comment_count>
      <attachid>10521</attachid>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2006-09-12 22:35:41 -0700</bug_when>
    <thetext>Created attachment 10521
Patch that fully implements label

I came up with a way to do this that still uses defaultEventHandler but that manages to hack the hover/active state for the controls properly.  It&apos;s a bit like Martin&apos;s approach but a little more generic (it doesn&apos;t try to special case any particular control type).  My RenderLayer suggestion was lame (it worked but is not nearly as elegant as this new way of doing hover/active, which ensures that hover/active sitll works on the label too).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55348</commentid>
    <comment_count>13</comment_count>
      <attachid>10521</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2006-09-12 22:59:30 -0700</bug_when>
    <thetext>Comment on attachment 10521
Patch that fully implements label

r=me

Please add a test case though (you can use eventSender, see examples in fast/events)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55349</commentid>
    <comment_count>14</comment_count>
      <attachid>10521</attachid>
    <who name="Adam Roben (:aroben)">aroben</who>
    <bug_when>2006-09-12 23:01:48 -0700</bug_when>
    <thetext>Comment on attachment 10521
Patch that fully implements label

r=me. Great to have this working!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55359</commentid>
    <comment_count>15</comment_count>
    <who name="Dave Hyatt">hyatt</who>
    <bug_when>2006-09-12 23:25:46 -0700</bug_when>
    <thetext>Fixed.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55378</commentid>
    <comment_count>16</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2006-09-13 04:09:22 -0700</bug_when>
    <thetext>(In reply to comment #15)
&gt; Fixed.

Implementation in r16341, tests in r16340.
</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>55379</commentid>
    <comment_count>17</comment_count>
    <who name="Gregory Block">gblock</who>
    <bug_when>2006-09-13 04:11:19 -0700</bug_when>
    <thetext>Sidenote:  I can select all of the fields via their access keys, save one:  control-H does not or cannot select the honorific field in that table on that page.

Intentional?  Bug?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>24054</commentid>
    <comment_count>18</comment_count>
    <who name="">mitz</who>
    <bug_when>2007-02-12 06:30:16 -0800</bug_when>
    <thetext>*** Bug 12741 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>12591</commentid>
    <comment_count>19</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2007-04-25 10:21:44 -0700</bug_when>
    <thetext>*** Bug 13482 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>3799</attachid>
            <date>2005-09-07 12:42:42 -0700</date>
            <delta_ts>2006-09-12 22:35:41 -0700</delta_ts>
            <desc>Proposed patch for the partial implementation of LABEL element support</desc>
            <filename>WebCore_bug-3244.patch</filename>
            <type>text/plain</type>
            <size>2017</size>
            <attacher name="Martin Davidsson">martin.davidsson</attacher>
            
              <data encoding="base64">SW5kZXg6IGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTog
L2N2cy9yb290L1dlYkNvcmUva2h0bWwvaHRtbC9odG1sX2Zvcm1pbXBsLmNwcCx2CnJldHJpZXZp
bmcgcmV2aXNpb24gMS4xOTIKZGlmZiAtcCAtdSAtcjEuMTkyIGtodG1sL2h0bWwvaHRtbF9mb3Jt
aW1wbC5jcHAKLS0tIGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5jcHAJMyBTZXAgMjAwNSAyMzow
OTo1OSAtMDAwMAkxLjE5MgorKysga2h0bWwvaHRtbC9odG1sX2Zvcm1pbXBsLmNwcAk3IFNlcCAy
MDA1IDE5OjMyOjIxIC0wMDAwCkBAIC0yNTU4LDYgKzI1NTgsMjcgQEAgdm9pZCBIVE1MTGFiZWxF
bGVtZW50SW1wbDo6cGFyc2VNYXBwZWRBdAogICAgICAgICBIVE1MRWxlbWVudEltcGw6OnBhcnNl
TWFwcGVkQXR0cmlidXRlKGF0dHIpOwogfQogCit2b2lkIEhUTUxMYWJlbEVsZW1lbnRJbXBsOjpk
ZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50SW1wbCAqZXZ0KQoreworICAgIGlmIChldnQtPmlzTW91
c2VFdmVudCgpICYmIGV2dC0+dHlwZSgpID09IGNsaWNrRXZlbnQpIHsKKyAgICAgICAgSFRNTElu
cHV0RWxlbWVudEltcGwqIGlucHV0RWx0ID0gc3RhdGljX2Nhc3Q8SFRNTElucHV0RWxlbWVudElt
cGwqPihmb3JtRWxlbWVudCgpKTsKKyAgICAgICAgaWYgKGlucHV0RWx0LT5pbnB1dFR5cGUoKSA9
PSBIVE1MSW5wdXRFbGVtZW50SW1wbDo6UkFESU8pIHsKKyAgICAgICAgICAgIGlucHV0RWx0LT5z
ZXRDaGVja2VkKHRydWUpOworICAgICAgICAgICAgZXZ0LT5zZXREZWZhdWx0SGFuZGxlZCgpOwor
ICAgICAgICB9IGVsc2UgaWYgKGlucHV0RWx0LT5pbnB1dFR5cGUoKSA9PSBIVE1MSW5wdXRFbGVt
ZW50SW1wbDo6Q0hFQ0tCT1gpIHsKKyAgICAgICAgICAgIGlmIChldnQtPnRhcmdldCgpID09IHRo
aXMpIHsKKyAgICAgICAgICAgICAgICBpbnB1dEVsdC0+c2V0Q2hlY2tlZCghaW5wdXRFbHQtPmNo
ZWNrZWQoKSk7CisgICAgICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgICAgIGlucHV0RWx0
LT5zZXRDaGVja2VkKGlucHV0RWx0LT5jaGVja2VkKCkpOworICAgICAgICAgICAgfQorICAgICAg
ICAgICAgZXZ0LT5zZXREZWZhdWx0SGFuZGxlZCgpOworICAgICAgICB9IGVsc2UgeworICAgICAg
ICAgICAgaW5wdXRFbHQtPmZvY3VzKCk7CisgICAgICAgICAgICBldnQtPnNldERlZmF1bHRIYW5k
bGVkKCk7CisgICAgICAgIH0KKyAgICB9Cit9CisKIEVsZW1lbnRJbXBsICpIVE1MTGFiZWxFbGVt
ZW50SW1wbDo6Zm9ybUVsZW1lbnQoKQogewogICAgIERPTVN0cmluZyBmb3JtRWxlbWVudElkID0g
Z2V0QXR0cmlidXRlKGZvckF0dHIpOwpJbmRleDoga2h0bWwvaHRtbC9odG1sX2Zvcm1pbXBsLmgK
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvaHRtbC9odG1sX2Zv
cm1pbXBsLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuODcKZGlmZiAtcCAtdSAtcjEuODcga2h0
bWwvaHRtbC9odG1sX2Zvcm1pbXBsLmgKLS0tIGtodG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5oCTEg
U2VwIDIwMDUgMTc6NDA6MTIgLTAwMDAJMS44NworKysga2h0bWwvaHRtbC9odG1sX2Zvcm1pbXBs
LmgJNyBTZXAgMjAwNSAxOTozMjoyMSAtMDAwMApAQCAtNDgxLDYgKzQ4MSw4IEBAIHB1YmxpYzoK
ICAgICB2aXJ0dWFsIHZvaWQgcGFyc2VNYXBwZWRBdHRyaWJ1dGUoTWFwcGVkQXR0cmlidXRlSW1w
bCAqYXR0cik7CiAKICAgICB2aXJ0dWFsIHZvaWQgYWNjZXNzS2V5QWN0aW9uKGJvb2wgc2VuZFRv
QW55RWxlbWVudCk7CisJCisgICAgdmlydHVhbCB2b2lkIGRlZmF1bHRFdmVudEhhbmRsZXIoRXZl
bnRJbXBsICpldnQpOwogCiAgICAgLyoqCiAgICAgICogdGhlIGZvcm0gZWxlbWVudCB0aGlzIGxh
YmVsIGlzIGFzc29jaWF0ZWQgdG8uCg==
</data>
<flag name="review"
          id="706"
          type_id="1"
          status="-"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>10521</attachid>
            <date>2006-09-12 22:35:41 -0700</date>
            <delta_ts>2006-09-12 22:59:30 -0700</delta_ts>
            <desc>Patch that fully implements label</desc>
            <filename>patch.txt</filename>
            <type>text/plain</type>
            <size>5229</size>
            <attacher name="Dave Hyatt">hyatt</attacher>
            
              <data encoding="base64">SW5kZXg6IGh0bWwvSFRNTExhYmVsRWxlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gaHRtbC9IVE1M
TGFiZWxFbGVtZW50LmNwcAkocmV2aXNpb24gMTYzMjcpCisrKyBodG1sL0hUTUxMYWJlbEVsZW1l
bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCw3IEBACiAKICNpbmNsdWRlICJIVE1M
TmFtZXMuaCIKICNpbmNsdWRlICJFdmVudE5hbWVzLmgiCisjaW5jbHVkZSAiRXZlbnQuaCIKICNp
bmNsdWRlICJEb2N1bWVudC5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01MSwxOCArNTIs
OCBAQAogICAgIHJldHVybiBmYWxzZTsKIH0KIAotdm9pZCBIVE1MTGFiZWxFbGVtZW50OjpwYXJz
ZU1hcHBlZEF0dHJpYnV0ZShNYXBwZWRBdHRyaWJ1dGUgKmF0dHIpCitIVE1MRWxlbWVudCogSFRN
TExhYmVsRWxlbWVudDo6Zm9ybUVsZW1lbnQoKQogewotICAgIGlmIChhdHRyLT5uYW1lKCkgPT0g
b25mb2N1c0F0dHIpIHsKLSAgICAgICAgc2V0SFRNTEV2ZW50TGlzdGVuZXIoZm9jdXNFdmVudCwg
YXR0cik7Ci0gICAgfSBlbHNlIGlmIChhdHRyLT5uYW1lKCkgPT0gb25ibHVyQXR0cikgewotICAg
ICAgICBzZXRIVE1MRXZlbnRMaXN0ZW5lcihibHVyRXZlbnQsIGF0dHIpOwotICAgIH0gZWxzZQot
ICAgICAgICBIVE1MRWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1dGUoYXR0cik7Ci19Ci0KLUVs
ZW1lbnQgKkhUTUxMYWJlbEVsZW1lbnQ6OmZvcm1FbGVtZW50KCkKLXsKICAgICBjb25zdCBBdG9t
aWNTdHJpbmcmIGZvcm1FbGVtZW50SWQgPSBnZXRBdHRyaWJ1dGUoZm9yQXR0cik7CiAgICAgaWYg
KGZvcm1FbGVtZW50SWQuaXNOdWxsKCkpIHsKICAgICAgICAgLy8gU2VhcmNoIGNoaWxkcmVuIG9m
IHRoZSBsYWJlbCBlbGVtZW50IGZvciBhIGZvcm0gZWxlbWVudC4KQEAgLTc4LDkgKzY5LDY0IEBA
CiAgICAgfQogICAgIGlmIChmb3JtRWxlbWVudElkLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJu
IDA7Ci0gICAgcmV0dXJuIGRvY3VtZW50KCktPmdldEVsZW1lbnRCeUlkKGZvcm1FbGVtZW50SWQp
OworICAgICAgICAKKyAgICAvLyBPbmx5IHJldHVybiBIVE1MIGVsZW1lbnRzLgorICAgIEVsZW1l
bnQqIGVsdCA9IGRvY3VtZW50KCktPmdldEVsZW1lbnRCeUlkKGZvcm1FbGVtZW50SWQpOworICAg
IGlmIChlbHQgJiYgZWx0LT5pc0hUTUxFbGVtZW50KCkpCisgICAgICAgIHJldHVybiBzdGF0aWNf
Y2FzdDxIVE1MRWxlbWVudCo+KGVsdCk7CisgICAgcmV0dXJuIDA7CiB9CiAKK3ZvaWQgSFRNTExh
YmVsRWxlbWVudDo6c2V0QWN0aXZlKGJvb2wgZG93biwgYm9vbCBwYXVzZSkKK3sKKyAgICBpZiAo
ZG93biA9PSBhY3RpdmUoKSkKKyAgICAgICAgcmV0dXJuOworCisgICAgLy8gVXBkYXRlIG91ciBz
dGF0dXMgZmlyc3QuCisgICAgSFRNTEVsZW1lbnQ6OnNldEFjdGl2ZShkb3duLCBwYXVzZSk7CisK
KyAgICAvLyBBbHNvIHVwZGF0ZSBvdXIgY29ycmVzcG9uZGluZyBjb250cm9sLgorICAgIGlmIChF
bGVtZW50KiBlbGVtZW50ID0gZm9ybUVsZW1lbnQoKSkKKyAgICAgICAgZWxlbWVudC0+c2V0QWN0
aXZlKGRvd24sIHBhdXNlKTsKK30KKwordm9pZCBIVE1MTGFiZWxFbGVtZW50OjpzZXRIb3ZlcmVk
KGJvb2wgb3ZlcikKK3sKKyAgICBpZiAob3ZlciA9PSBob3ZlcmVkKCkpCisgICAgICAgIHJldHVy
bjsKKyAgICAgICAgCisgICAgLy8gVXBkYXRlIG91ciBzdGF0dXMgZmlyc3QuCisgICAgSFRNTEVs
ZW1lbnQ6OnNldEhvdmVyZWQob3Zlcik7CisKKyAgICAvLyBBbHNvIHVwZGF0ZSBvdXIgY29ycmVz
cG9uZGluZyBjb250cm9sLgorICAgIGlmIChFbGVtZW50KiBlbGVtZW50ID0gZm9ybUVsZW1lbnQo
KSkKKyAgICAgICAgZWxlbWVudC0+c2V0SG92ZXJlZChvdmVyKTsKK30KKwordm9pZCBIVE1MTGFi
ZWxFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldnQpCit7CisgICAgc3RhdGlj
IGJvb2wgcHJvY2Vzc2luZ0NsaWNrID0gZmFsc2U7CisKKyAgICBpZiAoZXZ0LT50eXBlKCkgPT0g
Y2xpY2tFdmVudCAmJiAhcHJvY2Vzc2luZ0NsaWNrKSB7CisgICAgICAgIEhUTUxFbGVtZW50KiBl
bGVtZW50ID0gZm9ybUVsZW1lbnQoKTsKKyAgICAgICAgaWYgKCFlbGVtZW50KQorICAgICAgICAg
ICAgcmV0dXJuOworICAgICAgICAKKyAgICAgICAgcHJvY2Vzc2luZ0NsaWNrID0gdHJ1ZTsKKwor
ICAgICAgICAvLyBDbGljayB0aGUgY29ycmVzcG9uZGluZyBjb250cm9sLgorICAgICAgICBlbGVt
ZW50LT5jbGljayhmYWxzZSk7CisgICAgICAgICAgICAKKyAgICAgICAgLy8gSWYgdGhlIGNvbnRy
b2wgY2FuIGJlIGZvY3VzZWQgdmlhIHRoZSBtb3VzZSwgdGhlbiBkbyB0aGF0IHRvby4KKyAgICAg
ICAgaWYgKGVsZW1lbnQtPmlzTW91c2VGb2N1c2FibGUoKSkKKyAgICAgICAgICAgIGVsZW1lbnQt
PmZvY3VzKCk7CisgICAgICAgICAgICAKKyAgICAgICAgcHJvY2Vzc2luZ0NsaWNrID0gZmFsc2U7
CisgICAgfQorICAgIAorICAgIHJldHVybiBIVE1MRWxlbWVudDo6ZGVmYXVsdEV2ZW50SGFuZGxl
cihldnQpOworfQorCiB2b2lkIEhUTUxMYWJlbEVsZW1lbnQ6OmZvY3VzKCkKIHsKICAgICBpZiAo
RWxlbWVudCAqZWxlbWVudCA9IGZvcm1FbGVtZW50KCkpCkluZGV4OiBodG1sL0hUTUxMYWJlbEVs
ZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09Ci0tLSBodG1sL0hUTUxMYWJlbEVsZW1lbnQuaAkocmV2aXNpb24g
MTYzMjcpCisrKyBodG1sL0hUTUxMYWJlbEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtNDIs
MTQgKzQyLDE5IEBACiAKICAgICB2aXJ0dWFsIGJvb2wgaXNGb2N1c2FibGUoKSBjb25zdDsKIAot
ICAgIHZpcnR1YWwgdm9pZCBwYXJzZU1hcHBlZEF0dHJpYnV0ZShNYXBwZWRBdHRyaWJ1dGUgKmF0
dHIpOwotCiAgICAgdmlydHVhbCB2b2lkIGFjY2Vzc0tleUFjdGlvbihib29sIHNlbmRUb0FueUVs
ZW1lbnQpOwogCisgICAgLy8gT3ZlcnJpZGRlbiB0byB1cGRhdGUgdGhlIGhvdmVyL2FjdGl2ZSBz
dGF0ZSBvZiB0aGUgY29ycmVzcG9uZGluZyBjb250cm9sLgorICAgIHZpcnR1YWwgdm9pZCBzZXRB
Y3RpdmUoYm9vbCBiID0gdHJ1ZSwgYm9vbCBwYXVzZSA9IGZhbHNlKTsKKyAgICB2aXJ0dWFsIHZv
aWQgc2V0SG92ZXJlZChib29sIGIgPSB0cnVlKTsKKworICAgIC8vIE92ZXJyaWRkZW4gdG8gZWl0
aGVyIGNsaWNrKCkgb3IgZm9jdXMoKSB0aGUgY29ycmVzcG9uZGluZyBjb250cm9sLgorICAgIHZp
cnR1YWwgdm9pZCBkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50Kik7CisKICAgICAvKioKICAgICAg
KiB0aGUgZm9ybSBlbGVtZW50IHRoaXMgbGFiZWwgaXMgYXNzb2NpYXRlZCB0by4KICAgICAgKi8K
LSAgICBFbGVtZW50ICpmb3JtRWxlbWVudCgpOworICAgIEhUTUxFbGVtZW50ICpmb3JtRWxlbWVu
dCgpOwogCiAgICAgSFRNTEZvcm1FbGVtZW50ICpmb3JtKCk7CiAKSW5kZXg6IFdlYkNvcmUueGNv
ZGVwcm9qL3Byb2plY3QucGJ4cHJvago9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlLnhjb2RlcHJvai9w
cm9qZWN0LnBieHByb2oJKHJldmlzaW9uIDE2MzI3KQorKysgV2ViQ29yZS54Y29kZXByb2ovcHJv
amVjdC5wYnhwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC0yMDI1LDYgKzIwMjUsMjMgQEAKIAkJRkFF
MDQxOTAwOTc1OTZDOTAwMDU0MEJFIC8qIFNWR0ltYWdlTG9hZGVyLmggaW4gSGVhZGVycyAqLyA9
IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSBGQUUwNDE4RTA5NzU5NkM5MDAwNTQwQkUg
LyogU1ZHSW1hZ2VMb2FkZXIuaCAqLzsgfTsKIC8qIEVuZCBQQlhCdWlsZEZpbGUgc2VjdGlvbiAq
LwogCisvKiBCZWdpbiBQQlhCdWlsZFN0eWxlIHNlY3Rpb24gKi8KKwkJQkNEQjI4NkIwQUI3QzNF
RTAwRDgyMjE2IC8qIERldmVsb3BtZW50ICovID0geworCQkJaXNhID0gUEJYQnVpbGRTdHlsZTsK
KwkJCWJ1aWxkU2V0dGluZ3MgPSB7CisJCQkJQ09QWV9QSEFTRV9TVFJJUCA9IE5POworCQkJfTsK
KwkJCW5hbWUgPSBEZXZlbG9wbWVudDsKKwkJfTsKKwkJQkNEQjI4NkMwQUI3QzNFRTAwRDgyMjE2
IC8qIERlcGxveW1lbnQgKi8gPSB7CisJCQlpc2EgPSBQQlhCdWlsZFN0eWxlOworCQkJYnVpbGRT
ZXR0aW5ncyA9IHsKKwkJCQlDT1BZX1BIQVNFX1NUUklQID0gWUVTOworCQkJfTsKKwkJCW5hbWUg
PSBEZXBsb3ltZW50OworCQl9OworLyogRW5kIFBCWEJ1aWxkU3R5bGUgc2VjdGlvbiAqLworCiAv
KiBCZWdpbiBQQlhDb250YWluZXJJdGVtUHJveHkgc2VjdGlvbiAqLwogCQlERDA0MUZGMDA5RDlF
MzI1MDAxMEFGMkEgLyogUEJYQ29udGFpbmVySXRlbVByb3h5ICovID0gewogCQkJaXNhID0gUEJY
Q29udGFpbmVySXRlbVByb3h5OwpAQCAtNzg5Nyw2ICs3OTE0LDEyIEBACiAJCTA4NjdENjkwRkU4
NDAyOEZDMDJBQUMwNyAvKiBQcm9qZWN0IG9iamVjdCAqLyA9IHsKIAkJCWlzYSA9IFBCWFByb2pl
Y3Q7CiAJCQlidWlsZENvbmZpZ3VyYXRpb25MaXN0ID0gMTQ5QzI4NDMwODkwMkIxMTAwOEE5RUZD
IC8qIEJ1aWxkIGNvbmZpZ3VyYXRpb24gbGlzdCBmb3IgUEJYUHJvamVjdCAiV2ViQ29yZSIgKi87
CisJCQlidWlsZFNldHRpbmdzID0geworCQkJfTsKKwkJCWJ1aWxkU3R5bGVzID0gKAorCQkJCUJD
REIyODZCMEFCN0MzRUUwMEQ4MjIxNiAvKiBEZXZlbG9wbWVudCAqLywKKwkJCQlCQ0RCMjg2QzBB
QjdDM0VFMDBEODIyMTYgLyogRGVwbG95bWVudCAqLywKKwkJCSk7CiAJCQloYXNTY2FubmVkRm9y
RW5jb2RpbmdzID0gMTsKIAkJCWtub3duUmVnaW9ucyA9ICgKIAkJCQlFbmdsaXNoLApJbmRleDog
Y3NzL2h0bWw0LmNzcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjc3MvaHRtbDQuY3NzCShyZXZpc2lvbiAxNjMy
NykKKysrIGNzcy9odG1sNC5jc3MJKHdvcmtpbmcgY29weSkKQEAgLTI3NSw2ICsyNzUsMTEgQEAK
ICAgICBtYXJnaW46IDBfX3FlbSAwIDFlbSAwCiB9CiAKK2xhYmVsIHsKKyAgICBjdXJzb3I6IGRl
ZmF1bHQ7CisgICAgLXdlYmtpdC11c2VyLXNlbGVjdDogbm9uZTsKK30KKwogbGVnZW5kIHsKICAg
ICBkaXNwbGF5OiBibG9jazsKICAgICBwYWRkaW5nLWxlZnQ6IDJweDsK
</data>
<flag name="review"
          id="3404"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>