32427 2009-12-11 05:21:33 -0800 [Cairo][Qt] Alpha blending in SVG filters is wrong 2009-12-12 02:21:11 -0800 1 1 1 Unclassified WebKit SVG 525.x (Safari 3.1) PC All RESOLVED FIXED P2 Normal --- 1 krit webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 170711 0 krit 2009-12-11 05:21:33 -0800 This bug is related to bug 32378 and needs the same fix for Cairo and Qt. 170717 1 44679 krit 2009-12-11 05:31:06 -0800 Created attachment 44679 correct color spacetransformation SVG Filter for Qt, Cairo ImageBuffer::platformTransformColorSpace shouldn't transform the alpha channel on sRGB <-> linearRGB on Qt, Cairo. 170719 2 webkit.review.bot 2009-12-11 05:31:55 -0800 style-queue ran check-webkit-style on attachment 44679 without any errors. 170961 3 44679 eric 2009-12-11 15:38:13 -0800 Comment on attachment 44679 correct color spacetransformation SVG Filter for Qt, Cairo Looks sane. Obviously needs updates to those tests too. 171073 4 krit 2009-12-12 00:45:55 -0800 (In reply to comment #3) > (From update of attachment 44679 [details]) > Looks sane. Obviously needs updates to those tests too. Looks like both ports don't have pixel tests. The regression tests don't need an update. 171091 5 44679 commit-queue 2009-12-12 02:21:07 -0800 Comment on attachment 44679 correct color spacetransformation SVG Filter for Qt, Cairo Clearing flags on attachment: 44679 Committed r52049: <http://trac.webkit.org/changeset/52049> 171092 6 commit-queue 2009-12-12 02:21:11 -0800 All reviewed patches have been landed. Closing bug. 44679 2009-12-11 05:31:06 -0800 2009-12-12 02:21:06 -0800 correct color spacetransformation SVG Filter for Qt, Cairo svg-filter-alpha.patch text/plain 2392 krit SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTk4MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMTItMTEgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2Fp cm9dW1F0XSBBbHBoYSBibGVuZGluZyBpbiBTVkcgZmlsdGVycyBpcyB3cm9uZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzI0MjcKKworICAgICAgICBU aGlzIHBhdGNoIGlzIGEgZm9sbG93LXVwIHRvOgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQu b3JnL2NoYW5nZXNldC81MTk1MAorICAgICAgICBJdCBmaXhlcyB0aGUgYWxwaGEgYmxlbmRpbmcg Zm9yIENhaXJvIGFuZCBRdCBvbiBTVkcgRmlsdGVycy4KKworICAgICAgICBDb3ZlcmVkIGJ5OiAq IExheW91dFRlc3RzL3N2Zy9maWx0ZXJzL2ZlR2F1c3NpYW5CbHVyLnN2ZworICAgICAgICAgICAg ICAgICAgICAqIExheW91dFRlc3RzL3N2Zy9maWx0ZXJzL2ZlQ29tcG9zaXRlLnN2ZworICAgICAg ICAgICAgICAgICAgICAgYW5kIG90aGVycy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZm ZXI6OnBsYXRmb3JtVHJhbnNmb3JtQ29sb3JTcGFjZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZl cjo6cGxhdGZvcm1UcmFuc2Zvcm1Db2xvclNwYWNlKToKKwogMjAwOS0xMi0xMSAgR3JhY2UgS2xv YmEgIDxrbG9iYWdAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1ZmZlckNhaXJv LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdl QnVmZmVyQ2Fpcm8uY3BwCShyZXZpc2lvbiA1MTk3OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMiw3 ICsxMzIsNyBAQCB2b2lkIEltYWdlQnVmZmVyOjpwbGF0Zm9ybVRyYW5zZm9ybUNvbG9yCiAgICAg ICAgICAgICBwaXhlbENvbG9yID0gQ29sb3IobG9va1VwVGFibGVbcGl4ZWxDb2xvci5yZWQoKV0s CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9va1VwVGFibGVbcGl4ZWxDb2xvci5n cmVlbigpXSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsb29rVXBUYWJsZVtwaXhl bENvbG9yLmJsdWUoKV0sCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9va1VwVGFi bGVbcGl4ZWxDb2xvci5hbHBoYSgpXSk7CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cGl4ZWxDb2xvci5hbHBoYSgpKTsKICAgICAgICAgICAgICpwaXhlbCA9IHByZW11bHRpcGxpZWRB UkdCRnJvbUNvbG9yKHBpeGVsQ29sb3IpOwogICAgICAgICB9CiAgICAgfQpJbmRleDogV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9JbWFnZUJ1ZmZlclF0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlQnVmZmVyUXQuY3BwCShyZXZpc2lvbiA1 MTk3OSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VCdWZmZXJRdC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTExNCw3ICsxMTQsNyBAQCB2b2lkIEltYWdlQnVmZmVyOjpwbGF0 Zm9ybVRyYW5zZm9ybUNvbG9yCiAgICAgICAgICAgICB2YWx1ZSA9IHFSZ2JhKGxvb2tVcFRhYmxl W3FSZWQodmFsdWUpXSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgbG9va1VwVGFibGVbcUdy ZWVuKHZhbHVlKV0sCiAgICAgICAgICAgICAgICAgICAgICAgICAgIGxvb2tVcFRhYmxlW3FCbHVl KHZhbHVlKV0sCi0gICAgICAgICAgICAgICAgICAgICAgICAgIGxvb2tVcFRhYmxlW3FBbHBoYSh2 YWx1ZSldKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgcUFscGhhKHZhbHVlKSk7CiAgICAg ICAgICAgICBpbWFnZS5zZXRQaXhlbCh4LCB5LCB2YWx1ZSk7CiAgICAgICAgIH0KICAgICB9Cg==