32399 2009-12-10 16:33:03 -0800 Pan Scrolling Jumps out of frames if the initial location is in a frame that can't be scrolled 2009-12-11 11:59:30 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 bweinstein bweinstein aroben maxime.britto webkit.review.bot oldest_to_newest 170581 0 bweinstein 2009-12-10 16:33:03 -0800 Pan Scrolling Jumps out of frames if the initial location is in a frame that can't be scrolled. Case: Empty iFrame that can't scroll inside of a page that can scroll Try to pan scroll - starting in the empty frame: IE: Doesn't scroll anything Firefox: Doesn't scroll anything Safari: Scrolls the page. We shouldn't scroll at all here. 170583 1 bweinstein 2009-12-10 16:34:41 -0800 Additionally, we don't jump out of frames in the rest of the scrolling process, so it doesn't make sense for us to do it on the initial scroll. 170655 2 maxime.britto 2009-12-11 00:50:04 -0800 The regular wheel scroll doesn't trigger in that case ? 170835 3 bweinstein 2009-12-11 10:58:02 -0800 The scroll wheel doesn't jump out of iFrames either. The bug here is that: 1) There's an iFrame that can scroll. 2) There's an iFrame that can't scroll. If you start pan scrolling in (1), it will scroll the iFrame, and then NOT jump out to the main document. If you start pan scrolling in (2), it will jump out of the document. That behavior is inconsistent and a bug. It wasn't always like this, but was a regression from r52008. Before r52008, it would think it could pan scroll, and show the icon even if there was nothing for it to scroll inside the iFrame. 170845 4 aroben 2009-12-11 11:13:49 -0800 (In reply to comment #3) > The scroll wheel doesn't jump out of iFrames either. Do you mean "pan scroll" instead of "scroll wheel"? 170847 5 bweinstein 2009-12-11 11:15:00 -0800 (In reply to comment #4) > (In reply to comment #3) > > The scroll wheel doesn't jump out of iFrames either. > > Do you mean "pan scroll" instead of "scroll wheel"? No, Maxime asked about the scroll wheel, so I was saying that the scroll wheel doesn't jump out of frames/iFrames either. 170849 6 44698 bweinstein 2009-12-11 11:16:56 -0800 Created attachment 44698 [PATCH] Fix 170851 7 webkit.review.bot 2009-12-11 11:19:49 -0800 style-queue ran check-webkit-style on attachment 44698 without any errors. 170854 8 aroben 2009-12-11 11:26:11 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > The scroll wheel doesn't jump out of iFrames either. > > > > Do you mean "pan scroll" instead of "scroll wheel"? > > No, Maxime asked about the scroll wheel, so I was saying that the scroll wheel > doesn't jump out of frames/iFrames either. This does not match the behavior I see in ToT Safari. Scrolling the mouse wheel within an iframe scrolls that iframe until it can't be scrolled anymore, then scrolls the iframe's parent frame until that frame can't be scrolled, and so on. 170855 9 bweinstein 2009-12-11 11:28:01 -0800 Oh, I was using a bad test case that called preventDefault on mousewheel. Sorry. 170856 10 44698 darin 2009-12-11 11:31:24 -0800 Comment on attachment 44698 [PATCH] Fix This looks OK and probably fixes this bug. But the existing logic doesn’t seem exactly right to me. A renderer can be an element with fixed positioning, in which case it doesn't make sense to advance to its parent when deciding what to scroll. r=me 170867 11 bweinstein 2009-12-11 11:59:30 -0800 Landed in r52012. 44698 2009-12-11 11:16:56 -0800 2009-12-11 11:31:24 -0800 [PATCH] Fix no_jump_iframes.patch text/plain 5831 bweinstein SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MjAwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMDktMTItMTEgIEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5A YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzMyMzk5Pi4KKyAgICAgICAgUGFuIFNjcm9s bGluZyBKdW1wcyBvdXQgb2YgZnJhbWVzIGlmIHRoZSBpbml0aWFsIGxvY2F0aW9uIGlzIGluIGEg ZnJhbWUgdGhhdCBjYW4ndCBiZSBzY3JvbGxlZC4KKyAgICAgICAgCisgICAgICAgIFdoZW4gd2Ug aW5pdGlhbGx5IGZpZ3VyZSBvdXQgdGhlIGxheWVyIHRoYXQgd2Ugc2hvdWxkIGJlZ2luIHNjcm9s bGluZywgZG9uJ3QgdHJ5IHRvIGp1bXAgb3V0CisgICAgICAgIG9mIGZyYW1lcy9pRnJhbWVzIHRv IGxvb2sgYXQgdGhlIG93bmVyIGRvY3VtZW50LiBXZSBkb24ndCB3YW50IHRvIGp1bXAgb3V0IG9m IGZyYW1lcywgc28gd2UKKyAgICAgICAgZG9uJ3QgbmVlZCB0aGF0IGxvZ2ljIGFueW1vcmUuCisg ICAgICAgIAorICAgICAgICBBZGRlZCBhIHRlc3QgdG8gbWFrZSBzdXJlIHRoYXQgd2UgZG9uJ3Qg cGFuIHNjcm9sbCBpZiB3ZSBzdGFydCB0byBzY3JvbGwgaW4gYW4gZW1wdHkKKyAgICAgICAgaUZy YW1lIHRoYXQgaGFzIGEgc2Nyb2xsYWJsZSBvd25lciBkb2N1bWVudC4KKworICAgICAgICBUZXN0 OiBwbGF0Zm9ybS93aW4vZmFzdC9ldmVudHMvcGFuU2Nyb2xsLW5vLWlmcmFtZS1qdW1wLmh0bWwK KworICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmRlZmF1 bHRFdmVudEhhbmRsZXIpOgorCiAyMDA5LTEyLTExICBCcmlhbiBXZWluc3RlaW4gIDxid2VpbnN0 ZWluQGFwcGxlLmNvbT4KIApJbmRleDogV2ViQ29yZS9kb20vTm9kZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9kb20vTm9kZS5jcHAJKHJldmlzaW9uIDUyMDA4KQorKysgV2ViQ29yZS9kb20v Tm9kZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI4MzMsMTcgKzI4MzMsMTEgQEAgdm9pZCBOb2Rl OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldgogICAgICAgICBpZiAobW91c2VFdmVudC0+ YnV0dG9uKCkgPT0gTWlkZGxlQnV0dG9uICYmICF0aGlzLT5pc0xpbmsoKSkgewogICAgICAgICAg ICAgUmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IHRoaXMtPnJlbmRlcmVyKCk7CiAKLSAgICAgICAg ICAgIHdoaWxlIChyZW5kZXJlciAmJiAoIXJlbmRlcmVyLT5pc0JveCgpIHx8ICF0b1JlbmRlckJv eChyZW5kZXJlciktPmNhbkJlU2Nyb2xsZWRBbmRIYXNTY3JvbGxhYmxlQXJlYSgpKSkgewotICAg ICAgICAgICAgICAgIC8vIEZJWE1FOiBJZiB3ZSBzdGFydCBpbiBhIGZyYW1lIHRoYXQgY2FuJ3Qg c2Nyb2xsLCB3ZSBkb24ndCB3YW50IHRvIGp1bXAgb3V0IG9mIGl0IHRvIHN0YXJ0IHNjcm9sbGlu ZzoKLSAgICAgICAgICAgICAgICAvLyA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMyMzk5Pi4KLSAgICAgICAgICAgICAgICBpZiAoIXJlbmRlcmVyLT5wYXJlbnQoKSAm JiByZW5kZXJlci0+bm9kZSgpID09IHJlbmRlcmVyLT5kb2N1bWVudCgpICYmIHJlbmRlcmVyLT5k b2N1bWVudCgpLT5vd25lckVsZW1lbnQoKSkKLSAgICAgICAgICAgICAgICAgICAgcmVuZGVyZXIg PSByZW5kZXJlci0+ZG9jdW1lbnQoKS0+b3duZXJFbGVtZW50KCktPnJlbmRlcmVyKCk7Ci0gICAg ICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAgICByZW5kZXJlciA9IHJlbmRlcmVy LT5wYXJlbnQoKTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIHdoaWxlIChyZW5kZXJlciAm JiAoIXJlbmRlcmVyLT5pc0JveCgpIHx8ICF0b1JlbmRlckJveChyZW5kZXJlciktPmNhbkJlU2Ny b2xsZWRBbmRIYXNTY3JvbGxhYmxlQXJlYSgpKSkKKyAgICAgICAgICAgICAgICByZW5kZXJlciA9 IHJlbmRlcmVyLT5wYXJlbnQoKTsKIAogICAgICAgICAgICAgaWYgKHJlbmRlcmVyKSB7Ci0gICAg ICAgICAgICAgICAgaWYgKEZyYW1lKiBmcmFtZSA9IHJlbmRlcmVyLT5kb2N1bWVudCgpLT5mcmFt ZSgpKQorICAgICAgICAgICAgICAgIGlmIChGcmFtZSogZnJhbWUgPSBkb2N1bWVudCgpLT5mcmFt ZSgpKQogICAgICAgICAgICAgICAgICAgICBmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPnN0YXJ0UGFu U2Nyb2xsaW5nKHJlbmRlcmVyKTsKICAgICAgICAgICAgIH0KICAgICAgICAgfQpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gNTIwMDkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMi0xMSAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVp bkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRml4ZXMgPGh0dHA6Ly93ZWJraXQub3JnL2IvMzIzOTk+LgorICAgICAgICBQYW4gU2Ny b2xsaW5nIEp1bXBzIG91dCBvZiBmcmFtZXMgaWYgdGhlIGluaXRpYWwgbG9jYXRpb24gaXMgaW4g YSBmcmFtZSB0aGF0IGNhbid0IGJlIHNjcm9sbGVkLgorICAgICAgICAKKyAgICAgICAgQWRkZWQg YSB0ZXN0IHRvIG1ha2Ugc3VyZSB0aGF0IHdlIGRvbid0IHBhbiBzY3JvbGwgaWYgd2Ugc3RhcnQg dG8gc2Nyb2xsIGluIGFuIGVtcHR5CisgICAgICAgIGlGcmFtZSB0aGF0IGhhcyBhIHNjcm9sbGFi bGUgb3duZXIgZG9jdW1lbnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS93aW4vZmFzdC9ldmVudHMv cGFuU2Nyb2xsLW5vLWlmcmFtZS1qdW1wLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog cGxhdGZvcm0vd2luL2Zhc3QvZXZlbnRzL3BhblNjcm9sbC1uby1pZnJhbWUtanVtcC5odG1sOiBB ZGRlZC4KKwogMjAwOS0xMi0xMSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5ub3Jv bmhhQGNvbGxhYm9yYS5jby51az4KIAogICAgICAgICBTa2lwIHRlc3QgdGhhdCBpcyBmYWlsaW5n IGJlY2F1c2Ugc2NyaXB0IGlzIG5vdCBleGVjdXRlZCBhZnRlciB0aGUKSW5kZXg6IExheW91dFRl c3RzL3BsYXRmb3JtL3dpbi9mYXN0L2V2ZW50cy9wYW5TY3JvbGwtbm8taWZyYW1lLWp1bXAtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2V2 ZW50cy9wYW5TY3JvbGwtbm8taWZyYW1lLWp1bXAtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZXZlbnRzL3BhblNjcm9sbC1uby1pZnJh bWUtanVtcC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorCitUZXN0 IGZvciBidWcgMzIzOTkgVGhpcyB0ZXN0cyB0aGF0IHBhbiBzY3JvbGxpbmcgZG9lc24ndCBqdW1w IG91dCBvZiBhbiBpRnJhbWUgaWYgdGhlIGFjdGlvbiBiZWdpbnMgaW4gYW4gaUZyYW1lIHRoYXQg Y2Fubm90IHNjcm9sbC4KKworU3VjY2VzcyEgRGl2IHdpdGggb3ZlcmZsb3cgd2FzIG5vdCBzY3Jv bGxlZApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL2Zhc3QvZXZlbnRzL3BhblNjcm9s bC1uby1pZnJhbWUtanVtcC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3Jt L3dpbi9mYXN0L2V2ZW50cy9wYW5TY3JvbGwtbm8taWZyYW1lLWp1bXAuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9mYXN0L2V2ZW50cy9wYW5TY3JvbGwtbm8t aWZyYW1lLWp1bXAuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MCBAQAorPGh0bWw+DQor ICAgIDxoZWFkPg0KKyAgICAgICAgPHRpdGxlPlBhbiBTY3JvbGxpbmcgVGVzdDwvdGl0bGU+DQor ICAgIDwvaGVhZD4NCisgICAgPGJvZHk+DQorICAgICAgICA8c2NyaXB0Pg0KKyAgICAgICAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsNCisgICAgICAgICAgICAgICAgbGF5 b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOw0KKyAgICAgICAgICAgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7DQorICAgICAgICAgICAgfQ0KKyAgICAgICAg PC9zY3JpcHQ+DQorICAgICAgICA8ZGl2IGlkPSJvdmVyZmxvdyIgc3R5bGU9IndpZHRoOjUwMHB4 OyBoZWlnaHQ6MTUwcHg7IG92ZXJmbG93OmF1dG87IGJvcmRlcjoycHggc29saWQgcmVkOyBwYWRk aW5nOjEwcHgiPg0KKyAgICAgICAgICAgIDxpZnJhbWUgd2lkdGg9IjEwMHB4IiBoZWlnaHQ9IjEw MHB4Ij48L2lmcmFtZT4NCisgICAgICAgICAgICA8aDE+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzk5Ij5idWcgMzIzOTk8L2E+IFRo aXMgdGVzdHMgdGhhdCBwYW4NCisgICAgICAgICAgICBzY3JvbGxpbmcgZG9lc24ndCBqdW1wIG91 dCBvZiBhbiBpRnJhbWUgaWYgdGhlIGFjdGlvbiBiZWdpbnMgaW4gYW4gaUZyYW1lIHRoYXQgY2Fu bm90IHNjcm9sbC48L2gxPg0KKyAgICAgICAgPC9kaXY+DQorICAgICAgICA8cD4NCisgICAgICAg IDxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2Pg0KKyAgICAgICAgPHNjcmlwdD4NCisgICAgICAgICAg ICBpZiAod2luZG93LmV2ZW50U2VuZGVyKQ0KKyAgICAgICAgICAgIHsNCisgICAgICAgICAgICAg ICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oNTAsIDUwKTsNCisgICAgICAgICAgICAgICAgZXZl bnRTZW5kZXIubW91c2VEb3duKDEpOw0KKyAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3Vz ZVVwKDEpOw0KKyAgICAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyg1MCwgMjAw KTsNCisgICAgICAgICAgICAgICAgc2V0VGltZW91dChmaW5pc2hlZCwgNTAwKTsNCisgICAgICAg ICAgICB9DQorICAgICAgICAgICAgDQorICAgICAgICAgICAgZnVuY3Rpb24gZmluaXNoZWQoKQ0K KyAgICAgICAgICAgIHsNCisgICAgICAgICAgICAgICAgaWYgKCFkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnb3ZlcmZsb3cnKS5zY3JvbGxUb3ApDQorICAgICAgICAgICAgICAgICAgICBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpLmlubmVySFRNTCA9ICJTdWNjZXNzISBEaXYgd2l0 aCBvdmVyZmxvdyB3YXMgbm90IHNjcm9sbGVkIjsNCisgICAgICAgICAgICAgICAgZWxzZQ0KKyAg ICAgICAgICAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKS5pbm5l ckhUTUwgPSAiRmFpbCEgRGl2IHdpdGggb3ZlcmZsb3cgd2FzIHNjcm9sbGVkIjsNCisgICAgICAg ICAgICAgICAgDQorICAgICAgICAgICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlci5u b3RpZnlEb25lKCk7DQorICAgICAgICAgICAgfQ0KKyAgICAgICAgPC9zY3JpcHQ+DQorICAgIDwv Ym9keT4NCis8L2h0bWw+DQo=