32392 2009-12-10 13:16:34 -0800 Web Inspector: debugger shortcuts don't work when Search field or Console field has focus. 2009-12-10 13:54:51 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy webkit.review.bot oldest_to_newest 170500 0 pfeldman 2009-12-10 13:16:34 -0800 Reason is that they are handled from within main panels key handler, not the document's one. 170503 1 44635 pfeldman 2009-12-10 13:23:47 -0800 Created attachment 44635 [PATCH] fix 170504 2 webkit.review.bot 2009-12-10 13:25:50 -0800 style-queue ran check-webkit-style on attachment 44635 without any errors. 170511 3 pfeldman 2009-12-10 13:54:51 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsTreeOutline.js M WebCore/inspector/front-end/KeyboardShortcut.js M WebCore/inspector/front-end/inspector.js Committed r51961 44635 2009-12-10 13:23:47 -0800 2009-12-10 13:25:52 -0800 [PATCH] fix shortcuts text/plain 4603 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjhiMTU1MS4uZmUzYjYxNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAwOS0xMi0xMCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBkZWJ1Z2dlciBzaG9ydGN1dHMgZG9u J3Qgd29yayB3aGVuIAorICAgICAgICBTZWFyY2ggZmllbGQgb3IgQ29uc29sZSBkcmF3ZXIgaGFz IGZvY3VzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMjM5MgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IubG9hZGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5kb2N1 bWVudEtleURvd24pOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5VXApOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLnNlYXJjaEtleURvd24pOgorCisyMDA5LTEyLTEwICBQYXZlbCBG ZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFRp bW90aHkgSGF0Y2hlci4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgY29udGV4dCBtZW51 IGFjdGlvbnMgZm9yIERPTSB0cmVlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL2luc3BlY3Rvci5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0 b3IuanMKaW5kZXggNzNkYzc0Yy4uNjFhZmZjMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvaW5zcGVjdG9yLmpzCkBAIC00ODIsOCArNDgyLDYgQEAgV2ViSW5zcGVjdG9yLmxvYWRlZCA9 IGZ1bmN0aW9uKCkKICAgICBkb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJjb250ZXh0bWVudSIs IHRoaXMuY29udGV4dE1lbnVFdmVudEZpcmVkLmJpbmQodGhpcyksIHRydWUpOwogCiAgICAgdmFy IG1haW5QYW5lbHNFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1haW4tcGFuZWxz Iik7Ci0gICAgbWFpblBhbmVsc0VsZW1lbnQuaGFuZGxlS2V5RXZlbnQgPSB0aGlzLm1haW5LZXlE b3duLmJpbmQodGhpcyk7Ci0gICAgbWFpblBhbmVsc0VsZW1lbnQuaGFuZGxlS2V5VXBFdmVudCA9 IHRoaXMubWFpbktleVVwLmJpbmQodGhpcyk7CiAgICAgbWFpblBhbmVsc0VsZW1lbnQuaGFuZGxl Q29weUV2ZW50ID0gdGhpcy5tYWluQ29weS5iaW5kKHRoaXMpOwogCiAgICAgLy8gRm9jdXMgdGhl IG1haW5QYW5lbHNFbGVtZW50IGluIGEgdGltZW91dCBzbyBpdCBoYXBwZW5zIGFmdGVyIHRoZSBp bml0aWFsIGZvY3VzLApAQCAtNjQwLDEyICs2MzgsMTcgQEAgV2ViSW5zcGVjdG9yLmRvY3VtZW50 Q2xpY2sgPSBmdW5jdGlvbihldmVudCkKIAogV2ViSW5zcGVjdG9yLmRvY3VtZW50S2V5RG93biA9 IGZ1bmN0aW9uKGV2ZW50KQogewotICAgIGlmICghdGhpcy5jdXJyZW50Rm9jdXNFbGVtZW50KQot ICAgICAgICByZXR1cm47Ci0gICAgaWYgKHRoaXMuY3VycmVudEZvY3VzRWxlbWVudC5oYW5kbGVL ZXlFdmVudCkKLSAgICAgICAgdGhpcy5jdXJyZW50Rm9jdXNFbGVtZW50LmhhbmRsZUtleUV2ZW50 KGV2ZW50KTsKLSAgICBlbHNlIGlmICh0aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQuaWQgJiYgdGhp cy5jdXJyZW50Rm9jdXNFbGVtZW50LmlkLmxlbmd0aCAmJiBXZWJJbnNwZWN0b3JbdGhpcy5jdXJy ZW50Rm9jdXNFbGVtZW50LmlkICsgIktleURvd24iXSkKLSAgICAgICAgV2ViSW5zcGVjdG9yW3Ro aXMuY3VycmVudEZvY3VzRWxlbWVudC5pZCArICJLZXlEb3duIl0oZXZlbnQpOworICAgIGlmICh0 aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQpIHsKKyAgICAgICAgaWYgKHRoaXMuY3VycmVudEZvY3Vz RWxlbWVudC5oYW5kbGVLZXlFdmVudCkKKyAgICAgICAgICAgIHRoaXMuY3VycmVudEZvY3VzRWxl bWVudC5oYW5kbGVLZXlFdmVudChldmVudCk7CisgICAgICAgIGVsc2UgaWYgKHRoaXMuY3VycmVu dEZvY3VzRWxlbWVudC5pZCAmJiB0aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQuaWQubGVuZ3RoICYm IFdlYkluc3BlY3Rvclt0aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQuaWQgKyAiS2V5RG93biJdKQor ICAgICAgICAgICAgV2ViSW5zcGVjdG9yW3RoaXMuY3VycmVudEZvY3VzRWxlbWVudC5pZCArICJL ZXlEb3duIl0oZXZlbnQpOworICAgICAgICBpZiAoZXZlbnQuaGFuZGxlZCkKKyAgICAgICAgICAg IHJldHVybjsKKyAgICB9CisKKyAgICBpZiAodGhpcy5jdXJyZW50UGFuZWwgJiYgdGhpcy5jdXJy ZW50UGFuZWwuaGFuZGxlS2V5RXZlbnQpCisgICAgICAgIHRoaXMuY3VycmVudFBhbmVsLmhhbmRs ZUtleUV2ZW50KGV2ZW50KTsKIAogICAgIGlmICghZXZlbnQuaGFuZGxlZCkgewogICAgICAgICB2 YXIgaXNNYWMgPSBXZWJJbnNwZWN0b3IuaXNNYWMoKTsKQEAgLTczMCw5ICs3MzMsMTUgQEAgV2Vi SW5zcGVjdG9yLmRvY3VtZW50S2V5RG93biA9IGZ1bmN0aW9uKGV2ZW50KQogCiBXZWJJbnNwZWN0 b3IuZG9jdW1lbnRLZXlVcCA9IGZ1bmN0aW9uKGV2ZW50KQogewotICAgIGlmICghdGhpcy5jdXJy ZW50Rm9jdXNFbGVtZW50IHx8ICF0aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQuaGFuZGxlS2V5VXBF dmVudCkKLSAgICAgICAgcmV0dXJuOwotICAgIHRoaXMuY3VycmVudEZvY3VzRWxlbWVudC5oYW5k bGVLZXlVcEV2ZW50KGV2ZW50KTsKKyAgICBpZiAodGhpcy5jdXJyZW50Rm9jdXNFbGVtZW50KSB7 CisgICAgICAgIGlmICh0aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQuaGFuZGxlS2V5VXBFdmVudCkK KyAgICAgICAgICAgIHRoaXMuY3VycmVudEZvY3VzRWxlbWVudC5oYW5kbGVLZXlVcEV2ZW50KGV2 ZW50KTsKKyAgICAgICAgaWYgKGV2ZW50LmhhbmRsZWQpCisgICAgICAgICAgICByZXR1cm47Cisg ICAgfQorCisgICAgaWYgKHRoaXMuY3VycmVudFBhbmVsICYmIHRoaXMuY3VycmVudFBhbmVsLmhh bmRsZUtleVVwRXZlbnQpCisgICAgICAgIHRoaXMuY3VycmVudFBhbmVsLmhhbmRsZUtleVVwRXZl bnQoZXZlbnQpOwogfQogCiBXZWJJbnNwZWN0b3IuZG9jdW1lbnRDYW5Db3B5ID0gZnVuY3Rpb24o ZXZlbnQpCkBAIC03NjIsMTggKzc3MSw2IEBAIFdlYkluc3BlY3Rvci5jb250ZXh0TWVudUV2ZW50 RmlyZWQgPSBmdW5jdGlvbihldmVudCkKICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsK IH0KIAotV2ViSW5zcGVjdG9yLm1haW5LZXlEb3duID0gZnVuY3Rpb24oZXZlbnQpCi17Ci0gICAg aWYgKHRoaXMuY3VycmVudFBhbmVsICYmIHRoaXMuY3VycmVudFBhbmVsLmhhbmRsZUtleUV2ZW50 KQotICAgICAgICB0aGlzLmN1cnJlbnRQYW5lbC5oYW5kbGVLZXlFdmVudChldmVudCk7Ci19Ci0K LVdlYkluc3BlY3Rvci5tYWluS2V5VXAgPSBmdW5jdGlvbihldmVudCkKLXsKLSAgICBpZiAodGhp cy5jdXJyZW50UGFuZWwgJiYgdGhpcy5jdXJyZW50UGFuZWwuaGFuZGxlS2V5VXBFdmVudCkKLSAg ICAgICAgdGhpcy5jdXJyZW50UGFuZWwuaGFuZGxlS2V5VXBFdmVudChldmVudCk7Ci19Ci0KIFdl Ykluc3BlY3Rvci5tYWluQ29weSA9IGZ1bmN0aW9uKGV2ZW50KQogewogICAgIGlmICh0aGlzLmN1 cnJlbnRQYW5lbCAmJiB0aGlzLmN1cnJlbnRQYW5lbC5oYW5kbGVDb3B5RXZlbnQpCkBAIC0xNTUw LDE0ICsxNTQ3LDE1IEBAIFdlYkluc3BlY3Rvci5zZWFyY2hLZXlEb3duID0gZnVuY3Rpb24oZXZl bnQpCiAgICAgLy8gRXNjYXBlIEtleSB3aWxsIGNsZWFyIHRoZSBmaWVsZCBhbmQgY2xlYXIgdGhl IHNlYXJjaCByZXN1bHRzCiAgICAgaWYgKGV2ZW50LmtleUNvZGUgPT09IFdlYkluc3BlY3Rvci5L ZXlib2FyZFNob3J0Y3V0LktleUNvZGVzLkVzYykgewogICAgICAgICBldmVudC5wcmV2ZW50RGVm YXVsdCgpOwotICAgICAgICBldmVudC5oYW5kbGVkID0gdHJ1ZTsKKyAgICAgICAgLy8gV2hlbiBz ZWFyY2ggd2FzIHNlbGVjdGVkIG1hbnVhbGx5IGFuZCBpcyBjdXJyZW50bHkgYmxhbmssIHdlJ2Qg bGlrZSBFc2Mgc3RheSB1bmhhbmRsZWQKKyAgICAgICAgLy8gYW5kIGhpdCBjb25zb2xlIGRyYXdl ciBoYW5kbGVyLgorICAgICAgICBldmVudC5oYW5kbGVkID0gISh0aGlzLnByZXZpb3VzRm9jdXNF bGVtZW50ID09PSBldmVudC50YXJnZXQgJiYgZXZlbnQudGFyZ2V0LnZhbHVlID09PSAiIik7CiAg ICAgICAgIGV2ZW50LnRhcmdldC52YWx1ZSA9ICIiOwogCiAgICAgICAgIHRoaXMucGVyZm9ybVNl YXJjaChldmVudCk7CiAgICAgICAgIHRoaXMuY3VycmVudEZvY3VzRWxlbWVudCA9IHRoaXMucHJl dmlvdXNGb2N1c0VsZW1lbnQ7CiAgICAgICAgIGlmICh0aGlzLmN1cnJlbnRGb2N1c0VsZW1lbnQg PT09IGV2ZW50LnRhcmdldCkKICAgICAgICAgICAgIHRoaXMuY3VycmVudEZvY3VzRWxlbWVudC5z ZWxlY3QoKTsKLQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogCg==