32390 2009-12-10 12:27:33 -0800 Crash in WebCore::SplitElementCommand::SplitElementCommand ReadAV@NULL (3d3ebb81789addf3fcdd28c39a72b244) 2010-01-27 05:51:31 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Windows Vista RESOLVED FIXED http://skypher.com/SkyLined/Repro/WebKit/Bug%2032390%20-%20WebCore..SplitElementCommand..SplitElementCommand%20ReadAV@NULL%20(3d3ebb81789addf3fcdd28c39a72b244)/repro.html P1 Normal --- 1 skylined tony adele commit-queue enrica eric oliver rniwa tony oldest_to_newest 170486 0 44632 skylined 2009-12-10 12:27:33 -0800 Created attachment 44632 Repro Id: WebCore::SplitElementCommand::SplitElementCommand ReadAV@NULL (3d3ebb81789addf3fcdd28c39a72b244) Description: Attempt to read from NULL pointer (+0x10) in WebCore::SplitElementCommand::SplitElementCommand Stack: WebCore::SplitElementCommand::SplitElementCommand WebCore::SplitElementCommand::create WebCore::CompositeEditCommand::splitTreeToNode WebCore::IndentOutdentCommand::indentIntoBlockquote WebCore::IndentOutdentCommand::indentRegion WebCore::IndentOutdentCommand::doApply WebCore::EditCommand::apply WebCore::applyCommand WebCore::executeIndent WebCore::Editor::Command::execute WebCore::Document::execCommand WebCore::DocumentInternal::execCommandCallback Repro: <BODY></BODY> <SCRIPT> document.designMode = "on"; document.execCommand("SelectAll",false,""); document.execCommand("InsertUnorderedList",""); document.execCommand("inserthorizontalrule",false, "??"); document.execCommand("indent",false,3); </SCRIPT> 170488 1 skylined 2009-12-10 12:30:49 -0800 Online repro 170491 2 skylined 2009-12-10 12:40:19 -0800 Fix online repro link 180097 3 tony 2010-01-12 23:13:11 -0800 What should happen is that we have a list item with a horizontal rule in it that gets indented to be a 2 level deep list item. The call to insert should just indent the list item one level in. Instead, it doesn't try to indent the list item and gets confused and tries to put a blockquote around the HR. It doesn't try to indent the list item because enclosingBlock(Node*) in htmlediting.cpp can return the current element. The FIXME on the function says: // FIXME: Pass a position to this function. The enclosing block of [table, x] for example, should be the // block that contains the table and not the table, and this function should be the only one responsible for // knowing about these kinds of special cases. I'm not sure how passing a Position into the function will fix this. However, I can work around this at the call site and call enclosingBlock a second time if it returns the passed in Node. Patch coming that demonstrates this approach. 180099 4 46427 tony 2010-01-12 23:17:47 -0800 Created attachment 46427 Patch 180100 5 tony 2010-01-12 23:19:16 -0800 I'm not sure this is the best way to solve this. It'd be better to fix enclosingBlock(Node*), but I need some guidance on how to do that. 184724 6 46427 eric 2010-01-26 14:13:28 -0800 Comment on attachment 46427 Patch I think the fix and test are fine. Certainly better than crashing. You should add a FIXME next to your fix saying that enclosingBlock should eventually be fixed instead. 184856 7 47473 tony 2010-01-26 17:25:06 -0800 Created attachment 47473 Patch 184857 8 47473 tony 2010-01-26 17:25:39 -0800 Comment on attachment 47473 Patch just adding the fixme 184871 9 47473 eric 2010-01-26 17:51:52 -0800 Comment on attachment 47473 Patch LGTM. 185053 10 47473 commit-queue 2010-01-27 05:51:21 -0800 Comment on attachment 47473 Patch Clearing flags on attachment: 47473 Committed r53927: <http://trac.webkit.org/changeset/53927> 185055 11 commit-queue 2010-01-27 05:51:31 -0800 All reviewed patches have been landed. Closing bug. 44632 2009-12-10 12:27:33 -0800 2009-12-10 12:27:33 -0800 Repro repro.html text/html 267 skylined PEJPRFk+PC9CT0RZPg0KPFNDUklQVD4NCiAgZG9jdW1lbnQuZGVzaWduTW9kZSA9ICJvbiI7DQog IGRvY3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiLGZhbHNlLCIiKTsNCiAgZG9jdW1lbnQu ZXhlY0NvbW1hbmQoIkluc2VydFVub3JkZXJlZExpc3QiLCIiKTsNCiAgZG9jdW1lbnQuZXhlY0Nv bW1hbmQoImluc2VydGhvcml6b250YWxydWxlIixmYWxzZSwgIj8/Iik7DQogIGRvY3VtZW50LmV4 ZWNDb21tYW5kKCJpbmRlbnQiLGZhbHNlLDMpOw0KPC9TQ1JJUFQ+ 46427 2010-01-12 23:17:47 -0800 2010-01-26 17:24:59 -0800 Patch bug-32390-20100113161745.patch text/plain 4035 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiN2Y4MjY2Li5hNzM2NmVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDEt MTIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBjcmFzaCB3aGVuIHRyeWluZyB0byBp bmRlbnQgYSBibG9jayBlbGVtZW50IHRoYXQgd2FzIGNvbnRhaW5lZAorICAgICAgICBpbiBhIGxp c3QuICBUaGlzIHdhcyBoYXBwZW5pbmcgYmVjYXVzZSBlbmNsb3NpbmdCbG9jaygpIGluCisgICAg ICAgIGh0bWxlZGl0aW5nLmNwcCBjYW4gcmV0dXJuIHRoZSBjdXJyZW50IHRoZSBzYW1lIE5vZGUg d2hlbiBhIGJsb2NrCisgICAgICAgIGVsZW1lbnQgKGxpa2UgYW4gPGhyPiBvciBhIDx0YWJsZT4p IGlzIHBhc3NlZCBpbi4gIFRoaXMgY2F1c2VzCisgICAgICAgIHRoZSBpbmRlbnQgY29tbWFuZCB0 byB0aGluayB0aGF0IGl0IGlzIG5vdCBpbiBhIGxpc3QgaXRlbS4KKworICAgICAgICBXb3JrIGFy b3VuZCB0aGlzIGJ5IGNoZWNraW5nIHRvIHNlZSBpZiBlbmNsb3NpbmdCbG9jayByZXR1cm5lZCB0 aGUKKyAgICAgICAgc2FtZSBOb2RlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMjM5MAorCisgICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC9p bmRlbnQtYmxvY2staW4tbGlzdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRp bmcvZXhlY0NvbW1hbmQvaW5kZW50LWJsb2NrLWluLWxpc3QuaHRtbDogQWRkZWQuCisKIDIwMTAt MDEtMTIgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4 ZWNDb21tYW5kL2luZGVudC1ibG9jay1pbi1saXN0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5kZW50LWJsb2NrLWluLWxpc3QtZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjUzY2RmMWUKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1ibG9jay1pbi1saXN0 LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTRUQKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5kZW50LWJsb2NrLWluLWxpc3QuaHRtbCBiL0xheW91 dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5kZW50LWJsb2NrLWluLWxpc3QuaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42M2M1ZjZhCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pbmRlbnQtYmxvY2staW4tbGlzdC5o dG1sCkBAIC0wLDAgKzEsMTUgQEAKKzxib2R5PgorPC9ib2R5PgorPFNDUklQVD4KKyAgaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisKKyAgZG9jdW1lbnQuZGVzaWduTW9kZSA9ICJvbiI7CisgIGRv Y3VtZW50LmV4ZWNDb21tYW5kKCJTZWxlY3RBbGwiLCBmYWxzZSwgbnVsbCk7CisgIGRvY3VtZW50 LmV4ZWNDb21tYW5kKCJJbnNlcnRVbm9yZGVyZWRMaXN0IiwgZmFsc2UsIG51bGwpOworICBkb2N1 bWVudC5leGVjQ29tbWFuZCgiaW5zZXJ0aG9yaXpvbnRhbHJ1bGUiKTsKKyAgLy8gVGhpcyB3YXMg dHJpZ2dlcmluZyBhbiBhc3NlcnQgYmVjYXVzZSB3ZSB3ZXJlbid0IHByb3Blcmx5IGluZGVudGlu ZworICAvLyBibG9jayBlbGVtZW50cyBpbiBsaXN0cy4KKyAgZG9jdW1lbnQuZXhlY0NvbW1hbmQo ImluZGVudCIpOworICBkb2N1bWVudC5leGVjQ29tbWFuZCgiaW5zZXJ0aHRtbCIsIGZhbHNlLCAi UEFTU0VEIik7Cis8L1NDUklQVD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggOGEyYzQzNi4uYjZiZDA4MyAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAx MC0wMS0xMiAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIGNyYXNoIHdoZW4gdHJ5aW5n IHRvIGluZGVudCBhIGJsb2NrIGVsZW1lbnQgdGhhdCB3YXMgY29udGFpbmVkCisgICAgICAgIGlu IGEgbGlzdC4gIFRoaXMgd2FzIGhhcHBlbmluZyBiZWNhdXNlIGVuY2xvc2luZ0Jsb2NrKCkgaW4K KyAgICAgICAgaHRtbGVkaXRpbmcuY3BwIGNhbiByZXR1cm4gdGhlIGN1cnJlbnQgdGhlIHNhbWUg Tm9kZSB3aGVuIGEgYmxvY2sKKyAgICAgICAgZWxlbWVudCAobGlrZSBhbiA8aHI+IG9yIGEgPHRh YmxlPikgaXMgcGFzc2VkIGluLiAgVGhpcyBjYXVzZXMKKyAgICAgICAgdGhlIGluZGVudCBjb21t YW5kIHRvIHRoaW5rIHRoYXQgaXQgaXMgbm90IGluIGEgbGlzdCBpdGVtLgorCisgICAgICAgIFdv cmsgYXJvdW5kIHRoaXMgYnkgY2hlY2tpbmcgdG8gc2VlIGlmIGVuY2xvc2luZ0Jsb2NrIHJldHVy bmVkIHRoZQorICAgICAgICBzYW1lIE5vZGUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzkwCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9leGVj Q29tbWFuZC9pbmRlbnQtYmxvY2staW4tbGlzdC5odG1sCisKKyAgICAgICAgKiBlZGl0aW5nL0lu ZGVudE91dGRlbnRDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkluZGVudE91dGRlbnRD b21tYW5kOjp0cnlJbmRlbnRpbmdBc0xpc3RJdGVtKToKKwogMjAxMC0wMS0xMiAgRnVtaXRvc2hp IFVrYWkgIDx1a2FpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBI YXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50Q29tbWFu ZC5jcHAgYi9XZWJDb3JlL2VkaXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3BwCmluZGV4IDVl NmYzMzkuLmFlOWRjZmMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50 Q29tbWFuZC5jcHAKKysrIGIvV2ViQ29yZS9lZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5kLmNw cApAQCAtNzYsNyArNzYsMTAgQEAgYm9vbCBJbmRlbnRPdXRkZW50Q29tbWFuZDo6dHJ5SW5kZW50 aW5nQXNMaXN0SXRlbShjb25zdCBWaXNpYmxlUG9zaXRpb24mIGVuZE9mQ3UKICAgICAgICAgcmV0 dXJuIGZhbHNlOwogCiAgICAgLy8gRmluZCB0aGUgbGlzdCBpdGVtIGVuY2xvc2luZyB0aGUgY3Vy cmVudCBwYXJhZ3JhcGgKLSAgICBFbGVtZW50KiBzZWxlY3RlZExpc3RJdGVtID0gc3RhdGljX2Nh c3Q8RWxlbWVudCo+KGVuY2xvc2luZ0Jsb2NrKGVuZE9mQ3VycmVudFBhcmFncmFwaC5kZWVwRXF1 aXZhbGVudCgpLm5vZGUoKSkpOworICAgIEVsZW1lbnQqIHNlbGVjdGVkTGlzdEl0ZW0gPSBzdGF0 aWNfY2FzdDxFbGVtZW50Kj4oZW5jbG9zaW5nQmxvY2sobGFzdE5vZGVJblNlbGVjdGVkUGFyYWdy YXBoKSk7CisgICAgaWYgKHNlbGVjdGVkTGlzdEl0ZW0gPT0gbGFzdE5vZGVJblNlbGVjdGVkUGFy YWdyYXBoKQorICAgICAgICBzZWxlY3RlZExpc3RJdGVtID0gc3RhdGljX2Nhc3Q8RWxlbWVudCo+ KGVuY2xvc2luZ0Jsb2NrKGxhc3ROb2RlSW5TZWxlY3RlZFBhcmFncmFwaC0+cGFyZW50Tm9kZSgp KSk7CisKICAgICAvLyBGSVhNRTogd2UgbmVlZCB0byBkZWFsIHdpdGggdGhlIGNhc2Ugd2hlcmUg dGhlcmUgaXMgbm8gbGkgKG1hbGZvcm1lZCBIVE1MKQogICAgIGlmICghc2VsZWN0ZWRMaXN0SXRl bS0+aGFzVGFnTmFtZShsaVRhZykpCiAgICAgICAgIHJldHVybiBmYWxzZTsK 47473 2010-01-26 17:25:06 -0800 2010-01-27 05:51:21 -0800 Patch bug-32390-20100127102504.patch text/plain 4187 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5YzBjYjhmLi5iYjgwMzU5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDEt MjYgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KKworICAgICAgICBGaXggYSBjcmFzaCB3aGVuIHRyeWluZyB0byBpbmRl bnQgYSBibG9jayBlbGVtZW50IHRoYXQgd2FzIGNvbnRhaW5lZAorICAgICAgICBpbiBhIGxpc3Qu ICBUaGlzIHdhcyBoYXBwZW5pbmcgYmVjYXVzZSBlbmNsb3NpbmdCbG9jaygpIGluCisgICAgICAg IGh0bWxlZGl0aW5nLmNwcCBjYW4gcmV0dXJuIHRoZSBjdXJyZW50IHRoZSBzYW1lIE5vZGUgd2hl biBhIGJsb2NrCisgICAgICAgIGVsZW1lbnQgKGxpa2UgYW4gPGhyPiBvciBhIDx0YWJsZT4pIGlz IHBhc3NlZCBpbi4gIFRoaXMgY2F1c2VzCisgICAgICAgIHRoZSBpbmRlbnQgY29tbWFuZCB0byB0 aGluayB0aGF0IGl0IGlzIG5vdCBpbiBhIGxpc3QgaXRlbS4KKworICAgICAgICBXb3JrIGFyb3Vu ZCB0aGlzIGJ5IGNoZWNraW5nIHRvIHNlZSBpZiBlbmNsb3NpbmdCbG9jayByZXR1cm5lZCB0aGUK KyAgICAgICAgc2FtZSBOb2RlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zMjM5MAorCisgICAgICAgICogZWRpdGluZy9leGVjQ29tbWFuZC9pbmRl bnQtYmxvY2staW4tbGlzdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcv ZXhlY0NvbW1hbmQvaW5kZW50LWJsb2NrLWluLWxpc3QuaHRtbDogQWRkZWQuCisKIDIwMTAtMDEt MjYgIEVucmljYSBDYXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBKb24gSG9uZXljdXR0LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVj Q29tbWFuZC9pbmRlbnQtYmxvY2staW4tbGlzdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9l ZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1ibG9jay1pbi1saXN0LWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi41M2NkZjFlCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9leGVjQ29tbWFuZC9pbmRlbnQtYmxvY2staW4tbGlzdC1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSBAQAorUEFTU0VECmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1ibG9jay1pbi1saXN0Lmh0bWwgYi9MYXlvdXRU ZXN0cy9lZGl0aW5nL2V4ZWNDb21tYW5kL2luZGVudC1ibG9jay1pbi1saXN0Lmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNjNjNWY2YQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2VkaXRpbmcvZXhlY0NvbW1hbmQvaW5kZW50LWJsb2NrLWluLWxpc3QuaHRt bApAQCAtMCwwICsxLDE1IEBACis8Ym9keT4KKzwvYm9keT4KKzxTQ1JJUFQ+CisgIGlmICh3aW5k b3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOworCisgIGRvY3VtZW50LmRlc2lnbk1vZGUgPSAib24iOworICBkb2N1 bWVudC5leGVjQ29tbWFuZCgiU2VsZWN0QWxsIiwgZmFsc2UsIG51bGwpOworICBkb2N1bWVudC5l eGVjQ29tbWFuZCgiSW5zZXJ0VW5vcmRlcmVkTGlzdCIsIGZhbHNlLCBudWxsKTsKKyAgZG9jdW1l bnQuZXhlY0NvbW1hbmQoImluc2VydGhvcml6b250YWxydWxlIik7CisgIC8vIFRoaXMgd2FzIHRy aWdnZXJpbmcgYW4gYXNzZXJ0IGJlY2F1c2Ugd2Ugd2VyZW4ndCBwcm9wZXJseSBpbmRlbnRpbmcK KyAgLy8gYmxvY2sgZWxlbWVudHMgaW4gbGlzdHMuCisgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJp bmRlbnQiKTsKKyAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImluc2VydGh0bWwiLCBmYWxzZSwgIlBB U1NFRCIpOworPC9TQ1JJUFQ+CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IGJjOTk2YzAuLmNhNjI0N2EgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTAt MDEtMjYgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBFcmljIFNlaWRlbC4KKworICAgICAgICBGaXggYSBjcmFzaCB3aGVuIHRyeWluZyB0byBp bmRlbnQgYSBibG9jayBlbGVtZW50IHRoYXQgd2FzIGNvbnRhaW5lZAorICAgICAgICBpbiBhIGxp c3QuICBUaGlzIHdhcyBoYXBwZW5pbmcgYmVjYXVzZSBlbmNsb3NpbmdCbG9jaygpIGluCisgICAg ICAgIGh0bWxlZGl0aW5nLmNwcCBjYW4gcmV0dXJuIHRoZSBjdXJyZW50IHRoZSBzYW1lIE5vZGUg d2hlbiBhIGJsb2NrCisgICAgICAgIGVsZW1lbnQgKGxpa2UgYW4gPGhyPiBvciBhIDx0YWJsZT4p IGlzIHBhc3NlZCBpbi4gIFRoaXMgY2F1c2VzCisgICAgICAgIHRoZSBpbmRlbnQgY29tbWFuZCB0 byB0aGluayB0aGF0IGl0IGlzIG5vdCBpbiBhIGxpc3QgaXRlbS4KKworICAgICAgICBXb3JrIGFy b3VuZCB0aGlzIGJ5IGNoZWNraW5nIHRvIHNlZSBpZiBlbmNsb3NpbmdCbG9jayByZXR1cm5lZCB0 aGUKKyAgICAgICAgc2FtZSBOb2RlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zMjM5MAorCisgICAgICAgIFRlc3Q6IGVkaXRpbmcvZXhlY0NvbW1h bmQvaW5kZW50LWJsb2NrLWluLWxpc3QuaHRtbAorCisgICAgICAgICogZWRpdGluZy9JbmRlbnRP dXRkZW50Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbmRlbnRPdXRkZW50Q29tbWFu ZDo6dHJ5SW5kZW50aW5nQXNMaXN0SXRlbSk6CisKIDIwMTAtMDEtMjYgIERhbiBCZXJuc3RlaW4g IDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2VkaXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3BwIGIvV2Vi Q29yZS9lZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5kLmNwcAppbmRleCA1ZTZmMzM5Li4wZjM5 NzViIDEwMDY0NAotLS0gYS9XZWJDb3JlL2VkaXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3Bw CisrKyBiL1dlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50Q29tbWFuZC5jcHAKQEAgLTc2LDcg Kzc2LDEyIEBAIGJvb2wgSW5kZW50T3V0ZGVudENvbW1hbmQ6OnRyeUluZGVudGluZ0FzTGlzdEl0 ZW0oY29uc3QgVmlzaWJsZVBvc2l0aW9uJiBlbmRPZkN1CiAgICAgICAgIHJldHVybiBmYWxzZTsK IAogICAgIC8vIEZpbmQgdGhlIGxpc3QgaXRlbSBlbmNsb3NpbmcgdGhlIGN1cnJlbnQgcGFyYWdy YXBoCi0gICAgRWxlbWVudCogc2VsZWN0ZWRMaXN0SXRlbSA9IHN0YXRpY19jYXN0PEVsZW1lbnQq PihlbmNsb3NpbmdCbG9jayhlbmRPZkN1cnJlbnRQYXJhZ3JhcGguZGVlcEVxdWl2YWxlbnQoKS5u b2RlKCkpKTsKKyAgICBFbGVtZW50KiBzZWxlY3RlZExpc3RJdGVtID0gc3RhdGljX2Nhc3Q8RWxl bWVudCo+KGVuY2xvc2luZ0Jsb2NrKGxhc3ROb2RlSW5TZWxlY3RlZFBhcmFncmFwaCkpOworICAg IC8vIEZJWE1FOiBlbmNsb3NpbmdCbG9jayBzaG91bGRuJ3QgcmV0dXJuIHRoZSBwYXNzZWQgaW4g ZWxlbWVudC4gIFNlZSB0aGUKKyAgICAvLyBjb21tZW50IG9uIHRoZSBmdW5jdGlvbiBhYm91dCBo b3cgdG8gZml4IHJhdGhlciB0aGFuIGhhdmluZyB0byBhZGp1c3QgaGVyZS4KKyAgICBpZiAoc2Vs ZWN0ZWRMaXN0SXRlbSA9PSBsYXN0Tm9kZUluU2VsZWN0ZWRQYXJhZ3JhcGgpCisgICAgICAgIHNl bGVjdGVkTGlzdEl0ZW0gPSBzdGF0aWNfY2FzdDxFbGVtZW50Kj4oZW5jbG9zaW5nQmxvY2sobGFz dE5vZGVJblNlbGVjdGVkUGFyYWdyYXBoLT5wYXJlbnROb2RlKCkpKTsKKwogICAgIC8vIEZJWE1F OiB3ZSBuZWVkIHRvIGRlYWwgd2l0aCB0aGUgY2FzZSB3aGVyZSB0aGVyZSBpcyBubyBsaSAobWFs Zm9ybWVkIEhUTUwpCiAgICAgaWYgKCFzZWxlY3RlZExpc3RJdGVtLT5oYXNUYWdOYW1lKGxpVGFn KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=