32371 2009-12-10 03:53:41 -0800 body with display:inline causes crash 2009-12-11 17:50:53 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 hamaji webkit-unassigned webkit.review.bot oldest_to_newest 170386 0 hamaji 2009-12-10 03:53:41 -0800 The following HTML causes WebKit crash. <body style="display: inline;"> <marquee>No crash means PASS</marquee> </body> 170387 1 44605 hamaji 2009-12-10 03:56:11 -0800 Created attachment 44605 Patch v1 170389 2 webkit.review.bot 2009-12-10 03:59:35 -0800 style-queue ran check-webkit-style on attachment 44605 without any errors. 170392 3 hamaji 2009-12-10 04:10:09 -0800 The two modified lines assume <body> is always a block element. I used encolsingBox instead of toRenderBox. For FrameView::createScrollbar(), I'm not sure if using encolsingBox is the best solution. We may be able to just check body->isBox() in this if-clause. For FrameView::layout(), I think we should use encolsingBox. Otherwise, an unnecessary horizontal scrollbar will appear for the testcase with marquee because the updated height won't be considered. 170791 4 44605 darin 2009-12-11 09:40:02 -0800 Comment on attachment 44605 Patch v1 r=me 171007 5 hamaji 2009-12-11 17:50:53 -0800 Committed r52036: <http://trac.webkit.org/changeset/52036> 44605 2009-12-10 03:56:11 -0800 2009-12-11 09:40:02 -0800 Patch v1 bug-32371-20091210205609.patch text/plain 4864 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMDZiZjdkLi5mNWRjZGUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTIt MTAgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBib2R5IHdpdGggZGlzcGxheTpp bmxpbmUgY2F1c2VzIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMjM3MQorCisgICAgICAgICogZmFzdC9pbmxpbmUvaW5saW5lLWJvZHktY3Jh c2gtZXhwZWN0ZWQudHh0OiBDb3BpZWQgZnJvbSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0 ZWQtY29udGVudC9hYnNvbHV0ZS1wb3NpdGlvbi1pbnNpZGUtaW5saW5lLWV4cGVjdGVkLnR4dC4K KyAgICAgICAgKiBmYXN0L2lubGluZS9pbmxpbmUtYm9keS1jcmFzaC5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2lubGluZS9pbmxpbmUtYm9keS13aXRoLXNjcm9sbGJhci1jcmFzaC1leHBl Y3RlZC50eHQ6IENvcGllZCBmcm9tIExheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250 ZW50L2Fic29sdXRlLXBvc2l0aW9uLWluc2lkZS1pbmxpbmUtZXhwZWN0ZWQudHh0LgorICAgICAg ICAqIGZhc3QvaW5saW5lL2lubGluZS1ib2R5LXdpdGgtc2Nyb2xsYmFyLWNyYXNoLmh0bWw6IEFk ZGVkLgorCiAyMDA5LTEyLTA5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvZmFzdC9pbmxpbmUvaW5saW5lLWJvZHktY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvZmFzdC9pbmxpbmUvaW5saW5lLWJvZHktY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjc2OTY0MjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2lubGluZS9pbmxpbmUtYm9keS1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAs MCArMSBAQAorTm8gY3Jhc2ggbWVhbnMgUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9pbmxpbmUvaW5saW5lLWJvZHktY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaW5saW5l L2lubGluZS1ib2R5LWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uYTY2OTU5ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaW5saW5lL2lu bGluZS1ib2R5LWNyYXNoLmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPGh0bWw+Cis8aGVhZD4KKzx0 aXRsZT5pbmxpbmUgYm9keSBjYXVzZXMgY3Jhc2g8L3RpdGxlPgorPHNjcmlwdD4KKyAgaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1 bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPC9oZWFkPgorCis8Ym9keSBzdHlsZT0iZGlzcGxheTog aW5saW5lOyI+CisgIDxtYXJxdWVlPk5vIGNyYXNoIG1lYW5zIFBBU1M8L21hcnF1ZWU+Cis8L2Jv ZHk+CisKKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaW5saW5lL2lubGlu ZS1ib2R5LXdpdGgtc2Nyb2xsYmFyLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zh c3QvaW5saW5lL2lubGluZS1ib2R5LXdpdGgtc2Nyb2xsYmFyLWNyYXNoLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43Njk2NDIxCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9pbmxpbmUvaW5saW5lLWJvZHktd2l0aC1zY3JvbGxiYXIt Y3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK05vIGNyYXNoIG1lYW5zIFBBU1MKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaW5saW5lL2lubGluZS1ib2R5LXdpdGgtc2Nyb2xs YmFyLWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9pbmxpbmUtYm9keS13aXRo LXNjcm9sbGJhci1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAu LjFlZWIwZmQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2lubGluZS9pbmxp bmUtYm9keS13aXRoLXNjcm9sbGJhci1jcmFzaC5odG1sCkBAIC0wLDAgKzEsMTcgQEAKKzxodG1s PgorPGhlYWQ+Cis8dGl0bGU+aW5saW5lIGJvZHkgY2F1c2VzIGNyYXNoIHdpdGggY3VzdG9tIHNj cm9sbGJhcjwvdGl0bGU+Cis8c3R5bGU+CisgIDo6LXdlYmtpdC1zY3JvbGxiYXIgeyB3aWR0aDog NXB4OyBoZWlnaHQ6IDVweDsgfQorPC9zdHlsZT4KKzxzY3JpcHQ+CisgIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7Cis8L3NjcmlwdD4KKzwvaGVhZD4KKworPGJvZHkgc3R5bGU9Im92ZXJmbG93OiBzY3JvbGw7 IGRpc3BsYXk6IGlubGluZTsiPgorICA8ZGl2IHN0eWxlPSJ3aWR0aDogNTAwMHB4OyBoZWlnaHQ6 IDUwMDBweDsiPk5vIGNyYXNoIG1lYW5zIFBBU1M8L2Rpdj4KKzwvYm9keT4KKworPC9odG1sPgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBk NzI2MGRiLi45YTAxZjQ5IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDA5LTEyLTEwICBTaGluaWNoaXJvIEhh bWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgYm9keSB3aXRoIGRpc3BsYXk6aW5saW5lIGNhdXNlcyBjcmFz aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIzNzEK KworICAgICAgICBUZXN0czogZmFzdC9pbmxpbmUvaW5saW5lLWJvZHktY3Jhc2guaHRtbAorICAg ICAgICAgICAgICAgZmFzdC9pbmxpbmUvaW5saW5lLWJvZHktd2l0aC1zY3JvbGxiYXItY3Jhc2gu aHRtbAorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RnJhbWVWaWV3OjpjcmVhdGVTY3JvbGxiYXIpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3 OjpsYXlvdXQpOgorCiAyMDA5LTEyLTA5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAppbmRl eCAwYjI2NGY3Li5jNDE3MWM3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cAorKysgYi9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMzQ1LDcgKzM0NSw3IEBAIFBh c3NSZWZQdHI8U2Nyb2xsYmFyPiBGcmFtZVZpZXc6OmNyZWF0ZVNjcm9sbGJhcihTY3JvbGxiYXJP cmllbnRhdGlvbiBvcmllbnRhdGlvCiAgICAgLy8gVHJ5IHRoZSA8Ym9keT4gZWxlbWVudCBmaXJz dCBhcyBhIHNjcm9sbGJhciBzb3VyY2UuCiAgICAgRWxlbWVudCogYm9keSA9IGRvYyA/IGRvYy0+ Ym9keSgpIDogMDsKICAgICBpZiAoYm9keSAmJiBib2R5LT5yZW5kZXJlcigpICYmIGJvZHktPnJl bmRlcmVyKCktPnN0eWxlKCktPmhhc1BzZXVkb1N0eWxlKFNDUk9MTEJBUikpCi0gICAgICAgIHJl dHVybiBSZW5kZXJTY3JvbGxiYXI6OmNyZWF0ZUN1c3RvbVNjcm9sbGJhcih0aGlzLCBvcmllbnRh dGlvbiwgYm9keS0+cmVuZGVyQm94KCkpOworICAgICAgICByZXR1cm4gUmVuZGVyU2Nyb2xsYmFy OjpjcmVhdGVDdXN0b21TY3JvbGxiYXIodGhpcywgb3JpZW50YXRpb24sIGJvZHktPnJlbmRlcmVy KCktPmVuY2xvc2luZ0JveCgpKTsKICAgICAKICAgICAvLyBJZiB0aGUgPGJvZHk+IGRpZG4ndCBo YXZlIGEgY3VzdG9tIHN0eWxlLCB0aGVuIHRoZSByb290IGVsZW1lbnQgbWlnaHQuCiAgICAgRWxl bWVudCogZG9jRWxlbWVudCA9IGRvYyA/IGRvYy0+ZG9jdW1lbnRFbGVtZW50KCkgOiAwOwpAQCAt NjA0LDggKzYwNCw3IEBAIHZvaWQgRnJhbWVWaWV3OjpsYXlvdXQoYm9vbCBhbGxvd1N1YnRyZWUp CiAgICAgICAgICAgICAgICAgdk1vZGUgPSBTY3JvbGxiYXJBbHdheXNPZmY7CiAgICAgICAgICAg ICAgICAgaE1vZGUgPSBTY3JvbGxiYXJBbHdheXNPZmY7CiAgICAgICAgICAgICB9IGVsc2UgaWYg KGJvZHktPmhhc1RhZ05hbWUoYm9keVRhZykpIHsKLSAgICAgICAgICAgICAgICBpZiAoIW1fZmly c3RMYXlvdXQgJiYgbV9zaXplLmhlaWdodCgpICE9IGxheW91dEhlaWdodCgpCi0gICAgICAgICAg ICAgICAgICAgICAgICAmJiB0b1JlbmRlckJveChib2R5LT5yZW5kZXJlcigpKS0+c3RyZXRjaGVz VG9WaWV3SGVpZ2h0KCkpCisgICAgICAgICAgICAgICAgaWYgKCFtX2ZpcnN0TGF5b3V0ICYmIG1f c2l6ZS5oZWlnaHQoKSAhPSBsYXlvdXRIZWlnaHQoKSAmJiBib2R5LT5yZW5kZXJlcigpLT5lbmNs b3NpbmdCb3goKS0+c3RyZXRjaGVzVG9WaWV3SGVpZ2h0KCkpCiAgICAgICAgICAgICAgICAgICAg IGJvZHktPnJlbmRlcmVyKCktPnNldENoaWxkTmVlZHNMYXlvdXQodHJ1ZSk7CiAgICAgICAgICAg ICAgICAgLy8gSXQncyBzdWZmaWNpZW50IHRvIGp1c3QgY2hlY2sgdGhlIFggb3ZlcmZsb3csCiAg ICAgICAgICAgICAgICAgLy8gc2luY2UgaXQncyBpbGxlZ2FsIHRvIGhhdmUgdmlzaWJsZSBpbiBv bmx5IG9uZSBkaXJlY3Rpb24uCg==