3237 2005-06-01 15:56:49 -0700 CSS2: Background repeats when it shouldn't 2005-07-13 23:09:33 -0700 1 1 1 Unclassified WebKit CSS 412 All All VERIFIED FIXED http://sonofhans.net/css/snippets/background_position_safari.html P2 Normal --- 1 hyatt hyatt oldest_to_newest 10427 0 hyatt 2005-06-01 15:56:49 -0700 2/13/05 10:44 PM Randal Hansen: Summary: When told to position a background image taller than its container below the container top and not to repeat it, Safari does repeat the image. This is fiddly to describe but easy to see. Example: I have a simple test case at: http://sonofhans.net/css/snippets/background_position_safari.html This test page passes W3C XHTML and CSS validators, and works correctly in Mozilla 1.7 and Windows Internet Explorer 6. 10428 1 hyatt 2005-06-01 15:57:22 -0700 Apple Bug: rdar://4005553/ 11312 2 2221 natecook 2005-06-10 09:50:10 -0700 Created attachment 2221 Test of x and y positioning The same thing also happens if the image is wider & positioned to the right of 0. This test case demonstrates that. 11313 3 2222 natecook 2005-06-10 09:52:30 -0700 Created attachment 2222 Proposed fix This makes it render properly. 11328 4 darin 2005-06-10 13:24:51 -0700 Looks good to me, but I think Dave should review. Style-wise, I think the code is a tiny bit inelegant. The existing code always sets sx in all the code paths, even though it's initialized at the top of the function. The new code introduces code paths that rely on the default value of 0 for sx and sy. I'd prefer a patch that goes further and gets rid of the "sx = 0" cases by changing the if structure and just doing nothing in the "pixh == 0" cases. This is an example of something we can't test with a dumped render tree, so we probably shouldn't add this to the layout-tests subdirectory. While I don't want to go to a design where we dump the pixmap of every test result, it would be good to figure out a way to make a regression test for this bug some day. 11337 5 2231 natecook 2005-06-10 14:55:02 -0700 Created attachment 2231 Proposed fix #2 Good points. I was trying to edit as little as possible. For testing, maybe we could extend the layoutTestController so that individual tests could force a pixmap dump? 11367 6 hyatt 2005-06-10 22:15:27 -0700 Fixed. I added a new directory to the layout tests... fast/backgrounds, that can at least be visually inspected for correctness until we come up with something better. Additional bg tests are encouraged. 14625 7 joost 2005-07-13 23:01:58 -0700 Fixed in 10.4.2 2221 2005-06-10 09:50:10 -0700 2005-06-10 09:50:10 -0700 Test of x and y positioning bg_position_larger.html text/html 759 natecook PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMCBUcmFuc2l0aW9uYWwv L0VOIiAiaHR0cDovL3d3dy53My5vcmcvVFIvUkVDLWh0bWw0MC9sb29zZS5kdGQiPgo8aHRtbD4K PGhlYWQ+Cjx0aXRsZT5Cb3ggd2l0aCBsYXJnZXIgYmFja2dyb3VuZCBpbWFnZTwvdGl0bGU+Cjxt ZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0 PWlzby04ODU5LTEiPgo8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVN0eWxlLVR5cGUiIGNvbnRl bnQ9InRleHQvY3NzIj4KCjxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+Ci5vbmUge2JhY2tncm91bmQt aW1hZ2U6IHVybChodHRwOi8vbmF0ZWNvb2suY29tL2xheW91dC10ZXN0cy9yZXNvdXJjZXMvYmdf cG9zaXRpb25fbGFyZ2VyLmdpZik7IGJhY2tncm91bmQtcG9zaXRpb246IDEwcHggMTBweDsKICAg ICAgIGJhY2tncm91bmQtcmVwZWF0OiBuby1yZXBlYXQ7IGJhY2tncm91bmQtY29sb3I6IGdyZWVu OyB3aWR0aDogNTBweDsgaGVpZ2h0OiA1MHB4O30KPC9zdHlsZT4KPC9oZWFkPgoKPGJvZHk+CgpU aGUgYm94IGJlbG93IHNob3VsZCBiZSBzb2xpZCBncmVlbi4gSWYgdGhlcmUgYXJlIDEwIHBpeGVs cyBvZiByZWQgdmlzaWJsZSBvbiB0aGUgdG9wIGFuZCBsZWZ0LCB0aGUgYmFja2dyb3VuZCBpbWFn ZSBpcyBiZWluZyByZXBlYXRlZCBpbXByb3Blcmx5Lgo8L3A+CjxwIGNsYXNzPSJvbmUiPgo8L3A+ Cgo8L2JvZHk+CjwvaHRtbD4K 2222 2005-06-10 09:52:30 -0700 2005-06-10 14:55:02 -0700 Proposed fix bg_position_larger.patch text/plain 2105 natecook SW5kZXg6IGtodG1sL3JlbmRlcmluZy9yZW5kZXJfYm94LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2JveC5jcHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMTUzCmRpZmYgLXUgLXAgLXIxLjE1MyByZW5kZXJfYm94LmNwcAot LS0gcmVuZGVyX2JveC5jcHAJMjAwNS8wNC8xOCAyMDo1NzowNAkxLjE1MworKysgcmVuZGVyX2Jv eC5jcHAJMjAwNS8wNi8xMCAxNjo0NTowNgpAQCAtNDM4LDggKzQzOCwxNCBAQCB2b2lkIFJlbmRl ckJveDo6cGFpbnRCYWNrZ3JvdW5kRXh0ZW5kZWQoCiAgICAgICAgICAgICAgICAgaWYgKHBpeHcg PT0gMCkKICAgICAgICAgICAgICAgICAgICAgc3ggPSAwOwogICAgICAgICAgICAgICAgIGVsc2Ug ewotICAgICAgICAgICAgICAgICAgICBzeCA9ICBwaXh3IC0gKChiZ0xheWVyLT5iYWNrZ3JvdW5k WFBvc2l0aW9uKCkubWluV2lkdGgocHctcGl4dykpICUgcGl4dyApOwotICAgICAgICAgICAgICAg ICAgICBzeCAtPSBibGVmdCAlIHBpeHc7CisJCQkJCWludCB4UG9zaXRpb24gPSBiZ0xheWVyLT5i YWNrZ3JvdW5kWFBvc2l0aW9uKCkubWluV2lkdGgocHctcGl4dyk7CisJCQkJCWlmICgoeFBvc2l0 aW9uID49IDApICYmIChiZ3IgPT0gTk9fUkVQRUFUKSkgeworCQkJCQkJY3ggKz0geFBvc2l0aW9u OworCQkJCQkJY3cgLT0geFBvc2l0aW9uOworCQkJCQl9IGVsc2UgeworCQkJCQkJc3ggPSAgcGl4 dyAtICh4UG9zaXRpb24gJSBwaXh3ICk7CisJCQkJCQlzeCAtPSBibGVmdCAlIHBpeHc7CisJCQkJ CX0KICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAKQEAgLTQ2NSw4ICs0NzEsMTQg QEAgdm9pZCBSZW5kZXJCb3g6OnBhaW50QmFja2dyb3VuZEV4dGVuZGVkKAogICAgICAgICAgICAg ICAgIGlmKHBpeGggPT0gMCl7CiAgICAgICAgICAgICAgICAgICAgIHN5ID0gMDsKICAgICAgICAg ICAgICAgICB9ZWxzZXsKLSAgICAgICAgICAgICAgICAgICAgc3kgPSBwaXhoIC0gKChiZ0xheWVy LT5iYWNrZ3JvdW5kWVBvc2l0aW9uKCkubWluV2lkdGgocGgtcGl4aCkpICUgcGl4aCApOwotICAg ICAgICAgICAgICAgICAgICBzeSAtPSBib3JkZXJUb3AoKSAlIHBpeGg7CisJCQkJCWludCB5UG9z aXRpb24gPSBiZ0xheWVyLT5iYWNrZ3JvdW5kWVBvc2l0aW9uKCkubWluV2lkdGgocGgtcGl4aCk7 CisJCQkJCWlmICgoeVBvc2l0aW9uID49IDApICYmIChiZ3IgPT0gTk9fUkVQRUFUKSkgeworCQkJ CQkJY3kgKz0geVBvc2l0aW9uOworCQkJCQkJY2ggLT0geVBvc2l0aW9uOworCQkJCQl9IGVsc2Ug eworCQkJCQkJc3kgPSBwaXhoIC0gKHlQb3NpdGlvbiAlIHBpeGggKTsKKwkJCQkJCXN5IC09IGJv cmRlclRvcCgpICUgcGl4aDsKKwkJCQkJfQogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAg IH0KICAgICAgICAgfQpAQCAtNTA1LDcgKzUxNyw3IEBAIHZvaWQgUmVuZGVyQm94OjpwYWludEJh Y2tncm91bmRFeHRlbmRlZCgKICAgICAgICAgICAgICAgICAgICAgc3kgPSBwaXhoIC0gKChiZ0xh eWVyLT5iYWNrZ3JvdW5kWVBvc2l0aW9uKCkubWluV2lkdGgocGgtcGl4aCkpICUgcGl4aCApOwog ICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KLQorCQkJCiAgICAgICAgICAgICBRUmVj dCBmaXgoY3gsY3ksY3csY2gpOwogICAgICAgICAgICAgUVJlY3QgZWxlKF90eCxfdHksdyxoKTsK ICAgICAgICAgICAgIFFSZWN0IGIgPSBmaXguaW50ZXJzZWN0KGVsZSk7CkBAIC01MTYsNyArNTI4 LDcgQEAgdm9pZCBSZW5kZXJCb3g6OnBhaW50QmFja2dyb3VuZEV4dGVuZGVkKAogCiAKIC8vICAg ICAgICBrZERlYnVnKCkgPDwgImN4PSI8PGN4IDw8ICIgY3k9Ijw8Y3k8PCAiIGN3PSI8PGN3IDw8 ICIgY2g9Ijw8Y2ggPDwgIiBzeD0iPDxzeCA8PCAiIHN5PSI8PHN5IDw8IGVuZGw7Ci0KKwkJCiAg ICAgICAgIGlmIChjdz4wICYmIGNoPjApCiAgICAgICAgICAgICBwLT5kcmF3VGlsZWRQaXhtYXAo Y3gsIGN5LCBjdywgY2gsIGJnLT50aWxlZF9waXhtYXAoYyksIHN4LCBzeSk7CiAgICAgfQo= 2231 2005-06-10 14:55:02 -0700 2005-06-10 14:55:02 -0700 Proposed fix #2 bg_image_larger2.patch text/plain 3879 natecook SW5kZXg6IGtodG1sL3JlbmRlcmluZy9yZW5kZXJfYm94LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvcmVuZGVyX2JveC5jcHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMTUzCmRpZmYgLXUgLXAgLXIxLjE1MyByZW5kZXJfYm94LmNwcAot LS0gcmVuZGVyX2JveC5jcHAJMjAwNS8wNC8xOCAyMDo1NzowNAkxLjE1MworKysgcmVuZGVyX2Jv eC5jcHAJMjAwNS8wNi8xMCAyMTo0NzoxNwpAQCAtNDI0LDIyICs0MjQsMjUgQEAgdm9pZCBSZW5k ZXJCb3g6OnBhaW50QmFja2dyb3VuZEV4dGVuZGVkKAogICAgICAgICAgICAgICAgICAgICBjeCA9 IF90eCArIHhQb3NpdGlvbjsKICAgICAgICAgICAgICAgICBlbHNlIHsKICAgICAgICAgICAgICAg ICAgICAgY3ggPSBfdHg7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChwaXh3ID09IDApCi0gICAg ICAgICAgICAgICAgICAgICAgICBzeCA9IDA7Ci0gICAgICAgICAgICAgICAgICAgIGVsc2Ugewor ICAgICAgICAgICAgICAgICAgICBpZiAocGl4dyA+IDApIHsKICAgICAgICAgICAgICAgICAgICAg ICAgIHN4ID0gLXhQb3NpdGlvbjsKICAgICAgICAgICAgICAgICAgICAgICAgIGN3ICs9IHhQb3Np dGlvbjsKICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIH0KICAgICAgICAg ICAgICAgICBjeCArPSBibGVmdDsKICAgICAgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICAg ICAgLy8gcmVwZWF0IG92ZXIgeCBvciBiYWNrZ3JvdW5kIGlzIHdpZGVyIHRoYW4gYm94CiAgICAg ICAgICAgICAgICAgY3cgPSB3OwogICAgICAgICAgICAgICAgIGN4ID0gX3R4OwotICAgICAgICAg ICAgICAgIGlmIChwaXh3ID09IDApCi0gICAgICAgICAgICAgICAgICAgIHN4ID0gMDsKLSAgICAg ICAgICAgICAgICBlbHNlIHsKLSAgICAgICAgICAgICAgICAgICAgc3ggPSAgcGl4dyAtICgoYmdM YXllci0+YmFja2dyb3VuZFhQb3NpdGlvbigpLm1pbldpZHRoKHB3LXBpeHcpKSAlIHBpeHcgKTsK LSAgICAgICAgICAgICAgICAgICAgc3ggLT0gYmxlZnQgJSBwaXh3OworICAgICAgICAgICAgICAg IGlmIChwaXh3ID4gMCkgeworCQkJCQlpbnQgeFBvc2l0aW9uID0gYmdMYXllci0+YmFja2dyb3Vu ZFhQb3NpdGlvbigpLm1pbldpZHRoKHB3LXBpeHcpOworCQkJCQlpZiAoKHhQb3NpdGlvbiA+IDAp ICYmIChiZ3IgPT0gTk9fUkVQRUFUKSkgeworCQkJCQkJY3ggKz0geFBvc2l0aW9uOworCQkJCQkJ Y3cgLT0geFBvc2l0aW9uOworCQkJCQl9IGVsc2UgeworCQkJCQkJc3ggPSAgcGl4dyAtICh4UG9z aXRpb24gJSBwaXh3ICk7CisJCQkJCQlzeCAtPSBibGVmdCAlIHBpeHc7CisJCQkJCX0KICAgICAg ICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAKQEAgLTQ1MCw5ICs0NTMsNyBAQCB2b2lkIFJl bmRlckJveDo6cGFpbnRCYWNrZ3JvdW5kRXh0ZW5kZWQoCiAgICAgICAgICAgICAgICAgICAgIGN5 ID0gX3R5ICsgeVBvc2l0aW9uOwogICAgICAgICAgICAgICAgIGVsc2UgewogICAgICAgICAgICAg ICAgICAgICBjeSA9IF90eTsKLSAgICAgICAgICAgICAgICAgICAgaWYgKHBpeGggPT0gMCkKLSAg ICAgICAgICAgICAgICAgICAgICAgIHN5ID0gMDsKLSAgICAgICAgICAgICAgICAgICAgZWxzZSB7 CisgICAgICAgICAgICAgICAgICAgIGlmIChwaXhoID4gMCkgewogICAgICAgICAgICAgICAgICAg ICAgICAgc3kgPSAteVBvc2l0aW9uOwogICAgICAgICAgICAgICAgICAgICAgICAgY2ggKz0geVBv c2l0aW9uOwogICAgICAgICAgICAgICAgICAgICB9CkBAIC00NjAsMTMgKzQ2MSwxOCBAQCB2b2lk IFJlbmRlckJveDo6cGFpbnRCYWNrZ3JvdW5kRXh0ZW5kZWQoCiAgICAgICAgICAgICAgICAgCiAg ICAgICAgICAgICAgICAgY3kgKz0gYm9yZGVyVG9wKCk7CiAgICAgICAgICAgICB9IGVsc2Ugewor ICAgICAgICAgICAgICAgIC8vIHJlcGVhdCBvdmVyIHkgb3IgYmFja2dyb3VuZCBpcyB0YWxsZXIg dGhhbiBib3gKICAgICAgICAgICAgICAgICBjaCA9IGg7CiAgICAgICAgICAgICAgICAgY3kgPSBf dHk7Ci0gICAgICAgICAgICAgICAgaWYocGl4aCA9PSAwKXsKLSAgICAgICAgICAgICAgICAgICAg c3kgPSAwOwotICAgICAgICAgICAgICAgIH1lbHNlewotICAgICAgICAgICAgICAgICAgICBzeSA9 IHBpeGggLSAoKGJnTGF5ZXItPmJhY2tncm91bmRZUG9zaXRpb24oKS5taW5XaWR0aChwaC1waXho KSkgJSBwaXhoICk7Ci0gICAgICAgICAgICAgICAgICAgIHN5IC09IGJvcmRlclRvcCgpICUgcGl4 aDsKKyAgICAgICAgICAgICAgICBpZiAocGl4aCA+IDApIHsKKwkJCQkJaW50IHlQb3NpdGlvbiA9 IGJnTGF5ZXItPmJhY2tncm91bmRZUG9zaXRpb24oKS5taW5XaWR0aChwaC1waXhoKTsKKwkJCQkJ aWYgKCh5UG9zaXRpb24gPiAwKSAmJiAoYmdyID09IE5PX1JFUEVBVCkpIHsKKwkJCQkJCWN5ICs9 IHlQb3NpdGlvbjsKKwkJCQkJCWNoIC09IHlQb3NpdGlvbjsKKwkJCQkJfSBlbHNlIHsKKwkJCQkJ CXN5ID0gcGl4aCAtICh5UG9zaXRpb24gJSBwaXhoICk7CisJCQkJCQlzeSAtPSBib3JkZXJUb3Ao KSAlIHBpeGg7CisJCQkJCX0KICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KQEAgLTQ4Niw5ICs0OTIsNyBAQCB2b2lkIFJlbmRlckJveDo6cGFpbnRCYWNrZ3JvdW5k RXh0ZW5kZWQoCiAgICAgICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgIGN3ID0gcHc7 CiAgICAgICAgICAgICAgICAgY3ggPSB2ci54KCk7Ci0gICAgICAgICAgICAgICAgaWYocGl4dyA9 PSAwKXsKLSAgICAgICAgICAgICAgICAgICAgc3ggPSAwOwotICAgICAgICAgICAgICAgIH1lbHNl eworICAgICAgICAgICAgICAgIGlmIChwaXh3ID4gMCkgewogICAgICAgICAgICAgICAgICAgICBz eCA9ICBwaXh3IC0gKChiZ0xheWVyLT5iYWNrZ3JvdW5kWFBvc2l0aW9uKCkubWluV2lkdGgocHct cGl4dykpICUgcGl4dyApOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KQEAgLTQ5 OSwxMyArNTAzLDExIEBAIHZvaWQgUmVuZGVyQm94OjpwYWludEJhY2tncm91bmRFeHRlbmRlZCgK ICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgY2ggPSBwaDsKICAgICAgICAg ICAgICAgICBjeSA9IHZyLnkoKTsKLSAgICAgICAgICAgICAgICBpZihwaXhoID09IDApewotICAg ICAgICAgICAgICAgICAgICBzeSA9IDA7Ci0gICAgICAgICAgICAgICAgfWVsc2V7CisgICAgICAg ICAgICAgICAgaWYgKHBpeGggPiAwKSB7CiAgICAgICAgICAgICAgICAgICAgIHN5ID0gcGl4aCAt ICgoYmdMYXllci0+YmFja2dyb3VuZFlQb3NpdGlvbigpLm1pbldpZHRoKHBoLXBpeGgpKSAlIHBp eGggKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9Ci0KKwkJCQogICAgICAgICAg ICAgUVJlY3QgZml4KGN4LGN5LGN3LGNoKTsKICAgICAgICAgICAgIFFSZWN0IGVsZShfdHgsX3R5 LHcsaCk7CiAgICAgICAgICAgICBRUmVjdCBiID0gZml4LmludGVyc2VjdChlbGUpOwpAQCAtNTE2 LDcgKzUxOCw3IEBAIHZvaWQgUmVuZGVyQm94OjpwYWludEJhY2tncm91bmRFeHRlbmRlZCgKIAog CiAvLyAgICAgICAga2REZWJ1ZygpIDw8ICJjeD0iPDxjeCA8PCAiIGN5PSI8PGN5PDwgIiBjdz0i PDxjdyA8PCAiIGNoPSI8PGNoIDw8ICIgc3g9Ijw8c3ggPDwgIiBzeT0iPDxzeSA8PCBlbmRsOwot CisJCQogICAgICAgICBpZiAoY3c+MCAmJiBjaD4wKQogICAgICAgICAgICAgcC0+ZHJhd1RpbGVk UGl4bWFwKGN4LCBjeSwgY3csIGNoLCBiZy0+dGlsZWRfcGl4bWFwKGMpLCBzeCwgc3kpOwogICAg IH0K