32364 2009-12-10 00:38:10 -0800 [Chromium] SporeViewer demo doesn't work in Chromium 2009-12-10 01:21:14 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr brettw cmarrin commit-queue dglazkov fishd oliver petersont rlp oldest_to_newest 170361 0 kbr 2009-12-10 00:38:10 -0800 Mozilla's SporeViewer WebGL demo doesn't work in Chromium. There are a few bugs in the custom V8 bindings for WebGLRenderingContext causing JavaScript exceptions to be raised. 170364 1 44599 kbr 2009-12-10 01:08:31 -0800 Created attachment 44599 Patch 170365 2 44599 oliver 2009-12-10 01:11:42 -0800 Comment on attachment 44599 Patch r=me 170367 3 44599 commit-queue 2009-12-10 01:21:08 -0800 Comment on attachment 44599 Patch Clearing flags on attachment: 44599 Committed r51943: <http://trac.webkit.org/changeset/51943> 170368 4 commit-queue 2009-12-10 01:21:14 -0800 All reviewed patches have been landed. Closing bug. 44599 2009-12-10 01:08:31 -0800 2009-12-10 01:21:08 -0800 Patch 32364.patch text/plain 7275 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTk0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTItMTAgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtD aHJvbWl1bV0gU3BvcmVWaWV3ZXIgZGVtbyBkb2Vzbid0IHdvcmsgaW4gQ2hyb21pdW0KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzY0CisKKyAgICAg ICAgVGVzdDogZmFzdC9jYW52YXMvd2ViZ2wvYnVnLTMyMzY0Lmh0bWwKKworICAgICAgICAqIGJp bmRpbmdzL3Y4L2N1c3RvbS9WOFdlYkdMUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDQUxMQkFDS19GVU5DX0RFQ0wpOgorICAgICAgICAoV2ViQ29yZTo6dmVy dGV4QXR0cmliQW5kVW5pZm9ybUhlbHBlcmYpOgorICAgICAgICAoV2ViQ29yZTo6dW5pZm9ybUhl bHBlcmkpOgorCiAyMDA5LTEyLTA5ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4V2ViR0xSZW5kZXJpbmdDb250ZXh0Q3VzdG9tLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdlYkdMUmVuZGVyaW5nQ29udGV4dEN1c3Rv bS5jcHAJKHJldmlzaW9uIDUxOTM5KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhX ZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Miw2ICs1 Miw3IEBACiAjaW5jbHVkZSAiVjhXZWJHTFVuc2lnbmVkQnl0ZUFycmF5LmgiCiAjaW5jbHVkZSAi VjhXZWJHTFVuc2lnbmVkSW50QXJyYXkuaCIKICNpbmNsdWRlICJWOFdlYkdMVW5zaWduZWRTaG9y dEFycmF5LmgiCisjaW5jbHVkZSAiVjhIVE1MQ2FudmFzRWxlbWVudC5oIgogI2luY2x1ZGUgIlY4 SFRNTEltYWdlRWxlbWVudC5oIgogI2luY2x1ZGUgIlY4UHJveHkuaCIKIApAQCAtNDU5LDYgKzQ2 MCw4IEBAIENBTExCQUNLX0ZVTkNfREVDTChXZWJHTFJlbmRlcmluZ0NvbnRleHQKICAgICAvLyAg ICAgICAgICAgICAgICAgICBpbiBHTGVudW0gZm9ybWF0LCBpbiBHTGVudW0gdHlwZSwgaW4gV2Vi R0xBcnJheSBwaXhlbHMpOwogICAgIC8vICogdm9pZCB0ZXhJbWFnZTJEKGluIEdMZW51bSB0YXJn ZXQsIGluIEdMaW50IGxldmVsLCBpbiBIVE1MSW1hZ2VFbGVtZW50IGltYWdlLAogICAgIC8vICAg ICAgICAgICAgICAgICAgIFtPcHRpb25hbF0gaW4gR0xib29sZWFuIGZsaXBZLCBbT3B0aW9uYWxd IGluIEdMYm9vbGVhbiBwcmVtdWx0aXBseUFscGhhKTsKKyAgICAvLyAqIHZvaWQgdGV4SW1hZ2Uy RChpbiBHTGVudW0gdGFyZ2V0LCBpbiBHTGludCBsZXZlbCwgaW4gSFRNTENhbnZhc0VsZW1lbnQg aW1hZ2UsCisgICAgLy8gICAgICAgICAgICAgICAgICAgW09wdGlvbmFsXSBpbiBHTGJvb2xlYW4g ZmxpcFksIFtPcHRpb25hbF0gaW4gR0xib29sZWFuIHByZW11bHRpcGx5QWxwaGEpOwogICAgIGlm IChhcmdzLkxlbmd0aCgpICE9IDMgJiYKICAgICAgICAgYXJncy5MZW5ndGgoKSAhPSA0ICYmCiAg ICAgICAgIGFyZ3MuTGVuZ3RoKCkgIT0gNSAmJgpAQCAtNDg2LDE2ICs0ODksMjAgQEAgQ0FMTEJB Q0tfRlVOQ19ERUNMKFdlYkdMUmVuZGVyaW5nQ29udGV4dAogICAgICAgICBhcmdzLkxlbmd0aCgp ID09IDQgfHwKICAgICAgICAgYXJncy5MZW5ndGgoKSA9PSA1KSB7CiAgICAgICAgIHY4OjpIYW5k bGU8djg6OlZhbHVlPiBhcmcgPSBhcmdzWzJdOworICAgICAgICBib29sIGZsaXBZID0gZmFsc2U7 CisgICAgICAgIGJvb2wgcHJlbXVsdGlwbHlBbHBoYSA9IGZhbHNlOworICAgICAgICBpZiAoYXJn cy5MZW5ndGgoKSA+PSA0KQorICAgICAgICAgICAgZmxpcFkgPSBhcmdzWzNdLT5Cb29sZWFuVmFs dWUoKTsKKyAgICAgICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPj0gNSkKKyAgICAgICAgICAgIHByZW11 bHRpcGx5QWxwaGEgPSBhcmdzWzRdLT5Cb29sZWFuVmFsdWUoKTsKICAgICAgICAgaWYgKFY4SFRN TEltYWdlRWxlbWVudDo6SGFzSW5zdGFuY2UoYXJnKSkgewotICAgICAgICAgICAgSFRNTEltYWdl RWxlbWVudCogaW1hZ2VfZWxlbWVudCA9IFY4RE9NV3JhcHBlcjo6Y29udmVydERPTVdyYXBwZXJU b05vZGU8SFRNTEltYWdlRWxlbWVudD4odjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdChhcmcp KTsKLSAgICAgICAgICAgIGJvb2wgZmxpcFkgPSBmYWxzZTsKLSAgICAgICAgICAgIGJvb2wgcHJl bXVsdGlwbHlBbHBoYSA9IGZhbHNlOwotICAgICAgICAgICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPj0g NCkKLSAgICAgICAgICAgICAgICBmbGlwWSA9IGFyZ3NbM10tPkJvb2xlYW5WYWx1ZSgpOwotICAg ICAgICAgICAgaWYgKGFyZ3MuTGVuZ3RoKCkgPj0gNSkKLSAgICAgICAgICAgICAgICBwcmVtdWx0 aXBseUFscGhhID0gYXJnc1s0XS0+Qm9vbGVhblZhbHVlKCk7Ci0gICAgICAgICAgICBjb250ZXh0 LT50ZXhJbWFnZTJEKHRhcmdldCwgbGV2ZWwsIGltYWdlX2VsZW1lbnQsIGZsaXBZLCBwcmVtdWx0 aXBseUFscGhhLCBlYyk7CisgICAgICAgICAgICBIVE1MSW1hZ2VFbGVtZW50KiBlbGVtZW50ID0g VjhET01XcmFwcGVyOjpjb252ZXJ0RE9NV3JhcHBlclRvTm9kZTxIVE1MSW1hZ2VFbGVtZW50Pih2 ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KGFyZykpOworICAgICAgICAgICAgY29udGV4dC0+ dGV4SW1hZ2UyRCh0YXJnZXQsIGxldmVsLCBlbGVtZW50LCBmbGlwWSwgcHJlbXVsdGlwbHlBbHBo YSwgZWMpOworICAgICAgICB9IGVsc2UgaWYgKFY4SFRNTENhbnZhc0VsZW1lbnQ6Okhhc0luc3Rh bmNlKGFyZykpIHsKKyAgICAgICAgICAgIEhUTUxDYW52YXNFbGVtZW50KiBlbGVtZW50ID0gVjhE T01XcmFwcGVyOjpjb252ZXJ0RE9NV3JhcHBlclRvTm9kZTxIVE1MQ2FudmFzRWxlbWVudD4odjg6 OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdChhcmcpKTsKKyAgICAgICAgICAgIGNvbnRleHQtPnRl eEltYWdlMkQodGFyZ2V0LCBsZXZlbCwgZWxlbWVudCwgZmxpcFksIHByZW11bHRpcGx5QWxwaGEs IGVjKTsKICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBzdXBwb3J0IEhU TUxWaWRlb0VsZW1lbnQgYW5kIEltYWdlRGF0YS4KICAgICAgICAgICAgIC8vIEZJWE1FOiBjb25z aWRlciBkaWZmZXJlbnQgLyBiZXR0ZXIgZXhjZXB0aW9uIHR5cGUuCiAgICAgICAgICAgICBWOFBy b3h5OjpzZXRET01FeGNlcHRpb24oU1lOVEFYX0VSUik7CiAgICAgICAgICAgICByZXR1cm4gbm90 SGFuZGxlZEJ5SW50ZXJjZXB0b3IoKTsKQEAgLTYxMyw3ICs2MjAsNyBAQCBzdGF0aWMgdjg6Okhh bmRsZTx2ODo6VmFsdWU+IHZlcnRleEF0dHJpCiAgICAgLy8gKiBnbFZlcnRleEF0dHJpYjRmdihH TGludCBpbmRleCwgQXJyYXkgZGF0YSk7CiAgICAgLy8gKiBnbFZlcnRleEF0dHJpYjRmdihHTGlu dCBpbmRleCwgV2ViR0xGbG9hdEFycmF5IGRhdGEpOwogCi0gICAgaWYgKGFyZ3MuTGVuZ3RoKCkg IT0gMykgeworICAgIGlmIChhcmdzLkxlbmd0aCgpICE9IDIpIHsKICAgICAgICAgVjhQcm94eTo6 c2V0RE9NRXhjZXB0aW9uKFNZTlRBWF9FUlIpOwogICAgICAgICByZXR1cm4gbm90SGFuZGxlZEJ5 SW50ZXJjZXB0b3IoKTsKICAgICB9CkBAIC02OTgsNyArNzA1LDcgQEAgc3RhdGljIHY4OjpIYW5k bGU8djg6OlZhbHVlPiB1bmlmb3JtSGVscAogICAgIC8vICogZ2xVbmlmb3JtNGl2KEdMVW5pZm9y bUxvY2F0aW9uIGxvY2F0aW9uLCBBcnJheSBkYXRhKTsKICAgICAvLyAqIGdsVW5pZm9ybTRpdihH TFVuaWZvcm1Mb2NhdGlvbiBsb2NhdGlvbiwgV2ViR0xJbnRBcnJheSBkYXRhKTsKIAotICAgIGlm IChhcmdzLkxlbmd0aCgpICE9IDMpIHsKKyAgICBpZiAoYXJncy5MZW5ndGgoKSAhPSAyKSB7CiAg ICAgICAgIFY4UHJveHk6OnNldERPTUV4Y2VwdGlvbihTWU5UQVhfRVJSKTsKICAgICAgICAgcmV0 dXJuIG5vdEhhbmRsZWRCeUludGVyY2VwdG9yKCk7CiAgICAgfQpJbmRleDogTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24g NTE5NDIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNSBAQAorMjAwOS0xMi0xMCAgS2VubmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0Nocm9taXVt XSBTcG9yZVZpZXdlciBkZW1vIGRvZXNuJ3Qgd29yayBpbiBDaHJvbWl1bQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIzNjQKKworICAgICAgICBUZXN0 OiBmYXN0L2NhbnZhcy93ZWJnbC9idWctMzIzNjQuaHRtbAorCisgICAgICAgICogZmFzdC9jYW52 YXMvd2ViZ2wvYnVnLTMyMzY0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9j YW52YXMvd2ViZ2wvYnVnLTMyMzY0Lmh0bWw6IEFkZGVkLgorCiAyMDA5LTEyLTA5ICBNYWNpZWog U3RhY2hvd2lhayAgPG1qc0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVy IEh1bnQuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9idWctMzIzNjQtZXhw ZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2J1 Zy0zMjM2NC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nh bnZhcy93ZWJnbC9idWctMzIzNjQtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDEzIEBACitSZWdyZXNzaW9uIHRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMjM2NCA6IFtDaHJvbWl1bV0gU3BvcmVWaWV3ZXIgZGVtbyBkb2Vzbid0IHdv cmsgaW4gQ2hyb21pdW0KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQ QVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCitQQVNTIGdsLnVz ZVByb2dyYW0oZmxvYXRQcm9ncmFtKSBpcyB1bmRlZmluZWQuCitQQVNTIGdsLmdldEVycm9yKCkg aXMgZ2wuTk9fRVJST1IKK1BBU1MgZ2wudW5pZm9ybTRmdihmdmFsNExvYywgbmV3IFdlYkdMRmxv YXRBcnJheShbMC4xLCAwLjIsIDAuNCwgMS4wXSkpOyBpcyB1bmRlZmluZWQuCitQQVNTIGdsLmJp bmRUZXh0dXJlKGdsLlRFWFRVUkVfMkQsIHRleHR1cmUpIGlzIHVuZGVmaW5lZC4KK1BBU1MgZ2wu dGV4SW1hZ2UyRChnbC5URVhUVVJFXzJELCAwLCB0bXBjYW52YXMpIGlzIHVuZGVmaW5lZC4KK1BB U1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBM YXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9idWctMzIzNjQuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9idWctMzIzNjQuaHRtbAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2J1Zy0zMjM2NC5odG1sCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDM1IEBACis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHls ZXNoZWV0IiBocmVmPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiLz4KKzxz Y3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgor PHNjcmlwdCBzcmM9InJlc291cmNlcy93ZWJnbC10ZXN0LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4K Kzxib2R5PgorPGRpdiBpZD0iZGVzY3JpcHRpb24iPjwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+CisKKzxzY3JpcHQ+CisKK2Rlc2NyaXB0aW9uKCdSZWdyZXNzaW9uIHRlc3QgZm9yIDxh IGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMjM2NCI+aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzY0PC9hPiA6IDxjb2RlPltD aHJvbWl1bV0gU3BvcmVWaWV3ZXIgZGVtbyBkb2VzblwndCB3b3JrIGluIENocm9taXVtPC9jb2Rl PicpOworCit2YXIgZ2wgPSBjcmVhdGUzRENvbnRleHQoKTsKK3ZhciBmbG9hdFByb2dyYW0gPSBs b2FkUHJvZ3JhbShnbCwgInJlc291cmNlcy9mbG9hdFVuaWZvcm1TaGFkZXIudmVydCIsICJyZXNv dXJjZXMvbm9vcFVuaWZvcm1TaGFkZXIuZnJhZyIpOworc2hvdWxkQmVVbmRlZmluZWQoImdsLnVz ZVByb2dyYW0oZmxvYXRQcm9ncmFtKSIpOwordmFyIGZ2YWw0TG9jID0gZ2wuZ2V0VW5pZm9ybUxv Y2F0aW9uKGZsb2F0UHJvZ3JhbSwgImZ2YWw0Iik7CitzaG91bGRCZSgiZ2wuZ2V0RXJyb3IoKSIs ICJnbC5OT19FUlJPUiIpOworc2hvdWxkQmVVbmRlZmluZWQoImdsLnVuaWZvcm00ZnYoZnZhbDRM b2MsIG5ldyBXZWJHTEZsb2F0QXJyYXkoWzAuMSwgMC4yLCAwLjQsIDEuMF0pKTsiKTsKKwordmFy IHRtcGNhbnZhcyA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImNhbnZhcyIpOwordG1wY2FudmFz LndpZHRoID0gMjsKK3RtcGNhbnZhcy5oZWlnaHQgPSAyOwordmFyIHRleHR1cmUgPSBnbC5jcmVh dGVUZXh0dXJlKCk7CitzaG91bGRCZVVuZGVmaW5lZCgiZ2wuYmluZFRleHR1cmUoZ2wuVEVYVFVS RV8yRCwgdGV4dHVyZSkiKTsKK3Nob3VsZEJlVW5kZWZpbmVkKCJnbC50ZXhJbWFnZTJEKGdsLlRF WFRVUkVfMkQsIDAsIHRtcGNhbnZhcykiKTsKKworc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsK KworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9z dC5qcyI+PC9zY3JpcHQ+CisKKzwvYm9keT4KKzwvaHRtbD4K