32361 2009-12-09 23:15:47 -0800 [GTK] Build with --disable-svg is broken 2009-12-12 09:22:48 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC All RESOLVED FIXED Gtk P2 Major --- 1 christian webkit-unassigned webkit.review.bot oldest_to_newest 170325 0 christian 2009-12-09 23:15:47 -0800 The build of current WebKitGTK+ TOT is broken with SVG features disabled due to incorrectly placed compiler guards. 170327 1 44593 christian 2009-12-09 23:17:29 -0800 Created attachment 44593 Fix ENABLE(SVG) guards. 170328 2 webkit.review.bot 2009-12-09 23:19:13 -0800 style-queue ran check-webkit-style on attachment 44593 without any errors. 170973 3 44593 eric 2009-12-11 15:53:11 -0800 Comment on attachment 44593 Fix ENABLE(SVG) guards. LGTM. 171103 4 christian 2009-12-12 09:22:48 -0800 2009-12-11 Christian Dywan <christian@twotoasts.de> Reviewed by Eric Seidel. [GTK] Build with --disable-svg is broken http://bugs.webkit.org/show_bug.cgi?id=32361 * webkit/webkitwebframe.cpp: (webkit_web_frame_pause_svg_animation): Fix ENABLE(SVG) guards. 44593 2009-12-09 23:17:29 -0800 2009-12-11 15:53:11 -0800 Fix ENABLE(SVG) guards. svg-fix.diff text/plain 1746 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZGZhYzkzNC4uNWE0ZjBkOCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMi0wOSAg Q2hyaXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBCdWlsZCB3aXRoIC0tZGlz YWJsZS1zdmcgaXMgYnJva2VuCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMyMzYxCisKKyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwOgor ICAgICAgICAod2Via2l0X3dlYl9mcmFtZV9wYXVzZV9zdmdfYW5pbWF0aW9uKTogRml4IEVOQUJM RShTVkcpIGd1YXJkcy4KKwogMjAwOS0xMi0wOCAgQ2hyaXN0aWFuIER5d2FuICA8Y2hyaXN0aWFu QHR3b3RvYXN0cy5kZT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEgU2ls dmEuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAgYi9X ZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJmcmFtZS5jcHAKaW5kZXggNjRmZGM0MC4uZjNlNzRh NyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2ViZnJhbWUuY3BwCisrKyBi L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYmZyYW1lLmNwcApAQCAtNTQsNyArNTQsOSBAQAog I2luY2x1ZGUgIkpTRE9NQmluZGluZy5oIgogI2luY2x1ZGUgIlNjcmlwdENvbnRyb2xsZXIuaCIK ICNpbmNsdWRlICJTdWJzdGl0dXRlRGF0YS5oIgorI2lmIEVOQUJMRShTVkcpCiAjaW5jbHVkZSAi U1ZHU01JTEVsZW1lbnQuaCIKKyNlbmRpZgogCiAjaW5jbHVkZSA8YXRrL2F0ay5oPgogI2luY2x1 ZGUgPEphdmFTY3JpcHRDb3JlL0FQSUNhc3QuaD4KQEAgLTk2MywxMyArOTY1LDEzIEBAIGJvb2wg d2Via2l0X3dlYl9mcmFtZV9wYXVzZV90cmFuc2l0aW9uKFdlYktpdFdlYkZyYW1lKiBmcmFtZSwg Y29uc3QgZ2NoYXIqIG5hbWUsCiBib29sIHdlYmtpdF93ZWJfZnJhbWVfcGF1c2Vfc3ZnX2FuaW1h dGlvbihXZWJLaXRXZWJGcmFtZSogZnJhbWUsIGNvbnN0IGdjaGFyKiBhbmltYXRpb25JZCwgZG91 YmxlIHRpbWUsIGNvbnN0IGdjaGFyKiBlbGVtZW50SWQpCiB7CiAgICAgQVNTRVJUKGNvcmUoZnJh bWUpKTsKKyNpZiBFTkFCTEUoU1ZHKQogICAgIERvY3VtZW50KiBkb2N1bWVudCA9IGNvcmUoZnJh bWUpLT5kb2N1bWVudCgpOwogICAgIGlmICghZG9jdW1lbnQgfHwgIWRvY3VtZW50LT5zdmdFeHRl bnNpb25zKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBFbGVtZW50KiBjb3JlRWxlbWVu dCA9IGRvY3VtZW50LT5nZXRFbGVtZW50QnlJZChBdG9taWNTdHJpbmcoYW5pbWF0aW9uSWQpKTsK ICAgICBpZiAoIWNvcmVFbGVtZW50IHx8ICFTVkdTTUlMRWxlbWVudDo6aXNTTUlMRWxlbWVudChj b3JlRWxlbWVudCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSNpZiBFTkFCTEUoU1ZHKQogICAg IHJldHVybiBkb2N1bWVudC0+YWNjZXNzU1ZHRXh0ZW5zaW9ucygpLT5zYW1wbGVBbmltYXRpb25B dFRpbWUoZWxlbWVudElkLCBzdGF0aWNfY2FzdDxTVkdTTUlMRWxlbWVudCo+KGNvcmVFbGVtZW50 KSwgdGltZSk7CiAjZWxzZQogICAgIHJldHVybiBmYWxzZTsK