32359 2009-12-09 20:32:39 -0800 [GTK] Don't assume downloads are always synchronous 2009-12-17 11:16:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Major --- 1 christian webkit-unassigned gustavo webkit.review.bot oldest_to_newest 170303 0 christian 2009-12-09 20:32:39 -0800 The download-requested signal assumes if the download was handled, it can start it right away. This is wrong if the application needs to handle the download asynchronously. In that case, WebKit should leave it up to the API user to start or cancel the download as appropriate. 170304 1 44590 christian 2009-12-09 20:37:42 -0800 Created attachment 44590 Check if the destination URI is set and clarify the documentation 170306 2 webkit.review.bot 2009-12-09 20:42:00 -0800 style-queue ran check-webkit-style on attachment 44590 without any errors. 172248 3 44590 gustavo 2009-12-16 03:06:22 -0800 Comment on attachment 44590 Check if the destination URI is set and clarify the documentation This works for me. Can you add a unittest, to make sure this works, to testdownload? 172683 4 45044 christian 2009-12-17 02:23:35 -0800 Created attachment 45044 Check destination URI, clarify docs and test downloads both ways Updated the patch, to test downloads with having the destination set in the callback, and again with setting it later. The test breaks without the frame loader change. 172684 5 webkit.review.bot 2009-12-17 02:24:05 -0800 Attachment 45044 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/tests/testdownload.c:29: Declaration has space between * and variable name in WebKitDownload* theDownload [whitespace/declaration] [3] WebKit/gtk/tests/testdownload.c:137: Declaration has space between * and variable name in gchar* filename [whitespace/declaration] [3] WebKit/gtk/tests/testdownload.c:138: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/tests/testdownload.c:148: Extra space before ( in function call [whitespace/parens] [4] WebKit/gtk/tests/testdownload.c:171: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 5 172686 6 45046 christian 2009-12-17 02:38:21 -0800 Created attachment 45046 Check destination URI, clarify docs and test downloads both ways #2 Bracket and indentation fixed. The globals the bot complains about are correct as far as I can see. 172689 7 webkit.review.bot 2009-12-17 02:39:54 -0800 Attachment 45046 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/tests/testdownload.c:29: Declaration has space between * and variable name in WebKitDownload* theDownload [whitespace/declaration] [3] WebKit/gtk/tests/testdownload.c:137: Declaration has space between * and variable name in gchar* filename [whitespace/declaration] [3] Total errors found: 2 172760 8 45046 gustavo 2009-12-17 07:33:51 -0800 Comment on attachment 45046 Check destination URI, clarify docs and test downloads both ways #2 Good, but please fix the issues pointed out by the style bot =). 172761 9 gustavo 2009-12-17 07:34:28 -0800 (In reply to comment #8) > (From update of attachment 45046 [details]) > Good, but please fix the issues pointed out by the style bot =). In fact, don't. Please report those as bugs to the bot =P. 172890 10 christian 2009-12-17 11:16:31 -0800 2009-12-17 Christian Dywan <christian@twotoasts.de> Reviewed by Gustavo Noronha Silva. [GTK] Don't assume downloads are always synchronous http://bugs.webkit.org/show_bug.cgi?id=32359 * tests/testdownload.c: (download_requested_cb): (set_filename): (test_webkit_download_perform): (test_webkit_download_synch): (test_webkit_download_asynch): (main): Test downloads synchronously and asynchronously. * webkit/webkitwebview.cpp: (webkit_web_view_class_init): (webkit_web_view_request_download): Only try to start a requested download if the destination URI is set and clarify the documentation. 44590 2009-12-09 20:37:42 -0800 2009-12-17 02:23:35 -0800 Check if the destination URI is set and clarify the documentation download-asynch.diff text/plain 2240 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggZGZhYzkzNC4uNjJmNTQxYyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMi0wOSAg Q2hyaXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBEb24ndCBhc3N1bWUgZG93 bmxvYWRzIGFyZSBhbHdheXMgc3luY2hyb25vdXMKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIzNTkKKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJ2 aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KToKKyAgICAgICAg KHdlYmtpdF93ZWJfdmlld19yZXF1ZXN0X2Rvd25sb2FkKTogT25seSB0cnkgdG8gc3RhcnQgYSBy ZXF1ZXN0ZWQKKyAgICAgICAgZG93bmxvYWQgaWYgdGhlIGRlc3RpbmF0aW9uIFVSSSBpcyBzZXQg YW5kIGNsYXJpZnkgdGhlIGRvY3VtZW50YXRpb24uCisKIDIwMDktMTItMDggIENocmlzdGlhbiBE eXdhbiAgPGNocmlzdGlhbkB0d290b2FzdHMuZGU+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR3Vz dGF2byBOb3JvbmhhIFNpbHZhLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0 d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAy YzU1ZDA5Li42ZjAxY2E4IDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2 aWV3LmNwcAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtMTUx NSw5ICsxNTE1LDEwIEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdl YktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgICAqIEByZXR1cm46ICVUUlVFIGlm IHRoZSBkb3dubG9hZCBzaG91bGQgYmUgcGVyZm9ybWVkLCAlRkFMU0UgdG8gY2FuY2VsIGl0Lgog ICAgICAqCiAgICAgICogQSBuZXcgRG93bmxvYWQgaXMgYmVpbmcgcmVxdWVzdGVkLiBCeSBkZWZh dWx0LCBpZiB0aGUgc2lnbmFsIGlzCi0gICAgICogbm90IGhhbmRsZWQsIHRoZSBkb3dubG9hZCBp cyBjYW5jZWxsZWQuIE5vdGljZSB0aGF0IHdoaWxlCi0gICAgICogaGFuZGxpbmcgdGhpcyBzaWdu YWwgeW91IG11c3Qgc2V0IHRoZSB0YXJnZXQgVVJJIHVzaW5nCi0gICAgICogd2Via2l0X2Rvd25s b2FkX3NldF90YXJnZXRfdXJpKCkuCisgICAgICogbm90IGhhbmRsZWQsIHRoZSBkb3dubG9hZCBp cyBjYW5jZWxsZWQuIElmIHlvdSBoYW5kbGUgdGhlIGRvd25sb2FkCisgICAgICogYW5kIGNhbGwg d2Via2l0X2Rvd25sb2FkX3NldF9kZXN0aW5hdGlvbl91cmkoKSwgaXQgd2lsbCBiZQorICAgICAq IHN0YXJ0ZWQgZm9yIHlvdS4gSWYgeW91IG5lZWQgdG8gc2V0IHRoZSBkZXN0aW5hdGlvbiBhc3lu Y2hyb25vdXNseQorICAgICAqIHlvdSBhcmUgcmVzcG9uc2libGUgZm9yIHN0YXJ0aW5nIG9yIGNh bmNlbGxpbmcgaXQgeW91cnNlbGYuCiAgICAgICoKICAgICAgKiBJZiB5b3UgaW50ZW5kIHRvIGhh bmRsZSBkb3dubG9hZHMgeW91cnNlbGYgcmF0aGVyIHRoYW4gdXNpbmcKICAgICAgKiB0aGUgI1dl YktpdERvd25sb2FkIGhlbHBlciBvYmplY3QgeW91IG11c3QgaGFuZGxlIHRoaXMgc2lnbmFsLApA QCAtMjYyNiw3ICsyNjI3LDEwIEBAIHZvaWQgd2Via2l0X3dlYl92aWV3X3JlcXVlc3RfZG93bmxv YWQoV2ViS2l0V2ViVmlldyogd2ViVmlldywgV2ViS2l0TmV0d29ya1JlcXVlCiAgICAgICAgIHJl dHVybjsKICAgICB9CiAKLSAgICB3ZWJraXRfZG93bmxvYWRfc3RhcnQoZG93bmxvYWQpOworICAg IC8qIFN0YXJ0IHRoZSBkb3dubG9hZCBub3cgaWYgaXQgaGFzIGEgZGVzdGluYXRpb24gVVJJLCBv dGhlcndpc2UgaXQKKyAgICAgICAgbWF5IGJlIGhhbmRsZWQgYXN5bmNocm9ub3VzbHkgYnkgdGhl IGFwcGxpY2F0aW9uLiAqLworICAgIGlmICh3ZWJraXRfZG93bmxvYWRfZ2V0X2Rlc3RpbmF0aW9u X3VyaShkb3dubG9hZCkpCisgICAgICAgIHdlYmtpdF9kb3dubG9hZF9zdGFydChkb3dubG9hZCk7 CiB9CiAKIGJvb2wgd2Via2l0X3dlYl92aWV3X3VzZV9wcmltYXJ5X2Zvcl9wYXN0ZShXZWJLaXRX ZWJWaWV3KiB3ZWJWaWV3KQo= 45044 2009-12-17 02:23:35 -0800 2009-12-17 02:38:21 -0800 Check destination URI, clarify docs and test downloads both ways dlasynch.diff text/plain 5484 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggY2YxM2M3Zi4uYjI5ZjkxOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0xMi0xNyAg Q2hyaXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBEb24ndCBhc3N1bWUgZG93 bmxvYWRzIGFyZSBhbHdheXMgc3luY2hyb25vdXMKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIzNTkKKworICAgICAgICAqIHRlc3RzL3Rlc3Rkb3dubG9h ZC5jOgorICAgICAgICAoZG93bmxvYWRfcmVxdWVzdGVkX2NiKToKKyAgICAgICAgKHNldF9maWxl bmFtZSk6CisgICAgICAgICh0ZXN0X3dlYmtpdF9kb3dubG9hZF9wZXJmb3JtKToKKyAgICAgICAg KHRlc3Rfd2Via2l0X2Rvd25sb2FkX3N5bmNoKToKKyAgICAgICAgKHRlc3Rfd2Via2l0X2Rvd25s b2FkX2FzeW5jaCk6CisgICAgICAgIChtYWluKTogVGVzdCBkb3dubG9hZHMgc3luY2hyb25vdXNs eSBhbmQgYXN5bmNocm9ub3VzbHkuCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3Bw OgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorICAgICAgICAod2Via2l0 X3dlYl92aWV3X3JlcXVlc3RfZG93bmxvYWQpOiBPbmx5IHRyeSB0byBzdGFydCBhIHJlcXVlc3Rl ZAorICAgICAgICBkb3dubG9hZCBpZiB0aGUgZGVzdGluYXRpb24gVVJJIGlzIHNldCBhbmQgY2xh cmlmeSB0aGUgZG9jdW1lbnRhdGlvbi4KKwogMjAwOS0xMi0xNiAgRGFuIFdpbnNoaXAgIDxkYW53 QGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEgU2lsdmEu CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rkb3dubG9hZC5jIGIvV2ViS2l0L2d0 ay90ZXN0cy90ZXN0ZG93bmxvYWQuYwppbmRleCAwZDk2NGVkLi42ZDlmOWVhIDEwMDY0NAotLS0g YS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rkb3dubG9hZC5jCisrKyBiL1dlYktpdC9ndGsvdGVzdHMv dGVzdGRvd25sb2FkLmMKQEAgLTI2LDYgKzI2LDcgQEAKIAogR01haW5Mb29wKiBsb29wOwogY2hh ciogdGVtcG9yYXJ5RmlsZW5hbWUgPSBOVUxMOworV2ViS2l0RG93bmxvYWQqIHRoZURvd25sb2Fk ID0gTlVMTDsKIAogc3RhdGljIHZvaWQKIHRlc3Rfd2Via2l0X2Rvd25sb2FkX2NyZWF0ZSh2b2lk KQpAQCAtODcsNiArODgsNyBAQCBkb3dubG9hZF9yZXF1ZXN0ZWRfY2IoV2ViS2l0V2ViVmlldyog d2ViX3ZpZXcsCiAgICAgICAgICAgICAgICAgICAgICAgV2ViS2l0RG93bmxvYWQqIGRvd25sb2Fk LAogICAgICAgICAgICAgICAgICAgICAgIGdib29sZWFuKiBiZWVuVGhlcmUpCiB7CisgICAgdGhl RG93bmxvYWQgPSBkb3dubG9hZDsKICAgICAqYmVlblRoZXJlID0gVFJVRTsKICAgICBpZiAodGVt cG9yYXJ5RmlsZW5hbWUpIHsKICAgICAgICAgZ2NoYXIgKnVyaSA9IGdfZmlsZW5hbWVfdG9fdXJp KHRlbXBvcmFyeUZpbGVuYW1lLCBOVUxMLCBOVUxMKTsKQEAgLTEwMSw4ICsxMDMsMTkgQEAgZG93 bmxvYWRfcmVxdWVzdGVkX2NiKFdlYktpdFdlYlZpZXcqIHdlYl92aWV3LAogICAgIHJldHVybiBU UlVFOwogfQogCitzdGF0aWMgZ2Jvb2xlYW4KK3NldF9maWxlbmFtZShnY2hhciogZmlsZW5hbWUp Cit7CisgICAgZ2NoYXIgKnVyaSA9IGdfZmlsZW5hbWVfdG9fdXJpKGZpbGVuYW1lLCBOVUxMLCBO VUxMKTsKKyAgICB3ZWJraXRfZG93bmxvYWRfc2V0X2Rlc3RpbmF0aW9uX3VyaSh0aGVEb3dubG9h ZCwgdXJpKTsKKyAgICBnX2ZyZWUodXJpKTsKKyAgICB0ZW1wb3JhcnlGaWxlbmFtZSA9IGZpbGVu YW1lOworICAgIHdlYmtpdF9kb3dubG9hZF9zdGFydCh0aGVEb3dubG9hZCk7CisgICAgcmV0dXJu IEZBTFNFOworfQorCiBzdGF0aWMgdm9pZAotdGVzdF93ZWJraXRfZG93bmxvYWRfcGVyZm9ybSh2 b2lkKQordGVzdF93ZWJraXRfZG93bmxvYWRfcGVyZm9ybShnYm9vbGVhbiBhc3luY2gpCiB7CiAg ICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IFdFQktJVF9XRUJfVklFVyh3ZWJraXRfd2ViX3Zp ZXdfbmV3KCkpOwogCkBAIC0xMjEsMTYgKzEzNCwyMyBAQCB0ZXN0X3dlYmtpdF9kb3dubG9hZF9w ZXJmb3JtKHZvaWQpCiAgICAgICogdXRpbGl0aWVzIGZpbGUsIGJlY2F1c2Ugd2UgaGF2ZSBhIHZl cnkgc2ltaWxhciBvbmUgaW4KICAgICAgKiB0ZXN0d2ViZnJhbWUuYyAqLwogICAgIEdFcnJvciAq ZXJyb3IgPSBOVUxMOwotICAgIGludCBmZCA9IGdfZmlsZV9vcGVuX3RtcCAoIndlYmtpdC10ZXN0 d2ViZG93bmxvYWQtWFhYWFhYIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ0ZW1w b3JhcnlGaWxlbmFtZSwgJmVycm9yKTsKKyAgICBnY2hhciogZmlsZW5hbWU7CisgICAgaW50IGZk ID0gZ19maWxlX29wZW5fdG1wICgid2Via2l0LXRlc3R3ZWJkb3dubG9hZC1YWFhYWFgiLCAmZmls ZW5hbWUsICZlcnJvcik7CiAgICAgY2xvc2UoZmQpOwogCiAgICAgaWYgKGVycm9yKQogICAgICAg ICBnX2NyaXRpY2FsKCJGYWlsZWQgdG8gb3BlbiBhIHRlbXBvcmFyeSBmaWxlIGZvciB3cml0aW5n OiAlcy4iLCBlcnJvci0+bWVzc2FnZSk7CiAKLSAgICBpZiAoZ191bmxpbmsodGVtcG9yYXJ5Rmls ZW5hbWUpID09IC0xKQorICAgIGlmIChnX3VubGluayhmaWxlbmFtZSkgPT0gLTEpCiAgICAgICAg IGdfY3JpdGljYWwoIkZhaWxlZCB0byBkZWxldGUgdGhlIHRlbXBvcmFyeSBmaWxlOiAlcy4iLCBn X3N0cmVycm9yKGVycm5vKSk7CiAKKyAgICBpZiAoYXN5bmNoKQorICAgICAgICBnX2lkbGVfYWRk ICgoR1NvdXJjZUZ1bmMpc2V0X2ZpbGVuYW1lLCBmaWxlbmFtZSk7CisgICAgZWxzZQorICAgICAg ICB0ZW1wb3JhcnlGaWxlbmFtZSA9IGZpbGVuYW1lOworCisgICAgdGhlRG93bmxvYWQgPSBOVUxM OworCiAgICAgbG9vcCA9IGdfbWFpbl9sb29wX25ldyhOVUxMLCBUUlVFKTsKICAgICB3ZWJraXRf d2ViX3ZpZXdfbG9hZF91cmkod2ViVmlldywgImh0dHA6Ly9nbm9tZS5vcmcvIik7CiAgICAgZ19t YWluX2xvb3BfcnVuKGxvb3ApOwpAQCAtMTQ1LDYgKzE2NSwxOCBAQCB0ZXN0X3dlYmtpdF9kb3du bG9hZF9wZXJmb3JtKHZvaWQpCiAgICAgZ19vYmplY3RfdW5yZWYod2ViVmlldyk7CiB9CiAKK3N0 YXRpYyB2b2lkCit0ZXN0X3dlYmtpdF9kb3dubG9hZF9zeW5jaCh2b2lkKQoreworICB0ZXN0X3dl YmtpdF9kb3dubG9hZF9wZXJmb3JtKEZBTFNFKTsKK30KKworc3RhdGljIHZvaWQKK3Rlc3Rfd2Vi a2l0X2Rvd25sb2FkX2FzeW5jaCh2b2lkKQoreworICAgIHRlc3Rfd2Via2l0X2Rvd25sb2FkX3Bl cmZvcm0oVFJVRSk7Cit9CisKIGludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKIHsKICAg ICBnX3RocmVhZF9pbml0KE5VTEwpOwpAQCAtMTUyLDcgKzE4NCw4IEBAIGludCBtYWluKGludCBh cmdjLCBjaGFyKiogYXJndikKIAogICAgIGdfdGVzdF9idWdfYmFzZSgiaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvIik7CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2Rvd25sb2FkL2NyZWF0 ZSIsIHRlc3Rfd2Via2l0X2Rvd25sb2FkX2NyZWF0ZSk7Ci0gICAgZ190ZXN0X2FkZF9mdW5jKCIv d2Via2l0L2Rvd25sb2FkL3BlcmZvcm0iLCB0ZXN0X3dlYmtpdF9kb3dubG9hZF9wZXJmb3JtKTsK KyAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvZG93bmxvYWQvc3luY2giLCB0ZXN0X3dlYmtp dF9kb3dubG9hZF9zeW5jaCk7CisgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2Rvd25sb2Fk L2FzeW5jaCIsIHRlc3Rfd2Via2l0X2Rvd25sb2FkX2FzeW5jaCk7CiAgICAgcmV0dXJuIGdfdGVz dF9ydW4gKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggMzM1MDk5 OS4uMDAyZGIyZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j cHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTE1NDEsOSAr MTU0MSwxMCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRX ZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAgKiBAcmV0dXJuOiAlVFJVRSBpZiB0aGUg ZG93bmxvYWQgc2hvdWxkIGJlIHBlcmZvcm1lZCwgJUZBTFNFIHRvIGNhbmNlbCBpdC4KICAgICAg KgogICAgICAqIEEgbmV3IERvd25sb2FkIGlzIGJlaW5nIHJlcXVlc3RlZC4gQnkgZGVmYXVsdCwg aWYgdGhlIHNpZ25hbCBpcwotICAgICAqIG5vdCBoYW5kbGVkLCB0aGUgZG93bmxvYWQgaXMgY2Fu Y2VsbGVkLiBOb3RpY2UgdGhhdCB3aGlsZQotICAgICAqIGhhbmRsaW5nIHRoaXMgc2lnbmFsIHlv dSBtdXN0IHNldCB0aGUgdGFyZ2V0IFVSSSB1c2luZwotICAgICAqIHdlYmtpdF9kb3dubG9hZF9z ZXRfdGFyZ2V0X3VyaSgpLgorICAgICAqIG5vdCBoYW5kbGVkLCB0aGUgZG93bmxvYWQgaXMgY2Fu Y2VsbGVkLiBJZiB5b3UgaGFuZGxlIHRoZSBkb3dubG9hZAorICAgICAqIGFuZCBjYWxsIHdlYmtp dF9kb3dubG9hZF9zZXRfZGVzdGluYXRpb25fdXJpKCksIGl0IHdpbGwgYmUKKyAgICAgKiBzdGFy dGVkIGZvciB5b3UuIElmIHlvdSBuZWVkIHRvIHNldCB0aGUgZGVzdGluYXRpb24gYXN5bmNocm9u b3VzbHkKKyAgICAgKiB5b3UgYXJlIHJlc3BvbnNpYmxlIGZvciBzdGFydGluZyBvciBjYW5jZWxs aW5nIGl0IHlvdXJzZWxmLgogICAgICAqCiAgICAgICogSWYgeW91IGludGVuZCB0byBoYW5kbGUg ZG93bmxvYWRzIHlvdXJzZWxmIHJhdGhlciB0aGFuIHVzaW5nCiAgICAgICogdGhlICNXZWJLaXRE b3dubG9hZCBoZWxwZXIgb2JqZWN0IHlvdSBtdXN0IGhhbmRsZSB0aGlzIHNpZ25hbCwKQEAgLTI2 OTEsNyArMjY5MiwxMCBAQCB2b2lkIHdlYmtpdF93ZWJfdmlld19yZXF1ZXN0X2Rvd25sb2FkKFdl YktpdFdlYlZpZXcqIHdlYlZpZXcsIFdlYktpdE5ldHdvcmtSZXF1ZQogICAgICAgICByZXR1cm47 CiAgICAgfQogCi0gICAgd2Via2l0X2Rvd25sb2FkX3N0YXJ0KGRvd25sb2FkKTsKKyAgICAvKiBT dGFydCB0aGUgZG93bmxvYWQgbm93IGlmIGl0IGhhcyBhIGRlc3RpbmF0aW9uIFVSSSwgb3RoZXJ3 aXNlIGl0CisgICAgICAgIG1heSBiZSBoYW5kbGVkIGFzeW5jaHJvbm91c2x5IGJ5IHRoZSBhcHBs aWNhdGlvbi4gKi8KKyAgICBpZiAod2Via2l0X2Rvd25sb2FkX2dldF9kZXN0aW5hdGlvbl91cmko ZG93bmxvYWQpKQorICAgICAgICB3ZWJraXRfZG93bmxvYWRfc3RhcnQoZG93bmxvYWQpOwogfQog CiBib29sIHdlYmtpdF93ZWJfdmlld191c2VfcHJpbWFyeV9mb3JfcGFzdGUoV2ViS2l0V2ViVmll dyogd2ViVmlldykK 45046 2009-12-17 02:38:21 -0800 2009-12-17 07:33:49 -0800 Check destination URI, clarify docs and test downloads both ways #2 dlasynch.diff text/plain 5484 christian ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggY2YxM2M3Zi4uYjI5ZjkxOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAwOS0xMi0xNyAg Q2hyaXN0aWFuIER5d2FuICA8Y2hyaXN0aWFuQHR3b3RvYXN0cy5kZT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBEb24ndCBhc3N1bWUgZG93 bmxvYWRzIGFyZSBhbHdheXMgc3luY2hyb25vdXMKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIzNTkKKworICAgICAgICAqIHRlc3RzL3Rlc3Rkb3dubG9h ZC5jOgorICAgICAgICAoZG93bmxvYWRfcmVxdWVzdGVkX2NiKToKKyAgICAgICAgKHNldF9maWxl bmFtZSk6CisgICAgICAgICh0ZXN0X3dlYmtpdF9kb3dubG9hZF9wZXJmb3JtKToKKyAgICAgICAg KHRlc3Rfd2Via2l0X2Rvd25sb2FkX3N5bmNoKToKKyAgICAgICAgKHRlc3Rfd2Via2l0X2Rvd25s b2FkX2FzeW5jaCk6CisgICAgICAgIChtYWluKTogVGVzdCBkb3dubG9hZHMgc3luY2hyb25vdXNs eSBhbmQgYXN5bmNocm9ub3VzbHkuCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3Bw OgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQpOgorICAgICAgICAod2Via2l0 X3dlYl92aWV3X3JlcXVlc3RfZG93bmxvYWQpOiBPbmx5IHRyeSB0byBzdGFydCBhIHJlcXVlc3Rl ZAorICAgICAgICBkb3dubG9hZCBpZiB0aGUgZGVzdGluYXRpb24gVVJJIGlzIHNldCBhbmQgY2xh cmlmeSB0aGUgZG9jdW1lbnRhdGlvbi4KKwogMjAwOS0xMi0xNiAgRGFuIFdpbnNoaXAgIDxkYW53 QGdub21lLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEgU2lsdmEu CmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rkb3dubG9hZC5jIGIvV2ViS2l0L2d0 ay90ZXN0cy90ZXN0ZG93bmxvYWQuYwppbmRleCAwZDk2NGVkLi4wNWMzYThkIDEwMDY0NAotLS0g YS9XZWJLaXQvZ3RrL3Rlc3RzL3Rlc3Rkb3dubG9hZC5jCisrKyBiL1dlYktpdC9ndGsvdGVzdHMv dGVzdGRvd25sb2FkLmMKQEAgLTI2LDYgKzI2LDcgQEAKIAogR01haW5Mb29wKiBsb29wOwogY2hh ciogdGVtcG9yYXJ5RmlsZW5hbWUgPSBOVUxMOworV2ViS2l0RG93bmxvYWQqIHRoZURvd25sb2Fk ID0gTlVMTDsKIAogc3RhdGljIHZvaWQKIHRlc3Rfd2Via2l0X2Rvd25sb2FkX2NyZWF0ZSh2b2lk KQpAQCAtODcsNiArODgsNyBAQCBkb3dubG9hZF9yZXF1ZXN0ZWRfY2IoV2ViS2l0V2ViVmlldyog d2ViX3ZpZXcsCiAgICAgICAgICAgICAgICAgICAgICAgV2ViS2l0RG93bmxvYWQqIGRvd25sb2Fk LAogICAgICAgICAgICAgICAgICAgICAgIGdib29sZWFuKiBiZWVuVGhlcmUpCiB7CisgICAgdGhl RG93bmxvYWQgPSBkb3dubG9hZDsKICAgICAqYmVlblRoZXJlID0gVFJVRTsKICAgICBpZiAodGVt cG9yYXJ5RmlsZW5hbWUpIHsKICAgICAgICAgZ2NoYXIgKnVyaSA9IGdfZmlsZW5hbWVfdG9fdXJp KHRlbXBvcmFyeUZpbGVuYW1lLCBOVUxMLCBOVUxMKTsKQEAgLTEwMSw4ICsxMDMsMTkgQEAgZG93 bmxvYWRfcmVxdWVzdGVkX2NiKFdlYktpdFdlYlZpZXcqIHdlYl92aWV3LAogICAgIHJldHVybiBU UlVFOwogfQogCitzdGF0aWMgZ2Jvb2xlYW4KK3NldF9maWxlbmFtZShnY2hhciogZmlsZW5hbWUp Cit7CisgICAgZ2NoYXIgKnVyaSA9IGdfZmlsZW5hbWVfdG9fdXJpKGZpbGVuYW1lLCBOVUxMLCBO VUxMKTsKKyAgICB3ZWJraXRfZG93bmxvYWRfc2V0X2Rlc3RpbmF0aW9uX3VyaSh0aGVEb3dubG9h ZCwgdXJpKTsKKyAgICBnX2ZyZWUodXJpKTsKKyAgICB0ZW1wb3JhcnlGaWxlbmFtZSA9IGZpbGVu YW1lOworICAgIHdlYmtpdF9kb3dubG9hZF9zdGFydCh0aGVEb3dubG9hZCk7CisgICAgcmV0dXJu IEZBTFNFOworfQorCiBzdGF0aWMgdm9pZAotdGVzdF93ZWJraXRfZG93bmxvYWRfcGVyZm9ybSh2 b2lkKQordGVzdF93ZWJraXRfZG93bmxvYWRfcGVyZm9ybShnYm9vbGVhbiBhc3luY2gpCiB7CiAg ICAgV2ViS2l0V2ViVmlldyogd2ViVmlldyA9IFdFQktJVF9XRUJfVklFVyh3ZWJraXRfd2ViX3Zp ZXdfbmV3KCkpOwogCkBAIC0xMjEsMTYgKzEzNCwyMyBAQCB0ZXN0X3dlYmtpdF9kb3dubG9hZF9w ZXJmb3JtKHZvaWQpCiAgICAgICogdXRpbGl0aWVzIGZpbGUsIGJlY2F1c2Ugd2UgaGF2ZSBhIHZl cnkgc2ltaWxhciBvbmUgaW4KICAgICAgKiB0ZXN0d2ViZnJhbWUuYyAqLwogICAgIEdFcnJvciAq ZXJyb3IgPSBOVUxMOwotICAgIGludCBmZCA9IGdfZmlsZV9vcGVuX3RtcCAoIndlYmtpdC10ZXN0 d2ViZG93bmxvYWQtWFhYWFhYIiwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ0ZW1w b3JhcnlGaWxlbmFtZSwgJmVycm9yKTsKKyAgICBnY2hhciogZmlsZW5hbWU7CisgICAgaW50IGZk ID0gZ19maWxlX29wZW5fdG1wKCJ3ZWJraXQtdGVzdHdlYmRvd25sb2FkLVhYWFhYWCIsICZmaWxl bmFtZSwgJmVycm9yKTsKICAgICBjbG9zZShmZCk7CiAKICAgICBpZiAoZXJyb3IpCiAgICAgICAg IGdfY3JpdGljYWwoIkZhaWxlZCB0byBvcGVuIGEgdGVtcG9yYXJ5IGZpbGUgZm9yIHdyaXRpbmc6 ICVzLiIsIGVycm9yLT5tZXNzYWdlKTsKIAotICAgIGlmIChnX3VubGluayh0ZW1wb3JhcnlGaWxl bmFtZSkgPT0gLTEpCisgICAgaWYgKGdfdW5saW5rKGZpbGVuYW1lKSA9PSAtMSkKICAgICAgICAg Z19jcml0aWNhbCgiRmFpbGVkIHRvIGRlbGV0ZSB0aGUgdGVtcG9yYXJ5IGZpbGU6ICVzLiIsIGdf c3RyZXJyb3IoZXJybm8pKTsKIAorICAgIGlmIChhc3luY2gpCisgICAgICAgIGdfaWRsZV9hZGQo KEdTb3VyY2VGdW5jKXNldF9maWxlbmFtZSwgZmlsZW5hbWUpOworICAgIGVsc2UKKyAgICAgICAg dGVtcG9yYXJ5RmlsZW5hbWUgPSBmaWxlbmFtZTsKKworICAgIHRoZURvd25sb2FkID0gTlVMTDsK KwogICAgIGxvb3AgPSBnX21haW5fbG9vcF9uZXcoTlVMTCwgVFJVRSk7CiAgICAgd2Via2l0X3dl Yl92aWV3X2xvYWRfdXJpKHdlYlZpZXcsICJodHRwOi8vZ25vbWUub3JnLyIpOwogICAgIGdfbWFp bl9sb29wX3J1bihsb29wKTsKQEAgLTE0NSw2ICsxNjUsMTggQEAgdGVzdF93ZWJraXRfZG93bmxv YWRfcGVyZm9ybSh2b2lkKQogICAgIGdfb2JqZWN0X3VucmVmKHdlYlZpZXcpOwogfQogCitzdGF0 aWMgdm9pZAordGVzdF93ZWJraXRfZG93bmxvYWRfc3luY2godm9pZCkKK3sKKyAgICB0ZXN0X3dl YmtpdF9kb3dubG9hZF9wZXJmb3JtKEZBTFNFKTsKK30KKworc3RhdGljIHZvaWQKK3Rlc3Rfd2Vi a2l0X2Rvd25sb2FkX2FzeW5jaCh2b2lkKQoreworICAgIHRlc3Rfd2Via2l0X2Rvd25sb2FkX3Bl cmZvcm0oVFJVRSk7Cit9CisKIGludCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikKIHsKICAg ICBnX3RocmVhZF9pbml0KE5VTEwpOwpAQCAtMTUyLDcgKzE4NCw4IEBAIGludCBtYWluKGludCBh cmdjLCBjaGFyKiogYXJndikKIAogICAgIGdfdGVzdF9idWdfYmFzZSgiaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvIik7CiAgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2Rvd25sb2FkL2NyZWF0 ZSIsIHRlc3Rfd2Via2l0X2Rvd25sb2FkX2NyZWF0ZSk7Ci0gICAgZ190ZXN0X2FkZF9mdW5jKCIv d2Via2l0L2Rvd25sb2FkL3BlcmZvcm0iLCB0ZXN0X3dlYmtpdF9kb3dubG9hZF9wZXJmb3JtKTsK KyAgICBnX3Rlc3RfYWRkX2Z1bmMoIi93ZWJraXQvZG93bmxvYWQvc3luY2giLCB0ZXN0X3dlYmtp dF9kb3dubG9hZF9zeW5jaCk7CisgICAgZ190ZXN0X2FkZF9mdW5jKCIvd2Via2l0L2Rvd25sb2Fk L2FzeW5jaCIsIHRlc3Rfd2Via2l0X2Rvd25sb2FkX2FzeW5jaCk7CiAgICAgcmV0dXJuIGdfdGVz dF9ydW4gKCk7CiB9CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZp ZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggMzM1MDk5 OS4uMDAyZGIyZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5j cHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTE1NDEsOSAr MTU0MSwxMCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRX ZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAgKiBAcmV0dXJuOiAlVFJVRSBpZiB0aGUg ZG93bmxvYWQgc2hvdWxkIGJlIHBlcmZvcm1lZCwgJUZBTFNFIHRvIGNhbmNlbCBpdC4KICAgICAg KgogICAgICAqIEEgbmV3IERvd25sb2FkIGlzIGJlaW5nIHJlcXVlc3RlZC4gQnkgZGVmYXVsdCwg aWYgdGhlIHNpZ25hbCBpcwotICAgICAqIG5vdCBoYW5kbGVkLCB0aGUgZG93bmxvYWQgaXMgY2Fu Y2VsbGVkLiBOb3RpY2UgdGhhdCB3aGlsZQotICAgICAqIGhhbmRsaW5nIHRoaXMgc2lnbmFsIHlv dSBtdXN0IHNldCB0aGUgdGFyZ2V0IFVSSSB1c2luZwotICAgICAqIHdlYmtpdF9kb3dubG9hZF9z ZXRfdGFyZ2V0X3VyaSgpLgorICAgICAqIG5vdCBoYW5kbGVkLCB0aGUgZG93bmxvYWQgaXMgY2Fu Y2VsbGVkLiBJZiB5b3UgaGFuZGxlIHRoZSBkb3dubG9hZAorICAgICAqIGFuZCBjYWxsIHdlYmtp dF9kb3dubG9hZF9zZXRfZGVzdGluYXRpb25fdXJpKCksIGl0IHdpbGwgYmUKKyAgICAgKiBzdGFy dGVkIGZvciB5b3UuIElmIHlvdSBuZWVkIHRvIHNldCB0aGUgZGVzdGluYXRpb24gYXN5bmNocm9u b3VzbHkKKyAgICAgKiB5b3UgYXJlIHJlc3BvbnNpYmxlIGZvciBzdGFydGluZyBvciBjYW5jZWxs aW5nIGl0IHlvdXJzZWxmLgogICAgICAqCiAgICAgICogSWYgeW91IGludGVuZCB0byBoYW5kbGUg ZG93bmxvYWRzIHlvdXJzZWxmIHJhdGhlciB0aGFuIHVzaW5nCiAgICAgICogdGhlICNXZWJLaXRE b3dubG9hZCBoZWxwZXIgb2JqZWN0IHlvdSBtdXN0IGhhbmRsZSB0aGlzIHNpZ25hbCwKQEAgLTI2 OTEsNyArMjY5MiwxMCBAQCB2b2lkIHdlYmtpdF93ZWJfdmlld19yZXF1ZXN0X2Rvd25sb2FkKFdl YktpdFdlYlZpZXcqIHdlYlZpZXcsIFdlYktpdE5ldHdvcmtSZXF1ZQogICAgICAgICByZXR1cm47 CiAgICAgfQogCi0gICAgd2Via2l0X2Rvd25sb2FkX3N0YXJ0KGRvd25sb2FkKTsKKyAgICAvKiBT dGFydCB0aGUgZG93bmxvYWQgbm93IGlmIGl0IGhhcyBhIGRlc3RpbmF0aW9uIFVSSSwgb3RoZXJ3 aXNlIGl0CisgICAgICAgIG1heSBiZSBoYW5kbGVkIGFzeW5jaHJvbm91c2x5IGJ5IHRoZSBhcHBs aWNhdGlvbi4gKi8KKyAgICBpZiAod2Via2l0X2Rvd25sb2FkX2dldF9kZXN0aW5hdGlvbl91cmko ZG93bmxvYWQpKQorICAgICAgICB3ZWJraXRfZG93bmxvYWRfc3RhcnQoZG93bmxvYWQpOwogfQog CiBib29sIHdlYmtpdF93ZWJfdmlld191c2VfcHJpbWFyeV9mb3JfcGFzdGUoV2ViS2l0V2ViVmll dyogd2ViVmlldykK