32353 2009-12-09 16:25:45 -0800 Add a manual test for crash in DOMWindow::clearTimeout when DOMWindow is not connected to frame 2010-03-05 19:18:17 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dimich dimich ap eric webkit.review.bot oldest_to_newest 170238 0 dimich 2009-12-09 16:25:45 -0800 Patch for bug 29832 fixed a crash in Safari 4 caused by not resetting a JSDOMWindow wrapper on a detached frame in some cases. The test reproducing the crash can not be added as layout test because it takes ~10 seconds to run. Need to add it as a manual test. 170256 1 44583 dimich 2009-12-09 17:12:21 -0800 Created attachment 44583 Proposed patch. 170257 2 webkit.review.bot 2009-12-09 17:13:03 -0800 style-queue ran check-webkit-style on attachment 44583 without any errors. 170285 3 44583 oliver 2009-12-09 19:06:38 -0800 Comment on attachment 44583 Proposed patch. r=me 170287 4 ap 2009-12-09 19:15:22 -0800 I don't quite understand why this needs to take ~10 seconds (what's back/forward cache expiration?), but maybe a new DRT method can make this instant? 170533 5 dimich 2009-12-10 14:33:21 -0800 (In reply to comment #4) > I don't quite understand why this needs to take ~10 seconds (what's > back/forward cache expiration?), but maybe a new DRT method can make this > instant? Indeed, there is no way today to cause immediate b/f cache expiration so the destruction of the cached pages can not be realistically tested in DRT today. I thought about something like layoutTestController.setBackForwardCacheExpiration(seconds) but wasn't sure the single test justifies it... Perhaps we should do it next time we have a need? 170542 6 ap 2009-12-10 15:12:11 -0800 This case seems significant enough to warrant adding a DRT method. Perhaps it would be easier to just force immediate expiration, rather than set a timeout? 170554 7 dimich 2009-12-10 15:39:43 -0800 (In reply to comment #6) > This case seems significant enough to warrant adding a DRT method. > > Perhaps it would be easier to just force immediate expiration, rather than set > a timeout? Ok. I'll take a look at adding a method. Will delay landing the patch until implementation is ready, then we'll decide. 175446 8 eric 2009-12-28 23:36:46 -0800 Ping? Curious what the status is here. This patch has been approved for landing for a little over 2 weeks. 196821 9 eric 2010-03-05 17:14:26 -0800 Ping? 196847 10 dimich 2010-03-05 19:12:01 -0800 I agree with Alexey that having manual test is somewhat useless since nobody ever runs them. I have this task (make it possibel to test the bf cache expiration from DRT in my list and will get to it at some point, in a few weeks. So for now I guess I'll commit this test so it is there, but will address the DRT testing at some point. 196849 11 dimich 2010-03-05 19:18:17 -0800 Landed: http://trac.webkit.org/changeset/55609 44583 2009-12-09 17:12:21 -0800 2009-12-09 19:06:38 -0800 Proposed patch. patch.txt text/plain 1837 dimich ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTBiNjMzMy4uMzI2NzIyOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0xMi0wOSAgRG1pdHJ5IFRpdG92 ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSBtYW51YWwgdGVzdCBmb3IgY3Jhc2ggaW4gRE9NV2luZG93 OjpjbGVhclRpbWVvdXQgd2hlbiBET01XaW5kb3cgaXMgbm90IGNvbm5lY3RlZCB0byBGcmFtZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIzNTMKKwor ICAgICAgICAqIG1hbnVhbC10ZXN0cy9jbGVhclRpbWVvdXQtY3Jhc2gtYnVnMjk4MzIuaHRtbDog QWRkZWQuCisKIDIwMDktMTItMDggIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgRGF2aWQgTGV2aW4uCmRpZmYgLS1naXQgYS9X ZWJDb3JlL21hbnVhbC10ZXN0cy9jbGVhclRpbWVvdXQtY3Jhc2gtYnVnMjk4MzIuaHRtbCBiL1dl YkNvcmUvbWFudWFsLXRlc3RzL2NsZWFyVGltZW91dC1jcmFzaC1idWcyOTgzMi5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmQ5ZWM1YzcKLS0tIC9kZXYvbnVsbAorKysg Yi9XZWJDb3JlL21hbnVhbC10ZXN0cy9jbGVhclRpbWVvdXQtY3Jhc2gtYnVnMjk4MzIuaHRtbApA QCAtMCwwICsxLDIwIEBACis8c2NyaXB0PgordmFyIHc7CitmdW5jdGlvbiBjbGVhcigpIHsKKyAg ICB3LmNsZWFyVGltZW91dCgxNTMpOworfQorCitmdW5jdGlvbiB0ZXN0KCkgeworICAgIHcgPSB3 aW5kb3cub3BlbigiZGF0YTp0ZXh0L2h0bWwsIisKKyAgICAgICAgIjxzY3JpcHQ+IiArCisgICAg ICAgICJmdW5jdGlvbiBuYXZpZ2F0ZSgpIHsgbG9jYXRpb24uaHJlZj0nZGF0YTp0ZXh0L2h0bWws PGJvZHk+Q2xvc2UgdGhpcyBwYWdlIGFuZCB3YWl0LjwvYm9keT4nfTsiICsKKyAgICAgICAgInNl dFRpbWVvdXQobmF2aWdhdGUsMCk7PC8iICsgCisgICAgICAgICJzY3JpcHQ+Iik7CisKKyAgICBz ZXRJbnRlcnZhbChjbGVhciwgMCk7Cit9Cis8L3NjcmlwdD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0 IHJlcHJvZHVjZXMgdGhlIGNyYXNoIGluIERPTVdpbmRvdzo6Y2xlYXJUaW1lb3V0IHRoYXQgaGFw cGVucyB3aGVuIERPTVdpbmRvdyBpcyBkaXNjb25uZWN0ZWQgZnJvbSB0aGUgRnJhbWUgKGFzIGlu IGJhY2svZm9yd2FyZCBjYWNoZSBleHBpcmF0aW9uIGNhc2UgdGVzdGVkIGhlcmUpLgorPHA+VGhp cyBpcyB0aGUgbGluayB0byB0aGUgYnVnOiA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9Mjk4MzIiPmh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yOTgzMjwvYT4KKzxwPlRvIHJlcHJvZHVjZSB0aGUgY3Jhc2gsIGNsaWNrIHRoZSBs aW5rIGJlbG93LCB0aGUgcG9wdXAgd2luZG93IG9wZW5zLCB3aGljaCB3aWxsIGltbWVkaWF0ZWx5 IG5hdmlnYXRlIHRvIGFub3RoZXIgb25lLCBzbyB0aGUgYi9mIGNhY2hlIGVudHJ5IHdpbGwgYmUg Y3JlYXRlZC4gQ2xvc2UgdGhlIHBvcHVwIHdpbmRvdy4gV2FpdCBhIGZldyBzZWNvbmRzICh+MTAp LCBmb3IgdGhlIHBhZ2UgY2FjaGUgdG8gc3RhcnQgZGVsZXRpbmcgcGFnZXMgaXQgZG9lc24ndCBu ZWVkIC0gY3Jhc2ggd2lsbCBoYXBwZW4uPGJyPjxhIGhyZWY9ImphdmFzY3JpcHQ6dGVzdCgpIj5D cmFzaCBtZSE8L2E+Cg==