32352 2009-12-09 16:05:24 -0800 CommandsTest.assert_execute_outputs doesn't check stderr 2009-12-11 14:39:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue webkit.review.bot oldest_to_newest 170233 0 eric 2009-12-09 16:05:24 -0800 CommandsTest.assert_execute_outputs doesn't check stderr It tries to, but fails: self.assertEqual(expected_stderr, expected_stderr) Fixing this will undoubtably reveal a bunch of failures. 170929 1 44708 eric 2009-12-11 14:27:35 -0800 Created attachment 44708 Patch 170931 2 webkit.review.bot 2009-12-11 14:29:02 -0800 style-queue ran check-webkit-style on attachment 44708 without any errors. 170932 3 44708 abarth 2009-12-11 14:29:30 -0800 Comment on attachment 44708 Patch Fantabulous! 170935 4 44708 commit-queue 2009-12-11 14:39:36 -0800 Comment on attachment 44708 Patch Clearing flags on attachment: 44708 Committed r52025: <http://trac.webkit.org/changeset/52025> 170936 5 commit-queue 2009-12-11 14:39:41 -0800 All reviewed patches have been landed. Closing bug. 44708 2009-12-11 14:27:35 -0800 2009-12-11 14:39:36 -0800 Patch bug-32352-20091211142733.patch text/plain 5667 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjNTUwMDlkLi42MDhlYjY2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMDktMTIt MTEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvbW1hbmRzVGVzdC5hc3NlcnRfZXhlY3V0ZV9v dXRwdXRzIGRvZXNuJ3QgY2hlY2sgc3RkZXJyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMjM1MgorCisgICAgICAgIEZpeCBhc3NlcnRfZXhlY3V0ZV9v dXRwdXRzIHRvIGNoZWNrIHN0ZGVycgorICAgICAgICBhbmQgdGhlbiBmaXggYWxsIHRoZSB1bml0 IHRlc3RzIHdoaWNoIG5lZWRlZCB0bworICAgICAgICBwYXNzIHN0ZGVyciBvdXRwdXQuCisKKyAg ICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvY29tbWFuZHRlc3QucHk6CisgICAgICAg ICogU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0ZXN0LnB5OgorICAgICAg ICAqIFNjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy91cGxvYWRfdW5pdHRlc3QucHk6CisKIDIwMDkt MTItMTAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIE5vIHJldmll dywganVzdCB1cGRhdGluZyB1bml0IHRlc3RzIHRvIG1hdGNoIHJlY2VudCBjaGVja2lucy4KZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9jb21tYW5kdGVz dC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9jb21tYW5kdGVzdC5w eQppbmRleCA2MThhNTE3Li4zMGMwZGU1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRz L21vZHVsZXMvY29tbWFuZHMvY29tbWFuZHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy9tb2R1bGVzL2NvbW1hbmRzL2NvbW1hbmR0ZXN0LnB5CkBAIC0zOSw0ICszOSw0IEBAIGNsYXNz IENvbW1hbmRzVGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgIGNvbW1hbmQuZXhlY3V0 ZShvcHRpb25zLCBhcmdzLCB0b29sKQogICAgICAgICAoc3Rkb3V0X3N0cmluZywgc3RkZXJyX3N0 cmluZykgPSBjYXB0dXJlLnJlc3RvcmVfb3V0cHV0KCkKICAgICAgICAgc2VsZi5hc3NlcnRFcXVh bChzdGRvdXRfc3RyaW5nLCBleHBlY3RlZF9zdGRvdXQpCi0gICAgICAgIHNlbGYuYXNzZXJ0RXF1 YWwoZXhwZWN0ZWRfc3RkZXJyLCBleHBlY3RlZF9zdGRlcnIpCisgICAgICAgIHNlbGYuYXNzZXJ0 RXF1YWwoc3RkZXJyX3N0cmluZywgZXhwZWN0ZWRfc3RkZXJyKQpkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0ZXN0LnB5IGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rvd25sb2FkX3VuaXR0ZXN0LnB5Cmlu ZGV4IGExZWQ0MWEuLmZmMjA5ZDkgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9k dWxlcy9jb21tYW5kcy9kb3dubG9hZF91bml0dGVzdC5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY29tbWFuZHMvZG93bmxvYWRfdW5pdHRlc3QucHkKQEAgLTQ3LDMxICs0Nywz OSBAQCBjbGFzcyBEb3dubG9hZENvbW1hbmRzVGVzdChDb21tYW5kc1Rlc3QpOgogICAgICAgICBy ZXR1cm4gb3B0aW9ucwogCiAgICAgZGVmIHRlc3RfYnVpbGQoc2VsZik6Ci0gICAgICAgIHNlbGYu YXNzZXJ0X2V4ZWN1dGVfb3V0cHV0cyhCdWlsZCgpLCBbXSwgb3B0aW9ucz1zZWxmLl9kZWZhdWx0 X29wdGlvbnMoKSkKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIlVwZGF0aW5nIHdvcmtpbmcg ZGlyZWN0b3J5XG5CdWlsZGluZyBXZWJLaXRcbiIKKyAgICAgICAgc2VsZi5hc3NlcnRfZXhlY3V0 ZV9vdXRwdXRzKEJ1aWxkKCksIFtdLCBvcHRpb25zPXNlbGYuX2RlZmF1bHRfb3B0aW9ucygpLCBl eHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQogCiAgICAgZGVmIHRlc3RfYXBwbHlfYXR0 YWNobWVudChzZWxmKToKICAgICAgICAgb3B0aW9ucyA9IHNlbGYuX2RlZmF1bHRfb3B0aW9ucygp CiAgICAgICAgIG9wdGlvbnMudXBkYXRlID0gVHJ1ZQogICAgICAgICBvcHRpb25zLmxvY2FsX2Nv bW1pdCA9IFRydWUKLSAgICAgICAgc2VsZi5hc3NlcnRfZXhlY3V0ZV9vdXRwdXRzKEFwcGx5QXR0 YWNobWVudCgpLCBbMTk3XSwgb3B0aW9ucz1vcHRpb25zKQorICAgICAgICBleHBlY3RlZF9zdGRl cnIgPSAiVXBkYXRpbmcgd29ya2luZyBkaXJlY3RvcnlcbkFwcGx5aW5nIGF0dGFjaG1lbnQgMTk3 IGZyb20gYnVnIDQyXG4iCisgICAgICAgIHNlbGYuYXNzZXJ0X2V4ZWN1dGVfb3V0cHV0cyhBcHBs eUF0dGFjaG1lbnQoKSwgWzE5N10sIG9wdGlvbnM9b3B0aW9ucywgZXhwZWN0ZWRfc3RkZXJyPWV4 cGVjdGVkX3N0ZGVycikKIAogICAgIGRlZiB0ZXN0X2FwcGx5X3BhdGNoZXMoc2VsZik6CiAgICAg ICAgIG9wdGlvbnMgPSBzZWxmLl9kZWZhdWx0X29wdGlvbnMoKQogICAgICAgICBvcHRpb25zLnVw ZGF0ZSA9IFRydWUKICAgICAgICAgb3B0aW9ucy5sb2NhbF9jb21taXQgPSBUcnVlCi0gICAgICAg IHNlbGYuYXNzZXJ0X2V4ZWN1dGVfb3V0cHV0cyhBcHBseVBhdGNoZXMoKSwgWzQyXSwgb3B0aW9u cz1vcHRpb25zKQorICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiVXBkYXRpbmcgd29ya2luZyBk aXJlY3RvcnlcbkFwcGx5aW5nIGF0dGFjaG1lbnQgMTk3IGZyb20gYnVnIDQyXG5BcHBseWluZyBh dHRhY2htZW50IDEyOCBmcm9tIGJ1ZyA0MlxuIgorICAgICAgICBzZWxmLmFzc2VydF9leGVjdXRl X291dHB1dHMoQXBwbHlQYXRjaGVzKCksIFs0Ml0sIG9wdGlvbnM9b3B0aW9ucywgZXhwZWN0ZWRf c3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAogICAgIGRlZiB0ZXN0X2xhbmRfZGlmZihzZWxmKToK LSAgICAgICAgc2VsZi5hc3NlcnRfZXhlY3V0ZV9vdXRwdXRzKExhbmREaWZmKCksIFs0Ml0sIG9w dGlvbnM9c2VsZi5fZGVmYXVsdF9vcHRpb25zKCkpCisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9 ICJCdWlsZGluZyBXZWJLaXRcblVwZGF0aW5nIGJ1ZyA0MlxuIgorICAgICAgICBzZWxmLmFzc2Vy dF9leGVjdXRlX291dHB1dHMoTGFuZERpZmYoKSwgWzQyXSwgb3B0aW9ucz1zZWxmLl9kZWZhdWx0 X29wdGlvbnMoKSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikKIAogICAgIGRlZiB0 ZXN0X2NoZWNrX3N0eWxlKHNlbGYpOgotICAgICAgICBzZWxmLmFzc2VydF9leGVjdXRlX291dHB1 dHMoQ2hlY2tTdHlsZSgpLCBbMTk3XSwgb3B0aW9ucz1zZWxmLl9kZWZhdWx0X29wdGlvbnMoKSkK KyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIlByb2Nlc3NpbmcgMSBwYXRjaCBmcm9tIDEgYnVn LlxuVXBkYXRpbmcgd29ya2luZyBkaXJlY3RvcnlcblByb2Nlc3NpbmcgcGF0Y2ggMTk3IGZyb20g YnVnIDQyLlxuUnVubmluZyBjaGVjay13ZWJraXQtc3R5bGVcbiIKKyAgICAgICAgc2VsZi5hc3Nl cnRfZXhlY3V0ZV9vdXRwdXRzKENoZWNrU3R5bGUoKSwgWzE5N10sIG9wdGlvbnM9c2VsZi5fZGVm YXVsdF9vcHRpb25zKCksIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRlcnIpCiAKICAgICBk ZWYgdGVzdF9idWlsZF9hdHRhY2htZW50KHNlbGYpOgotICAgICAgICBzZWxmLmFzc2VydF9leGVj dXRlX291dHB1dHMoQnVpbGRBdHRhY2htZW50KCksIFsxOTddLCBvcHRpb25zPXNlbGYuX2RlZmF1 bHRfb3B0aW9ucygpKQorICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiUHJvY2Vzc2luZyAxIHBh dGNoIGZyb20gMSBidWcuXG5VcGRhdGluZyB3b3JraW5nIGRpcmVjdG9yeVxuUHJvY2Vzc2luZyBw YXRjaCAxOTcgZnJvbSBidWcgNDIuXG5CdWlsZGluZyBXZWJLaXRcbiIKKyAgICAgICAgc2VsZi5h c3NlcnRfZXhlY3V0ZV9vdXRwdXRzKEJ1aWxkQXR0YWNobWVudCgpLCBbMTk3XSwgb3B0aW9ucz1z ZWxmLl9kZWZhdWx0X29wdGlvbnMoKSwgZXhwZWN0ZWRfc3RkZXJyPWV4cGVjdGVkX3N0ZGVycikK IAogICAgIGRlZiB0ZXN0X2xhbmRfYXR0YWNobWVudChzZWxmKToKLSAgICAgICAgc2VsZi5hc3Nl cnRfZXhlY3V0ZV9vdXRwdXRzKExhbmRBdHRhY2htZW50KCksIFsxOTddLCBvcHRpb25zPXNlbGYu X2RlZmF1bHRfb3B0aW9ucygpKQorICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiUHJvY2Vzc2lu ZyAxIHBhdGNoIGZyb20gMSBidWcuXG5VcGRhdGluZyB3b3JraW5nIGRpcmVjdG9yeVxuUHJvY2Vz c2luZyBwYXRjaCAxOTcgZnJvbSBidWcgNDIuXG5CdWlsZGluZyBXZWJLaXRcbiIKKyAgICAgICAg c2VsZi5hc3NlcnRfZXhlY3V0ZV9vdXRwdXRzKExhbmRBdHRhY2htZW50KCksIFsxOTddLCBvcHRp b25zPXNlbGYuX2RlZmF1bHRfb3B0aW9ucygpLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3Rk ZXJyKQogCiAgICAgZGVmIHRlc3RfbGFuZF9wYXRjaGVzKHNlbGYpOgotICAgICAgICBzZWxmLmFz c2VydF9leGVjdXRlX291dHB1dHMoTGFuZFBhdGNoZXMoKSwgWzQyXSwgb3B0aW9ucz1zZWxmLl9k ZWZhdWx0X29wdGlvbnMoKSkKKyAgICAgICAgZXhwZWN0ZWRfc3RkZXJyID0gIjIgcmV2aWV3ZWQg cGF0Y2hlcyBmb3VuZCBvbiBidWcgNDIuXG5Qcm9jZXNzaW5nIDIgcGF0Y2hlcyBmcm9tIDEgYnVn LlxuVXBkYXRpbmcgd29ya2luZyBkaXJlY3RvcnlcblByb2Nlc3NpbmcgcGF0Y2ggMTk3IGZyb20g YnVnIDQyLlxuQnVpbGRpbmcgV2ViS2l0XG5VcGRhdGluZyB3b3JraW5nIGRpcmVjdG9yeVxuUHJv Y2Vzc2luZyBwYXRjaCAxMjggZnJvbSBidWcgNDIuXG5CdWlsZGluZyBXZWJLaXRcbiIKKyAgICAg ICAgc2VsZi5hc3NlcnRfZXhlY3V0ZV9vdXRwdXRzKExhbmRQYXRjaGVzKCksIFs0Ml0sIG9wdGlv bnM9c2VsZi5fZGVmYXVsdF9vcHRpb25zKCksIGV4cGVjdGVkX3N0ZGVycj1leHBlY3RlZF9zdGRl cnIpCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvdXBs b2FkX3VuaXR0ZXN0LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3Vw bG9hZF91bml0dGVzdC5weQppbmRleCA0ZDNmODVjLi5jZjAwM2FhIDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0LnB5CisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy91cGxvYWRfdW5pdHRlc3QucHkK QEAgLTM5LDQgKzM5LDUgQEAgY2xhc3MgVXBsb2FkQ29tbWFuZHNUZXN0KENvbW1hbmRzVGVzdCk6 CiAgICAgICAgIHNlbGYuYXNzZXJ0X2V4ZWN1dGVfb3V0cHV0cyhPYnNvbGV0ZUF0dGFjaG1lbnRz KCksIFs0Ml0pCiAKICAgICBkZWYgdGVzdF9wb3N0X2RpZmYoc2VsZik6Ci0gICAgICAgIHNlbGYu YXNzZXJ0X2V4ZWN1dGVfb3V0cHV0cyhQb3N0RGlmZigpLCBbNDJdKQorICAgICAgICBleHBlY3Rl ZF9zdGRlcnIgPSAiT2Jzb2xldGluZyAyIG9sZCBwYXRjaGVzIG9uIGJ1ZyA0MlxuIgorICAgICAg ICBzZWxmLmFzc2VydF9leGVjdXRlX291dHB1dHMoUG9zdERpZmYoKSwgWzQyXSwgZXhwZWN0ZWRf c3RkZXJyPWV4cGVjdGVkX3N0ZGVycikK