3235 2005-06-01 14:56:31 -0700 CSS2: Table cell coalescing in CSS broken 2009-04-21 08:49:21 -0700 1 1 1 Unclassified WebKit Tables 412 All All RESOLVED FIXED InRadar P2 Normal --- 1 hyatt bdakin bdakin ian zwarich oldest_to_newest 10423 0 hyatt 2005-06-01 14:56:31 -0700 <html> <head> <style> .entries { display: table-cell; } .sidebar { display: table-cell; } </style> </head> <body> <div class="nav"></div> <div class="entries">One</div> <div class="sidebar">Two</div> </body> </html> "One" and "Two" should be in the same table, so they should be in a row together. Instead they end up in separate tables all because of the presence of the extra "nav" div. 10424 1 hyatt 2005-06-01 14:57:37 -0700 Apple Bug: rdar://3299883/ 26976 2 5331 eric 2005-12-28 02:12:04 -0800 Created attachment 5331 test case as attachement 26977 3 eric 2005-12-28 02:13:00 -0800 CC'ing beth as this is in her area of expertise. 82025 4 genisis329 2008-05-31 01:06:42 -0700 After looking into the bug I cannot seem to locate the logic for testing adjacent cells. It does not occur in all the Rendering files and my next guess was the CSSParser, which also does not appear to have the logic. Also the use of setStyle only occurs once for TABLE_CELL, and that also does not appear to contain the logic. Any clues? 82086 5 rwlbuis 2008-06-01 23:50:52 -0700 Hi Bradley, (In reply to comment #4) > After looking into the bug I cannot seem to locate the logic for testing > adjacent cells. It does not occur in all the Rendering files and my next guess > was the CSSParser, which also does not appear to have the logic. Also the use > of setStyle only occurs once for TABLE_CELL, and that also does not appear to > contain the logic. Any clues? I noticed that the render tree dumps are different if you position the non table cell div first or last. In the last case two RenderTableCell's are created, the first case just one. It may be worth debugging on what basis and where these RenderTableCell's are created, maybe by stepping through the code or adding printf statements. Cheers, Rob. 118251 6 29644 zwarich 2009-04-21 02:00:54 -0700 Created attachment 29644 Patch to add test The bug is now fixed, but we should add this as a test. 118265 7 zwarich 2009-04-21 08:49:21 -0700 Landed in r42711. 5331 2005-12-28 02:12:04 -0800 2005-12-28 02:12:04 -0800 test case as attachement table.html text/html 216 eric PGh0bWw+CjxoZWFkPgo8c3R5bGU+Ci5lbnRyaWVzIHsgZGlzcGxheTogdGFibGUtY2VsbDsgfQou c2lkZWJhciB7IGRpc3BsYXk6IHRhYmxlLWNlbGw7IH0KPC9zdHlsZT4KPC9oZWFkPgo8Ym9keT4K PGRpdiBjbGFzcz0ibmF2Ij48L2Rpdj4KPGRpdiBjbGFzcz0iZW50cmllcyI+T25lPC9kaXY+Cjxk aXYgY2xhc3M9InNpZGViYXIiPlR3bzwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 29644 2009-04-21 02:00:54 -0700 2009-04-21 07:54:10 -0700 Patch to add test tables.diff text/plain 2198 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQyNzA3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMDQt MjEgIENhbWVyb24gWndhcmljaCAgPGN3endhcmljaEB1d2F0ZXJsb28uY2E+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCBmb3IgYnVn IDMyMzU6IENTUzI6IFRhYmxlIGNlbGwgY29hbGVzY2luZyBpbiBDU1MgYnJva2VuCisgICAgICAg IDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzIzNT4KKyAgICAgICAg PHJkYXI6Ly8zMjk5ODgzLz4KKworICAgICAgICBUaGlzIHdhcyBmaXhlZCBsb25nIGFnbywgYnV0 IHdlIHNob3VsZCBhZGQgYSB0ZXN0IHRvIHByZXZlbnQgYSByZWdyZXNzaW9uLgorCisgICAgICAg ICogZmFzdC90YWJsZS9jZWxsLWNvYWxlc2NpbmcuaHRtbDogQWRkZWQuCisgICAgICAgICogcGxh dGZvcm0vbWFjL2Zhc3QvdGFibGUvY2VsbC1jb2FsZXNjaW5nLWV4cGVjdGVkLnR4dDogQWRkZWQu CisKIDIwMDktMDQtMjAgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogZmFzdC90YWJsZS9jZWxsLWNv YWxlc2NpbmcuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBmYXN0L3RhYmxlL2NlbGwtY29hbGVzY2luZy5o dG1sCShyZXZpc2lvbiAwKQorKysgZmFzdC90YWJsZS9jZWxsLWNvYWxlc2NpbmcuaHRtbAkocmV2 aXNpb24gMCkKQEAgLTAsMCArMSwxMyBAQAorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KKy5lbnRy aWVzIHsgZGlzcGxheTogdGFibGUtY2VsbDsgfQorLnNpZGViYXIgeyBkaXNwbGF5OiB0YWJsZS1j ZWxsOyB9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2IGNsYXNzPSJuYXYiPjwvZGl2 PgorPGRpdiBjbGFzcz0iZW50cmllcyI+T25lPC9kaXY+Cis8ZGl2IGNsYXNzPSJzaWRlYmFyIj5U d288L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IHBsYXRmb3JtL21hYy9mYXN0L3RhYmxl L2NlbGwtY29hbGVzY2luZy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0vbWFj L2Zhc3QvdGFibGUvY2VsbC1jb2FsZXNjaW5nLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr IHBsYXRmb3JtL21hYy9mYXN0L3RhYmxlL2NlbGwtY29hbGVzY2luZy1leHBlY3RlZC50eHQJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEsMTUgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAor ICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4 MDB4NjAwCisgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgICBS ZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHg1ODQKKyAgICAgIFJlbmRlckJsb2Nr IHtESVZ9IGF0ICgwLDApIHNpemUgNzg0eDAKKyAgICAgIFJlbmRlclRhYmxlIGF0ICgwLDApIHNp emUgNTd4MTgKKyAgICAgICAgUmVuZGVyVGFibGVTZWN0aW9uIChhbm9ueW1vdXMpIGF0ICgwLDAp IHNpemUgNTd4MTgKKyAgICAgICAgICBSZW5kZXJUYWJsZVJvdyAoYW5vbnltb3VzKSBhdCAoMCww KSBzaXplIDU3eDE4CisgICAgICAgICAgICBSZW5kZXJUYWJsZUNlbGwge0RJVn0gYXQgKDAsMCkg c2l6ZSAyN3gxOCBbcj0wIGM9MCBycz0xIGNzPTFdCisgICAgICAgICAgICAgIFJlbmRlclRleHQg eyN0ZXh0fSBhdCAoMCwwKSBzaXplIDI3eDE4CisgICAgICAgICAgICAgICAgdGV4dCBydW4gYXQg KDAsMCkgd2lkdGggMjc6ICJPbmUiCisgICAgICAgICAgICBSZW5kZXJUYWJsZUNlbGwge0RJVn0g YXQgKDI3LDApIHNpemUgMzB4MTggW3I9MCBjPTEgcnM9MSBjcz0xXQorICAgICAgICAgICAgICBS ZW5kZXJUZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSAzMHgxOAorICAgICAgICAgICAgICAgIHRl eHQgcnVuIGF0ICgwLDApIHdpZHRoIDMwOiAiVHdvIgo=